Re: [PATCH] Separate target visibility from reaped state information

2016-02-01 Thread Martin K. Petersen
lockup on 4.5-rc1. And you have verified that Bart's patch applied on top of 4.5-rc1 still fixes the lockup? (I know you tested a previous version) I am concerned about queuing something as a stable fix if it is just masking a fundamental underlying problem. James' comment suggests that

Re: [PATCH 0/2] RESEND: Enable iBFT IPv6 booting with prefix length

2016-02-01 Thread Martin K. Petersen
just supports Lee> netmask. Mike, care to review? https://patchwork.kernel.org/patch/8092511/ https://patchwork.kernel.org/patch/8092501/ -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

Re: [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it

2016-02-01 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> And in anycase, I guess we should be using the same logic sd.c Hannes> is using. Please see the attached patch. I'm OK with this change but please send it as a proper patch submission so somebody else ca

Re: [PATCH 01/12] be2iscsi: Remove unused mcc_cq_lock

2016-02-01 Thread Martin K. Petersen
ot;[PATCH 00/12] be2iscsi: important fixes for 11.0.0.0 driver in 4.6/scsi-queue". That way we know which tree to apply the patches to and it's clear that it's an incremental update to a previously queued series. Thanks! -- Martin K. Petersen Oracle Linux Engineeri

Re: [PATCH] bnx2fc: Show information about log levels in 'modinfo'

2016-02-01 Thread Martin K. Petersen
>>>>> "Jose" == Jose Castillo writes: Jose> This patch adds the information of the different values that can Jose> be used in the module parameter 'debug_logging', as it is shown Jose> below: Applied to 4.6/scsi-queue. Thanks! -- Martin K.

Re: [PATCH] bnx2fc: bnx2fc_eh_abort(): fix wrong return code.

2016-02-01 Thread Martin K. Petersen
>>>>> "Maurizio" == Maurizio Lombardi writes: Maurizio> If the link is not ready, the bnx2fc_eh_abort() function Maurizio> should return FAILED. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: s

Re: [PATCH] megaraid: fix null pointer check in megasas_detach_one().

2016-02-01 Thread Martin K. Petersen
>>>>> "Maurizio" == Maurizio Lombardi writes: Maurizio> The pd_seq_sync pointer can't be NULL, we have to check its Maurizio> entries instead. Sumit? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "

Re: [RESEND PATCH v2 00/23] HiSilicon SAS v2 hw support

2016-02-01 Thread Martin K. Petersen
>>>>> "John" == John Garry writes: John> This patchset introduces support for the HiSi SAS v2 hw. The John> major difference between v1 and v2 hw is support for SATA/STP. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsub

Re: [PATCHv4 00/23] ALUA device handler update, part II

2016-02-01 Thread Martin K. Petersen
scsi_dh_alua: Use workqueue for RTPG https://patchwork.kernel.org/patch/8058991/ [PATCHv4 15/23] scsi_dh_alua: Add new blacklist flag 'BLIST_SYNC_ALUA' https://patchwork.kernel.org/patch/8058951/ [PATCHv4 22/23] scsi_dh_alua: update 'access_state' field https://patchwork.kernel.org/patch

Re: [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads

2016-02-02 Thread Martin K. Petersen
>>>>> "Kirill" == Kirill A Shutemov writes: Kirill> I have the same problem. Kirill> Shouldn't we put quirk for that? I was hoping that Hannes' patch would do the trick so we could avoid blacklisting: https://patchwork.kernel.org/patch/807

Re: scsi_debug, iosize optimal < minimum

2016-02-03 Thread Martin K. Petersen
>>>>> "Ruediger" == Ruediger Meier writes: Ruediger> In past (kernel<=4.1) optimal_io_size io size was 32768. Is Ruediger> this really correct now? We recently bumped the scsi_debug optimal I/O size to something akin to what real-world storage reports. -- Ma

Re: [PATCH] megaraid: fix null pointer check in megasas_detach_one().

2016-02-03 Thread Martin K. Petersen
se? The patch fixes a bug and it applies cleanly. That's all that matters. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads

2016-02-03 Thread Martin K. Petersen
>>>>> "Kirill" == Kirill A Shutemov writes: Kirill> It didn't help me. OK, that's fine. I'll queue your patch if we can get somebody to review it... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the lin

Re: [PATCH] scsi_dh_rdac: always retry MODE SELECT on command lock violation

2016-02-03 Thread Martin K. Petersen
cumstances one might see a flood of MODE SELECT command from Hannes> various HBAs, which will easily trigger the sense code and Hannes> exceed the retry count. Should this be Cc: stable? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [patch] bfa: use strncpy() instead of memcpy()

2016-02-03 Thread Martin K. Petersen
>>>>> "Dan" == Dan Carpenter writes: Dan> BFA_MFG_NAME is "QLogic" which is only 7 bytes, but we are copying Dan> 8 bytes. It's harmless because the badding byte is likely zero but Dan> it makes static checkers complain. Applied to 4.6/scsi

Re: dm-mpath: fix a tiny case which can cause an infinite loop

2016-02-03 Thread Martin K. Petersen
; block by association/dependency) to return permanent errors that Mike> are identified during request preparation. There currently isn't any way to make BLKPREP_KILL return anything other than -EIO. I'll take a look tomorrow... -- Martin K. Petersen Oracle Linux Engineeri

[PATCH] block/sd: Return -EREMOTEIO when WRITE SAME and DISCARD are disabled

2016-02-03 Thread Martin K. Petersen
which indicates that this is an invalid request for the device. blk_peek_request() is modified to return -EREMOTEIO in that case. Reported-by: Yiwen Jiang Suggested-by: Mike Snitzer Signed-off-by: Martin K. Petersen --- I contemplated making blk_peek_request() use rq->errors to decide what

Re: [PATCH V6 00/10] aacraid: Patchset for aacraid driver version 41052

2016-02-04 Thread Martin K. Petersen
the patch changelog below the "---" separator. I had to edit every patch. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 00/12] be2iscsi: Important fixes for 11.0.0.0 in 4.6/scsi-queue

2016-02-04 Thread Martin K. Petersen
>>>>> "Jitendra" == Jitendra Bhivare writes: Jitendra> This driver update has critical fixes for following issues: - Jitendra> Management tasks with incorrect ExpStatSn - WRB allocation Jitendra> failures in IO path - MCC WRB leak Applied to 4.6/scsi-queue

Re: [mpt3sas driver patches 00/10] mpt3sas driver enhancements and

2016-02-04 Thread Martin K. Petersen
>>>>> "Suganath" == Suganath prabu Subaramani >>>>> writes: Suganath> Posting 10 patches for mpt3sas driver enhancements and few Suganath> fixes. Please address Tomas' comments to patches 6 and 7 and resubmit. Thank you! -- Martin K. Peter

Re: [PATCH] block/sd: Return -EREMOTEIO when WRITE SAME and DISCARD are disabled

2016-02-04 Thread Martin K. Petersen
much expect that I can see these Yiwen> patches which are merged into kernel. I am working on a refresh of the series that includes token-based copy offload support in addition to EXTENDED COPY. The patches depend on Mike Christie's request flag patch series which has yet to be merged.

Re: [PATCH] block/sd: Return -EREMOTEIO when WRITE SAME and DISCARD are disabled

2016-02-04 Thread Martin K. Petersen
you are changing the ordinal value of Ewan> BLKPREP_DEFER from 2 to 3. Could you swap these? I felt that KILL and INVALID were closely related. That's why I kept them together. But it doesn't matter to me. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this l

Re: [PATCH 1/3] hisi_sas: use Unified Device Properties API

2016-02-04 Thread Martin K. Petersen
>>>>> "John" == John Garry writes: John> The hisi_sas driver is required to support both device tree and John> ACPI. The scanning of the device properties now uses the Unified John> Device Properties API, which serves both OF and ACPI. Series applied to 4.6/s

Re: [PATCH] megaraid: fix null pointer check in megasas_detach_one().

2016-02-04 Thread Martin K. Petersen
>>>>> "Maurizio" == Maurizio Lombardi writes: Maurizio> The pd_seq_sync pointer can't be NULL, we have to check its Maurizio> entries instead. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: s

Re: [PATCH] scsi_dh_rdac: always retry MODE SELECT on command lock violation

2016-02-04 Thread Martin K. Petersen
cumstances one might see a flood of MODE SELECT command from Hannes> various HBAs, which will easily trigger the sense code and Hannes> exceed the retry count. Applied to 4.5/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH] SCSI: Add Marvell Console to VPD blacklist

2016-02-04 Thread Martin K. Petersen
>>>>> "Mika" == Mika Westerberg writes: Mika> I have a Marvell 88SE9230 SATA Controller that has some sort of Mika> integrated console SCSI device attached to one of the ports. Applied to 4.5/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineer

Re: [PATCH 2/2] megaraid_sas: Fix SMAP issue

2016-02-09 Thread Martin K. Petersen
>>>>> "Sumit" == Sumit Saxena writes: Sumit> Inside compat IOCTL hook of driver, driver was using wrong Sumit> address of ioc-> frame.raw which leads sense_ioc_ptr to be Sumit> calculated wrongly and failing IOCTL. Applied to 4.6/scsi-queue. -- Martin K. P

Re: [PATCH 1/2] megaraid_sas: Fix for IO failing post OCR in SRIOV environment

2016-02-09 Thread Martin K. Petersen
ing HA/non-HA path decision. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads

2016-02-09 Thread Martin K. Petersen
lp and I had to add this Todd> second Marvell line. I'm not sure if you can just wildcard the Todd> second and third fields or not. I tweaked your patch to match all revisions. Applied to 4.5/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe f

Re: [PATCH] st: Fix MTMKPART to work with newer drives

2016-02-09 Thread Martin K. Petersen
quired. Use LOAD to position the tape at the beginning of Kai> tape. Kai> The operation is extended so that if the argument is negative, its Kai> absolute value specifies the size of partition 0, which is the Kai> physically first partition of the tape. Applied to 4.6/scsi-queue. --

Re: [mpt3sas driver patches 00/10] mpt3sas driver enhancements and

2016-02-10 Thread Martin K. Petersen
>>>>> "Suganath" == Suganath prabu Subaramani >>>>> writes: Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message t

Re: [PATCH] be2iscsi: Fix memory leak in beiscsi_alloc_mem()

2016-02-10 Thread Martin K. Petersen
xt) > + if (!phwi_ctrlr->wrb_context) { > + kfree(phba->phwi_ctrlr); > return -ENOMEM; > + } > > phba->init_mem = kcalloc(SE_MEM_MAX, sizeof(*mem_descr), >GFP_KERNEL); > -- Martin K. Petersen Oracle Lin

Re: [PATCH v2] megaraid_sas: add an i/o barrier

2016-02-10 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Henzl writes: Tomas> A barrier should be added to ensure proper ordering of memory Tomas> mapped writes. Tomas> V2: - added the barrier also to megasas_fire_cmd_skinny, as Tomas> suggested by Kashyap Desai Sumit, Kashyap: Please revie

Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

2016-02-10 Thread Martin K. Petersen
>>>>> "Denys" == Denys Vlasenko writes: Denys> __bfa_trc32() is very similar, so it is uninlined too. However, Denys> it appears to be unused, therefore this patch ifdefs it out. Why don't we just drop it? -- Martin K. Petersen Oracle Linux Engineer

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-02-10 Thread Martin K. Petersen
; cases, hence we unify it again. James and Dick: Ping! https://patchwork.kernel.org/patch/8072451/ -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-02-10 Thread Martin K. Petersen
annes> cases, hence we unify it again. Johannes> This probably is a left over from some sort of refactoring. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a messag

Re: [PATCH v2] megaraid_sas: add an i/o barrier

2016-02-10 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Henzl writes: Tomas> A barrier should be added to ensure proper ordering of memory Tomas> mapped writes. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "

Re: [PATCH 0/7] SCSI bug fixes for 4.6

2016-02-10 Thread Martin K. Petersen
esults from the current code, and the warnings are all hard to Arnd> trigger. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.

Re: [Resend PATCH 1/3] scsi:stex.c Support to Pegasus series.

2016-02-10 Thread Martin K. Petersen
o merge the first two patches in the series but your mailer mangled them and they did not apply. Please use git send-email to submit patches. Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCH 00/23] ALUA device handler update, part II

2016-02-10 Thread Martin K. Petersen
www.redhat.com/archives/dm-devel/2016-February/msg00066.html. Have you had time to take a look? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH v7 00/14] Big fixes, retries, handle a race condition

2016-02-10 Thread Martin K. Petersen
>>>>> "Yaniv" == Yaniv Gardi writes: Yaniv> V7: updated patch 0001 according to a comment also, removed patch Yaniv> 07/15 from V6, so now there are only 14 patches Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [scsi 1/2] ufs: fix typo: MAZ to MAX

2016-02-11 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Winkler writes: Tomas> QUERY_DESC_GEOMETRY_MAZ_SIZE QUERY_DESC_GEOMETRY_MAX_SIZE Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH] be2iscsi: Fix memory leak in beiscsi_alloc_mem()

2016-02-11 Thread Martin K. Petersen
>>>>> "Jitendra" == Jitendra Bhivare writes: Jitendra> In case of error, the memory allocated for phwi_ctrlr was not Jitendra> freed. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH RESEND] scsi: sim710: fix build warning

2016-02-11 Thread Martin K. Petersen
r Sudip> references the function __init sim710_eisa_probe()" Sudip> sim710_eisa_probe() was having __init but that was being Sudip> referenced from sim710_eisa_driver. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

2016-02-11 Thread Martin K. Petersen
>>>>> "Denys" == Denys Vlasenko writes: Denys> __bfa_trc() compiles to 115 bytes of machine code. With this Denys> .config: http://busybox.net/~vda/kernel_config there are 1494 Denys> calls of __bfa_trc(). Applied to 4.6/scsi-queue. -- Martin K. Petersen

Re: [PATCH RESEND] scsi: ppa: use new parport device model

2016-02-11 Thread Martin K. Petersen
done in scsi/imm.c which has already Sudip> been accepted. Applied to 4.6/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH 1/1] mpt3sas: Fix - Remove cpumask_clear for zalloc_cpumask_var and dont free free_cpu_mask_var before reply_q

2016-02-11 Thread Martin K. Petersen
next time please submit two patches, one for each issue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: lpfc: Modularize and cleanup FDMI code in driver

2016-02-11 Thread Martin K. Petersen
547 memcpy(&rh->rpl.pe, &phba->pport->fc_sparam.portName, ^^^ .pe is a u32. 2548 sizeof(struct lpfc_name)); ^^^^^^^^ lpfc_name is an 8 byte union. 2549 regar

Re: megaraid_sas: Task management support

2016-02-11 Thread Martin K. Petersen
ROT_INFO_TYPE_CONTROLLER) 1789 blk_queue_update_dma_alignment(sdev->request_queue, 0x7); It looks like the code is correct but the patch just deleted a tab accidentally. 1790 mr_device_priv_data->is_tm_capable = 1791 raid->capability.tmCapable;

Re: [PATCH v2 0/7] ibmvscsi code cleanup

2016-02-12 Thread Martin K. Petersen
to 4.6/scsi-queue. (And added the missing review from Johannes for patch 3 as pointed out by James). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-12 Thread Martin K. Petersen
>>>>> "James" == James Bottomley writes: James> OK we need a re-review then ... I'll hold off pushing for now. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the bod

Re: megaraid_sas: Task management support

2016-02-12 Thread Martin K. Petersen
>>>>> "Sumit" == Sumit Saxena writes: Sumit, >> It looks like the code is correct but the patch just deleted a tab Sumit> Yes code is correct, tab got deleted accidentally. Please submit a patch to correct the formatting. -- Martin K. Petersen Oracle L

Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

2016-02-16 Thread Martin K. Petersen
h is slightly changed from v1. A define for AIX os type Tyrel> was added as mentioned in the cover letter v2 changes, and I Tyrel> moved the defines to the mad_adapter_info_data structure around Tyrel> the fields they apply. Johannes: Mind checking this out? https://patchwork.kernel.org/pa

Re: [PATCH] ibmvfc: byteswap scsi_id, wwpn, and node_name prior to logging

2016-02-17 Thread Martin K. Petersen
a LE system. Instead byteswap these values to host endian Tyrel> prior to logging. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majo

Re: [PATCH 1/2] mpt3sas: Deallocate resources before trying reallocation of the same in _base_allocate_memory_pools()

2016-02-17 Thread Martin K. Petersen
has the driver update from Suganath. Please rebase and resubmit. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] Modified Maintainers list for MPT FUSION DRIVERS.

2016-02-17 Thread Martin K. Petersen
too? Chaitra: Please address Joe's comments and resubmit. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] lpfc: fix missing zero termination in debugfs

2016-02-17 Thread Martin K. Petersen
>>>>> "Alan" == Alan writes: Alan> If you feed 32 bytes in then the kstrtoull() doesn't receive a Alan> terminated string so will run off the end. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this li

Re: [PATCH] aic7xxx: Fix queue depth handling

2016-02-17 Thread Martin K. Petersen
one. Applied to 4.6/scsi-queue, CC:stable@. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] esas2r: Fix array overrun

2016-02-17 Thread Martin K. Petersen
>>>>> "Alan" == Alan writes: Alan> Check the array size *before* dereferencing it with a user Alan> provided offset Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] block/sd: Return -EREMOTEIO when WRITE SAME and DISCARD are disabled

2016-02-17 Thread Martin K. Petersen
>>>>> "Yiwen" == jiangyiwen writes: Yiwen, Yiwen> When called scsi_prep_fn return BLKPREP_INVALID, we should use Yiwen> the same code with BLKPREP_KILL in scsi_prep_return. You are right! Applied to 4.5/scsi-fixes. -- Martin K. Petersen Oracle Linux Eng

Re: [PATCHv8 20/23] scsi: Add 'access_state' attribute

2016-02-21 Thread Martin K. Petersen
; submission? No, it's OK. I'll merge the first part of the series in the morning. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value.

2016-02-23 Thread Martin K. Petersen
>>>>> "Suganath" == Suganath Prabu Subramani >>>>> writes: Suganath> Deallocate resources before reallocating of the same in Suganath> retry_allocation path of _base_allocate_memory_pools() Both patches applied to 4.6/scsi-queue. -- Martin K

Re: [PATCH RESEND] dpt_i2o: fix build warning

2016-02-23 Thread Martin K. Petersen
ip> is not defined then dptids[] becomes unused. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] mptbase: fixup error handling paths in mpt_attach()

2016-02-23 Thread Martin K. Petersen
>>>>> "Ewan" == Ewan D Milne writes: Ewan> mpt_attach() was not checking for the failure to create Ewan> fw_event_q. Also, iounmap() was not being called in all error Ewan> cases after ioremap() had been called by mpt_mapresources(). Applied to 4.6/s

Re: [PATCHv8 00/23] ALUA device handler update, part II

2016-02-23 Thread Martin K. Petersen
dded a blacklist flag which then uses a singlethreaded Hannes> workqueue, thereby effectively synchronize STPG handling. Hannes> Thanks to Bart for this suggestion. Applied 1-19 and 23 to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: sen

Re: aicasm: fix kbuild for separated build directories

2016-02-23 Thread Martin K. Petersen
gt; work, I removed them and used the existing kbuild Michal> infrastructure. Please try the patch below on top of yours. James? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majo

Re: [PATCH 0/7] hpsa updates

2016-02-23 Thread Martin K. Petersen
t; hba devices - check for null pointer in ioaccel2 path - remove Don> definition for sanitize_inquiry_string This patch depends on - Don> commit ac10a3e4ed64 ("Export function Don> scsi_scan.c:sanitize_inquiry_string") - update copyright Don> information --- Applied to 4.6/s

Re: [PATCH] hpsa: update MAINTAINERS with new e-mail

2016-02-23 Thread Martin K. Petersen
>>>>> "Don" == Don Brace writes: Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majord

Re: aacraid: ioctl hang (4.5-rc4)

2016-02-23 Thread Martin K. Petersen
completes, but the driver Roger> doesn't call up() because the XFerState in the reply doesn't Roger> match to the request. Roger> sent: 1010a1 rcvd: 804832ad Roger> I don't really know enough about the controller protocol to debug Roger> this further. Roger> First thi

Re: [v2 PATCH 1/3] scsi:stex.c Support to Pegasus series.

2016-02-23 Thread Martin K. Petersen
>>>>> "Charles" == Charles Chiou writes: Charles> Pegasus is a high performace hardware RAID solution designed to Charles> unleash the raw power of Thunderbolt technology. Applied patches 1-3 to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineer

Re: [PATCH v3 6/10] megaraid_sas : Chip reset if driver fail to bring ioc ready

2015-09-03 Thread Martin K. Petersen
, that call back was void, so it will not do any chip Sumit> reset. Sumit> Now, using this patch megasas_adp_reset_fusion() will have chip Sumit> reset logic for Fusion adapter. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from th

Re: [PATCH v3 7/10] megaraid_sas : Print critical fw event message

2015-09-03 Thread Martin K. Petersen
>>>>> "Sumit" == sumit saxena writes: Sumit> Print firmware event in readable format. This will help user to Sumit> track any critical firmware event without any application Sumit> support. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle L

Re: [PATCH v3 8/10] megaraid_sas : Fix validHandles check in io path

2015-09-03 Thread Martin K. Petersen
er driver code does not use dual path Sumit> functionality. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 9/10] megaraid_sas : Code refactor for use of requestorId

2015-09-03 Thread Martin K. Petersen
o support only for specific device id Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 10/10] megaraid_sas : Version upgrade

2015-09-03 Thread Martin K. Petersen
>>>>> "Sumit" == sumit saxena writes: Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kern

Re: [PATCH 01/23] scsi_dh_alua: Disable ALUA handling for non-disk devices

2015-09-03 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Non-disk devices might support ALUA, but the firmware Hannes> implementation is untested and frequently broken. As we're Hannes> don't actually need it disable ALUA support for non-disk device Hanne

Re: [PATCH 02/23] scsi_dh_alua: Use vpd_pg83 information

2015-09-03 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> The SCSI device now has the VPD page 0x83 information attached, Hannes> so there is no need to query it again. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH 03/23] scsi_dh_alua: improved logging

2015-09-03 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Issue different logging messages if ALUA is not supported or the Hannes> TPGS setting is invalid. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this l

Re: [PATCH 06/23] scsi_dh_alua: fixup description of stpg_endio()

2015-09-03 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Fixup copy-and-paste error in the description of stpg_endio(). Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 07/23] scsi: remove scsi_show_sense_hdr()

2015-09-03 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Last caller is gone, so remove it. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH 08/23] scsi_dh_alua: use flag for RTPG extended header

2015-09-03 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> We should be using a flag when RTPG extended header is not Hannes> supported, that saves us sending RTPG twice for older arrays. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineer

Re: [PATCH 09/23] scsi_dh_alua: use unaligned access macros

2015-09-03 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Use 'get_unaligned_XX' and 'put_unaligned_XX' instead of Hannes> open-coding it. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from t

Re: [PATCH 10/23] scsi_dh_alua: Pass buffer as function argument

2015-09-03 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Pass in the buffer as a function argument for submit_rtpg(). Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH 01/12] megaraid_sas : Expose TAPE drives unconditionally

2015-10-27 Thread Martin K. Petersen
ose up for now. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/12] megaraid_sas : Code optimization- remove PCI Ids based checks

2015-10-27 Thread Martin K. Petersen
o Sumit> divided in two categories- 1)THUNDERBOLT SERIES and 2)INVADER Sumit> SERIES. Does not apply against current upstream. Please fix and repost. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

Re: [PATCH 02/12] megaraid_sas : Code optimization- remove PCI Ids based checks

2015-10-28 Thread Martin K. Petersen
o ACK anything which is not Kashyap> critical to avoid such issue and probably piggy back those Kashyap> patches. Last series and latest series has reviewed-by Kashyap> tags. Can we have outstanding patches committed in next window Kashyap> ? Just pulled in the previous patch series.

Re: [PATCH] SCSI: Increase REPORT_LUNS timeout

2015-11-02 Thread Martin K. Petersen
>>>>> "Brian" == Brian King writes: Brian> This patch increases the timeout used on the REPORT_LUNS to 30 Brian> seconds. This patch solves the issue of 512 non existent LUNs Brian> showing up after this event. Applied. -- Martin K. Petersen Oracle L

Re: [PATCH 0/12] megaraid_sas : Updates for scsi for-next

2015-11-02 Thread Martin K. Petersen
>>>>> "sumit" == sumit saxena writes: sumit> This patch set is rebased on top of last patch set sent by me- sumit> http://marc.info/?l=linux-scsi&m=144102204225400&w=2 Please sumit> consider this patch set for next kernel release. Applied. -- Martin

Re: [PATCH 0/8] pm80xx: Add ATTO 12Gb HBA support and fix various issues

2015-11-02 Thread Martin K. Petersen
sed Benjamin> other various issues that were discovered during our testing Benjamin> and verification phase, mainly with resume-from-sleep, Benjamin> configuring PHY profiles, and using legacy interrupts. Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH 1 00/25] hpsa updates

2015-11-02 Thread Martin K. Petersen
>>>>> "Don" == Don Brace writes: Don, There were several minor nits in the review comments. Please address these and repost with the relevant Reviewed-by tags added so we can get this series queued up. Thanks! -- Martin K. Petersen Oracle Linux Engineering --

Re: [PATCH] sg: Fix double-free when drives detach during SG_IO

2015-11-02 Thread Martin K. Petersen
so we >> end up freeing rq->cmd in the already free rq object, and then free >> the object itself out from under the current user. >> >> This ends up corrupting random memory via the list_head on the rq >> object. The most common crash trace I saw is this: >

Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only

2015-11-02 Thread Martin K. Petersen
have to deal with mail archive-mangled versions. Please apply the relevant Reviewed-by tags and repost. Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.ke

Re: [PATCH 0/2] megaraid_sas: couple of fixes

2015-11-09 Thread Martin K. Petersen
>>>>> "Sumit" == Sumit Saxena writes: Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND] scsi: Export SCSI Inquiry data to sysfs

2015-11-09 Thread Martin K. Petersen
>>>>> "Johannes" == Johannes Thumshirn writes: Johannes> Export the RAW SCSI Inquiry to sysfs as binfile. This way the Johannes> data can be used by userland without the need to have and Johannes> ioctl or use the sg_inq tool. Applied. -- Martin K. Petersen

Re: [PATCH v2 00/27] hpsa updates

2015-11-09 Thread Martin K. Petersen
Applied this series. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND] hpsa: move lockup_detected attribute to host attr

2015-11-09 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Henzl writes: Tomas> This patch fixes a 'general protection fault' issue by moving the Tomas> attribute to where it was likely meant. Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list:

Re: [PATCH v9 0/8] Fix error message and present UFS variant

2015-11-09 Thread Martin K. Petersen
>>>>> "Yaniv" == Yaniv Gardi writes: I have applied this series. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH v2 1/5] ipr: Add delay to ensure coherent dumps.

2015-11-09 Thread Martin K. Petersen
we'll be Gabriel> collecting meaningful dump data, even when dumping right after Gabriel> an adapter reset. I have applied patches 1-5. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: [PATCH] pm80xx: remove the SCSI host before detaching from SAS transport

2015-11-09 Thread Martin K. Petersen
the Benjamin> system, necessitating a reboot. Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] isci: remove SCSI host before detaching from SAS transport

2015-11-09 Thread Martin K. Petersen
>>>>> "Jack" == Jack Wang writes: Applied patches 1-3. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info a

<    5   6   7   8   9   10   11   12   13   14   >