Re: [PATCH 3/6] scsi_debug: clear correct memory region when LBPRZ is enabled

2013-04-24 Thread Martin K. Petersen
ng to a logical block address which should Akinobu> be cleared, it is a index of probisioning map (map_storep). Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a m

Re: [PATCH 4/6] scsi_debug: add translation functions between LBA and index of provisioning map

2013-04-24 Thread Martin K. Petersen
dex); Akinobu> Actual bug fixes with using these functions will be done by Akinobu> forthcoming patches. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: [PATCH 5/6] scsi_debug: fix initialization of provisioning map

2013-04-24 Thread Martin K. Petersen
> bitmap_clear() instead of memset(). Akinobu> Otherwise it will cause problem on big-endian architecture if Akinobu> the number of bits is not a multiple of BITS_PER_LONG. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send th

Re: [PATCH 6/6] scsi_debug: fix logical block provisioning support

2013-04-24 Thread Martin K. Petersen
>>>>> "Akinobu" == Akinobu Mita writes: Akinobu> This problem is due to the wrong translation between LBA and Akinobu> index of provisioning map. Fix it by using correct translation Akinobu> functions added previously. Acked-by: Martin K. Petersen -- Ma

Re: [patch 1/1] sd_dif: problem with verify of type 1 protection information (PI)

2013-04-24 Thread Martin K. Petersen
rify functions so I never noticed. The same issue was reported recently by Keith Busch. Signed-off-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord..

Re: [PATCH 1/6] scsi_debug: call map_region() and unmap_region() only when needed

2013-04-24 Thread Martin K. Petersen
p_region() to be called only Akinobu> when scsi_debug_lbp() returns true, i.e. logical block Akinobu> provisioning is enabled. Acked-by: Martin K. Petersen Akinobu> Because scsi_debug_unmap_granularity cannot be zero with usual Akinobu> setting: scsi_debug_unmap_granularity is 1 by default

Re: [PATCH 1/3] scsi_debug: fix data integrity support on highmem machine

2013-04-24 Thread Martin K. Petersen
nce. Akinobu> This also fixes another issue that invalid kmap address is used Akinobu> for kunmap_atomic(): the kmap address 'daddr' is incremented in Akinobu> the loop for each data page, and it can reach the next page Akinobu> boundary. That fix is fine. -- Martin K. Peter

Re: [PATCH 3/3] scsi_debug: simplify offset calculation for dif_storep

2013-04-24 Thread Martin K. Petersen
>>>>> "Akinobu" == Akinobu Mita writes: + sector += len / sizeof(*dif_storep); I'd rather see sizeof(struct scsi_dif_tuple) here. But that's just personal preference. Otherwise ok. -- Martin K. Petersen Oracle Linux Engineering -- To u

Re: [PATCH 2/3] scsi_debug: fix NULL pointer dereference with parameters dif=0 dix=1

2013-04-24 Thread Martin K. Petersen
particular case I'm ok with your patch keying off of scsi_debug_dix. But it's very important to me that I'm able to set P_TYPE and the host protection mask as I see fit using the module parameters. Even when the combination of options don't make strict sense. Acked-by: Martin

Re: "WRITE SAME failed. Manually zeroing" with 3w-xxxx driver

2013-04-29 Thread Martin K. Petersen
se buffer in that case. Could you please test the patch below? Florian> This goes on and on. The second question is what it is that's issuing these zeroouts at boot? Which filesystem are you using? What's your DM/MD config? -- Martin K. Petersen Oracle Linux Engineering 3w-xxx

Re: linux-next: Tree for May 6 (lpfc)

2013-05-06 Thread Martin K. Petersen
o needs the generic checksum, so the fix would seem to be James> this. Patch ok as a short term fix. Longer term I'd like to provide a helper function that HBAs can call to validate the data and PI scatterlists. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from thi

Re: SCSI testing/USB devices are amazing

2013-05-09 Thread Martin K. Petersen
Right now you always expect RDPROTECT/WRPROTECT > 0 to fail, but they should succeed if the device is formatted with PI. FWIW, my slightly outdated document is here: https://oss.oracle.com/~mkp/docs/linux-advanced-storage.pdf -- Martin K. Petersen Oracle Linux Engineering -- To

[PATCH] scsi: Allow error handling timeout to be specified

2013-05-09 Thread Martin K. Petersen
) before we give up. Signed-off-by: Martin K. Petersen diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index c1b05a8..91adc52 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -44,8 +44,6 @@ static void scsi_eh_done(struct scsi_cmnd *scmd); -#define

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Martin K. Petersen
enarios it is necessary to be able to tune this as it can take several iterations (bus device, target, bus, controller) before we give up. Signed-off-by: Martin K. Petersen diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index c1b05a8..91adc52 100644 --- a/drivers/scsi/scsi_error.

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Martin K. Petersen
; from my experience a host reset is usually not required and the Baruch> Linux kernel currently reaches to this big hammer too fast. I'm also working on a patch to add some heuristics to avoid the HBA and bus resets if I/O is completing successfully on other attached targets. But that's a

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Martin K. Petersen
>>>>> "Martin" == Martin K Petersen writes: Martin> I'm also working on a patch to add some heuristics to avoid the Martin> HBA and bus resets Or rather: Defer the HBA and bus resets... Martin> if I/O is completing successfully on other attached targets.

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-13 Thread Martin K. Petersen
hout doing an HBA firmware reset. Despite I/O completing successfully on other targets connected to the same HBA. So at some point we do need to give up and escalate to a full HBA reset. We would just like to defer that hammer until we have run out of other options. -- Martin K. Petersen Oracle Linux

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-14 Thread Martin K. Petersen
emy> underlying problem is unknown is a bad strategy. There is no one size that fits all. Which is why we're taking steps to make the error recovery parameters tweakable. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscr

Re: SCSI testing/USB devices are amazing

2013-05-14 Thread Martin K. Petersen
6 tests so that IF SBC-3 is Ronnie> claimed, or if IQN->PROTECT is set then the device must support Ronnie> this opcode or the test will fail. Otherwise, if it is not Ronnie> SBC-3 and if PROTECT is clear, then the test will be skipped but Ronnie> not fail if the opcode is missing. *nod* --

Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions

2015-11-25 Thread Martin K. Petersen
>>>>> "Andy" == Andy Shevchenko writes: Andy, Andy> but can you pay a little attention to Andy> http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems Andy> it wasn't applied. Please resubmit to linux-scsi. We'll take a look. -- Mart

Re: [PATCH] scsi: use sector_div instead of do_div

2015-11-25 Thread Martin K. Petersen
>>>>> "Arnd" == Arnd Bergmann writes: Arnd> do_div is the wrong way to divide a sector_t, as it is less Arnd> efficient when sector_t is 32-bit wide. With the upcoming do_div Arnd> optimizations, the kernel starts warning about this: Applied. -- Ma

Re: [PATCH] scsi: rescan VPD attributes

2015-11-25 Thread Martin K. Petersen
ooking into merging the ALUA series but this prerequisite patch is lacking reviews... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] Fix a scsi_host_dev_release() memory leak

2015-11-25 Thread Martin K. Petersen
t> second patch that fixes the actual memory leak. I gave a bunch of reviews for v1 but no takers for v2 of the second patch. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majo

Re: [PATCH] scsi: rescan VPD attributes

2015-11-30 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> The VPD page information might change, so we need to be able to Hannes> update it. This patch implements a VPD page rescan whenever the Hannes> 'rescan' sysfs attribute is triggered. Applied to 4.5/scs

Re: [PATCH 01/18] scsi_dh: move 'dh_state' sysfs attribute to generic code

2015-11-30 Thread Martin K. Petersen
ing scsi device"). Looked simple enough and I started to fix it up but then decided to let you do since you'll have to check it anyway. Please rebase on top of latest 4.5/scsi-queue (which has your VPD rescan patch in place). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscri

Re: [PATCH v1 1/1] scsi_debug: check for bigger value first

2015-11-30 Thread Martin K. Petersen
>>>>> "Andy" == Andy Shevchenko writes: Andy> Even for signed types we have to check for bigger positive value Andy> first. Otherwise it will be never happened. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH v2 0/4] bfa: Patches for scsi "misc" branch

2015-11-30 Thread Martin K. Petersen
updated series. Patches 1, 3 and 4 got reviewed by Johannes. No need to resend, I'll try to remember this time (assuming patch 2 gets reviewed soon-ish). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in t

Re: [PATCH 1/2] scsi_transport_fc: Introduce scsi_host_{get,put}()

2015-11-30 Thread Martin K. Petersen
>>>>> "Bart" == Bart Van Assche writes: Bart, Bart> Use scsi_host_{get,put}() instead of open-coding these functions. Bart> Compile-tested only. Do you want me to queue this as a general cleanup for 4.5 (independently of the leak patch)? -- Martin K. Peterse

Re: [PATCH 1/2] scsi_transport_fc: Introduce scsi_host_{get,put}()

2015-11-30 Thread Martin K. Petersen
>>>>> "Bart" == Bart Van Assche writes: >> Do you want me to queue this as a general cleanup for 4.5 >> (independently of the leak patch)? Bart> That would be appreciated. OK. Done. -- Martin K. Petersen Oracle Linux Engineering -- To u

Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

2015-11-30 Thread Martin K. Petersen
sure you tag with "Signed-off-by:". Your signoff was mistyped in all the patches. Thank you! Martin -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...

Re: [PATCH] Fix a bdi reregistration race, v2

2015-11-30 Thread Martin K. Petersen
gt; these debug options slow down the SCSI device removal code and Bart> thereby increase the chance that this race is triggered. Any updates on this? Your updated patch has no reviews. Should I just revert the original patch for 4.4? -- Martin K. Petersen Oracle Linux Engineering -- To u

Re: [PATCH] Fix a memory leak in scsi_host_dev_release()

2015-11-30 Thread Martin K. Petersen
iggers that scenario: Applied to 4.4/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: ufs: fix spelling mistake in error message

2015-11-30 Thread Martin K. Petersen
>>>>> "Colin" == Colin King writes: Colin, Colin> Minor issue, fix spelling mistake, Intialization -> Colin> Initialization Applied to 4.5/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the li

Re: [RESEND] scsi: mvsas: fix misleading indentation

2015-11-30 Thread Martin K. Petersen
return SAS_PHY_DOWN. But current Luis> indentation makes it look like we only do so in the else branch of Luis> if (mvi_dev). Applied to 4.5/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscrib

Re: [scsi:fixes 16/18] warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct dependencies (SCSI_LOWLEVEL && ..)

2015-12-02 Thread Martin K. Petersen
guang to add scsi.git to the kbuild test robot. It looks like it's only been testing the SCSI branches I kept in my regular git tree and they were a bit behind scsi.git. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "uns

Re: [PATCHv2 00/18] ALUA device handler update, part 1

2015-12-02 Thread Martin K. Petersen
scsi_vpd_lun_id() and scsi_vpd_tpg_id(). This series has been Hannes> split off from the original 'Asynchronous ALUA' patchset, as Hannes> these bits are pretty uncontroversial and have a good chance of Hannes> being merged reasonably soon. Applied to 4.5/scsi-queue. -- Marti

Re: [PATCH v2 0/4] bfa: Patches for scsi "misc" branch

2015-12-02 Thread Martin K. Petersen
>>>>> "Anil" ==writes: Anil> Please apply the following patches to the scsi tree, misc branch Anil> at your earliest convenience. Series applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send t

Re: Linux kernels 4.3+ mess up MPT2SAS configs

2015-12-03 Thread Martin K. Petersen
s John> like a merge of the mpt2sas and mpt3sas drivers. http://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.4/scsi-queue -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message

Re: [PATCH] scsi_dh_alua: Remove stale variables

2015-12-07 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> With commit 83ea0e5e3501 these variables became obsolete, but Hannes> weren't removed. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

Re: [PATCH RESEND] cxlflash: a couple off by one bugs

2015-12-10 Thread Martin K. Petersen
>>>>> "Matthew" == Matthew R Ochs writes: Matthew> The "> MAX_CONTEXT" should be ">= MAX_CONTEXT". Otherwise we Matthew> go one step beyond the end of the cfg->ctx_tbl[] array. Applied to 4.5/scsi-queue. -- Martin K. Petersen

Re: [PATCH RESEND] cxlflash: drop unlikely before IS_ERR_OR_NULL

2015-12-10 Thread Martin K. Petersen
>>>>> "Matthew" == Matthew R Ochs writes: Matthew> IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop Matthew> it. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "un

Re: [PATCH v2] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

2015-12-10 Thread Martin K. Petersen
; option is enabled. This change fixes the issue and makes Josh> pvscsi_map_buffers() function more robust. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH v2] storvsc: add logging for error/warning messages

2015-12-10 Thread Martin K. Petersen
>>>>> "Long" == Long Li writes: Long> Introduce a logging level for storvsc to log certain error/warning Long> messages. Those messages are helpful in some environments, Long> e.g. Microsoft Azure, for customer support and troubleshooting Long> purposes. App

Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

2015-12-10 Thread Martin K. Petersen
ly Rasmus> intended. One way to fix it would be to change the casts to Rasmus> (u8*) aka (unsigned char*), but it is much simpler (and Rasmus> generates smaller code) to use the %ph extension which was Rasmus> created for such short hexdumps. Applied to 4.5/scsi-queue. -- Martin K.

Re: [patch] hisi_sas: fix error codes in hisi_sas_task_prep()

2015-12-10 Thread Martin K. Petersen
>>>>> "Dan" == Dan Carpenter writes: Dan> There were a couple cases where the error codes weren't set and Dan> also I changed the success return to "return 0;" which is the same Dan> as "return rc;" but more explicit. Applied t

Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

2015-12-10 Thread Martin K. Petersen
ending to linux-scsi is fine. The trick is finding people willing to review them... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/15] copy offload patches

2015-12-10 Thread Martin K. Petersen
afraid I didn't get a chance to dig very deep in your series since it coincided with me scrambling to sort out SCSI for 4.4. Do you think there's a chance we could get your patches in shape for 4.5? Is there an up-to-date tree I can look at? -- Martin K. Petersen Oracle Linux Enginee

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-12-14 Thread Martin K. Petersen
bullet. I don't see much value in the module parameter since it will require customers to tweak their configs and reproduce. Not worth the hassle. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Martin K. Petersen
However, I think I have found the smoking gun. More in a bit... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Martin K. Petersen
>>>>> "Eryu" == Eryu Guan writes: Eryu, Does the patch below fix the issue? -- Martin K. Petersen Oracle Linux Engineering diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 3d22fc3e3c1a..d1eb7aa78b8d 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scs

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Martin K. Petersen
I agree that the value chosen by scsi_debug in this case is very low and we should fix that. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2015-12-15 Thread Martin K. Petersen
AX_SECTORS which is not correct. Ming> Also it is ugly to set limits->max_sectors from drivers directly, Ming> and drivers should have called block helpers to do that. We're trying to avoid unnecessary accessor functions for the queue limits. But I will add a sanity check for the pa

Re: [PATCH 0/15] copy offload patches

2015-12-15 Thread Martin K. Petersen
from the xcopy stuff. I will have to reconcile those two branches and then layer your stuff on top. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More major

Re: [patch] qla2xxx: fix a timeout loop

2015-12-16 Thread Martin K. Petersen
>>>>> "Dan" == Dan Carpenter writes: Dan> After the loop we test for "if (!retries) " as a failure, but Dan> actually the post-op here will end with retries set to -1. I have Dan> fixed this by using a pre-op instead. Applied to 4.4/scsi-fixe

[PATCH 1/3] scsi_debug: Increase the reported optimal transfer length

2015-12-16 Thread Martin K. Petersen
The OPTIMAL TRANSFER LENGTH reported by scsi_debug is 64 blocks which translates to 32KB with the default logical block size. That's much lower than what real storage devices typically report (256KB to 1MB). Bump the optimal transfer length to 1024 blocks. Signed-off-by: Martin K. Pet

[PATCH 3/3] block: Export max_dev_sectors_kb in sysfs

2015-12-16 Thread Martin K. Petersen
evice. Export the max_dev_sectors_kb queue limit in sysfs and update the documentation accordingly. Signed-off-by: Martin K. Petersen --- Documentation/ABI/testing/sysfs-block | 9 + Documentation/block/queue-sysfs.txt | 11 +-- block/blk-settings.c | 4 +++- bloc

[PATCH 2/3] sd: Reject optimal transfer length smaller than page size

2015-12-16 Thread Martin K. Petersen
it is bigger than or equal to the page cache size. Reported-by: Eryu Guan Reported-by: Ming Lei Signed-off-by: Martin K. Petersen --- drivers/scsi/sd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 3d22fc3e3c1a

Note to driver maintainers

2015-12-16 Thread Martin K. Petersen
ur changes. You have to review everybody else's. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] hisi_sas: use platform_get_irq()

2015-12-16 Thread Martin K. Petersen
>>>>> "John" == John Garry writes: John> It is preferred that drivers use platform_get_irq() instead of John> irq_of_parse_and_map(), so replace. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: s

Re: [patch] qla2xxx: fix a timeout loop

2015-12-17 Thread Martin K. Petersen
t;applied".) I dropped it for now. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Reviews, please

2015-12-17 Thread Martin K. Petersen
bunch of trivial fixes on the list that would be nice to get either acked or nacked: https://patchwork.kernel.org/project/linux-scsi/list/ Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH 1/1] mvsas: add SGPIO support to Marvell 94xx

2015-12-21 Thread Martin K. Petersen
>>>>> "Wilfried" == Wilfried Weissmann writes: Wilfried, Wilfried> add SGPIO support to Marvell 94xx Does not apply to current tree. Please rebase on top of: http://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/log/?h=4.5/scsi-queue Thank you! -- Martin K

Re: [PATCH 00/17] lpfc: Update to revision 11.0.0.10

2015-12-21 Thread Martin K. Petersen
>>>>> "James" == James Smart writes: James> This patch set updates the lpfc driver to revision 11.0.0.10 James> The patches were cut against scsi-misc Applied to 4.5/scsi-queue except for 3/17. -- Martin K. Petersen Oracle Linux Engineering -- To unsub

Re: [PATCH RFC 0/2] avoid crashing when reading /proc/scsi/scsi and simultaneously removing devices

2016-01-04 Thread Martin K. Petersen
removed from the list. Thus, we get errors and eventually panic, Ewan> as shown in the traces below. Fix this by keeping a klist Ewan> iterator in the seq_file private data. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: se

Re: [PATCH v3 0/3] hpsa update

2016-01-04 Thread Martin K. Petersen
; in enclosure information Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mpt3sas: a correction in unmap_resources

2016-01-04 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Henzl writes: Tomas> It might happen that we try to free an already freed pointer. Tomas> Tomas Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsu

Re: [PATCH V2 0/9] aacraid: Patchset for aacraid driver version 41052

2016-01-04 Thread Martin K. Petersen
You dropped all the review/fix/stable tags you had received from Tomas and Johannes. Please apply the relevant tags and resubmit this series. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the b

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2016-01-05 Thread Martin K. Petersen
>>>>> "Lee" == Lee Duncan writes: Lee> Do you need me to resubmit this patch now that it's accepted? Please resend. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

2016-01-05 Thread Martin K. Petersen
>>>>> "Eryu" == Eryu Guan writes: Eryu> Any updates on this? It's still reproducible with 4.4-rc8 kernel, Eryu> and still blocks some of my tests :) http://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/log/?h=4.4/scsi-fixes It just hasn't made i

Re: [PATCH] scsi: mvsas: fix indenting on return error code

2016-01-06 Thread Martin K. Petersen
gt; braces) rather than a DEV_IS_GONE() failure. This problem has already been addressed: https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.5/scsi-queue&id=7789cd39274c -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsub

Re: [PATCH 1/1] mvsas: add SGPIO support to Marvell 94xx

2016-01-06 Thread Martin K. Petersen
>>>>> "Wilfried" == Wilfried Weissmann writes: Wilfried> add SGPIO support to Marvell 94xx Applied to 4.5/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH v3 0/4] scsi: cleanup ioctl headers and provide UAPI versions

2016-01-06 Thread Martin K. Petersen
v2 to v3 is that >> defaults for sg.c are not exported in include/uapi/linux/sg.c. Paolo> What happened to these patches?... They predate me being patch monkey. Please repost with any review tags or acks you may have received. -- Martin K. Petersen Oracle Linux Engineering -- To unsubs

Re: [PATCH V4 0/4] scsi: storvsc: Properly support FC hosts

2016-01-06 Thread Martin K. Petersen
>>>>> "KYS" == K Y Srinivasan writes: The template discussion appears to have lost momentum and since the concerns were minor I have applied your latest series to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: s

Re: [PATCH 02/35] block: add REQ_OP definitions and bi_op/op fields

2016-01-06 Thread Martin K. Petersen
bios since the flags were consolidated a while back. When I attempted to fix the READ/WRITE mess I used a BLK_ prefix as a result. Anyway. Just bikeshedding... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: [PATCH 00/35 v2] separate operations from flags in the bio/request structs

2016-01-06 Thread Martin K. Petersen
ible to me. I wonder what the best approach is to move a patch set with this many stakeholders forward? Set a "speak now or forever hold your peace" review deadline? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH v2 0/6] cxlflash: Miscellaneous fixes and updates

2016-01-06 Thread Martin K. Petersen
s been altered from previous versions of this patch set. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 00/78] More fixes, cleanup and modernization for NCR5380 drivers

2016-01-06 Thread Martin K. Petersen
g/cgit/linux/kernel/git/mkp/scsi.git/log/?h=4.5/ncr5380 -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread Martin K. Petersen
Commit ca369d51b3e1 ("block/sd: Fix device-imposed transfer length limits") accidentally switched optimal I/O size reporting from bytes to block layer sectors. Signed-off-by: Martin K. Petersen Reported-by: Christian Borntraeger --- drivers/scsi/sd.c | 2 +- 1 file changed, 1 inser

Re: scsi-debug regression with 4.5-rc?

2016-01-20 Thread Martin K. Petersen
>>>>> "Ewan" == Ewan Milne writes: Ewan> So I have a report from our test people that the optimal_io_size Ewan> sysfs value is now different by a factor of 512 from what it used Ewan> to be... Yes, just prepared a patch this morning. I messed up sectors

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

2016-01-20 Thread Martin K. Petersen
ames E.J. Bottomley James> I'll add the tags. The reason I didn't explicitly put 4.4+ is that the original commit has made its way quite far in various stable trees by now. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "uns

Re: [PATCH v4 00/17] be2iscsi: driver update 11.0.0.0

2016-01-26 Thread Martin K. Petersen
mkp/scsi.git/commit/?h=4.6/scsi-queue&id=fa512e1a3156 -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] be2iscsi: add checks for dma mapping errors

2016-01-26 Thread Martin K. Petersen
>>>>> "Alexey" == Alexey Khoroshilov writes: Alexey> hwi_write_buffer() does not check if mapping dma memory succeed. Alexey> The patch adds the check and failure handling. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To u

Re: [PATCH 00/11] qla2xxx: Patches for scsi "misc" branch.

2016-01-26 Thread Martin K. Petersen
>>>>> "Himanshu" == Himanshu Madhani writes: Himanshu> Please apply following patches to the scsi tree, misc branch Himanshu> at your earliest convenience. Please fix kbuild warnings and repost. Thanks! -- Martin K. Petersen Oracle Linux Engineering -

Re: [PATCH 09/15] megaraid_sas: Dual Queue depth support

2016-01-26 Thread Martin K. Petersen
y >> purpose of increasing JBOD performance. This focuses on firmware >> deployment with less VDs(or no) and more JBODs in configuration. Tomas> OK, so it is switched off by default in the firmware and the user Tomas> and an educated user can switch it on ? if so, it's fine for

Re: [PATCH] scsi: export function scsi_scan.c:sanitize_inquiry_string

2016-01-26 Thread Martin K. Petersen
>>>>> "Don" == Don Brace writes: Don> It was pointed out to me by Kevin Barnett that I should also add a Don> prototype in scsi.h. Yes, please. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval'

2016-01-26 Thread Martin K. Petersen
t; systems in year 2038 beyond. The patch uses Arnd> ktime_get_real_seconds() which returns a 64-bit seconds value. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs

2016-01-26 Thread Martin K. Petersen
>>>>> "John" == John Garry writes: John> We can just add HAS_IOMEM dependency on the scsi fixes branch, ok? Yes, please submit a patch against 4.5/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line &qu

Re: [PATCH] hisi_sas: add dependency for HAS_IOMEM

2016-01-26 Thread Martin K. Petersen
>>>>> "John" == John Garry writes: John> Not every arch has io, so fix build by adding necessary John> dependency. Ignore previous mail. Will apply this... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "

Re: [PATCH] hisi_sas: fix v1 hw check for slot error

2016-01-26 Thread Martin K. Petersen
a slot has an error. Also redundant check on John> CMPLT_HDR_CMD_CMPLT_MSK is removed. Applied to 4.5/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majo

Re: [PATCH v3] mptlan: add checks for dma mapping errors

2016-01-26 Thread Martin K. Petersen
Tomas> user bug report. This example nicely shows how easy it is to add Tomas> new bugs even when a fix looks trivial. Yeah, I'm inclined to leave it as is. If somebody provides a Tested-by: I'll reconsider. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe f

Re: [PATCH] lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl

2016-01-26 Thread Martin K. Petersen
annes> cases, hence we unify it again. Johannes> This probably is a left over from some sort of refactoring. James/Dick: Please review. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a messag

Re: [PATCH V3 7/9] aacraid: Fix AIF triggered IOP_RESET

2016-01-26 Thread Martin K. Petersen
n find a tiny Tomas> race window. What do you think about a mutual exclusive access Tomas> using a mutex, do you think this could work? [...] Raghava? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH v2 00/11] qla2xxx: Patches for scsi "misc" branch.

2016-01-28 Thread Martin K. Petersen
>>>>> "Himanshu" == Himanshu Madhani writes: Himanshu> Please apply following patches to the scsi tree, misc branch Himanshu> at your earliest convenience. Applied to 4.6/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH V1] scsi: export function scsi_scan.c:sanitize_inquiry_string

2016-01-28 Thread Martin K. Petersen
hpsa and the pqi Don> drivers can use this function directly. Applied to 4.6/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 00/15] megaraid_sas: Updates for scsi-next

2016-01-28 Thread Martin K. Petersen
>>>>> "Sumit" == Sumit Saxena writes: Sumit, Applied to 4.6/scsi-queue. Please make sure you put patch revision and feedback comments under the --- separator so they don't become part of the commit message. -- Martin K. Petersen Oracle Linux Engineering --

Re: [PATCHv2] SCSI: usd ida for host number management

2016-01-28 Thread Martin K. Petersen
>>>>> "Lee" == Lee Duncan writes: Lee> Update the SCSI hosts module to use ida to manage its host_no index Lee> instead of an ATOMIC integer. This means that the SCSI host number Lee> will now be reclaimable. Applied to 4.6/scsi-queue. -- Martin K. Petersen

Re: scsi_debug, iosize optimal < minimum

2016-02-01 Thread Martin K. Petersen
able version 4.1.15. For stable tree the last known working Ruediger> version is 4.1.13. http://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.5/scsi-fixes&id=d0eb20a863ba7dc1d3f4b841639671f134560be2 -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this

Re: [v2 PATCH 1/3] scsi:stex.c Support to Pegasus series.

2016-02-01 Thread Martin K. Petersen
>>>>> "Charles" == Charles Chiou writes: Charles> Does this patch has others issues need to fix? Please resubmit your patch series with the review tag from Johannes added. Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe f

Re: [PATCH 0/2] scsi_transport_fc: LUN masking

2016-02-01 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Hmm. this seemed to have fallen through -ENOREVIEWS So, yes. Please resend. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH V4 0/9] aacraid: Patchset for aacraid driver version 41052

2016-02-01 Thread Martin K. Petersen
_PM is not defined and address Tomas' comments for 7/9. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

<    4   5   6   7   8   9   10   11   12   13   >