Re: [PATCH] fnic: move printk()s outside of the critical code section.

urizio> printk()s because the same error message was printed twice. Applied to 4.6/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH 1/3] aacraid: add missing curly braces

>>>>> "Arnd" == Arnd Bergmann writes: Arnd> gcc-6 warns about obviously wrong indentation for newly added code Arnd> in aac_slave_configure(): Applied to 4.6/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send t

Re: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization

alvin> Since the code pulls the pointer for the next iteration at the Calvin> bottom of the loop, it triggers the a KASAN dump on the final Calvin> iteration: Broadcom folks, please review. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: sen

Re: [PATCH] megaraid_sas: fix missing { }, nullify kbuff_arr[i] only when necessary

: Please review. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sd: fixup capacity calculation for 4k drives

value and the new value always false for drives with a sector Hannes> size != 512. So introduce a 'new_capacity' carrying the new, Hannes> scaled, capacity. I agree with Christoph. How about something like this instead? -- Martin K. Petersen Oracle Linux Engineering commit

Re: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization

alvin> Since the code pulls the pointer for the next iteration at the Calvin> bottom of the loop, it triggers the a KASAN dump on the final Calvin> iteration: Applied to 4.6/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: sen

Re: [PATCH] megaraid_sas: fix missing { }, nullify kbuff_arr[i] only when necessary

>>>>> "Colin" == Colin King writes: Colin, Colin> Fix missing { } on if statement, this change will nullify Colin> kbuff_arr[i] only where necessary as the code intended. Arnd beat you to it. We already have a patch for this. Thanks! -- Martin K. Petersen

Re: [PATCH v3 0/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k

mus> was a bit exaggerated. After these patches are applied, the Rasmus> impact of choosing CONFIG_SCSI_CONSTANTS=y is about 36 KB, while Rasmus> it was about 44 KB before. I took the liberty of including Rasmus> Hannes' Reviewed-by and Douglas' Tested-by despite that Rasmus>

Re: [PATCH v4 00/23] ncr5380: Eliminate macros, reduce code duplication, fix bugs etc

NCR5380 and g_NCR5380_mmio on various ISA cards. Applied to 4.7/scsi-queue. And thanks for re-posting with all the relevant tags applied. Much appreciated! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCH] scsi: vpd pages are mandatory for SPC-2

ch that moves the vpd heuristic to scsi_device.h (I think you originally sent that as an inline RFC). In any case. This patch depends on it. Please resend these two as a series. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscri

Re: UFS V11 patch-set

>>>>> "Joao" == Joao Pinto writes: Joao, Joao> Isn't it possible to be merged into a ufs-dwc branch in the SCSI Joao> Git tree that could be pulled later, like Bjorn did in the PCIe Joao> RC? I just started 4.7/scsi-queue so now is a good time to res

Re: [PATCHv3] scsi: disable automatic target scan

he 'rescan' value to 'SCSI_SCAN_MANUAL' if invoked via the Hannes> 'scan' option in sysfs. Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 0/3] scsi trace updates

>>>>> "Hannes" == Hannes Reinecke writes: Hannes> here are some some small updates to scsi tracing; it fixes the Hannes> decoding for MAINTENANCE_IN and MAINTENANCE_OUT and adds Hannes> definitions for the new ZBC_IN and ZBC_OUT commands. Applied to 4.7/s

Re: [PATCH v2 0/2] Fix regression and performance issue in cxlflash

ush the limits of what constitutes "a bug fix". I let it slide because you submitted inside the merge window. Applied to 4.6/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

Re: [PATCH] sd: fixup capacity calculation for 4k drives

as going back and forth how to fix this. But in the end I find it really ugly that capacity suddenly changes from logical blocks to block layer sectors. And I prefer to make that conversion explicit when it is necessary. Amended patch follows... -- Martin K. Petersen Oracle Linux Engineerin

[PATCH v2] sd: Fix excessive capacity printing on devices with blocks bigger than 512 bytes

ays fail for devices with sectors bigger than 512 bytes and we would print several copies of the same discovery information. Avoid scaling sdkp->capacity and instead adjust the value on the fly when setting the block device capacity and generating fake C/H/S geometry. Signed-off-by: Martin K. Pe

Re: [PATCH 0/2] scsi_dh_alua fixes for kernel v4.6

>>>>> "Bart" == Bart Van Assche writes: Bart> Please consider the two patches in this series for inclusion in Bart> kernel v4.6. These patches are what I came up with while retesting Bart> the v4.6-rc1 scsi_dh_alua handler. The actual patches are: Applie

Re: [PATCH v1 1/3] Fix to cleanup aborted IO to avoid device being offlined by mid-layer

1.6.0.18 has been skipped I applied patches 1-3 to 4.7/scsi-queue. In the future, please make sure you add an "fnic:" prefix to the patch description so it's clear in the commit log which driver is being modified. Also, always run checkpatch before submitting. I had to fix up a

Re: [PATCH] scsi_transport_fc: Unexport scsi_is_fc_vport()

>>>>> "Bart" == Bart Van Assche writes: Bart> Running the command "git grep -nHw scsi_is_fc_vport" shows that Bart> this function is only called from inside Bart> scsi_transport_fc.c. Hence unexport this function. Applied to 4.7/scsi-queue. Thank

Re: [PATCH 1/3] qla2xxx: Indicate out-of-memory with -ENOMEM

>>>>> "Bart" == Bart Van Assche writes: Bart> In the Linux kernel it is preferred to return a meaningful error Bart> code instead of -1. This patch does not change the behavior of the Bart> caller of qla82xx_pinit_from_rom(). Applied to 4.7/scsi-queue. -- Ma

Re: [PATCH 1/2] scsi: Do not attach VPD to devices that don't support it

r this parts Hannes> and should be avoided so the check for scsi_level has been moved Hannes> out of scsi_add_lun and into scsi_attach_vpd so that all callers Hannes> will not scan VPD for devices that don't support it. Applied to 4.6/scsi-fixes, CC:stable 4.5+. Thanks! -- Martin K

Re: [PATCH 0/5] Fix several static checker warnings reported against the iSCSI kernel code

ode_con.patch Bart> 0005-scsi_transport_iscsi-Declare-local-symbols-static.patch Applied to 4.7/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@

Re: [PATCH v13 0/9] add support for DWC UFS Controller

by: tags you have gotten from people and apply them to patches that you haven't changed. Otherwise we start from scratch every time you resubmit. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&quo

Re: [PATCH 0/9] lpfc: Update to revision 11.1.0.0

>>>>> "James" == James Smart writes: James> This patch set updates the lpfc driver to revision 11.1.0.00 Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH 2/8] snic: LUN goes offline due to scsi cmd timeouts

u> Signed-off-by: Sesidhar Baddela --- Narsimhulu> drivers/scsi/snic/snic_scsi.c | 18 ++ 1 file Narsimhulu> changed, 18 insertions(+) Applied patches 1-8 to to 4.7/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the lin

Re: [PATCH 03/12] BUG: Losing bits on request.cmd_flags

hat cleans all this up. Please use that as baseline. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 0/2] Update SCSI target removal path

si-fixes and applied v4 to 4.7/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Cant write to max_sectors_kb on 4.5.0 SRP target

hysical block size <= OTLG <= OTL <= MTL Or in terms of queue_limits: lbs <= pbs <= io_min <= io_opt <= min_not_zero(max_dev_sectors, max_hw_sectors, max_sectors) -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line &qu

Re: [PATCH 2/2] scsi: vpd pages are mandatory for SPC-2

rebased 4.7/scsi-queue and applied patch 2/2. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Cant write to max_sectors_kb on 4.5.0 SRP target

; block queue sysfs interface. I should refresh the patch that exposes that. There were a few comments and I never got around to rolling those in. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the b

Re: [PATCH v3 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

>>>>> "Ming" == Ming Lin writes: Ming> Are we ready to merge it? We're still missing an ack from Sagi. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

Re: [PATCH v2 0/5] bnx2fc: Update driver to version 2.10.3.

>>>>> "Chad" == Chad Dupuis writes: Chad> Please apply the patch series for the next merge window at your Chad> earliest convenience. Applied to 4.7/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send t

Re: fnic: Using rport->dd_data to check rport online instead of rport_lookup.

.c:457 fnic_queuecommand_lck() warn: Dan> variable dereferenced before check 'rport' (see line 449) Satish? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...

Re: [PATCH v3] mvsas: Generalize Marvell 9485 in pci_device_id

>>>>> "Leonid" == Leonid Moiseichuk writes: Leonid> For generic subvendor has sense to use generic subdevice. If Leonid> subdevice ID not equal to 0x9480/0x9485 mvsas will be not Leonid> activated. Applied to 4.7/scsi-queue. Thank you! -- Martin K. Pete

Re: [PATCH] zfcp: Revert to original scanning behaviour

>>>>> "Hannes" == Hannes Reinecke writes: Hannes> zfcp has its own mechanism for selective scanning, so revert to Hannes> the original scanning behaviour to not confuse users. Benjamin? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH 0/5] hisi_sas: v2 hw SATA fixes

>>>>> "John" == John Garry writes: John> This patchset introduces SATA support fixes for the HiSilicon v2 John> hw SAS controller. Somebody please review. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "

Re: [PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io_req, save 1792 bytes

>>>>> "Denys" == Denys Vlasenko writes: Denys> This function compiles to 511 bytes of machine code. Abort Denys> commands are not time-critical at all. Satish, please review. https://patchwork.kernel.org/patch/8785281/ -- Martin K. Petersen Oracle Linu

Re: [PATCH 1/1] scsi: add Synology DSM 6.0 and higher to 1024 sector blacklist

>>>>> "Michel" == Michel Meyers writes: Michel> SYNOLOGY iSCSI devices do not work with large I/O and SYNOLOGY Michel> changed the identifier of the devices Shouldn't we just quirk SYNOLOGY, then? -- Martin K. Petersen Oracle Linux Engineering -- To

Re: [PATCH] zfcp: Revert to original scanning behaviour

>>>>> "Hannes" == Hannes Reinecke writes: Hannes> zfcp has its own mechanism for selective scanning, so revert to Hannes> the original scanning behaviour to not confuse users. Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To u

Re: [PATCH 1/1] scsi: add Synology DSM 6.0 and higher to 1024 sector blacklist

same problem as mine). Mike: Any preference? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] scsi: add Synology DSM 6.0 and higher to 1024 sector blacklist

>>>>> "Mike" == Mike Christie writes: >> Mike: Any preference? Mike> I think quirking SYNOLOGY is best. It will be the safest route and Mike> work for all devices. Michel: Please spin a new version of the patch. Thanks! -- Martin K. Petersen Oracl

Re: [PATCH v3 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

>>>>> "Ming" == Ming Lin writes: Ming> Are we ready to merge it? I have queued your patches in my for-next branch. Will let them simmer there for a bit so they can get tested in linux-next. Barring any problems I will shuffle them over to 4.7/scsi-queue at the en

Re: LSF/MM Schedule and improving discard support

se WRITE SAME, DISCARD and ANCHOR to implement their functionality based on the parameters reported by the underlying device. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message t

Re: [Lsf] LSF/MM Schedule and improving discard support

rity and alignment at all. Nowhere does it say that a request that is not an aligned multiple of any reported granularity should be considered "invalid" or rejected by the storage. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line &qu

Re: [Lsf] LSF/MM Schedule and improving discard support

gt; from sectors to logical blocks. This means that if a non-aligned Bart> BLKDISCARD is submitted from user space that one or more sectors Bart> *before* the start of the range specified in the ioctl will be Bart> discarded. Isn't that a bug? Yes. But Darrick already addressed that

Re: [PATCH 0/5] hisi_sas: v2 hw SATA fixes

ching multiple SATA John> disks - add support for directly attaching SATA disk to phy index John> 4+ - ITCT config issue Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

Re: [PATCH, RESEND 3] qla2xxx: Remove use of 'struct timeval'

>>>>> "Tina" == Tina Ruchandani writes: Tina, >> Applied to 4.6/scsi-queue. Tina> I am not seeing this patch in v4.6-rc3 in Linus's tree. Not sure how I messed that up. Sorry! Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engin

Re: [PATCH] pm80xx: Remove bogus address masking in pm8001_ioremap()

bits above bit-31 (arm64 for example) the result is an David> eventual OOPs when initializing the driver. David> Remove the bogus code to fix it. Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

>>>>> "Joe" == Joe Lawrence writes: Joe> Do we know why f1c35e6aea579 "mpt2sas: RESCAN Barrier work is added Joe> in case of HBA reset" was unneeded for the mpt3 version? If that Joe> is interesting, that info could be added to v2 commit message as

Re: [PATCH] mpt3sas: fix possible NULL dereference

gt; pci_pool_free() and pci_pool_destroy(). Broadcom folks, please review. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mpt3sas: Remove usage of 'struct timeval'

ead Tina> uses ktime_t which provides 64-bit seconds value. The timestamp Tina> computed remains unaffected (milliseconds since Unix epoch). Broadcom folks, please review. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "uns

Re: [PATCH 0/5] hisi_sas: v2 hw SATA fixes

>>>>> "John" == John Garry writes: John, John> Could these also be applied to 4.6 fixes branch? Maybe I should John> have explicitly asked. Only taking critical patches for 4.6 at this point. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH] mpt3sas: Remove usage of 'struct timeval'

ead Tina> uses ktime_t which provides 64-bit seconds value. The timestamp Tina> computed remains unaffected (milliseconds since Unix epoch). Applied to 4.7/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "uns

Re: [PATCH] scsi_dh_alua: Declare local functions static

>>>>> "Bart" == Bart Van Assche writes: Bart> This patch avoids that building with W=1 causes gcc to report the Bart> following type of warning: Bart> no previous prototype for ... [-Wmissing-prototypes] Applied to 4.7/scsi-queue. -- Martin K. Petersen

Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_rtpg()

ize it for Dan> every iteration through the retry loop. Applied to 4.6/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] megaraid_sas: Updates for scsi-next

>>>>> "Sumit" == Sumit Saxena writes: Sumit> This patchset has few small fixes/optimizations. Please consider Sumit> this for next release. Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send t

Re: [-next] BUG_ON in scsi_target_destroy()

mes> running target when it has no more scsi devices left on it. So James> the correct patch should be to make the BUG_ON see this: Commit amended. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 0/3] hisi_sas: device id/IPTT collision workaround

1 - SAS John> device id has no restriction John> The major restriction of this workaround is the SAS IPTT range is John> halved, but this should be ok as testing has shown that even using John> half the IPTT range does not affect performance. Applied to 4.7/scsi-queue. Thanks

Re: [PATCH v2] mpt3sas - remove unused fw_event_work elements

nup fw_event_work's unused entries, update it's kerneldoc, and Joe> update _scsih_fw_event_cleanup_queue accordingly. Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [patch] hpsa: set the enclosure identifier to zero

>>>>> "Dan" == Dan Carpenter writes: Dan> This has only called from show_sas_rphy_enclosure_identifier(). Dan> The caller expects that we set an identifier, otherwise it uses an Dan> unintialized variable. Applied to 4.7/scsi-queue. -- Martin K. Petersen

Re: [patch] bnx2i: silence uninitialized variable warnings

>>>>> "Dan" == Dan Carpenter writes: Dan> Presumably it isn't possible to have empty lists here, but my Dan> static checker doesn't know that and complains that "ep" can be Dan> used uninitialized. Applied to 4.7/scsi-queue. --

Re: [PATCH] lpfc: remove incorrect lockdep assertion

>>>>> "Sebastian" == Sebastian Herbszt writes: Sebastian> Remove incorrect lockdep assertion from Sebastian> lpfc_sli_hbqbuf_find() which acquires the hbalock itself. Fix Sebastian> the comment which resulted in this mistake. Applied to 4.7/scsi-queue. -- Ma

Re: [PATCH] st: clear ILI if Medium Error

>>>>> "Kai" == Kai Makisara writes: Kai> Some drives set the ILI flag together with MEDIUM ERROR sense Kai> code. Clear the ILI flag in this case so that the medium error will Kai> be handled. The problem was reported by Maurizio Lombardi. Applied to 4.7/s

Re: [PATCH 1/1] scsi: add Synology DSM 6.0 and higher to 1024 sector blacklist

the pre-6.0 SYNOLOGY volumes that are affected) and Michel> discard the new patch. Sounds good to me. Thanks for the update! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majo

Re: [PATCH] MAINTAINERS: Update the file list for the NCR 5380 entry

>>>>> "Finn" == Finn Thain writes: Finn> The file atari_NCR5380.c has been removed from the tree so remove Finn> it from the MAINTAINERS file as well. Finn> While we are here, add the file dtc3x80.txt as it is only relevant Finn> to the dtc driver. App

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

>>>>> "Josh" == Josh Poimboeuf writes: Josh> Can you merge this patch for 4.6? I am really not a big fan of working around compiler bugs in a device driver. Are we sure there are no other get_unaligned_be64() calls in the kernel that suffer the same fate? -- Ma

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

doing something similar. Converting between u64 and $RANDOM_TYPE in an inline wrapper does not seem like a rare and unusual programming pattern. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a mes

Re: [PATCH] scsi: fc: force inlining of wwn conversion functions

o revert >> that patch, to have a higher confidence in the same bug not appearing >> elsewhere. It's also really a workaround for another quirk of the >> compiler, but that one only results in duplicated functions in object >> code rather than functions that end in

Re: [SCSI] pm80xx: Phy settings support for motherboard controller.

om Sep 18, 2013, leads to the following >> static checker warning: >> >> drivers/scsi/pm8001/pm80xx_hwi.c:4554 mpi_set_phy_profile_req() >> error: uninitialized symbol 'tag'. >> Jack> Thanks for reporting, attached patch should fix the warning. Dan: Pl

Re: [PATCH 0/5] mpt3sas: driver update for Phase12

eference tag field for 4K PI drives. > mpt3sas: Set maximum transfer length per IO to 4MB for VDs > mpt3sas: Used "synchronize_irq()"API to synchronize timed-out IO & > TMs Somebody please review. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscr

Re: [PATCH] mptsas: fix checks for dma mapping errors

>>>>> "Alexey" == Alexey Khoroshilov writes: Alexey> mptsas_smp_handler() checks for dma mapping errors by comparison Alexey> returned address with zero, while pci_dma_mapping_error() should Alexey> be used. Broadcom folks, please review! -- Martin K. Pete

Re: UFS patchset

are OK from a SCSI perspective but I believe there were still a couple of concerns in the ARM/device tree department. So I would like some confirmation from those developers that the code is now acceptable. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: sen

Re: [PATCH 0/7] hpsa driver updates

; initialization hangs. - correct ioaccel change events - correct Don> ioaccel error checking - enhance hot-plug operations for HBA mode - Don> add a sysfs attribute for sas addresses - bump driver version Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/10] aacraid: Patchset for aacraid driver version 41066

>>>>> "Raghava" == Raghava Aditya Renukunta >>>>> writes: Raghava> This patchset contains the following changes(bug fixes, Raghava> features and code refactors) specific to the aacraid driver Applied to 4.7/scsi-queue. -- Martin K. Petersen

Re: [PATCH 00/12] scsi_debug: multiple queue support and cleanup

ed on the comments. Sounds like 8 and 9 need a bit of tweaking. 10-12 look fine but don't apply out of order. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel

Re: UFS patchset

>>>>> "Joao" == Joao Pinto writes: Joao, >> It is on my list. Joao> Ok, great! In a previous email you said you had sent v14 to linux-scsi. However, I don't see neither v14, nor v13 in patchworks. The latest I have is v12 and it does not apply to

Re: UFS patchset

>>>>> "Martin" == Martin K Petersen writes: Joao, Martin> In a previous email you said you had sent v14 to Martin> linux-scsi. However, I don't see neither v14, nor v13 in Martin> patchworks. The latest I have is v12 and it does not apply to Martin>

Re: [PATCH v5] qla1280: Don't allocate 512kb of host tags

eues. This Johannes> was introduced with the change for host wide tags in commit Johannes> 64d513ac31b - "scsi: use host wide tags by default". Johannes> Reduce can_queue to MAX_OUTSTANDING_COMMANDS (512) to solve Johannes> the allocation error. Applied to 4.6/scsi-fixes. --

Re: [PATCH 1/1] cxlflash: Fix to resolve dead-lock during EEH recovery

The symptom logged after a couple of minutes is: Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] megaraid: Downgrade two success messages to info

>>>>> "Andy" == Andy Lutomirski writes: Andy> I actually read the error messages in my logs, and successful Andy> initialization is not an error. Andy> Arguably these log lines could be deleted entirely. Applied to 4.7/scsi-queue. Thanks! -- Martin K. Pete

Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling

ns Dan> zero on success and negative on failure. Anil, please review: https://patchwork.kernel.org/patch/8820751/ -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to major

Re: [PATCH resend v2] [SCSI] bfa: fix bfa_fcb_itnim_alloc() error handling

>>>>> "Anil" == Anil Gurumurthy writes: Anil> Apologies for the delay. Patch looks good. Acked by: Anil Anil> Gurumurthy Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsu

Re: [PATCH v3 0/6] scsi_debug: multiple queue support and cleanup

patches in your series to 4.7/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi_dh_alua: do not fail for unknown VPD identification

nes> attach individual ALUA device handler to each devices. Applied to 4.7/scsi-queue with typo fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCHv2] scsi_lib: Decode T-10 vendor IDs

>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Some arrays / HBAs will only present T-10 vendor IDs, so we Hannes> should be decoding them, too. Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: s

Re: [PATCH] libfc: replace 'rp_mutex' with 'rp_lock'

>>>>> "Bart" == Bart Van Assche writes: Bart> Is what you describe a theoretical concern or have you observed Bart> any issues that could have been caused by the rport mutex? I believe Ewan had some data. Ewan? -- Martin K. Petersen Oracle Linux Engineer

Re: [PATCH] hpsa: Fix type ZBC conditional checks

tros> sees a device of a TYPE_DISK and moves on to the second Petros> statement checking if not TYPE_ZBC, it will always hit the Petros> continue. Did not apply to 4.7/scsi-queue. I merged it by hand. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: se

Re: [patch] [SCSI] eata_pio: missing break statement

>>>>> "Dan" == Dan Carpenter writes: Dan> This missing break statement bug predates git. It's a very minor Dan> thing, it means that we print a '?' instead of a 'z' in dmesg. Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle

Re: [PATCH 0/6] mpt3sas: driver update to Phase12.

ence tag field in the CDB. * Updated mpt3sas driver Chaitra> version to Ph12 13.100.00.00 * Set maximum transfer length per Chaitra> IO on RAID volumes to 4MB. * Use "synchronize_irq()"API to Chaitra> handle Asynchronous TM's completion. Applied to 4.7/scsi-queue. -- Marti

Re: [PATCH] sd: Optimal I/O size is in bytes, not sectors

I'll fix this up properly. I'll post a fix for 4.7 and older tomorrow... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] target: fix max discard sectors calculation

o use Bart> do_div() or >> (ilog2(block_size) - 9) instead? For the latter Bart> alternative no 64-bit cast is needed. Please use logical_to_sectors(). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 0/2] UFS DWC Test Chip pci driver tweaks

>>>>> "Joao" == Joao Pinto writes: Joao, Joao> This patch set has the tweaks that I described to you in an Joao> e-mail, all related with the ufs test chip pci driver. I have applied the amended series to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linu

Re: [PATCH] scsi_lib: correctly retry failed zero length REQ_TYPE_FS commands

ed even for retryable conditions, like UNIT James> ATTENTION because we complete them early assuming they're done. James> Fix this by special casing the early completion condition to James> recognise zero length commands with errors and let them drop James> through to the retry cod

Re: [PATCH] sd: get disk reference in sd_check_events()

>>>>> "Ewan" == Ewan D Milne writes: Ewan> Reviewed-by: Ewan D. Milne Applied to 4.7/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to ma

Re: [PATCH] aacraid: do not activate events on non-SRC adapters

>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Only SRC-based adapters support the AifReqEvent function, so Hannes> there is no point in trying to activate it on older, non-SRC Hannes> based adapters. Doing so lead to crashes on older adapters. Applie

Re: [PATCH 1/7] snic: fix typo

>>>>> "Julia" == Julia Lawall writes: Julia> firmare -> firmware Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord.

[PATCH] sd: Fix rw_max for devices that report an optimal xfer size

ot sectors") Cc: sta...@vger.kernel.org # 4.4+ Reported-by: Fam Zheng Signed-off-by: Martin K. Petersen --- drivers/scsi/sd.c | 8 drivers/scsi/sd.h | 5 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index f459dff30512..60bf

Re: [PATCH] [SCSI] aacraid: use kmemdup

>>>>> "Muhammad" == Muhammad Falak R Wani writes: Muhammad> Use kmemdup when some other buffer is immediately copied into Muhammad> allocated region. It replaces call to allocation followed by Muhammad> memcpy, by a single call to kmemdup. Applied to 4.8/s

Re: [PATCH 42/54] MAINTAINERS: Add file patterns for scsi device tree bindings

>>>>> "Geert" == Geert Uytterhoeven writes: Geert> Submitters of device tree binding documentation may forget to CC Geert> the subsystem maintainer if this is missing. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsub

Re: [PATCH] ufs: Adding license info do tc-dwc-g210 and ufshcd-dwc to enable loadable modules

>>>>> "Joao" == Joao Pinto writes: Joao> This patch adds license info to the tc-dwc-g210 and ufshcd-dwc Joao> files in order for them to have access to some ufshcd symbols when Joao> all are built as modules. Applied to 4.8/scsi-queue. -- Martin K. Petersen

<    2   3   4   5   6   7   8   9   10   11   >