Re: [PATCH] PCI/MSI: Only disable affinity settings if pre and post vector count is equal to max_vecs and not min_vecs

2017-02-22 Thread Martin K. Petersen
ettings causes the qla2xxx driver Himanshu> scsi_add_host to fail when blk_mq is enabled as the Himanshu> blk_mq_pci_map_queues expects affinity masks on each vector. Himanshu> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index [...] This should go through the PCI tree and

Re: [patch] scsi_dh_emc: return success in clariion_std_inquiry()

2017-02-22 Thread Martin K. Petersen
>>>>> "Dan" == Dan Carpenter writes: Dan, Dan> We accidentally return an uninitialized variable on success. Applied to 4.11/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: sense handling improvements

2017-02-22 Thread Martin K. Petersen
- maybe Christoph> it's best to send the whole series through the SCSI tree in Christoph> this case. I applied 1-4 to 4.11/scsi-fixes. Both 5 and 6 had problems so please fix those up. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCHv3 01/10] mpt3sas: switch to pci_alloc_irq_vectors

2017-02-22 Thread Martin K. Petersen
e too. I'll queue it up for 4.11 unless Broadcom objects. And then we'll do the rest for 4.12. -- Martin K. Petersen Oracle Linux Engineering

Re: sense handling improvements

2017-02-23 Thread Martin K. Petersen
to fix them up by hand. 5 was easy but 6 caused a flurry of failures that I ran out of time to look into. So please resubmit 5 and 6 against 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: sense handling improvements, part 2

2017-02-23 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> No real changes, but I did an explicit rebase against the Christoph> 4.11/scsi-fixes branch. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qedf: fixup compilation warning about atomic_t usage

2017-02-23 Thread Martin K. Petersen
>>>>> "Chad" == Dupuis, Chad writes: Chad> The driver didn't follow the atomic_t vs refcount_t change, and Chad> anyway one should be using kref_read() instead of accessing the Chad> counter inside an kref. Applied to 4.11/scsi-fixes. Thanks! -

Re: [PATCH] aacraid: Fixed expander hotplug for SMART family

2017-02-23 Thread Martin K. Petersen
ice addition code relies on Raghava> older device type, which prevents the hotplug of adapter Raghava> expanders. Raghava> Fixed by removing code that skips over Enclosure channels and Raghava> using the latest device type for addition or removal or Raghava> enclosure expanders. Appli

Re: [PATCHv4 01/12] mpt3sas: switch to pci_alloc_irq_vectors

2017-02-23 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Cleanup the MSI-X handling allowing us to use the PCI-layer Hannes> provided vector allocation. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: fix spelling mistake: "seperator" -> "separator"

2017-02-23 Thread Martin K. Petersen
>>>>> "Colin" == Colin King writes: Colin> trivial fix to spelling mistake in pr_err message Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] cciss: correct check map error.

2017-02-23 Thread Martin K. Petersen
>>>>> "Don" == Don Brace writes: Don> remove device driver failed to check map error messages Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] libiscsi: add lock around task lists to fix list corruption regression

2017-02-23 Thread Martin K. Petersen
se supported kernels have been backing out the lock Chris> split for while now, thanks to the efforts at IBM where a lab Chris> setup has the most reliable reproducer I've seen on this issue. Chris> This patch has been tested there successfully. Reviews, please! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi/mac_scsi: Fix MAC_SCSI=m option when SCSI=m

2017-02-23 Thread Martin K. Petersen
>>>>> "Finn" == Finn Thain writes: Finn> The mac_scsi driver still gets disabled when SCSI=m. This should Finn> have been fixed back when I enabled the tristate but I didn't see Finn> the bug. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/2] Add S6 support

2017-02-27 Thread Martin K. Petersen
ostly focused on regressions. I expect to commence merging code for 4.12 sometime next week. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi_error: count medium access timeout only once per EH run

2017-02-27 Thread Martin K. Petersen
re on behalf of all discovered devices. Regardless of whether said drives were still alive or not. Medium Access commands, however, would always get passed on to the physical drive for processing. So when a drive went pining for the fjords, TUR would always succeed whereas reads and writes would time out. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: use proper format string for dma_addr_t

2017-02-27 Thread Martin K. Petersen
>>>>> "Arnd" == Arnd Bergmann writes: Arnd> dma_addr_t may be either u32 or u64, depending on the kernel Arnd> configuration, and we get a warning for the 32-bit case: Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: use div_u64 for 64-bit division

2017-02-27 Thread Martin K. Petersen
mply use Arnd> div_u64(). Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qedi: Fix memory leak in tmf response processing.

2017-02-27 Thread Martin K. Petersen
>>>>> "Manish" == Manish Rangankar writes: Manish, Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] sd: close hole in > 2T device rejection when !CONFIG_LBDAF

2017-02-27 Thread Martin K. Petersen
; opinion - results in code that is easier to read. I'll take a closer look at your patch tomorrow. I am sympathetic to having a sanity check helper function. That would also give us a single place to filter out crackpot values reported by USB doodads. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: aacraid: remove redundant zero check on ret

2017-02-27 Thread Martin K. Petersen
Colin> too. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: ufs: Factor out ufshcd_read_desc_param

2017-02-27 Thread Martin K. Petersen
> can not rely on hardcoded values taken from 2.0 Michal> specification. This patch introduces reading these lengths per Michal> each device from descriptor headers at probe time to ensure Michal> their correctness. Subhash: I assume v2 still carries your Reviewed-by:? -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/3] Separate zone requests from medium access requests

2017-02-28 Thread Martin K. Petersen
st have Christoph> operations in struct block_device instead.. Yeah, I'm afraid I don't like this either. Short term I still think we should adjust in sd. And then maybe longer term revisit whether these hybrid commands should be something other than bios. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] libiscsi: add lock around task lists to fix list corruption regression

2017-02-28 Thread Martin K. Petersen
>>>>> "Chris" == Chris Leech writes: Chris> There's a rather long standing regression from the commit Chris> "libiscsi: Reduce locking contention in fast path" Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int

2017-02-28 Thread Martin K. Petersen
>>>>> "Colin" == Colin King writes: Colin> The call to qedi_setup_int is not updating the return code rc yet Colin> rc is being checked for an error. Fix this by assigning rc to the Colin> return code from the call to qedi_setup_int. Applied to 4.11/s

Re: [PATCH 0/3] Separate zone requests from medium access requests

2017-02-28 Thread Martin K. Petersen
but I don't think it's necessary. Just having a default for the req_op switch should suffice. I believe that was your original sd approach. If you post it again I'll have another look. And then I'll put the bigger completion rework back on my todo list. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v6] sd: Check for unaligned partial completion

2017-03-01 Thread Martin K. Petersen
Damien> the report and reset zone commands are ignored. In addition, as Damien> sd_done() is not called for passthrough requests, resid Damien> corrections are not done as intended by the initial mpt3sas Damien> patch. Thanks! Applied to 4.11/scsi-fixes with a Cc: to stable. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: ufs: Factor out ufshcd_read_desc_param

2017-03-01 Thread Martin K. Petersen
scriptor lengths we Michal'> can not rely on hardcoded values taken from 2.0 Michal'> specification. This patch introduces reading these lengths per Michal'> each device from descriptor headers at probe time to ensure Michal'> their correctness. Applied to 4.11/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] fnic: Adding Check Condition counter to misc fnicstats

2017-03-01 Thread Martin K. Petersen
>>>>> "Satish" == Satish Kharat writes: Satish, Satish> Just a simple counter of number of check conditions encountered Satish> on that host. Please test and review the following: https://patchwork.kernel.org/patch/9549777/ Thank you! -- Marti

Re: [PATCH] mpt3sas: Avoid sleeping in interrupt context

2017-03-02 Thread Martin K. Petersen
Bart> interrupt handler. Hence add a second argument to Bart> scsi_internal_device_block() that restores the old behavior of Bart> this function for the mpt3sas handler. Applied to 4.11/scsi-fixes. Thanks, Bart! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] [v2] scsi: qedi: fix build error without DEBUG_FS

2017-03-06 Thread Martin K. Petersen
>>>>> "Arnd" == Arnd Bergmann writes: Arnd> Without CONFIG_DEBUG_FS, we run into a link error: Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: Fix ql_dump_buffer

2017-03-06 Thread Martin K. Petersen
>>>>> "Joe" == Joe Perches writes: Joe> Recent printk changes for KERN_CONT cause this logging to be Joe> defectively emitted on multiple lines. Fix it. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] aacraid: Fix typo in blink status

2017-03-06 Thread Martin K. Petersen
>>>>> "Raghava" == Raghava Aditya Renukunta >>>>> writes: Raghava> The return status of the adapter check on KERNEL_PANIC is Raghava> supposed to be the upper 16 bits of the OMR status register. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qedf: Use vsprintf extension %pad

2017-03-06 Thread Martin K. Petersen
>>>>> "Joe" == Joe Perches writes: Joe> Using %llx for a dma_addr_t can lead to format/argument mismatches. Joe> Use %pad and the address of the dma_addr_t instead. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-03-06 Thread Martin K. Petersen
ethod. Mauricio> @mkp, @jejb: may you please flag this patch for stable? Thank Mauricio> you. I don't recall a consensus being reached on this patch. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] vmw_pvscsi: handle the return value from pci_alloc_irq_vectors correctly

2017-03-06 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> It returns the number of vectors allocated when successful, Christoph> so check for a negative error only. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: replace init_timer by setup_timer

2017-03-06 Thread Martin K. Petersen
nor remove any existing functionality. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 00/20] lpfc: Update lpfc to revision 11.2.0.10

2017-03-06 Thread Martin K. Petersen
atches in this series felt quite a bit bigger than "a fix". I let them in because I acknowledge that it was a pretty big chunk of code that just got merged and that some fallout was inevitable. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 01/16] lpfc: Correct WQ creation for pagesize

2017-03-07 Thread Martin K. Petersen
I can't tag them for stable. Either you or James should mail sta...@vger.kernel.org and request for the patches to be queued up. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: Add shutdown method for kexec

2017-03-07 Thread Martin K. Petersen
>>>>> "Mauricio" == Mauricio Faria de Oliveira >>>>> writes: Mauricio> I think I should have included this in the tested-by tag Mauricio> email, for documentation/evidence: no regression observed in Mauricio> system shutdown path. Applied to 4.1

Re: [PATCH] storvsc: workaround for virtual DVD SCSI version

2017-03-07 Thread Martin K. Petersen
n> By setting the correct blacklist flags, the target with the DVD Stephen> device is scanned with REPORTLUN and that works correctly. Applied to 4.11/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 01/16] lpfc: Correct WQ creation for pagesize

2017-03-07 Thread Martin K. Petersen
ck from a scsi maintainer that this is an ok thing to Greg> do before I can do so. It's fine with me. This was merged as part of a bigger driver update. And as a result, the patch in question wasn't tagged as a fix/stable candidate. -- Martin K. Petersen Oracle Linux Engineering

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-07-21 Thread Martin K. Petersen
gned not so much. In general, I think this could be made much simpler if you treated the single reply_queue region as a subset of the multi region ditto. It would avoid a lot of code duplication throughout. You should really only need to make the distinction when you calculate the number of reply

Re: [PATCH 2/3] scsi: add a symbolic name for the ZBC device type

2014-07-21 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Make sure we have a symbolic name for the ZBC type available, Christoph> so that e.g. patch for a SATA to translate ZAC commands can Christoph> make use of it. Reviewed-by: Martin K. Petersen -- Ma

Re: [PATCH 1/3] scsi: update scsi_device_types

2014-07-21 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Add two new device types, most importantly the zoned block Christoph> device one. Christoph> + "Direct-Access-ZBC", Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux

Re: [PATCH 3/3] scsi: move the writeable from struct scsi_device to struct scsi_cd

2014-07-21 Thread Martin K. Petersen
stoph> Just leave this entirely to the CDROM driver to make Christoph> everyones life simpler. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message t

Re: [PATCH 01/14] scsi: add scsi_setup_cmnd helper

2014-07-21 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Factor out command setup code that will be shared with the Christoph> blk-mq code path. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this l

Re: [PATCH 02/14] scsi: split __scsi_queue_insert

2014-07-21 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Factor out a helper to set the _blocked values, which we'll Christoph> reuse for the blk-mq code path. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsub

Re: [PATCH 03/14] scsi: centralize command re-queueing in scsi_dispatch_fn

2014-07-21 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Make sure we only have the logic for requeing commands in one Christoph> place. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: s

Re: [PATCH 04/14] scsi: set ->scsi_done before calling scsi_dispatch_cmd

2014-07-21 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> The blk-mq code path will set this to a different function, Christoph> so make the code simpler by setting it up in a legacy-request Christoph> specific place. Reviewed-by: Martin K. Petersen -- Ma

Re: [PATCH 05/14] scsi: push host_lock down into scsi_{host,target}_queue_ready

2014-07-21 Thread Martin K. Petersen
Christoph> will actually increase lock roundtrips and thus decrease Christoph> performance on its own. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a m

Re: [PATCH 06/14] scsi: convert target_busy to an atomic_t

2014-07-21 Thread Martin K. Petersen
nessecary decrement it Minor nit: necessary Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH 07/14] scsi: convert host_busy to atomic_t

2014-07-21 Thread Martin K. Petersen
eue, and if nessecary decrement it necessary Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/14] scsi: convert host_busy to atomic_t

2014-07-21 Thread Martin K. Petersen
uct scsi_device *sdev = to_scsi_device(dev); + return snprintf(buf, 20, "%d\n", atomic_read(&sdev->device_busy)); +} +static DEVICE_ATTR(device_busy, S_IRUGO, sdev_show_device_busy, NULL); Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-07-22 Thread Martin K. Petersen
mpt2sas_base.h | 18 - 2 files changed, 558 insertions(+), 383 deletions(-) My patch: mpt2sas_base.c | 207 + mpt2sas_base.h | 18 +++- 2 files changed, 166 insertions(+), 59 deletions(-) commit ef510bd8dc0e43f8

Re: mpt2sas and mpt3sas merge (again)

2014-07-22 Thread Martin K. Petersen
of chip generations and firmware interface versions with a single driver. The problem I have with the mpt2sas/mpt3sas split is that there are way more commonalities than there are differences. It is trivial to handle multiple scatterlist format and features in a single driver. You guys already do th

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-07-23 Thread Martin K. Petersen
t; releasing these pools once we get the required memory pools. Why don't you just set pci_set_consistent_dma_mask() to DMA_BIT_MASK(32) before you allocate the queue entries? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Martin K. Petersen
we were trying to avoid with this patch series. Namely sending down commands unsupported by the target device. This kind of thing really needs to be a sysadmin decision and can be handled with a udev rule. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-24 Thread Martin K. Petersen
ives that are known to be working correctly. Your drive is an ADATA and therefore very likely to be blacklisted by default by a vendor SATL. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-25 Thread Martin K. Petersen
ation? One challenge in that department is that a single UNMAP command may turn into many, many, many DSM TRIM commands on the underlying SATA device. That's why we went with WRITE SAME for the internal Linux SATL, capping the maximum number of blocks to what we can fit in a single DSM TRIM co

Re: [PATCH 09/14] scsi: fix the {host,target,device}_blocked counter mess

2014-07-25 Thread Martin K. Petersen
to check for > 0 Christoph> values. Longer term every successful I/O completion will Christoph> reset the counters to zero, so the temporarily negative Christoph> values will not cause any harm. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To

Re: [PATCH 10/14] scsi: only maintain target_blocked if the driver has a target queue limit

2014-07-25 Thread Martin K. Petersen
Christoph> offload drivers set the per-target can_queue value at the Christoph> moment. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [PATCH 11/14] scsi: unwind blk_end_request_all and blk_end_request_err calls

2014-07-25 Thread Martin K. Petersen
gt; actual completion, and making the old code follow that same Christoph> model allows us to keep the code more similar for both paths. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH 12/14] scatterlist: allow chaining to preallocated chunks

2014-07-25 Thread Martin K. Petersen
mq code can preallocate a first page worth of S/G Christoph> entries as part of the request, and dynamically extend the Christoph> S/G list when needed. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line &quo

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-07-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> This patch adds support for an alternate I/O path in the scsi Christoph> midlayer which uses the blk-mq infrastructure instead of the Christoph> legacy request code. Reviewed-by: Martin K. Petersen

Re: [PATCH 14/14] fnic: reject device resets without assigned tags for the blk-mq case

2014-07-25 Thread Martin K. Petersen
ork Christoph> for real, but until that happens we fail these explicit Christoph> requests here. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-07-25 Thread Martin K. Petersen
y the time this is called. But to be sure you can call _base_config_dma_addressing() after you're done with the RDPQ allocations (or rearrange the code so you allocate RDPQ before the DMA mask is upped in general). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from th

[PATCH] [SCSI] Make scsi_transfer_length take a scsi_data_buffer argument

2014-07-25 Thread Martin K. Petersen
: Martin K. Petersen Cc: Sagi Grimberg Cc: Christoph Hellwig --- drivers/scsi/libiscsi.c| 2 +- drivers/target/loopback/tcm_loop.c | 2 +- include/scsi/scsi_cmnd.h | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/libiscsi.c b/drivers

Block/SCSI data integrity update v2

2014-07-25 Thread Martin K. Petersen
sor functions [10/14] - Augmented patch description for the integrity checksum flag [11/14] - T10 library relocated to block/ [13/14] - A couple of tweaks in the sd patch to make things work on top of the current SCSI queue tree [14/14] -- Martin K. Petersen Oracle Linux Engineering -- To unsubs

[PATCH 02/14] block: Replace bi_integrity with bi_special

2014-07-25 Thread Martin K. Petersen
a pointer to the integrity payload (when applicable). Signed-off-by: Martin K. Petersen --- Documentation/block/data-integrity.txt | 10 +- block/bio-integrity.c | 19 ++- drivers/scsi/sd_dif.c | 8 include/linux/bio.h

[PATCH 09/14] block: Add a disk flag to block integrity profile

2014-07-25 Thread Martin K. Petersen
protection information. Signed-off-by: Martin K. Petersen Reviewed-by: Sagi Grimberg --- Documentation/ABI/testing/sysfs-block | 8 block/blk-integrity.c | 12 drivers/scsi/sd_dif.c | 8 +++- include/linux/blkdev.h| 1 + 4

[PATCH 03/14] block: Remove integrity tagging functions

2014-07-25 Thread Martin K. Petersen
None of the filesystems appear interested in using the integrity tagging feature. Potentially because very few storage devices actually permit using the application tag space. Remove the tagging functions. Signed-off-by: Martin K. Petersen Reviewed-by: Christoph Hellwig --- Documentation

[PATCH 06/14] block: Make protection interval calculation generic

2014-07-25 Thread Martin K. Petersen
Now that the protection interval has been detached from the sector size we need to be able to handle sizes that are different from 4K and 512. Make the interval calculation generic. Signed-off-by: Martin K. Petersen --- block/bio-integrity.c | 6 +- 1 file changed, 1 insertion(+), 5

[PATCH 08/14] block: Add prefix to block integrity profile flags

2014-07-25 Thread Martin K. Petersen
Add a BLK_ prefix to the integrity profile flags. Also rename the flags to be more consistent with the generate/verify terminology in the rest of the integrity code. Signed-off-by: Martin K. Petersen Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg --- block/bio-integrity.c | 4

[PATCH 12/14] block: Don't merge requests if integrity flags differ

2014-07-25 Thread Martin K. Petersen
We'd occasionally merge requests with conflicting integrity flags. Introduce a merge helper which checks that the requests have compatible integrity payloads. Signed-off-by: Martin K. Petersen Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg --- block/blk-integrity.c

[PATCH 01/14] block: Get rid of bdev_integrity_enabled()

2014-07-25 Thread Martin K. Petersen
bdev_integrity_enabled() is only used by bio_integrity_enabled(). Combine these two functions. Signed-off-by: Martin K. Petersen Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg --- Documentation/block/data-integrity.txt | 10 - block/bio-integrity.c | 39

[PATCH 07/14] block: Clean up the code used to generate and verify integrity metadata

2014-07-25 Thread Martin K. Petersen
Instead of the "operate" parameter we pass in a seed value and a pointer to a function that can be used to process the integrity metadata. The generation function is changed to have a return value to fit into this scheme. Signed-off-by: Martin K. Petersen Reviewed-by: Sagi Grimberg

[PATCH 10/14] block: Relocate bio integrity flags

2014-07-25 Thread Martin K. Petersen
Move flags affecting the integrity code out of the bio bi_flags and into the block integrity payload. Signed-off-by: Martin K. Petersen Reviewed-by: Sagi Grimberg --- block/bio-integrity.c | 4 ++-- drivers/scsi/sd_dif.c | 4 ++-- include/linux/bio.h | 9 - include/linux

[PATCH 04/14] block: Remove bip_buf

2014-07-25 Thread Martin K. Petersen
bip_buf is not really needed so we can remove it. Signed-off-by: Martin K. Petersen Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg --- block/bio-integrity.c | 10 ++ include/linux/bio.h | 3 --- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/block/bio

[PATCH 11/14] block: Integrity checksum flag

2014-07-25 Thread Martin K. Petersen
on the HBA. Signed-off-by: Martin K. Petersen --- block/bio-integrity.c | 3 +++ drivers/scsi/sd_dif.c | 6 -- include/linux/bio.h| 1 + include/linux/blkdev.h | 1 + 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/block/bio-integrity.c b/block/bio-integrity.c index

[PATCH 13/14] block: Add T10 Protection Information functions

2014-07-25 Thread Martin K. Petersen
The T10 Protection Information format is also used by some devices that do not go through the SCSI layer (virtual block devices, NVMe). Relocate the relevant functions to a block layer library that can be used without involving SCSI. Signed-off-by: Martin K. Petersen Reviewed-by: Christoph

[PATCH 14/14] sd: Honor block layer integrity handling flags

2014-07-25 Thread Martin K. Petersen
property. Update sd_protect_op to communicate the relevant information to the low-level device driver via a set of flags in scsi_cmnd. Signed-off-by: Martin K. Petersen --- drivers/scsi/sd.c| 73 drivers/scsi/sd.h| 66

[PATCH 05/14] block: Deprecate the use of the term sector in the context of block integrity

2014-07-25 Thread Martin K. Petersen
l be used to describe the portion of the data buffer that a given piece of protection information is associated with. Signed-off-by: Martin K. Petersen --- block/bio-integrity.c | 42 +- block/blk-integrity.c | 10

Re: Block/SCSI data integrity update v2

2014-07-26 Thread Martin K. Petersen
agger their merges when we do this. But it would definitely be easier to just pull everything through SCSI. Except for the tweak in blk-merge.c I don't touch anything that would interfere with block code outside of the data integrity files. Jens, what do you think? -- Martin K. Petersen

Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-26 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Here's a formal one. James, can I get your signoff for it? Christoph> Vladimir, can I get a reviewed-by from you (or anyone else)? Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle

Re: [PATCH] eata: remove driver_lock

2014-07-26 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Can I get a quick review for this one? Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread Martin K. Petersen
al details. Great! I'd just like to have a reasonable level of confidence in what's happening down the stack before I entertain turning something on that's not being properly advertised. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread Martin K. Petersen
TY(16) response. The LBP VPD is correctly provided with LBPU flag set but because LBPME is reported as disabled we will not attempt to issue UNMAP commands to the device. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-28 Thread Martin K. Petersen
ovisioned) in the Logical Block Provisioning VPD page (see 6.6.4). That's a "shall". The LBP VPD elaborates on the provisioning type, commands preference, etc. But it's all gated by LBPME=1 in the READ CAPACITY(16) response. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] Do not issue SCSI RSOC command to Promise Vtrak E610f sd_mod RSOC usage

2014-07-29 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> ping? ÍI'd really like to get a review on this one and merge Christoph> it for 3.17 Looks good to me. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-29 Thread Martin K. Petersen
>>>>> "KY" == KY Srinivasan writes: KY> We will fix this bug in the next release of Windows; we are also KY> looking at backporting the fix to prior versions of Windows. Excellent. Thanks for looking into this! -- Martin K. Petersen Oracle Linux Engineer

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-08-05 Thread Martin K. Petersen
ay_enable && (++i < ioc->reply_queue_count)); Same thing. I think: for (i = 0; i < ioc->reply_queue_count ; i++) { was much clearer. If reply_queue_count is ever inconsistent wrt. ioc->rdpq_array_enable and _base_is_controller_msix_enabled(ioc) then that's an orthogonal pr

Re: [PATCH] [SCSI] Make scsi_transfer_length take a scsi_data_buffer argument

2014-08-06 Thread Martin K. Petersen
buffers is unnecessary and a bit of a burden. Unless it's a bidi command there is only one buffer. I don't think there's an inherent win in having multiple names for it depending on I/O direction. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list:

Re: [PATCH v2 2/3] libiscsi, iser: Adjust data_length to include protection information

2014-08-06 Thread Martin K. Petersen
ields in the DIF data buffer Sagi> (usually this is offloaded). READ CAPACITY returns a block size of 512 even though the blocks on disk are 520. That's the beauty of it. At the command level all transfers are expressed in number of blocks, not bytes. The application will see an N x 512 byt

Re: [RESEND][PATCH 07/10][SCSI]mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2014-08-11 Thread Martin K. Petersen
>>>>> "Sreekanth" == Sreekanth Reddy writes: Sreekanth> Please let me known any further changes are required so that Sreekanth> I can send this patch once again with git send-email. I'm OK with the latest iteration. -- Martin K. Petersen Oracle Linu

Re: [PATCH 2/3] scsi_debug: give unit attention and other errors precedence over TSF

2014-08-18 Thread Martin K. Petersen
Doug> like Unit Attentions are not hidden and lost by either max_queue Doug> exceeded or real/injected TSFs. Doug> Signed-off-by: Douglas Gilbert Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "uns

Re: [PATCH 1/3] scsi_debug: scsi_cmnd->cmnd check and casts unnecessary

2014-08-18 Thread Martin K. Petersen
ed as Doug> the pointer has that type. Doug> Signed-off-by: Douglas Gilbert Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vg

Re: [PATCH 3/3] scsi_debug: bump inquiry version to SPC-4, update version descriptors

2014-08-18 Thread Martin K. Petersen
ed-off-by: Douglas Gilbert Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_map_sg()

2014-08-20 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Can I get a review for this one, please? Looks good to me. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubsc

Re: [RFC 09/10] scsi: sd: Avoid sending medium write commands if device is write protected

2014-08-20 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> This looks reasonable to me. I agree. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH/RESEND] scsi.mq: Added use_cmd_list flag in scsi_host to reduce lock contention

2014-08-20 Thread Martin K. Petersen
ap> changes. Kashyap> Signed-off-by: Kashyap Desai Looks good to me. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

<    1   2   3   4   5   6   7   8   9   10   >