Re: [PATCH] scsi: qedi: select UIO

2017-01-10 Thread Martin K. Petersen
uild warnings. But we're still looking for a long term fix or an explanation as to why UIO is needed in the first place. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord..

Re: [PATCH V7 00/11] megaraid_sas: Updates for scsi-next

2017-01-10 Thread Martin K. Petersen
>>>>> "Sasikumar" == Sasikumar Chandrasekaran >>>>> writes: Sasikumar> Sasikumar Chandrasekaran (11): Sasikumar> megaraid_sas: driver version upgrade Applied patches 1 through 11 to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engi

Re: [PATCH] vmw_pvscsi: switch to pci_alloc_irq_vectors

2017-01-11 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> And simply the interrupt handler by splitting the INTx case Christoph> that needs to deal with shared interrupts into a separate Christoph> helper. Applied to 4.11/scsi-queue. -- Martin K. Petersen

Re: [PATCH v1] scsi: ufs: fix arguments order some trace calls

2017-01-11 Thread Martin K. Petersen
>>>>> "Subhash" == Subhash Jadavani writes: Subhash> Colin Ian King reported that with Subhash> commit 7ff5ab473633 ("scsi: ufs: add tracing support") static Subhash> analysis is reporting that we may have swapped arguments on Subhash> calls to: [

Re: two fixes for the qla2xxx MSI-X changes in 4.10-rc

2017-01-11 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Hi Himanshu, two small updates to to a) fix the way affinity Christoph> is assigned for qla2xxx, and b) remove the dead interrupt Christoph> affinity notifiers. Applied to 4.10/scsi-fixes. -- Ma

Re: [PATCH] qla4xxx: remove two unused MSI-X related #defines

2017-01-11 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Spotted while preparing qla2xxx changes as the symbols exist Christoph> in both drivers (sigh..). Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH] lpfc: avoid double free of resource identifiers

2017-01-11 Thread Martin K. Petersen
ry again. Applied to 4.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/4] cxlflash: Enhancements, cleanup and fixes

2017-01-11 Thread Martin K. Petersen
>>>>> "Uma" == Uma Krishnan writes: Uma> This patch series includes an enhancement to support a new command Uma> queuing model and also cleans up prints throughout the driver. The Uma> last patch in the series fixes a racing issue. Applied to 4.11/scsi-queue.

Re: [PATCH] libfc: Fix variable name in fc_set_wwpn

2017-01-16 Thread Martin K. Petersen
>>>>> "Fam" == Fam Zheng writes: Fam> The parameter name should be wwpn instead of wwnn. Applied to 4.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2

2017-01-16 Thread Martin K. Petersen
>>>>> "Don" == Don Brace writes: Don, Don> Wondering what has happened to this patch? According to my notes, there were some concerns with the series that did not get addressed. And only patch 3 actually got a reviewed-by tag. I suggest you repost the ser

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2017-01-16 Thread Martin K. Petersen
nd ack as soon as possible so we can get this fix queued up. Ingo: Since you appear to have hardware, it would be great if you could test James' v3 (https://patchwork.kernel.org/patch/9519383/). Sorry for the inconvenience. -- Martin K. Petersen Oracle Linux Engineering -- To unsubs

Re: [PATCH] ses: Fix SAS device detection in enclosure

2017-01-16 Thread Martin K. Petersen
v_gendev)) Ewan> + if (scsi_is_sas_rphy(sdev->sdev_target->dev.parent)) Ewan> efd.addr = sas_get_address(sdev); Ewan> if (efd.addr) { Ewan> -- 1.8.3.1 James? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH] ses: Fix SAS device detection in enclosure

2017-01-17 Thread Martin K. Petersen
>>>>> "Ewan" == Ewan D Milne writes: Ewan> The call to scsi_is_sas_rphy() needs to be made on the SAS Ewan> end_device, not on the SCSI device. Applied to 4.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: s

Re: [PATCH] Set elsiocb contexts to NULL after freeing it

2017-01-17 Thread Martin K. Petersen
>>>>> "Johannes" == Johannes Thumshirn writes: Johannes> Dick, James, any comments? I'd really like to get this in soon Johannes> as it solves customer issues. Ping? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

Re: [PATCH] bfa: fix wrongly initialized variable in bfad_im_bsg_els_ct_request()

2017-01-17 Thread Martin K. Petersen
s_ct_request() Johannes> is initialized to itself instead of pointing to the bsg job's Johannes> request. Applied to 4.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

Re: [PATCH 0/2] sd fixes for zoned block devices

2017-01-17 Thread Martin K. Petersen
gt; page for host-managed zoned block devices as there is no good Damien> match defined explicitely for HM by the standard. Damien> Damien Le Moal (2): sd: Fix wrong DPOFUA disable in Damien> sd_read_cache_type sd: Ignore zoned field for host-managed Damien> devices Applied to 4.1

Re: [bug report] scsi: lpfc: Reinstate lpfc_soft_wwn parameter

2017-01-17 Thread Martin K. Petersen
_store() info: Dan> return a literal instead of 'rc' James? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: mpt3sas: fix hang on ata passthru commands

2017-01-17 Thread Martin K. Petersen
it would be good Christoph> to give bit 0 of the bitmap a name instead of hardcoding the Christoph> 0. I tweaked the test case. We can name the bit later if more flags are needed (and in that case the ata_command_pending would need to get renamed too). In any case. This issue has taken w

Re: [PATCH] scsi: lpfc: Replace BUG() with BUG_ON()

2017-01-20 Thread Martin K. Petersen
>>>>> "Shyam" == Shyam Saini writes: Shyam> Replace BUG() with BUG_ON() using coccinelle Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH] Set elsiocb contexts to NULL after freeing it

2017-01-20 Thread Martin K. Petersen
>>>>> "Johannes" == Johannes Thumshirn writes: Johannes> Set the elsiocb contexts to NULL after freeing as others Johannes> depend on it. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the l

Re: [PATCH] Set elsiocb contexts to NULL after freeing it

2017-01-20 Thread Martin K. Petersen
>>>>> "Martin" == Martin K Petersen writes: >>>>> "Johannes" == Johannes Thumshirn writes: Johannes> Set the elsiocb contexts to NULL after freeing as others Johannes> depend on it. Martin> Applied to 4.11/scsi-queue. Replied to the w

Re: [PATCH -next] scsi: be2iscsi: Use GFP_ATOMIC under spin lock

2017-01-20 Thread Martin K. Petersen
>>>>> "Wei" == Wei Yongjun writes: Wei> From: Wei Yongjun A spin lock is taken Wei> here so we should use GFP_ATOMIC. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsu

Re: [PATCH] sd: Cleaned up comment references to @sdp argument explanation.

2017-01-20 Thread Martin K. Petersen
>>>>> "John" == John Pittman writes: John> In sd.c there are two comment references to 'struct scsi_device John> *sdp' as an argument. One of the references has a typo and the John> other should be a reference to 'struct device *dev' instead

Re: [PATCH v2 0/7] hisi_sas: SATA IO workaround and other misc patches

2017-01-20 Thread Martin K. Petersen
TIMEOUT in ITCT struct Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] virtio_scsi: Reject commands when virtqueue is broken

2017-01-20 Thread Martin K. Petersen
emoval from the guest viewpoint. Applied to 4.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi_debug: Add OPTIMAL TRANSFER LENGTH GRANULARITY option.

2017-01-20 Thread Martin K. Petersen
ck_size. No objection to the functionality but I don't really like the naming scheme. There are many granularities in SBC so "gran" isn't particularly descriptive. How about opt_xferlen_exp or something like that? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscri

Re: [PATCH] be2iscsi: switch to pci_alloc_irq_vectors

2017-01-20 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> And get automatic MSI-X affinity for free. Jitendra? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

Re: [PATCH] csiostor: switch to pci_alloc_irq_vectors

2017-01-20 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> And get automatic MSI-X affinity for free. Chelsio folks: Please review and test! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-25 Thread Martin K. Petersen
>>>>> "Finn" == Finn Thain writes: Finn> Michael, Ondrej, can I get you to review/test please? Pretty please! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a mes

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-01-25 Thread Martin K. Petersen
aiting for a resolution on patch 2... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash

2017-01-25 Thread Martin K. Petersen
>>>>> "Mauricio" == Mauricio Faria de Oliveira >>>>> writes: Hi Mauricio, Mauricio> First of all, sorry for the new bug; I didn't realize the Mauricio> pointer could be NULL at this scenario. Please do a proper patch submission for

Re: [PATCH 00/24] aacraid: Patchset for Smart Family card support

2017-01-25 Thread Martin K. Petersen
>>>>> "Raghava" == Raghava Aditya Renukunta >>>>> writes: Hi Raghava, Raghava> This patchset adds support to the HBA1000 and SMARTIOC2000 Raghava> family of cards. The driver version to now updated to 50740 Please address the kbuild test rob

Re: [PATCH] scsi_debug: Add OPTIMAL TRANSFER LENGTH GRANULARITY option.

2017-01-25 Thread Martin K. Petersen
>>>>> "Lukas" == Lukas Herbolt writes: Hi Lukas, Lukas> Sounds ok to me. Whitespace all messed up. Please send a real patch. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH v2] mpt3sas: Force request partial completion alignment

2017-01-25 Thread Martin K. Petersen
voided (xfer_cnt=%u, sector_sz=%u)\n", + xfer_cnt, sector_sz); + xfer_cnt = (xfer_cnt / sector_sz) * sector_sz; Not so keen on divisions. xfer_cnt = round_down(xfer_cnt, sector_sz), maybe? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH] sd: always scan VPD pages if thin provisioning is enabled

2017-01-25 Thread Martin K. Petersen
t to WS16 unless the device reports the UNMAP parameters in the Block Limits VPD. That has been a very solid heuristic for a long time so please don't mess with that. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [patch] qla4xxx: remove some bogus casts

2017-01-25 Thread Martin K. Petersen
>>>>> "Bart" == Bart Van Assche writes: Hi Bart, Bart> Do you need more reviews to queue this patch? It's more than a month old and consequently it doesn't exist :). Please repost. -- Martin K. Petersen Oracle Linux Engineering -- To uns

Re: [PATCH] Revert "sd: remove __data_len hack for WRITE SAME"

2017-01-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Thanks Bart, and sorry for messing this up. Acked-by: Christoph> Christoph Hellwig Jens: Since this came in via your tree would you mind reverting it? I'd prefer to avoid rebasing my fixes b

Re: [PATCH 01/18] block: add a op_is_flush helper

2017-01-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> This centralizes the checks for bios that needs to be go into Christoph> the flush state machine. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH 02/18] md: cleanup bio op / flags handling in raid1_write_request

2017-01-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> No need for the local variables, the bio is still live and we Christoph> can just assigned the bits we want directly. Make me wonder Christoph> why we can't assign all the bio flags to start

Re: [PATCH 03/18] block: fix elevator init check

2017-01-25 Thread Martin K. Petersen
or the flush flags in __get_request. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 04/18] block: simplify blk_init_allocated_queue

2017-01-25 Thread Martin K. Petersen
as Christoph> passing them as argument doesn't simplify anything. While Christoph> we're at it also remove two pointless NULL assignments, given Christoph> that the request structure is zeroed on allocation. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracl

Re: [PATCH 05/18] block: allow specifying size for extra command data

2017-01-25 Thread Martin K. Petersen
on the else brackets a couple of places. But no biggie. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 08/18] scsi_dh_rdac: switch to scsi_execute_req_flags()

2017-01-25 Thread Martin K. Petersen
EQ_PREEMPT, but this is okay as we're Christoph> evaluating the errors anyway and should be able to send the Christoph> command even if the device is quiesced. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send th

Re: [PATCH 09/18] scsi_dh_emc: switch to scsi_execute_req_flags()

2017-01-25 Thread Martin K. Petersen
EQ_PREEMPT, but this is okay as we're Christoph> evaluating the errors anyway and should be able to send the Christoph> command even if the device is quiesced. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send th

Re: [PATCH 10/18] scsi_dh_hp_sw: switch to scsi_execute_req_flags()

2017-01-25 Thread Martin K. Petersen
e're evaluating the errors anyway and should be Christoph> able to send the command even if the device is quiesced. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 11/18] scsi: remove gfp_flags member in scsi_host_cmd_pool

2017-01-25 Thread Martin K. Petersen
Christoph> the kmalloc-family only GFP_DMA flag to kmem_cache_alloc. Christoph> Drop all the infrastructure for doing so. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the b

Re: [PATCH 12/18] scsi: respect unchecked_isa_dma for blk-mq

2017-01-25 Thread Martin K. Petersen
oph> allocate the sense buffers as well as the sense buffer slab Christoph> caches between the legacy and blk-mq path. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the b

Re: [PATCH 13/18] scsi: remove scsi_cmd_dma_pool

2017-01-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> There is no need for GFP_DMA allocations of the scsi_cmnd Christoph> structures themselves, all that might be DMAed to or from is Christoph> the actual payload, or the sense buffers. Acked-by: Martin K.

Re: [PATCH 14/18] scsi: remove __scsi_alloc_queue

2017-01-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Instead do an internal export of __scsi_init_queue for the Christoph> transport classes that export BSG nodes. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsub

Re: [PATCH 15/18] scsi: allocate scsi_cmnd structures as part of struct request

2017-01-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Rely on the new block layer functionality to allocate Christoph> additional driver specific data behind struct request instead Christoph> of implementing it in SCSI itѕelf. Acked-by: Martin K.

Re: [PATCH 18/18] block: don't assign cmd_flags in __blk_rq_prep_clone

2017-01-25 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> These days we have the proper flags set since request Christoph> allocation time. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send t

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-25 Thread Martin K. Petersen
>>>>> "Michael" == Michael Schmitz writes: Michael> Martin, Finn, I'll get to that on the weekend - Auckland Michael> Anniversary Day coming up so plenty of time. Great, thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from t

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-31 Thread Martin K. Petersen
si. Finn> There's also a patch to add a missing error check during target Finn> selection. The only target I tested was a QUANTUM DAYTONA514S disk Finn> as that's all I have access to right now. Some testing with other Finn> targets would be prudent. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] storvsc: remove bogus code to transfer struct scatterlist

2017-01-31 Thread Martin K. Petersen
#x27;t ever be reached anyway. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V2] hpsa: remove coalescing settings for ioaccel2

2017-01-31 Thread Martin K. Petersen
>>>>> "Don" == Don Brace writes: Don> - Setting coalescing has a significant negative impact on low Don> queue-depth performance. - Does not help high queue-depth Don> performance. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: remove the cmd_type field from struct request

2017-01-31 Thread Martin K. Petersen
istoph> namespace that drivers can easily switch on. Very nice cleanup! Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/4] mpt3sas driver Enhancements and defect fixes:

2017-01-31 Thread Martin K. Petersen
r. * Fix Firmware fault state 0x2100 during heavy 4K RR Chaitra> FIO stress test. * Updated driver version to 15.100.00.00 Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi_debug: Add OPTIMAL TRANSFER LENGTH GRANULARITY option.

2017-01-31 Thread Martin K. Petersen
>>>>> "Lukas" == Lukas Herbolt writes: Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3] mpt3sas: Force request partial completion alignment

2017-01-31 Thread Martin K. Petersen
ssue in the driver. It aligns unaligned Guilherme> completions of FS requests, by truncating them to the nearest Guilherme> alignment boundary. Applied to 4.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [REGRESSION v4.10-rc1] blkdev_issue_zeroout() returns -EREMOTEIO on the first call for SCSI device that doesn't support WRITE SAME

2017-02-03 Thread Martin K. Petersen
ITE SAME - Only 2 out of about 50 different drive models support RSOC - About half of the arrays support WRITE SAME(10/16) - None of the arrays I have support RSOC So even if we were to entertain using RSOC for "enterprise" transport classes (which I concur would be nice for other reasons),

Re: [PATCH 13/39] megaraid_sas : set residual bytes count during IO compeltion

2017-02-06 Thread Martin K. Petersen
rwise you need to tweak the residual like we just did for mpt3sas. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

2017-02-06 Thread Martin K. Petersen
ase send a complete v2 with all the little issues fixed up. Also, please remove all the "This patch depends on ..." stuff from the patch descriptions. The dependencies are inherent in the ordering of the patches and we don't want that in the commit messages. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

2017-02-06 Thread Martin K. Petersen
>>>>> "Martin" == Martin K Petersen writes: Martin> Also, please remove all the "This patch depends on ..." stuff Martin> from the patch descriptions. The dependencies are inherent in Martin> the ordering of the patches and we don't want that in t

Re: sort out the ->eh_timed_out mess

2017-02-06 Thread Martin K. Petersen
milar to how we Christoph> supply generic helpers elsewhere. Christoph> In addition it removes a bit of cruft in the same area. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] pm8001: switch to pci_irq_alloc_vectors

2017-02-06 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] fnic: switch to pci_alloc_irq_vectors

2017-02-06 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Christoph> Not a full cleanup for the IRQ code, for that we'd need to Christoph> know if the max number of the various CQ types is going to Christoph> stay 1 forever. Satish: Please test and review! -

Re: [PATCH] snic: switch to pci_irq_alloc_vectors

2017-02-06 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Narsimhulu, Please test and review! https://patchwork.kernel.org/patch/9549801/ -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V4 00/24] aacraid: Patchset for Smart Family Support

2017-02-06 Thread Martin K. Petersen
>>>>> "Raghava" == Raghava Aditya Renukunta >>>>> writes: Raghava> This patchset adds support to the HBA1000 and SMARTIOC2000 Raghava> family of cards. The driver version is now updated to 50740 Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

2017-02-06 Thread Martin K. Petersen
Mauricio Faria de Oliveira AuthorDate: Wed Jan 25 22:07:06 2017 -0200 Commit: Martin K. Petersen CommitDate: Tue Jan 31 22:25:32 2017 -0500 scsi: qla2xxx: Avoid that issuing a LIP triggers a kernel crash [...] -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 13/39] megaraid_sas : set residual bytes count during IO compeltion

2017-02-07 Thread Martin K. Petersen
DMA data length return from firmware was not aligned with Kashyap> logical block size. Eventually, root caused + fixed in Kashyap> firmware. Great. Thanks for confirming! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int

2017-02-07 Thread Martin K. Petersen
spotting my original broken fix to Colin> this issue. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v1 0/8] scsi: ufs: enhancements, bug fixes and debug support

2017-02-07 Thread Martin K. Petersen
ubhash> timeout than clock scaling window - one bug fix to clock Subhash> scaling - additional debug support Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits

2017-02-07 Thread Martin K. Petersen
/aacraid/src.c:414:29: error: right shift count >= Arnd> width of type [-Werror=shift-count-overflow] Arnd> This changes the driver to use the predefined macros consistently, Arnd> including one correct but open-coded upper_32_bits() instance. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH -next] scsi: qedi: Fix possible memory leak in qedi_iscsi_update_conn()

2017-02-09 Thread Martin K. Petersen
>>>>> "Wei" == Wei Yongjun writes: Wei> 'conn_info' is malloced in qedi_iscsi_update_conn() and should be Wei> freed before leaving from the error handling cases, otherwise it Wei> will cause memory leak. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 21/39] megaraid_sas: big endian support changes

2017-02-09 Thread Martin K. Petersen
Kashyap> with below title. Please just send a complete v3. Many patches in v2 have changelog entries in the body of the commit message instead of after the --- separator and I am not going to fix all those up by hand. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V2] mpt3sas: disable ASPM for MPI2 controllers

2017-02-09 Thread Martin K. Petersen
>>>>> "ojab" == ojab writes: >> Acked-by: Sreekanth Reddy Applied to 4.10/scsi-fixes. ojab> Is it too late for 4.10.0? We'll see. Worst case I'll shuffle it over to the 4.11 tree. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] aacraid: Fix INTx/MSI-x issue with older controllers

2017-02-09 Thread Martin K. Petersen
gt; previous patch to controllers which support MSI-x Applied to 4.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] zfcp: fix use-after-free by not tracing WKA port open/close on failed send

2017-02-09 Thread Martin K. Petersen
Steffen> 0 and it can only become 0 on successful retval = Steffen> zfcp_fsf_req_send(req). With that we can also remove the then Steffen> again unnecessary unconditional initialization of req which was Steffen> introduced with that earlier commit. Applied to 4.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 08/39] megaraid_sas: megasas_get_request_descriptor always return valid desc

2017-02-09 Thread Martin K. Petersen
equired. With fusion controllers, Shivasharan> if there is a valid message frame available, we are Shivasharan> guaranteed to get a corresponding request descriptor. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 00/39] megaraid_sas: Updates for scsi-next

2017-02-13 Thread Martin K. Petersen
>>>>> "Shivasharan" == Shivasharan S >>>>> writes: Shivasharan> Changes in v3: Patch 21: Fix to pass rctx_g35 pointer to Shivasharan> set/get_num_sge() Move all v2 changelog descriptions beyond Shivasharan> actual commit message body Applied to

Re: [PATCH] snic: switch to pci_irq_alloc_vectors

2017-02-15 Thread Martin K. Petersen
>>>>> "Christoph" == Christoph Hellwig writes: Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [patch] scsi: megaraid_sas: array overflow in megasas_dump_frame()

2017-02-15 Thread Martin K. Petersen
n> context") Signed-off-by: Dan Carpenter Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: megaraid_sas: handle dma_addr_t right on 32-bit

2017-02-15 Thread Martin K. Petersen
>>>>> "Arnd" == Arnd Bergmann writes: Arnd> When building with a dma_addr_t that is different from pointer Arnd> size, we get this warning: Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4] sd: Check for unaligned partial completion

2017-02-15 Thread Martin K. Petersen
like the rounding logic would be better contained in sd_completed_bytes() since that is already doing sanity checking on what's reported. Also, I am no fan of perpetuating the arcane SCSI logging stuff now that we have tracing. So just make it a regular sd_printk(). Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: sense handling improvements

2017-02-15 Thread Martin K. Petersen
oph> on top of the block tree. I can bring them in after Linus' initial block pull. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v5] sd: Check for unaligned partial completion

2017-02-20 Thread Martin K. Petersen
cleanup. If you don't feel like mucking more with this, I understand. In that case might pick up your patch and attempt to clean things up later. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V2 00/15] aacraid: Fixes and enhancements for arc family

2017-02-20 Thread Martin K. Petersen
> driver's internal periodic health checkup. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] smartpqi: fix time handling

2017-02-20 Thread Martin K. Petersen
>>>>> "Arnd" == Arnd Bergmann writes: Arnd> When we have turned off RTC support, the smartpqi driver fails to Arnd> build: ERROR: "rtc_time64_to_tm" Arnd> [drivers/scsi/smartpqi/smartpqi.ko] undefined! Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v1 1/1] scsi: ufs-qcom: remove redundant condition check

2017-02-20 Thread Martin K. Petersen
checker warning: You had used "---" to enclose Dan's email. But that's also the "ignore everything beyond this point" delimiter so I ended up with an empty commit message. I fixed it up. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/3] qla2xxx: Bug fixes and cleanup for the driver.

2017-02-20 Thread Martin K. Petersen
s to 4.10/scsi-fixes at your earliest Himanshu> convenience. 4.10 is out and this series does not apply to 4.11/scsi-queue. Please rebase. Also, please make sure your "Fixes: d745952 ("scsi: qla2xxx:..." have a 12-char hash. And add a stable tag if you want these in 4.10.x. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCHv3] scsi: use 'scsi_device_from_queue()' for scsi_dh

2017-02-20 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> The device handler needs to check if a given queue belongs to a Hannes> scsi device; only then does it make sense to attach a device Hannes> handler. Fixed kbuild warning and applied to 4.11/scsi-queue. -- Ma

Re: [PATCH] cxlflash: Enable PCI device ID for future IBM CXL Flash AFU

2017-02-20 Thread Martin K. Petersen
>>>>> "Uma" == Uma Krishnan writes: Uma> From: "Matthew R. Ochs" Add support for Uma> a future IBM Coherent Accelerator (CXL) flash AFU with an ID of Uma> 0x0624. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 00/16] lpfc: Add NVME Fabrics support

2017-02-20 Thread Martin K. Petersen
>>>>> "James" == James Smart writes: James> This patch set adds support for NVME over Fabrics FC transport to James> lpfc Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v5] sd: Check for unaligned partial completion

2017-02-20 Thread Martin K. Petersen
d, I Damien> can respin everything into sd_completed_bytes to clean things Damien> up. Damien> I will resend a patch. Great, thanks! Would be nice to get this cleaned up. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v5] sd: Check for unaligned partial completion

2017-02-21 Thread Martin K. Petersen
driver should know how to special case REPORT ZONES or similar. That's clearly SBC/ZBC territory, so I prefer the sd_completed_bytes() approach. -- Martin K. Petersen Oracle Linux Engineering

Re: sense handling improvements

2017-02-22 Thread Martin K. Petersen
e Christoph> it's best to send the whole series through the SCSI tree in Christoph> this case. Will do. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] lpfc: add missing Kconfig NVME dependencies

2017-02-22 Thread Martin K. Petersen
>>>>> "James" == James Smart writes: James> add missing Kconfig NVME dependencies Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V5 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-02-22 Thread Martin K. Petersen
I have gone ahead and merged this into 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi, block: fix memory leak of sdpk on when gd fails to allocate

2017-02-22 Thread Martin K. Petersen
ith a change in the error exit path labels. Applied to 4.11/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Factor out ufshcd_read_desc_param

2017-02-22 Thread Martin K. Petersen
Michal> can not rely on hardcoded values taken from 2.0 Michal> specification. This patch introduces reading these lengths per Michal> each device from descriptor headers at probe time to ensure Michal> their correctness. This doesn't apply to 4.11/scsi-fixes. Please rebase and r

<    1   2   3   4   5   6   7   8   9   10   >