Re: [PATCH 00/24] FCoE VN2VN fixes, part two

2016-10-17 Thread Martin K. Petersen
gt; - Correctly handle timed-out xids Hannes> Additionally there are some minor fixes to get things to work Hannes> when running with FCoE over virtio. Hannes> Patches are relative to mkp/4.10/scsi-queue. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubs

Re: [PATCH] lpfc: use %zd format string for size_t

2016-10-17 Thread Martin K. Petersen
%z modifier is what the standard Arnd> expects to be used here, and this shuts up the warning. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL] final round of SCSI updates for the 4.8+ merge window

2016-10-17 Thread Martin K. Petersen
27;s fix which is commit 8f087c089dae5 ("scsi: NCR5380: no Finn> longer mark irq probing as __init") in mkp-scsi/4.10/scsi-queue. Queued in 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-s

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-18 Thread Martin K. Petersen
an influence the market. Also, I am not aware of anybody actually asking the drive vendors to support crazy zone configurations. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to major

Re: [PATCH v8 0/7] ZBC / Zoned block device support

2016-10-18 Thread Martin K. Petersen
int. Probably easier if either you or I take the whole lot. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-18 Thread Martin K. Petersen
include this eventual Damien> capacity change by sd_zbc_read_zones. This new function also Damien> includes a call to sd_zbc_print_zones to display the number of Damien> zones and zone size of the device. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] fcoe: Fixup missing initialisation in fcoe_dcb_create()

2016-10-18 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Found by 0-day robot. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to ma

Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency

2016-10-18 Thread Martin K. Petersen
>>>>> "Arnd" == Arnd Bergmann writes: Arnd> The driver was changed to call ioport_map, which breaks platforms Arnd> that cannot provide this function: Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this l

Re: [PATCH v2 0/6] Fixes for ibmvscsis driver

2016-10-18 Thread Martin K. Petersen
>>>>> "Michael" == Michael Cyr writes: Michael> Various fixes and cleanups for the ibmvscsis driver. The first Michael> is a sort of prequel to the second, which is the primary change Michael> (and the biggest). The rest are fairly small fixes. Applied

Re: [PATCH v8 0/7] ZBC / Zoned block device support

2016-10-18 Thread Martin K. Petersen
>>>>> "Jens" == Jens Axboe writes: Jens> I already queued up the other bits, if it's fine with you I'll add Jens> 6/7 as well. Sure. Feel free to add by Acked-by:. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list:

Re: [PATCH 00/20] libfc callback cleanup

2016-10-24 Thread Martin K. Petersen
tless. As I got some time to kill on the train back from Hannes> Vienna I've decided to finally kill them and call the functions Hannes> directly. Applied to 4.10/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line &

Re: [PATCH v2 00/10] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

2016-10-24 Thread Martin K. Petersen
APIs that phy drivers expose for ufs-qcom hcd driver to use. Please submit a v3 which addresses the review comments and adds the relevant Reviewed-by: tags. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH] lpfc: Revise MAINTAINERS to reflect Broadcom

2016-10-24 Thread Martin K. Petersen
>>>>> "James" == James Smart writes: James> Avago is now known as Broadcom. Revise the emails and website James> for lpfc accordingly Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the l

Re: [PATCH 00/10] mpt3sas driver Enhancements and

2016-10-24 Thread Martin K. Petersen
nath> SAS35 devices. Suganath> * For SAS35 devices MSIX vectors are inceased to 128 from Suganath> 96. Suganath> * Fixing Endianness issue. Suganath> * Updated driver version to 14.100.00.00 Please address the review comments, apply Hannes' review tags and resu

Re: [PATCH v3 4/8] megaraid_sas: Send SYNCHRONIZE_CACHE for non-raid to firmware

2016-10-24 Thread Martin K. Petersen
Day-1 MR Firmware Kashyap> always expect Driver to forward SYNCHRONIZE_CACHE for JBOD (non Kashyap> Raid disk) to the Firmware. We have fixed this as part of this Kashyap> patch. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this l

Re: [PATCH v3 0/7] megaraid_sas: Updates for scsi-next

2016-10-24 Thread Martin K. Petersen
- Send SYNCHRONIZE_CACHE for VD to firmware I applied patch 4 to 4.9/scsi-fixes and 1-3 to 4.10/scsi-queue. Once Linus merges patch 4 I'll rebase the 4.10 tree and queue 5-8. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line &quo

Re: [PATCH v3 0/6] scsi: collection of clean ups

2016-10-24 Thread Martin K. Petersen
>>>>> "Andy" == Andy Shevchenko writes: Andy> Just collection of clean ups against SCSI drivers. Some of them Andy> were Acked quite long ago, but didn't make upstream yet. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering --

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-24 Thread Martin K. Petersen
rmware) safe Tomas> for all arcmsr cards, even the oldest? Ching? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] libfc: don't have fc_exch_find log errors on a new exchange

2016-10-26 Thread Martin K. Petersen
necessary lookup attempt as well. Applied to 4.10/scsi-queue by hand as a result of all the libfc changes. Please verify. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message t

Re: [PATCH] advansys: fix build warning for PCI=n

2016-10-26 Thread Martin K. Petersen
; only exists for PCI, but changing the code to just error out here Arnd> is better for consistency and avoids the warning. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH v2 00/11] mpt3sas driver Enhancements and

2016-10-26 Thread Martin K. Petersen
SAS35 devices. Suganath> * For SAS35 devices MSIX vectors are inceased to 128 from Suganath> 96. Suganath> * Fixing Endianness issue. Suganath> * Updated driver version to 14.100.00.00 at the end of SAS3 Suganath> changes and updated driver minor version to 14.101.00

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-26 Thread Martin K. Petersen
>>>>> "ching" == 黃清隆 writes: ching, ching> Yes. Passing SYNCHRONIZE_CACHE command to firmware is safe for ching> all Areca Raid controllers, even the oldest. I applied your patch to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To u

Re: [PATCH] scsi_debug: Fix memory leak if LBP enabled and module is unloaded

2016-10-26 Thread Martin K. Petersen
>>>>> "Ewan" == Ewan D Milne writes: Ewan> map_storep was not being vfree()'d in the module_exit call. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: [PATCH] scsi_dh_alua: fix wrong scsi_device_put() in alua_rtpg_queue()

2016-11-01 Thread Martin K. Petersen
t> note that I do not know whether my tests hit the !(pg->flags & Bart> ALUA_PG_RUNNING) code path. Please submit a real patch with a suitable description for this. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH] scsi_dh_alua: fix missing kref_put() in alua_rtpg_work()

2016-11-01 Thread Martin K. Petersen
isfy), it tang> would cause memory of pg leakage. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND] mpt3sas: Fix for block device of raid exists even after deleting raid disk

2016-11-01 Thread Martin K. Petersen
raid volumes, and so during raid disk deletion Sreekanth> driver is not calling scsi_remove_target() API as driver Sreekanth> observes starget field of raid_device's structure as NULL. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH v3 00/12] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

2016-11-01 Thread Martin K. Petersen
t phy drivers expose for ufs-qcom hcd driver to use. Vivek: Please address the comments to patch 4. Subhash: Please review patches 5 and 9. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a mess

Re: [PATCH] vmw_pvscsi: return SUCCESS for successful command aborts

2016-11-01 Thread Martin K. Petersen
tch looks fine to us. Applied to 4.9/scsi-fixes with a bumped version number. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 0/4] scsi: ufs: bug fixes patch series #2

2016-11-01 Thread Martin K. Petersen
> important bug fixes required for UFS stability and Subhash> functionality. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.

Re: [PATCH 1/3] blk-mq: export blk_mq_map_queues

2016-11-01 Thread Martin K. Petersen
this change through the SCSI tree? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 11/14] SRP transport: Move queuecommand() wait code to SCSI core

2016-11-01 Thread Martin K. Petersen
>>>>> "Bart" == Bart Van Assche writes: Bart> Additionally, rename srp_wait_for_queuecommand() into Bart> scsi_wait_for_queuecommand() and add a comment about the Bart> queuecommand() call from scsi_send_eh_cmnd(). Reviewed-by: Martin K. Petersen -- Ma

Re: [PATCH v5 12/14] SRP transport, scsi-mq: Wait for .queue_rq() if necessary

2016-11-01 Thread Martin K. Petersen
>>>>> "Bart" == Bart Van Assche writes: Bart> Ensure that if scsi-mq is enabled that Bart> scsi_internal_device_block() waits until ongoing Bart> shost->hostt->queuecommand() calls have finished. Reviewed-by: Martin K. Petersen -- Martin K. Pete

Re: [PATCH] scsi_dh_alua: Fix a reference counting bug

2016-11-01 Thread Martin K. Petersen
btained by the same alua_rtpg_queue() call. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: expose queue the queue mapping for SCSI drivers V2

2016-11-01 Thread Martin K. Petersen
d over the smartpqi driver as an example as Christoph> it's the easiest of the multiqueue SCSI drivers to convert. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in th

Re: [PATCH] qla2xxx: Fix scsi scan hang triggered if adapter fails during init

2016-11-01 Thread Martin K. Petersen
e6e0 ("qla2xxx: Prevent Bill> removal and board_disable race"): Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.

Re: [PATCH v4 09/12] ufs-qcom: phy/hcd: Refactoring phy clock handling

2016-11-04 Thread Martin K. Petersen
that didn't fly. Please send a v5 series against 4.10/scsi-queue with the review tags from Subhash applied. Subhash and others: Please make sure you put your Reviewed-by: tags on a separate line. There were a few patches that had "LGTM, Reviewed-by:..." and patchwork sadly does no

Re: [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v2)

2016-11-04 Thread Martin K. Petersen
27; Hannes> or 'BUSY' in these cases. Doing so would nicely solve this Hannes> issue. I agree with Hannes that it would be appropriate for the SATL to report busy when it makes an non-queued command queueable. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe f

Re: [PATCH v3 8/8] megaraid_sas: driver version upgrade

2016-11-08 Thread Martin K. Petersen
>>>>> "Kashyap" == Kashyap Desai writes: Rebased on top of Linus' tree to get the JBOD SYNCHRONIZE CACHE fix pulled in and applied patches 5 through 8 to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send th

Re: [PATCH v5 00/12] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

2016-11-08 Thread Martin K. Petersen
>>>>> "Vivek" == Vivek Gautam writes: Vivek> Here's the rebased version of patches based on 4.10/scsi-queue Vivek> branch as requested. The patches can now be applied and Vivek> pulled-in. Thanks! Applied to 4.10/scsi-queue. -- Martin K. Peter

Re: [REGRESSION] 4.9-rc4+ doesn't boot on my test box

2016-11-08 Thread Martin K. Petersen
>>>>> "Jens" == Jens Axboe writes: Jens> I wasted half a day on this, thinking it was something in my Jens> 4.10 branches. But it turns out it is not, the regression is in Jens> mainline. Kashyap, have you tested the stable fix without the remainder of the dri

Re: [PATCH] scsi: fix spelling mistake in error message

2016-11-08 Thread Martin K. Petersen
>>>>> "Colin" == Colin King writes: Colin> From: Colin Ian King Trivial fix to Colin> spelling mistake "operatio" to "operation" in critical error Colin> message Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engin

Re: Ordering problems with 3ware controller

2016-11-08 Thread Martin K. Petersen
o use UUIDs, filesystem labels, or DM devices to get stable naming. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Martin K. Petersen
It's fine to post the patches split up to ease the review process. But whatever we commit must obviously be bisectable. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord..

Re: [PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Martin K. Petersen
tches for the driver (qedi) squashed as a single commit Arun> to the tree. We will ensure that this single combined commit Arun> compiles clean. That's fine with me. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH 4.9/scsi-fixes] libcxgbi: fix incorrect DDP resource cleanup

2016-11-08 Thread Martin K. Petersen
) before memset. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] qla2xxx: fix errors in PCI device remove with ongoing I/O

2016-11-08 Thread Martin K. Petersen
moval and re-addition of the Mauricio> adapter to the system, and cause an oops and/or invalid DMA Mauricio> access (triggers an EEH event). Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH v2 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

2016-11-08 Thread Martin K. Petersen
>>>>> "Chanwoo" == Chanwoo Choi writes: Chanwoo> This patch uses the resource-managed to add the devfreq device. Chanwoo> This function will make it easy to handle the devfreq device. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineer

Re: [REGRESSION] 4.9-rc4+ doesn't boot on my test box

2016-11-08 Thread Martin K. Petersen
with a megaraid card and things are broken in both 4.9/scsi-fixes and 4.10/scsi-queue unless the controller firmware has the new sync flag set. So, yes. Let's get a fix for this queued up ASAP. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: s

Re: [PATCH] megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression caused by commit 1e793f6fc0db920400574211c48f9157a37e3945

2016-11-09 Thread Martin K. Petersen
not have braces and Sumit> because of above commit using this macro was exposing lot of Sumit> non-existing SCSI devices(all SCSI commands to channels-1,2,3 was Sumit> returned as SUCCESS-DID_OK by driver). Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -

Re: Ordering problems with 3ware controller

2016-11-10 Thread Martin K. Petersen
specific physical controller needs to use a different scheme than discovery order to do so. Don't know if these cards provide a device identification VPD or something with a serial number that you could key off of? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this l

Re: Delivery Status Notification for linuxr...@lsi.com

2016-11-10 Thread Martin K. Petersen
ledge the 3ware product lines have been discontinued. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hpsa: use pci_alloc_irq_vectors and automatic irq affinity

2016-11-12 Thread Martin K. Petersen
; queues. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v4)

2016-11-12 Thread Martin K. Petersen
y to the SCSI tree. I merged it into 4.9/scsi-fixes by hand. Also, please check Documentation/SubmittingPatches for future submissions. Patch version goes inside the [PATCH foo/bar] brackets and patch changelog entries below "---" separator. Thanks! Martin -- Martin K. Petersen Or

Re: [PATCH v2] ufs: introduce setup_xfer_req callback

2016-11-12 Thread Martin K. Petersen
ke sure to put change entries like this below a --- separator so they don't become part of the git commit description. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to major

Re: [PATCH] scsi_transport_fc: Hold queue lock while calling blk_run_queue_async()

2016-11-14 Thread Martin K. Petersen
device() and put_device() Bart> calls from fc_bsg_goose_queue. It is namely the responsibility of Bart> the caller of fc_bsg_goose_queue() to ensure that the bsg queue Bart> does not disappear while fc_bsg_goose_queue() is in progress. Applied to 4.10/scsi-queue. -- Martin K. Petersen O

Re: [PATCH] scsi: megaraid_sas: add in missing white spaces in error messages text

2016-11-14 Thread Martin K. Petersen
>>>>> "Colin" == Colin King writes: Colin> A couple of dev_printk messages spans two lines and the literal Colin> string is missing a white space between words. Add the white Colin> space. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v4)

2016-11-14 Thread Martin K. Petersen
>>>>> "Andrey" == Andrey Grodzovsky writes: Andrey, Andrey> Regarding older code where there is still a separate mpt2sas Andrey> driver, should a separate patch to be done or this fix will be Andrey> ported there ? Feel free to submit a mpt2sas patch to the p

Re: [PATCH] iscsi: fix spelling mistakes in dev_warn messages

2016-11-14 Thread Martin K. Petersen
>>>>> "Colin" == Colin King writes: Colin> From: Colin Ian King Trivial fix to Colin> spelling mistake "suspeneded" to "suspended" in dev_warn messages Applied to 4.10/scsi-queue with s/iscsi/isci/. -- Martin K. Petersen Oracle Linux

Re: [PATCH] isci: fix typo in deg_dbg message

2016-11-14 Thread Martin K. Petersen
>>>>> "Colin" == Colin King writes: Colin> From: Colin Ian King Trivial fix to Colin> typo "repsonse" to "response" in dev_dbg message. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from t

Re: [PATCH] scsi: hpsa: free irq on q indexed by h->intr_mode and not i

2016-11-14 Thread Martin K. Petersen
>>>>> "Colin" == Colin King writes: Colin> From: Colin Ian King Use correct index Colin> on q, use h->intr_mode instead of i. Issue detected using static Colin> analysis with cppcheck Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux En

Re: [PATCH] qla2xxx: do not abort all commands in the adapter during EEH recovery

2016-11-14 Thread Martin K. Petersen
y, since the change to the Mauricio> qla2x00_abort_all_cmds() function calls qla2xxx_eh_abort(), Mauricio> which verifies the EEH recovery condition but handles it Mauricio> heavy-handed. (commit a465537ad1a4 "qla2xxx: Disable the Mauricio> adapter and skip error recovery in case o

Re: [PATCH] hpsa: correct logical resets

2016-11-14 Thread Martin K. Petersen
t reply_queue); + static inline struct ctlr_info *sdev_to_hba(struct scsi_device *sdev) { unsigned long *priv = shost_priv(sdev->host); Wouldn't it be nicer to put this with the rest of the function prototypes at the beginning of the file? -- Martin K. Petersen Oracle Linux E

Re: qed, qedi patchset submission

2016-11-14 Thread Martin K. Petersen
;qed" patches were Arun> taken by David in the net tree and "qedr", in the rdma tree Arun> (obviously) by Doug L. DaveM can queue the whole series or I can hold the SCSI pieces for rc1. Either way works for me. However, I would like to do a review of the driver first. I will try

Re: [PATCH] megaraid-sas: request irqs later

2016-11-14 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Henzl writes: Tomas> It is not good when an irq arrives before driver structures are Tomas> allocated. Sumit, Kashyap: Please review! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "

Re: [PATCH 00/11] hisi_sas: some fixes, improvements, and new features

2016-11-14 Thread Martin K. Petersen
>>>>> "John" == John Garry writes: John> This patchset introduces some misc bug fixes, improvements, and John> new features to the HiSilicon SAS driver. This series needs review. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this l

Re: [PATCH] fnic: remove a pointless test

2016-11-14 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Henzl writes: Tomas> rport can't be null here, it would have failed already in Tomas> fc_remote_port_chkready Cisco folks: Please review! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the

Re: [PATCH] megaraid-sas: request irqs later

2016-11-16 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Henzl writes: Tomas> It is not good when an irq arrives before driver structures are Tomas> allocated. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "un

Re: [PATCH V2] hpsa: correct logical resets

2016-11-16 Thread Martin K. Petersen
>>>>> "Don" == Don Brace writes: Don> - driver was not calling done in some cases which causes Don> the volume to be offlined. Don> - avoid doing rescan during a reset. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To un

Re: [PATCH 1/1] [fnic, snic] Updating maintainers list for Cisco FNI and SNIC drivers

2016-11-16 Thread Martin K. Petersen
>>>>> "Satish" == Satish Kharat writes: Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH] scsi: ufs: introduce a new ufshcd_statea UFSHCD_STATE_EH_SCHEDULED

2016-11-16 Thread Martin K. Petersen
>>>>> "Zang" == Zang Leigang writes: Zang> Add a new ufshcd_state, indicats that an err handler may get to Zang> run immediately. Use UFSHCD_STATE_ERROR here looks not literaly Zang> correct. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle L

Re: [PATCH v3] ufs: introduce UFSHCD_QUIRK_BROKEN_REQ_LIST_CLR quirk

2016-11-16 Thread Martin K. Petersen
don't apply cleanly to 4.10/scsi-queue. Please send a v4, ideally as a series. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fnic: remove a pointless test

2016-11-16 Thread Martin K. Petersen
Satish, Sesidhar, Please review Tomas' patch: https://patchwork.kernel.org/patch/9407637/ Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.

Re: [PATCH] 53c700: fix memory leak of dma non-cosistent memory

2016-11-16 Thread Martin K. Petersen
>>>>> "Li" == Li Qiang writes: Li> In NCR_700_detect function, if an error occurs it will return NULL Li> without freeing the dma non-cosistent memory once allocated. This Li> patch avoid this. James: Please review! -- Martin K. Petersen Oracle Linux

Re: [PATCH] fnic: Correcting rport check location in fnic_queuecommand_lck

2016-11-16 Thread Martin K. Petersen
>>>>> "Satish" == Satish Kharat writes: Applied to 4.10/scsi-queue. Please add a more verbose patch description next time. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: [PATCH] scsi: dmx3191d: use module_pci_driver

2016-11-16 Thread Martin K. Petersen
>>>>> "Geliang" == Geliang Tang writes: Geliang> Use module_pci_driver() helper to simplify the code. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&qu

Re: [PATCH] mvsas: fix command_active typo

2016-11-16 Thread Martin K. Petersen
>>>>> "Arnd" == Arnd Bergmann writes: Arnd> gcc-7 notices that the condition in mvs_94xx_command_active looks Arnd> suspicious: Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "

Re: [PATCH v2] libfc: fix seconds_since_last_reset miscalculation

2016-11-17 Thread Martin K. Petersen
x27;fcoeadm -s' Johannes> after kernel 4.8-rc1. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] hpsa: use bus '3' for legacy HBA devices

2016-11-17 Thread Martin K. Petersen
target id of Hannes> controller. This patch checks the SCSI revision, and moves Hannes> older controller to bus '3' to be compatible with older releases Hannes> and avoid this problem. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH] aacraid: switch to pci_alloc_irq_vectors

2016-11-17 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Use pci_alloc_irq_vectors and drop the hand-crafted interrupt Hannes> affinity routines. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send t

Re: [PATCH] mpt3sas: Fix for SATA drive in blocked state, after diag reset while ATA Passthrough command is outstanding.

2016-11-17 Thread Martin K. Petersen
f in-between any host Suganath> reset occurs then driver won't unblock the device and device Suganath> will be in blocked state. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: [PATCH] mptfusion: Fix printk continuations

2016-11-17 Thread Martin K. Petersen
B2: Helge>Capabilities={Initiator,Target} scsi host3: ioc1: LSI53C1030 Helge>B2, FwRev=01032341h, Ports=1, MaxQ=255, IRQ=67 Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: [PATCH] fnic: remove a pointless test

2016-11-17 Thread Martin K. Petersen
>>>>> "Tomas" == Tomas Henzl writes: Tomas> Martin, another (better) patch "fnic: Correcting rport check Tomas> location in fnic_queuecommand_lck" has been added to Tomas> 4.10/scsi-queue. Tomas> Please drop this one. Done! -- Martin

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

2016-11-17 Thread Martin K. Petersen
>>>>> "John" == John Garry writes: John> @Maintainers, would you be willing to accept this patch as an John> interim fix for the dastardly WARN while we try to fix the flutter John> issue? I'll defer to James since I don't have much libsas experienc

Re: [PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions

2016-11-21 Thread Martin K. Petersen
rnd> suggest '&&' instead [-Werror=int-in-bool-context] Arnd> Using inline functions makes them much more readable and avoids Arnd> the warnings. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the li

Re: [patch] scsi: be2iscsi: allocate enough memory in beiscsi_boot_get_sinfo()

2016-11-21 Thread Martin K. Petersen
>>>>> "Dan" == Dan Carpenter writes: Dan> We accidentally allocate sizeof(u32) instead of sizeof(struct Dan> be_cmd_get_session_resp). Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH v3] ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk

2016-11-21 Thread Martin K. Petersen
>>>>> "Kiwoong" == Kiwoong Kim writes: Hi Kiwoong, Kiwoong> Some UFS host controllers may think granularities of PRDT Kiwoong> length and offset as bytes, not double words. This patch does not apply to 4.10/scsi-queue. Please rebase and resubmit. Thanks! --

Re: [PATCH] xen-scsifront: Add a missing call to kfree

2016-11-21 Thread Martin K. Petersen
is issue was found with Hector. >> >> Signed-off-by: Quentin Lambert Juergen> Nice catch. I think this will need some more work, I'll do a Juergen> follow-on patch. Juergen> Reviewed-by: Juergen Gross Are you taking this patch through the Xen tree or should I queue

Re: [PATCH v2] ufs: qcom: Properly clear hba priv on failure

2016-11-21 Thread Martin K. Petersen
> operate on the uninitalized host object. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading

2016-11-21 Thread Martin K. Petersen
t; https://bugzilla.suse.com/show_bug.cgi?id=1010946 "You are not authorized to access bug #1010946. To see this bug, you must first log in to an account with the appropriate permissions." We'll see what the Microsemi folks think of the patches. If the patches get acked I can

Re: [PATCH] hpsa: fix uninitialized variable

2016-11-22 Thread Martin K. Petersen
ialized in this function [-Werror=maybe-uninitialized] I amended your original patch. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/11] hisi_sas: some fixes, improvements, and new features

2016-11-22 Thread Martin K. Petersen
>>>>> "John" == John Garry writes: John, John> Are you happy with this patchset now that I've got an external John> review? Zhangfei Geo asked a question about patch 1/11 that has yet to be answered. Patch 5/11 is still unreviewed. -- Martin K. Petersen

Re: [PATCH] scsi: pmcraid: Add missing resource releases

2016-11-22 Thread Martin K. Petersen
ranches following the call to Quentin> class_create contain a call to class_destroy. This patch add Quentin> these calls where they are missing. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH v4] ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk

2016-11-22 Thread Martin K. Petersen
>>>>> "Kiwoong" == Kiwoong Kim writes: Hi Kiwoong, Kiwoong> Some UFS host controllers may think granularities of PRDT Kiwoong> length and offset as bytes, not double words. Your patch still didn't apply cleanly to 4.10/scsi-queue. I did it by hand. P

Re: [PATCH 00/11] hisi_sas: some fixes, improvements, and new features

2016-11-25 Thread Martin K. Petersen
>>>>> "John" == John Garry writes: John> I think that these 2 outstanding issues have been John> addressed. Please let me know if there is anything else. Series applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscrib

Re: [PATCH] ufs: Add missing UFS_MASK macro definition

2016-11-25 Thread Martin K. Petersen
>>>>> "Zhangfei" == Zhangfei Gao writes: Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH 0/2] SRP transport, scsi-mq: Wait for .queue_rq() if necessary

2016-11-25 Thread Martin K. Petersen
d one comment have been changed. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] SRP transport, scsi-mq: Wait for .queue_rq() if necessary

2016-11-25 Thread Martin K. Petersen
>>>>> "Martin" == Martin K Petersen writes: Hi Bart, Martin> Applied to 4.10/scsi-queue. 2/2 needs a rebase and I'm not going to do another one this late in the cycle. Please resend this patch once we hit 4.10 rc1. Thanks! -- Martin K. Petersen

Re: [patch] scsi: libfc: Remove an unneeded condition

2016-11-25 Thread Martin K. Petersen
>>>>> "Dan" == Dan Carpenter writes: Dan> We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't Dan> need to check again here. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: s

Re: [PATCH] lpfc: fix oops/BUG in lpfc_sli_ringtxcmpl_put()

2016-11-25 Thread Martin K. Petersen
issue() function path [similar names], Mauricio> due to 'piocb->vport == NULL': Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] hpsa: fallback to use legacy REPORT PHYS command

2016-11-29 Thread Martin K. Petersen
>>>>> "Hannes" == Hannes Reinecke writes: Hannes> Older SmartArray controller do not support the extended REPORT Hannes> PHYS command, so fallback to use the legacy version here. Don: Please review. Thanks! -- Martin K. Petersen Oracle Linux Engineering -

<    1   2   3   4   5   6   7   8   9   10   >