Thanks for the quick reply and analysis Hannes! My apologies in advance, I'm
stuck on
Outlook here at work - I'll try to format this to be readable (hopefully it
doesn't get
mangled).
On 02/27/2018 06:01 AM, Hannes Reinecke wrote:
> Hmm. Isn't is rather the case that the labels and gotos are
On Thu, Mar 08, 2018 at 08:45:25AM, Meelis Roos wrote:
> When firmware init fails, qla2x00_probe_one() does double free of req and rsp
> queues and possibly other structures allocated by qla2x00_mem_alloc().
> Fix it by pulling out qla2x00_mem_free() and qla2x00_free_queues() invocations
> from ql
> No, that was the point of my changes - they must not be called from
> qla2x00_free_device or they will be double freed in some cases.
Meelis,
The patch I referred you to makes those routines idempotent, so they can be
called multiple times without harm.
Thanks and regards,
-Bill Kuzeja
:24 PM
To: Kuzeja, William
Cc: linux-scsi@vger.kernel.org; qla2xxx-upstr...@qlogic.com
Subject: Re: [PATCH RESEND] scsi: qla2xxx: I/Os timing out on surprise removal
of
Bill,
> When doing a surprise removal of an adapter, some in flight I/Os can
> get stuck and take a while to complete
Ewan,
I like it, more generic than my patch. I never saw the other cases, so I
limited my
patch to WS16.
Acked-by: Bill Kuzeja
On Tue-09-19 at 12:14 Ewan D. Milne wrote:
> Some devices do not support a WRITE SAME / WRITE SAME(16) with the
> UNMAP
> bit set up to the length specified in the M
5 matches
Mail list logo
