Re: [PATCH 14/59] sysctl: C99 convert xfs ctl_tables

minor extra space in table below... Kirill > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> > --- > fs/xfs/linux-2.6/xfs_sysctl.c | 258 > 1 files changed, 180 insertions(+), 78 deletions(

Re: [PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c

another small minor note. > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> > --- > arch/frv/kernel/pm.c | 50 > +++--- > 1 files changed, 43 insertions(+), 7 deletions(-) > > diff --g

Re: [PATCH 33/59] sysctl: s390 move sysctl definitions to sysctl.h

IDs not sorted in enum. see below. > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > We need to have the the definition of all top level sysctl > directories registers in sysctl.h so we don't conflict by > accident and cause abi problems. > > Signed-off-by: Eric W. Biederman <[EMAIL P

Re: [PATCH 50/59] sysctl: Move utsname sysctls to their own file

Eric, though I personally don't care much: 1. I ask for not setting your authorship/copyright on the code which you just copied from other places. Just doesn't look polite IMHO. 2. I would propose to not introduce utsname_sysctl.c. both files are too small and minor that I can't see much reaso

Re: [PATCH 51/59] sysctl: Move SYSV IPC sysctls to their own file

1. I ask for not setting your authorship/copyright on the code which you just copied from other places. Just doesn't look polite IMHO. 2. please don't name files like ipc/ipc_sysctl.c ipc/sysctl.c sounds better IMHO. 3. any reason to introduce CONFIG_SYSVIPC_SYSCTL? why not simply do >

Re: [PATCH 0/59] Cleanup sysctl

Eric, really good job! Patches: 1-13, 15-24, 26-32, 34-44, 46-49, 52-55, 57 (all except below) Acked-By: Kirill Korotaev <[EMAIL PROTECTED]> 14/59 - minor (extra space) 25/59 - minor note 33/59 - not sorted sysctl IDs 45/59 - typo 50/59 - copyright/file note 51/59 - copyright/fil