There was a seemingly missing call to setup_timer() in one handler,
so add setup_timer() here to remove the open-coded initialization.
Cc: qlogic-storage-upstr...@qlogic.com
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kee
eliminated.
Cc: John Stultz
Cc: Thomas Gleixner
Cc: Stephen Boyd
Signed-off-by: Kees Cook
---
include/linux/timer.h | 8
kernel/time/timer.c | 26 +++---
2 files changed, 27 insertions(+), 7 deletions(-)
diff --git a/include/linux/timer.h b/include/linux/timer.h
index
Drop the arguments from the macro and adjust all callers with the
following script:
perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \
$(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h)
Signed-off-by: Kees Cook
Acked-by: Geert Uytterhoeven # for
...@vger.kernel.org
Signed-off-by: Kees Cook
---
arch/s390/kernel/lgr.c | 6 +++---
arch/s390/kernel/topology.c | 6 +++---
kernel/workqueue.c | 8 +++-
3 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/arch/s390/kernel/lgr.c b/arch/s390/kernel/lgr.c
index ae7dff110054
In preparation for unconditionally passing the struct timer_list pointer
to all timer callbacks, switch workqueue to use from_timer() and pass the
timer pointer explicitly.
Cc: Tejun Heo
Cc: Lai Jiangshan
Signed-off-by: Kees Cook
---
include/linux/workqueue.h | 15 ---
kernel
Drops the last user of TIMER_INITIALIZER and adapts timer.h to use the
internal version.
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Mark Gross
Cc: Thomas Gleixner
Signed-off-by: Kees Cook
---
drivers/char/tlclk.c | 12 +---
include/linux/timer.h | 2 +-
2 files changed, 6
The expires field is normally initialized during the first mod_timer()
call. It was unused by all callers, so remove it from the macro.
Signed-off-by: Kees Cook
---
include/linux/kthread.h | 2 +-
include/linux/timer.h | 5 ++---
include/linux/workqueue.h | 2 +-
3 files changed, 4
In preparation for unconditionally passing the struct timer_list pointer
to all timer callbacks, switch kthread to use from_timer() and pass the
timer pointer explicitly.
Cc: Andrew Morton
Cc: Petr Mladek
Cc: Tejun Heo
Cc: Thomas Gleixner
Cc: Oleg Nesterov
Signed-off-by: Kees Cook
Cc: Geert Uytterhoeven
Cc: linux-m...@linux-mips.org
Cc: linux-watch...@vger.kernel.org
Signed-off-by: Kees Cook
---
arch/mips/mti-malta/malta-display.c | 6 +++---
drivers/watchdog/alim7101_wdt.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/mips/mti-malta
This removes the now unused TIMER_*INITIALIZER macros:
TIMER_INITIALIZER
TIMER_PINNED_INITIALIZER
TIMER_DEFERRED_INITIALIZER
TIMER_PINNED_DEFERRED_INITIALIZER
Signed-off-by: Kees Cook
---
include/linux/timer.h | 12
1 file changed, 12 deletions(-)
diff --git a/include/linux
-...@lists.ozlabs.org
Cc: net...@vger.kernel.org
Cc: linux-wirel...@vger.kernel.org
Signed-off-by: Kees Cook
---
arch/powerpc/mm/numa.c | 12 +--
drivers/hsi/clients/ssi_protocol.c | 32
drivers/net/ethernet/qlogic/qlge/qlge_main.c | 11
This refactors the only users of init_timer_pinned() to use
the new timer_setup() and from_timer(). Drops the definition of
init_timer_pinned().
Cc: Chris Metcalf
Cc: Thomas Gleixner
Cc: net...@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/net/ethernet/tile/tilepro.c | 9
Mackerras
Cc: Michael Ellerman
Cc: Thomas Gleixner
Cc: linux...@vger.kernel.org
Cc: linuxppc-...@lists.ozlabs.org
Signed-off-by: Kees Cook
---
drivers/cpufreq/powernv-cpufreq.c | 13 +++--
include/linux/timer.h | 2 --
2 files changed, 7 insertions(+), 8 deletions(-)
di
"James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: Thomas Gleixner
Cc: linux...@vger.kernel.org
Cc: linux1394-de...@lists.sourceforge.net
Cc: linux-s...@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/base/power/main.c | 8 +
Hi,
This is the first of many timer infrastructure cleanups to simplify the
timer API[1]. All of these patches are expected to land via the timer
tree, so Acks (or corrections) appreciated.
These patches refactor various users of timer API that are NOT just using
init_timer() or setup_timer() (wh
"
Cc: Johannes Thumshirn
Cc: linux-scsi@vger.kernel.org
Cc: fcoe-de...@open-fcoe.org
Cc: Thomas Gleixner
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-a
uot;
Cc: linux-scsi@vger.kernel.org
Cc: Thomas Gleixner
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
---
drivers/scsi/lpfc/lpfc_crtn.h| 16 ---
i@vger.kernel.org
Cc: Thomas Gleixner
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
---
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 8
drivers/scsi/cxgbi/cxgb4i/
uot;
Cc: linux-scsi@vger.kernel.org
Cc: Thomas Gleixner
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
---
drivers/scsi/qla2xxx/qla_gbl.h| 6 +++---
drivers/
tin K. Petersen"
Cc: linux-scsi@vger.kernel.org
Cc: Thomas Gleixner
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
---
drivers/scsi/isci/host.c| 12 +
Cc: Thomas Gleixner
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
---
drivers/scsi/pmcraid.c | 33 +
1 file changed, 13 insert
i@vger.kernel.org
Cc: Thomas Gleixner
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
---
drivers/scsi/ipr.c | 30 +++---
1 file changed,
slow_task.
Cc: John Garry
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: Jack Wang
Cc: lindar_...@usish.com
Cc: Jens Axboe
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Benjamin Block
Cc: Baoyou Xie
Cc: Wei Yongjun
Cc: linux-scsi@vger.kernel.org
Cc: Thomas Glei
"Martin K. Petersen"
Cc: Thomas Gleixner
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
stand-alone.
---
drivers/scsi/aic7xxx/aic79xx.h | 5 +
drivers/sc
c: Michael Ellerman
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Cc: linuxppc-...@lists.ozlabs.org
Signed-off-by: Kees Cook
---
This requires commit 686fef928bba ("timer: Prepare to change timer
callback argument type") in v4.14-rc3, but should be otherwise
tin K. Petersen"
Cc: dc3...@twibble.org
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/dc395x.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 5ee7f44cf869..60ef8df42b95 10064
scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/gdth.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index a4473356a9dc..c35f05c4c6bb 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi/gdth.c
@@ -3705,7 +3
...@microsemi.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/smartpqi/smartpqi_init.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
b/drivers/scsi/smartpqi/smartpqi_init.c
index 8fe918398336..b2880
bert
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/aic94xx/aic94xx_hwi.c | 3 +--
drivers/scsi/aic94xx/aic94xx_hwi.h | 5 ++---
drivers/scsi/aic94xx/aic94xx_scb.c | 6 +++---
drivers/scsi/aic94xx/aic94xx_tmf.c | 13 ++---
4 files changed, 12 insertions(+), 1
n"
Cc: open-is...@googlegroups.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/libiscsi.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index f8dc1601efd5..9c50d2d9f27c 10064
"Martin K. Petersen"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/be2iscsi/be_main.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 7561e1332257.
open-coded initialization.
Cc: qlogic-storage-upstr...@qlogic.com
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/bnx2i/bnx2i.h | 2 +-
drivers/scsi/bnx2i/bnx2i_hwi.c | 4 ++--
: Johannes Thumshirn
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: fcoe-de...@open-fcoe.org
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/libfc/fc_fcp.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git
.
>
> Reviewed-by: Martin K. Petersen
Thanks for the reviews! Do you want the timer tree to carry these
patches, or can you pick them up in the scsi tree?
-Kees
--
Kees Cook
Pixel Security
cycle
> so the patches would end up going in at the end of the merge window. If
> you prefer to have them hit the first pull you should queue them up in
> the timer tree.
Okay, thanks, I'll take them via the timer tree.
-Kees
--
Kees Cook
Pixel Security
Cc: Varun Prakash
Cc: Bart Van Assche
Cc: "Jason A. Donenfeld"
Cc: Al Viro
Cc: linux-scsi@vger.kernel.org
Cc: target-de...@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/target/iscsi/iscsi_target_erl0.c | 9 -
drivers/target/iscsi/iscsi_target_erl1.c | 8 +++-
"Martin K. Petersen"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/aic7xxx/aic79xx.h | 5 +
drivers/scsi/aic7xxx/aic79xx_core.c | 29 -
drivers/scsi/aic7xxx/aic79xx_osm.h | 7 ---
3 files changed, 9 insertions(+), 32 deleti
"
Cc: Johannes Thumshirn
Cc: linux-scsi@vger.kernel.org
Cc: fcoe-de...@open-fcoe.org
Signed-off-by: Kees Cook
Acked-by: Johannes Thumshirn
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 11 +--
drivers/scsi/fcoe/fcoe.c | 2 +-
drivers/scsi/fcoe/fcoe_transport.c | 6 --
in
c: Michael Ellerman
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Cc: linuxppc-...@lists.ozlabs.org
Signed-off-by: Kees Cook
---
drivers/scsi/ibmvscsi/ibmvfc.c | 14 ++
drivers/scsi/ibmvscsi/ibmvscsi.c | 7 +++
2 files changed, 9 insertions(+), 12 deleti
er.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/ipr.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index f838bd73befa..d53429371127 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ip
usage.
Cc: Kashyap Desai
Cc: Sumit Saxena
Cc: Shivasharan S
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: megaraidlinux@broadcom.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/megaraid/megaraid_ioctl.h | 6 +
d
tion = (void (*)(unsigned long))pmcraid_timeout_handler;
+ cmd->timer.function = (TIMER_FUNC_TYPE)pmcraid_timeout_handler;
if (!timer_pending(&cmd->timer))
add_timer(&cmd->timer);
--
2.7.4
--
Kees Cook
Pixel Security
slow_task.
Cc: John Garry
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: Jack Wang
Cc: lindar_...@usish.com
Cc: Jens Axboe
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Benjamin Block
Cc: Baoyou Xie
Cc: Wei Yongjun
Cc: linux-scsi@vger.kernel.org
Signed-off-by
uot;
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/qla4xxx/ql4_os.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 64c6fa563fdb..2b8a8ce2a431 100644
--- a/drivers/s
uot;
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/qla2xxx/qla_gbl.h| 6 +++---
drivers/scsi/qla2xxx/qla_init.c | 4 ++--
drivers/scsi/qla2xxx/qla_inline.h | 4 +---
drivers/scsi/qla2xxx/qla_mid.c| 2 +-
drivers/scsi/qla2xxx/qla_os.c | 11 +--
uot;
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/lpfc/lpfc_crtn.h| 16
drivers/scsi/lpfc/lpfc_ct.c | 4 ++--
drivers/scsi/lpfc/lpfc_els.c | 12 ++--
drivers/scsi/lpfc/lpfc_hbadisc.c | 7 +++
drivers/scsi/lpfc
Thumshirn
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/csiostor/csio_hw.c | 15 ++-
drivers/scsi/csiostor/csio_mb.c | 9 +++--
drivers/scsi/csiostor/csio_mb.h | 3 ++-
3 files changed, 11 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/
er.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 8
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 8
drivers/scsi/cxgbi/libcxgbi.c | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
b/drivers/scsi/c
On Wed, Oct 25, 2017 at 2:41 PM, Jason A. Donenfeld wrote:
> On Wed, Oct 25, 2017 at 12:01 PM, Kees Cook wrote:
>> sess->time2retain_timer.expires =
>> (get_jiffies_64() + sess->sess_ops->DefaultTime2Retain * HZ);
>> add_
On Wed, Oct 25, 2017 at 5:03 PM, Bart Van Assche wrote:
> On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote:
>> However, maintainers: sorry to send this one -- it can't be merged
>> yet, this uses timer_setup_on_stack() which is only in -next right
>> now. If it looks
On Thu, Oct 26, 2017 at 4:04 PM, Bart Van Assche wrote:
> On Thu, 2017-10-26 at 10:24 +0200, Kees Cook wrote:
>> On Wed, Oct 25, 2017 at 5:03 PM, Bart Van Assche
>> wrote:
>> > On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote:
>> > > However, maintainers: s
Assche
Cc: Jiang Yi
Cc: Varun Prakash
Cc: linux-scsi@vger.kernel.org
Cc: target-de...@vger.kernel.org
Signed-off-by: Kees Cook
---
This is rebased on top of Bart's timer clean-up patch:
https://www.spinics.net/lists/target-devel/msg15385.html
---
drivers/target/iscsi/iscsi_targ
On Fri, Oct 27, 2017 at 5:57 AM, Bart Van Assche wrote:
> On Fri, 2017-10-27 at 02:19 -0700, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to p
d in May 2017.
>
> OK. Just checking.
>
> So what's the plan here? Should both patches be routed through the timer
> tree?
That was my plan. Does that sound okay?
-Kees
--
Kees Cook
Pixel Security
from Martin’s tree + current
> patch.
>
> System has 3 adapters 8G/16G/32G.
>
>> Anyway, what kernel source tree did you use in your testing? I may be able to
>> free up some time to look into this myself.
>>
>> Bart.
>
> Thanks,
> - Himanshu
--
Kees Cook
Pixel Security
On Tue, Oct 31, 2017 at 11:36 AM, Madhani, Himanshu
wrote:
> Hi Kees,
>
>> On Oct 31, 2017, at 11:28 AM, Kees Cook wrote:
>>
>> How very strange. I don't see any code change with this patch. Even
>> the passed arguments are the same; it's only enforcing
This breaks out the logical steps to convert the qla2xxx timers:
1) init_timer() -> setup_timer()
2) refactor qla2x00_start_timer() to not pass callback as argument
3) qla2x00_timer() to use timer_setup()
4) qla2x00_sp_timeout() to use timer_setup()
The resulting diff is identical to the patch th
2xxx-upstr...@qlogic.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/qla2xxx/qla_gbl.h | 2 +-
drivers/scsi/qla2xxx/qla_mid.c | 2 +-
drivers/scsi/qla2xxx/qla_os.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gbl.h
...@qlogic.com
Cc: "Martin K. Petersen"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/qla2xxx/qla_inline.h | 5 ++---
drivers/scsi/qla2xxx/qla_os.c | 5 ++---
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_inline.h
b/dr
: "Martin K. Petersen"
Cc: qla2xxx-upstr...@qlogic.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/qla2xxx/qla_gbl.h | 2 +-
drivers/scsi/qla2xxx/qla_os.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/dr
: "Martin K. Petersen"
Cc: qla2xxx-upstr...@qlogic.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Cook
---
drivers/scsi/qla2xxx/qla_gbl.h| 2 +-
drivers/scsi/qla2xxx/qla_init.c | 4 ++--
drivers/scsi/qla2xxx/qla_inline.h | 3 +--
3 files changed, 4 insertions(+), 5 deletion
On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook wrote:
> This breaks out the logical steps to convert the qla2xxx timers:
>
> 1) init_timer() -> setup_timer()
> 2) refactor qla2x00_start_timer() to not pass callback as argument
> 3) qla2x00_timer() to use timer_setup()
> 4) ql
C action trace").
>
> However, they do apply to Linus' tree for v4.14-rc7 or later and
> thus they would also apply for the upcoming merge window.
>
> In http://www.spinics.net/lists/linux-scsi/msg114581.html I saw a decision
> to have such changes go in via the timer
101 - 163 of 163 matches
Mail list logo
