Re: [PATCH for-next] qla2xxx: delete references to unused firmware files

Hi All, On Thu, May 21, 2015 at 8:42 PM, Xose Vazquez Perez wrote: > On 05/19/2015 05:51 PM, Himanshu Madhani wrote: > >> On 5/18/15, 6:50 PM, "Julian Calaby" wrote: > >>> Do the devices these firmware files are for exist and is there any >>> chance of

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

Hi Xose, Adding you to CC. On Fri, May 22, 2015 at 10:00 AM, Julian Calaby wrote: > Some qla2xxx devices have firmware stored in flash on the device, > however for debugging and triage purposes, Qlogic staff like to > be able to load known-good versions of these firmware

[PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

publically, so to hide these missing firmware files from scripts which check such things, (e.g. Debian's initramfs-tools) put them behind a new EXPERT Kconfig option. Cc: Cc: James E.J. Bottomley Cc: Linux Firmware Maintainers Signed-off-by: Julian Calaby --- drivers/scsi/qla2xxx/Kconfig

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

spin_unlock_irq(&hw->lock); Are you _certain_ this is correct? This construct usually appears when a function has a particular lock held, then needs to unlock it to call some other function. Are you _certain_ that this isn't the case? Thanks, -- Julian Calaby Email: julian.cal...@gmail

Re: [PATCH] megaraid: add scsi_cmnd NULL check before use

necessary parentheses) will reduce the second test to: else if (scsi_io_req->Function == MPI2_FUNCTION_SCSI_IO_REQUEST || scsi_io_req->Function == MEGASAS_MPI2_FUNCTION_LD_IO_REQUEST) which is much cleaner. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.goo

Re: [PATCH] scsi:stex.c Support Pegasus 3 product

ies; > while (hba->ccb[tag].req_type & PASSTHRU_REQ_TYPE) { > if (time_after(jiffies, before + ST_INTERNAL_TIMEOUT * HZ)) { > @@ -1821,24 +1954,29 @@ static void stex_remove(struct pci_dev *pdev) > scsi_host_put(hba->host); > > pci_

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

; > - prom->sub_vendor_id[0] = (u8)PCI_VENDOR_ID_TEKRAM; > + eprom->sub_vendor_id[0] = (u8)(PCI_VENDOR_ID_TEKRAM & > le16_to_cpu(0xff)); No. The issue is that the driver is doing things like this: eeprom->member[0] = (u8)(CONSTANT & 0xff); eeprom->member[1] = (

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

Hi Jingoo, On Wed, Aug 7, 2013 at 6:36 PM, Jingoo Han wrote: > > >> -Original Message----- >> From: Julian Calaby [mailto:julian.cal...@gmail.com] >> Sent: Wednesday, August 07, 2013 5:21 PM >> To: Jingoo Han >> Cc: Oliver Neukum; James Bottomley;

Re: [PATCH 2/4] Fix for crash when bfa_itnim is NULL

py(hba_attr->vendor_info, "QLogic"); Shouldn't this be in the next patch? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/9] snic: snic module infrastructure

ivers/scsi/snic/snic_main.c > create mode 100644 drivers/scsi/snic/snic_os.h Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/9] snic: snic module infrastructure

w, so I only review for basic style issues. Thanks, Julian Calaby > Thanks > simha > > > On 12-Mar-2015, at 6:24 am, Julian Calaby wrote: > >> Hi, >> >> On Thu, Mar 12, 2015 at 4:01 AM, Narsimhulu Musini wrote: >>> snic_main.c contains module load and un

Re: [PATCH v13 1/9] scsi: sr: support runtime pm

(I'm assuming that nobody will access a data track without mounting it or holding the device open) Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this l

Re: [PATCH v13 1/9] scsi: sr: support runtime pm

Hi Aaron, On Mon, Jan 21, 2013 at 7:14 PM, Aaron Lu wrote: > On Mon, Jan 21, 2013 at 02:31:50PM +1100, Julian Calaby wrote: >> Hi Alan, >> >> On Sun, Jan 20, 2013 at 5:46 AM, Alan Stern >> wrote: >> > On Sat, 19 Jan 2013, Aaron Lu wrote: >> >>

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

verrides[current_override].board == BOARD_NCR53C400A || > + overrides[current_override].board == BOARD_DTC3181E) { These if statements are starting to get a bit long, would it make sense to replace them with a flag or equivalent? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com P

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

Hi Finn, On Fri, Dec 4, 2015 at 7:38 PM, Finn Thain wrote: > > On Fri, 4 Dec 2015, Julian Calaby wrote: > >> > - if (overrides[current_override].board == BOARD_NCR53C400A) >> > { >> > + if (overrides[current

Re: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

Hi Finn, On Sat, Dec 5, 2015 at 1:12 PM, Finn Thain wrote: > > On Sat, 5 Dec 2015, Julian Calaby wrote: > >> Hi Finn, >> >> On Fri, Dec 4, 2015 at 7:38 PM, Finn Thain >> wrote: >> > >> > On Fri, 4 Dec 2015, Julian Calaby wrote: >> > &

Re: Patch size problem

ccount, you could send it through that with appropriate From headers at the top of the email. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: How to set DPOFUA=0 ?

sn't working in debian/ubuntu & co., as happened to me... :-( Have you reported this as a bug against Jessie's kernel package? I don't believe the Debian kernel maintainers read this mailing list. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.go

Re: [PATCH] add support for DWC UFS Host Controller

should be enabled either by: 1. detecting it at runtime 2. adding a second compatible string and checking it where needed 3. using a separate driver with a different compatible string [snip] > @@ -5645,8 +6449,16 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem > *mmio_base, unsigned int irq) &

Re: [PATCH] add support for DWC UFS Host Controller

Hi Joao, On Tue, Feb 2, 2016 at 9:22 PM, Joao Pinto wrote: > Hi Julian, > > Thanks for the review. My comments are below. > > On 2/2/2016 1:00 AM, Julian Calaby wrote: >> Hi Joao, >> >> On Mon, Feb 1, 2016 at 11:47 PM, Joao Pinto wrote: >>> diff --git

Re: [PATCH] add support for DWC UFS Host Controller

Hi Joao, On Tue, Feb 2, 2016 at 10:47 PM, Joao Pinto wrote: > > Hi Julian, > I am already changing the architecture and I will send a v2 soon. > Thanks for the review. Awesome, I look forward to it. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://ww

Re: [PATCH] add support for DWC UFS Host Controller

ch will use common pci functions > from a > ufshcd-pci.c? Agree? That sounds sensible. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of

Re: [PATCH 3/7] scsi: Drop runtime PM usage count after host is added

); > @@ -290,6 +296,7 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, > struct device *dev, > goto out_destroy_host; > > scsi_proc_host_add(shost); > + scsi_autopm_put_host(shost); Would it be cleaner to export the code that runs when the

Re: RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k

t; - for (i = 0; additional[i].text; i++) > + for (i = 0; i < ARRAY_SIZE(additional); i++) { > if (additional[i].code12 == code) > - return additional[i].text; > + return additional_text + offset; > +

Re: RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k

Hi Rasmus, On Wed, Oct 7, 2015 at 2:39 AM, Rasmus Villemoes wrote: > On Tue, Oct 06 2015, Julian Calaby wrote: > >> Hi Rasmus, >> >>> >>> diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c >>> index 47aaccd5e68e..ccd34b0481cd 100644

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

Hi Xose, On Thu, Oct 8, 2015 at 2:13 AM, Xose Vazquez Perez wrote: > On Fri, May 22, 2015 at 10:00 AM, Julian Calaby > wrote: > >> Some qla2xxx devices have firmware stored in flash on the device, >> however for debugging and triage purposes, Qlogic staff like to >>

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

Hi James, On Fri, Oct 9, 2015 at 3:17 AM, James Bottomley wrote: > On Thu, 2015-10-08 at 15:46 +, Himanshu Madhani wrote: >> >> On 10/7/15, 4:41 PM, "Julian Calaby" wrote: >> >> >Hi Xose, >> > >> >On Thu, Oct 8, 2015 at 2:13 AM, Xo

Re: [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework

have lost the actual warnings here. > Please review and possibly fold the followup patch. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the bod

Re: [PATCH 1/2] qla2xxx: Remove unavailable firmware files

good to me. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] qla2xxx: Remove unavailable firmware files

Hi Himanshu, On Wed, Nov 18, 2015 at 7:44 AM, Himanshu Madhani wrote: > Remove firmware binary names for the ISPs, which > are not submitted to linux-firmware > > Signed-off-by: Himanshu Madhani > Signed-off-by: Giridhar Malavali > Reviewed-by: Julian Calaby The patch look

Re: [PATCH] SMP request handlers need to update resid

th; Would + rsp->data_len = -smprep->ResponseDataLength; not work? Thanks, -- Julian Calaby Email: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SMP request handlers need to update resid

On Dec 20, 2007 2:20 PM, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > On Thu, 20 Dec 2007 14:13:15 +1100 > "Julian Calaby" <[EMAIL PROTECTED]> wrote: > > > On Dec 20, 2007 1:44 PM, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > > > --- a/driv

Re: [PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()

eout, int copy_sense) > +int cmnd_size, int timeout, unsigned sense_bytes) Shouldn't that be unsigned _int_? Thanks, -- Julian Calaby Email: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL P

Re: aic79xx problems

boot. There is a network console - but I'm not sure whether that is useful for boot messages. Hope that helps =) -- Julian Calaby Email: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: What still uses the block layer?

tuff is being done in udev to make sure that your gigabit card is always assigned to eth0. -- Julian Calaby Email: [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: What still uses the block layer?

[adding back CCs which were dropped because I'm stupid - sorry!] On 10/16/07, Rob Landley <[EMAIL PROTECTED]> wrote: > On Monday 15 October 2007 5:27:55 am Julian Calaby wrote: > > On 10/15/07, Rob Landley <[EMAIL PROTECTED]> wrote: > > > On Monday 15 October

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

/// matched code has to be contiguous > /// > /// Blatantly cribbed from: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > > @@ > type T, T2; > expression x; > expression E1,E2,E3; > statement S; > @@ > > - x = (T)pci_alloc_consistent(E1,E2,E3); > + x = pci_za

Re: [PATCH] zfcp: Stop system after memory corruption

#x27;d be useful for debugging should this situation occur. If I'm completely mis-understanding the situation, please disregard this email. Thanks, -- Julian Calaby Email: [EMAIL PROTECTED] (please note that I'm only subscribed to linux-scsi if replying) - To unsubscribe from this

Re: [PATCH] zfcp: Stop system after memory corruption

On 5/8/07, Christof Schmitt <[EMAIL PROTECTED]> wrote: On Tue, May 08, 2007 at 01:56:07AM +1000, Julian Calaby wrote: > >From: Christof Schmitt <[EMAIL PROTECTED]> > [snip] > >- ZFCP_LOG_NORM

Re: scsi target, likely GPL violation

stion must still be asked: Can Rising Tide Systems assure us that there is no GPL licensed code within their proprietary target code? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -

Re: [PATCH 0/4] Fix performance burning or extracting audio etc. from multiple optical drives.

q is blocking? As you're playing with locks, I assume you're running with LOCKDEP enabled? If not, that might tell you what's going on. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/20] fix misspelling of current function in string

there be any value in doing this for _all_ cases where the function name is written in a format string? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&quo

Re: [PATCH 0/20] fix misspelling of current function in string

Hi Julia, On Mon, Dec 8, 2014 at 5:43 PM, Julia Lawall wrote: > On Mon, 8 Dec 2014, Julian Calaby wrote: > >> Hi Julia, >> >> On Mon, Dec 8, 2014 at 6:20 AM, Julia Lawall wrote: >> > These patches replace what appears to be a reference to the name of the >&g

Re: [PATCH] scsi:stex.c Support Pegasus 3 product

Hi Charles, On Mon, Jun 13, 2016 at 9:40 PM, Charles Chiou wrote: > Hi Julian, > > > On 06/10/2016 08:10 AM, Julian Calaby wrote: >> >> Hi Charles, >> >> On Mon, Jun 6, 2016 at 5:53 PM, Charles Chiou >> wrote: >>> >>> From: Charle

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

tained by: Jim Gill Shouldn't you update MAINTAINERs too? And isn't having this information in these files redundant? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line &quo

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

aintainers.pl patchfile.patch Thanks, Julian Calaby > > Thanks! > Arvind > ________ > From: Julian Calaby > Sent: Thursday, June 16, 2016 6:48 PM > To: Jim Gill > Cc: j...@linux.vnet.ibm.com; Martin K. Petersen; Arvind Kumar; > pv-driv

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Hi Joe, On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches wrote: > On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote: >> ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c > > just fyi: the script name is not plural Thanks, must have typo'd it between running it an

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Hi Joe, On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches wrote: > On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote: >> Hi Joe, > > rehi Julian. (I always put a salutation on my emails and always finish them with "Thanks," =) ) >> On Fri, Jun 17, 2016

Re: QLogicPTI Hangs on SPARC64

haps even, it's a a hardware > limitation that prevents up from pinpointing what is acutally no longer > responding on the bus? > -- > To unsubscribe from this list: send the line "unsubscribe sparclinux" in > the body of a message to majord...@vger.kernel.org > More maj

Re: Obtain file's inode in ufshcd driver

just its > number, so using reserved or unused fields of existing structures is > appropriate. The inode number is part of the filesystem so it wouldn't appear below that layer. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/