I hope this email meets you well in good health condition

2016-03-19 Thread Jones
My name is Jones, from the US. I'm in Syria right now fighting IS. I want to get to know you better, if I may be so bold. I consider myself an easy-going man, and I am currently looking for a relationship in which I feel loved. Please tell me more about yourself, if you don't mind

[no subject]

2018-02-03 Thread Jones
This is in regards to an inheritance on your surname, reply back using your email address, stating your full name for more details. Reply to email for info. Email me here ( ger...@dr.com )

blk-mq vs kmemleak

2015-07-03 Thread Dave Jones
After a fuzzing run recently, I noticed that the machine had oom'd, and killed everything, but there was still 3GB of memory still in use, that I couldn't even reclaim with /proc/sys/vm/drop_caches So I enabled kmemleak. After applying this.. diff --git a/mm/kmemleak.c b/mm/kmemleak.c index cf79f

Re: blk-mq vs kmemleak

2015-07-03 Thread Dave Jones
On Fri, Jul 03, 2015 at 10:04:00AM -0700, Bart Van Assche wrote: > On 07/03/15 09:11, Dave Jones wrote: > > After a fuzzing run recently, I noticed that the machine had oom'd, and > > killed everything, but there was still 3GB of memory still in use, that > > I couldn

scsi: qla2xxx: Fix apparent cut-n-paste error.

2016-12-27 Thread Dave Jones
commit 093df73771bac8a37d607c0e705d157a8cef4c5c introduces two bodies of code that look similar but with s/req/rsp/ in the second instance. But in one case, it looks like this conversion was missed. Signed-off-by: Dave Jones diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx

RE: Survey for Incident [INC0903501]

2017-01-16 Thread Jones, Cherine
From: Jones, Cherine Sent: Monday, January 16, 2017 11:10 AM To: Jones, Cherine Subject: Survey for Incident [INC0903501] Please take a moment to complete a survey on incident INC0903501 regarding "help desk survey on your email" Your feedback is

WARNING: at drivers/scsi/scsi_lib.c:1196 scsi_setup_fs_cmnd during RAID5 startup.

2013-06-12 Thread Dave Jones
3.10 seems to have a problem with dirty RAID5 sets. I've got a machine that panics on boot during RAID5 activation. After switching the BUG_ON to a WARN_ON, I was able to get this over serial console.. md/raid:md0: not clean -- starting background reconstruction md/raid:md0: device sdd1 operatio

Re: WARNING: at drivers/scsi/scsi_lib.c:1196 scsi_setup_fs_cmnd during RAID5 startup.

2013-06-12 Thread Dave Jones
On Wed, Jun 12, 2013 at 03:43:46PM -0400, Dave Jones wrote: > 3.10 seems to have a problem with dirty RAID5 sets. > > I've got a machine that panics on boot during RAID5 activation. > After switching the BUG_ON to a WARN_ON, I was able to get this over serial > console.

Re: [PATCH RESEND v2 2/2] scsi: 64-bit port of buslogic driver

2013-06-24 Thread Dave Jones
On Mon, Jun 24, 2013 at 02:26:00PM -0600, Khalid Aziz wrote: > @@ -821,7 +821,7 @@ struct blogic_ccb { > unsigned char cdblen; /* Byte 2 */ > unsigned char sense_datalen;/* Byte 3 */ > u32 datalen;

Re: [SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver

2013-09-04 Thread Dave Jones
> +struct esas2r_adapter { > +struct esas2r_target targetdb[ESAS2R_MAX_TARGETS]; > +struct esas2r_target *targetdb_end; ... > +u8 fw_coredump_buff[ESAS2R_FWCOREDUMP_SZ]; > +void esas2r_reset_chip(struct esas2r_adapter *a) > +{ > +if (!esas2r_is_adapter_present(a)) > +

fix swapped arguments in aic7xxx:ahc_find_pci_device

2013-09-04 Thread Dave Jones
The prototype for ahc_9005_subdevinfo_valid shows that the caller has the arguments in the wrong order. 637 ahc_9005_subdevinfo_valid(uint16_t device, uint16_t vendor, 638 uint16_t subdevice, uint16_t subvendor) Signed-off-by: Dave Jones diff --git a/drivers/scsi

Re: WARNING: at drivers/ata/libata-core.c:5049 ata_qc_issue+0x1c7/0x3a0()

2013-02-19 Thread Dave Jones
On Tue, Feb 19, 2013 at 04:04:33PM -0500, Douglas Gilbert wrote: > On 13-02-19 01:37 PM, Tommi Rantala wrote: > > Hello, > > > > Hit this WARNING once while fuzzing the kernel with trinity in a qemu > > virtual machine as the root user. > > > > Does this make any sense? I have occasionally s

Re: Add ACCUSYS RAID driver for Linux i386/x86-64

2007-10-22 Thread Dave Jones
On Mon, Oct 22, 2007 at 07:02:53PM -0700, David Miller wrote: > From: "Peter Chan" <[EMAIL PROTECTED]> > Date: Tue, 23 Oct 2007 09:45:48 +0800 > > > Add linux-scsi and linux-kernel in mail group. > > Please do not post your driver as a "RAR" attachment, > not only are most Linux folks not

fix cciss locking bug.

2007-12-11 Thread Dave Jones
do_cciss_intr takes the controller lock on entry, and if something goes wrong, it calls fail_all_cmds which tries to take the same lock. Signed-off-by: Dave Jones <[EMAIL PROTECTED]> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 7d70496..1c57583 100644 --- a/drivers

strange comparison in be2iscsi

2013-10-24 Thread Dave Jones
A few years ago, in 4183122dbc7c489f11971c5afa8e42011bca7fa2 this code was added to drivers/scsi/be2iscsi/be_main.c + if (abrt_task->sc->device->lun != abrt_task->sc->device->lun) + continue; Which doesn't make a lot of sense. What was the intent here ?

self assignment bug in aix94xx

2013-10-24 Thread Dave Jones
2908d778(James Bottomley2006-08-29 09:22:51 -0500 515) scb->ssp_task.retry_count = scb->ssp_task.retry_count; Is this supposed to maybe be.. scb->ssp_task.retry_count = task->ssp_task.retry_count; ? (This and a whole bunch of similar bugs found with Coverity.)

Re: strange comparison in be2iscsi

2013-10-24 Thread Dave Jones
On Thu, Oct 24, 2013 at 04:47:21AM -0400, Dave Jones wrote: > A few years ago, in 4183122dbc7c489f11971c5afa8e42011bca7fa2 > this code was added to drivers/scsi/be2iscsi/be_main.c > > + if (abrt_task->sc->device->lun != abrt_

libsrp: remove unreachable kfree

2014-01-30 Thread Dave Jones
srp_iu_pool_alloc implements what seems like a standard "common exit path with gotos" but there's only one way to reach it. Additionally the kfree(q->items) is unreachable. fold the error path back into the if. Signed-off-by: Dave Jones diff --git a/drivers/scsi/libsr

Re: [LSF/MM TOPIC] Fixing large block devices on 32 bit

2014-01-31 Thread Dave Jones
On Fri, Jan 31, 2014 at 11:02:58AM -0800, James Bottomley wrote: > it will only be a couple of years before 16TB devices are > available. By then, I bet that most arm (and other exotic CPU) Linux > based personal file servers are still going to be 32 bit, so they're not > going to be able to

suspicious self-assignment in lpfc

2014-02-18 Thread Dave Jones
Looking through coverity reports, and it flagged lpfc_read_fcf_conn_tbl() due to the following patch.. commit df0d085fdd2e7c39d1249c2d4ad6b3e176efb60c Author: James Smart Date: Fri May 31 17:05:08 2013 -0400 [SCSI] lpfc 8.3.40: Fixed FCoE connection list vlan identifier and add FCF list d

Re: [PATCH] buggered kmalloc()

2007-07-20 Thread Dave Jones
On Fri, Jul 20, 2007 at 04:03:40PM +0100, Al Viro wrote: > Signed-off-by: Al Viro <[EMAIL PROTECTED]> > --- > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c > index aebcd5f..7829ab1 100644 > --- a/drivers/scsi/iscsi_tcp.c > +++ b/drivers/scsi/iscsi_tcp.c > @@ -1885,7 +1885,

[GDTH] Remove pre 2.6 ifdefs

2007-10-09 Thread Dave Jones
Signed-off-by: Dave Jones <[EMAIL PROTECTED]> diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index 55e4d2d..bfba877 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -392,12 +392,7 @@ #include #include #include -#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,6)

aic build failure in latest linus git tree.

2007-10-12 Thread Dave Jones
CHK include/linux/utsrelease.h CALLscripts/checksyscalls.sh CHK include/linux/compile.h make -C drivers/scsi/aic7xxx/aicasm *** Install db development libraries gcc -I/usr/include -I. aicasm.c aicasm_symbol.c aicasm_gram.c aicasm_macro_gram.c aicasm_scan.c aicasm_macro_scan.c -o

Re: [PATCH] iscsi_ibft: search for broadcom specific ibft sign

2014-05-07 Thread Peter Jones
On Wed, May 07, 2014 at 02:49:59PM -0500, Mike Christie wrote: > On 05/07/2014 02:21 PM, Konrad Rzeszutek Wilk wrote: > > On Wed, May 07, 2014 at 07:12:31PM +, James Bottomley wrote: > >> On Wed, 2014-05-07 at 09:47 -0400, Konrad Rzeszutek Wilk wrote: > >>> On Wed, May 07, 2014 at 05:00:20AM -0

block: remove dead code in scsi_ioctl:blk_verify_command

2014-05-29 Thread Dave Jones
filter gets assigned the address of blk_default_cmd_filter on entry to this function, so the !filter condition can never be true. Signed-off-by: Dave Jones diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index 26487972ac54..9c28a5b38042 100644 --- a/block/scsi_ioctl.c +++ b/block

Re: why does x86 "make defconfig" build a single, lonely module?

2007-05-13 Thread Dave Jones
uestions when async scsi scanning was added. This might further clarify.. --- The scsi_wait_scan module is only really useful if async scanning is enabled. Signed-off-by: Dave Jones <[EMAIL PROTECTED]> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index e62d23f..0f6c370 100644 --

Re: why does x86 "make defconfig" build a single, lonely module?

2007-05-13 Thread Dave Jones
On Sun, May 13, 2007 at 11:10:55AM -0500, James Bottomley wrote: > > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > > index e62d23f..0f6c370 100644 > > --- a/drivers/scsi/Kconfig > > +++ b/drivers/scsi/Kconfig > > @@ -244,7 +244,7 @@ config SCSI_SCAN_ASYNC > > config SCSI_WAIT_S

Re: why does x86 "make defconfig" build a single, lonely module?

2007-05-13 Thread Dave Jones
On Sun, May 13, 2007 at 11:18:35AM -0500, James Bottomley wrote: > On Sun, 2007-05-13 at 11:10 -0500, James Bottomley wrote: > > > -depends on SCSI > > > +depends on SCSI_SCAN_ASYNC > > > > No. SCSI_SCAN_ASYNC is a bool ... if you depend on it, you'll force the > > wait scan

Re: why does x86 "make defconfig" build a single, lonely module?

2007-05-13 Thread Dave Jones
On Sun, May 13, 2007 at 07:26:31PM +0100, Simon Arlott wrote: > It looks like SCSI_WAIT_SCAN is pointless unless SCSI_SCAN_ASYNC > is selected - so it should depend on it: > > --- > diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > index e62d23f..0f6c370 100644 > --- a/drivers/sc

Re: Asynchronous scsi scanning

2007-05-17 Thread Dave Jones
On Thu, May 17, 2007 at 03:30:43PM -0600, Matthew Wilcox wrote: > On Thu, May 17, 2007 at 03:43:26PM -0400, Benjamin LaHaise wrote: > > On Thu, May 17, 2007 at 01:39:54PM -0600, Matthew Wilcox wrote: > > > On Fri, May 18, 2007 at 12:34:40AM +0530, Satyam Sharma wrote: > > > > Hmmm, actually tho

Re: Asynchronous scsi scanning

2007-05-17 Thread Peter Jones
Dave Jones wrote: On Thu, May 17, 2007 at 03:30:43PM -0600, Matthew Wilcox wrote: > On Thu, May 17, 2007 at 03:43:26PM -0400, Benjamin LaHaise wrote: > > On Thu, May 17, 2007 at 01:39:54PM -0600, Matthew Wilcox wrote: > > > On Fri, May 18, 2007 at 12:34:40AM +0530, S

Re: Asynchronous scsi scanning

2007-05-17 Thread Peter Jones
Matthew Wilcox wrote: On Tue, May 15, 2007 at 12:26:29PM +0100, Simon Arlott wrote: I've already suggested a sysfs attribute - or something equivalent - would be much better. It's just one function that a user might want to run multiple times (e.g. after adding scsi devices?) - why should loadin

Re: [patch 10/28] Fix |/|| confusion in fusion driver

2007-05-21 Thread Dave Jones
being bit-wise or'ed. Andrew, the last time this was posted, Eric picked up on some other flaws in the same area. James asked him to followup with a patch, but unless I'm mistaken, that never arrived. This diff should replace the one in your tree until Eric has an equivalent or better. Si

Re: [PATCH v5 0/3] UFS on APQ8098/MSM8998t

2019-02-26 Thread Lee Jones
i | 65 +++ > 3 files changed, 88 insertions(+) I assume these are the same patches we've been using in our tree. If so: Tested-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v5 0/2] Clean up UFSHC driver

2019-02-26 Thread Lee Jones
iver > > scsi: ufs: Remove unused device quirks > > > > drivers/scsi/ufs/ufs.h| 1 - > > drivers/scsi/ufs/ufs_quirks.h | 29 ---- > > drivers/scsi/ufs/ufshcd.c | 63 +++ > > 3 files changed, 4 insertions(+), 89 deletions(-) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: ufshcd_abort: Device abort task at tag 7

2019-09-02 Thread Lee Jones
k you! > > As I understand it's planned to eventually boot this devices via ACPI. > > @Lee Jones, is my understanding correct? No, not exactly. We can boot these devices using ACPI, but with limited functionality (when compared with booting using DT). There are too many b

Re: Transient disk failures not retried?

2001-01-15 Thread Dan Jones
inal system any change can have surprising effects. I take the same line regarding mixing drives as the RAID vendors, but it is more of a configuration matrix problem than one of functionality. I just can't test every possible combination, so I can't make a blanket recommendation except

Re: Transient disk failures not retried?

2001-01-17 Thread Dan Jones
Max TenEyck Woodbury wrote: > > Dan Jones wrote: > > > > Max TenEyck Woodbury wrote: > >> ... > >> > >> My impression is that no error recovery is being tried > >> for transient failures. Could someone confirm this? > >> If this i

Re: how to issue a FORMAT_UNIT command

2001-01-24 Thread Dan Jones
cessitated blowing away the old partition: dd if=/dev/zeros of= count=2 -- Dan Jones, Manager, Storage Products VA Linux Systems V:(510)687-6737 F:(510)683-8602 47071 Bayside Parkway [EMAIL PROTECTED]Fremont, CA 94538 - To unsubscribe from this li

Re: downloading drive firmware to a fibre channel drive through linux

2001-02-22 Thread Dan Jones
ses PTI. The firmware itself is normally a file that is written to the device via SCSI Write Buffer commands. -- Dan Jones, Manager, Storage Products VA Linux Systems V:(510)687-6737 F:(510)683-8602 47071 Bayside Parkway [EMAIL PROTECTED]Fremont,

Re: downloading drive firmware to a fibre channel drive through linux

2001-02-22 Thread Mike Jones
door stop! So, it's better (less dangerous) than it was a few years ago, but there are still opportunites to learn expensive lessons! Michael Jones Peripheral Test Instruments 303-763-7488 www.scsitools.com - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in t

Re: Decoding error message

2001-02-23 Thread Dan Jones
92 and 11308544 in some fashion. Having accesses to two widely displaced sectors fail with this error implies that the drive positioning hardware is going bad or the drive is seeing too much shock or vibration. -- Dan Jones, Manager, Storage Products VA Linux Systems V:(510)687-6737 F:(5

Re: stability problem with SCSI in linux 2.4.2

2001-03-05 Thread Dan Jones
uded extensive testing using cerberus on all of our systems with embedded SCSI and PCI HBA SCSI with SCSI drives, tape, and a few tape libraries. Life is better now. -- Dan Jones, Manager, Storage Products VA Linux Systems V:(510)687-6737 F:(510)683-8602 47071 Bayside Parkway

Re: FW: Help required on how to interface tcp in Linux

2001-04-16 Thread Dan Jones
on > Perhaps you will find something useful in Intel's reference implementation: http://sourceforge.net/projects/intel-iscsi/ -- Dan Jones, Manager, Storage Products VA Linux Systems V:(510)687-6737 F:(510)683-8602 47071 Bayside Parkway [EMAIL PROTECTED]

blacklist microtek scanmaker III

2005-02-23 Thread Dave Jones
of not too many) devices that broke. (See https://bugzilla.redhat.com/beta/show_bug.cgi?id=149402 for more info) Signed-off-by: Dave Jones <[EMAIL PROTECTED]> --- linux-2.6.10/drivers/scsi/scsi_devinfo.c~ 2005-02-23 14:27:53.0 -0500 +++ linux-2.6.10/drivers/scsi/scsi_devinfo.c

Re: [patch 1/1] Whitelist-Entry (FORCELUN) for SGS Thomson Microelectronics Cytronix 6in1 card reader in scsi_devinfo.c

2005-03-09 Thread Dave Jones
On Wed, Mar 09, 2005 at 01:03:32AM -0800, Andrew Morton wrote: > > From: Hanno Boeck <[EMAIL PROTECTED]> > > I have a usb-cardreader here that needs some FORCELUN-entries in > scsi_devinfo.c. > > lsusb says about the device: > > Bus 001 Device 003: ID 0483:1307 SGS Thomson Microelectro

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-03 Thread Dave Jones
On Thu, Aug 04, 2005 at 10:09:51AM +0530, Saripalli, Venkata Ramanamurthy (STSD) wrote: > - ULONG ulFibreFrame[2048/4]; // max DWORDS in incoming FC This is 512 ulongs, which is 2KB. > + ulFibreFrame = kmalloc((2048/4), GFP_KERNEL); You're replacing it with a 512 byte buffer.

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Dave Jones
On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote: > > >+ ulFibreFrame = kmalloc((2048/4), GFP_KERNEL); > The size bug was already found by Dave Jones. This never should be written > this way (not your fault). The array should have been [2048/sizeof(ULONG)]

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Dave Jones
On Thu, Aug 04, 2005 at 05:56:14PM +0200, Rolf Eike Beer wrote: > Am Donnerstag, 4. August 2005 17:40 schrieb Dave Jones: > >On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote: > > > >+ ulFibreFrame = kmalloc((2048/4), GFP_KERNEL); > > >

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Dave Jones
On Thu, Aug 04, 2005 at 07:11:38PM +0200, Rolf Eike Beer wrote: > >It's pointless to fix this, without fixing also CpqTsGetSFQEntry() > At least half of the file should be rewritten. Just half ? You're such an optimist :-) > > > No, ulDestPtr ist ULONG* so we increase it by sizeof(ULONG)*16 wh

blacklist addition.

2005-08-08 Thread Dave Jones
vendors just fine. Signed-off-by: Dave Jones <[EMAIL PROTECTED]> --- linux-2.6.11/drivers/scsi/scsi_devinfo.c~ 2005-04-29 18:16:15.0 -0400 +++ linux-2.6.11/drivers/scsi/scsi_devinfo.c2005-04-29 18:18:27.0 -0400 @@ -114,6 +114,7 @@ static struct { {"YAMAH

Re: [RFC 1/2] target: Add documentation on the target userspace pass-through driver

2014-08-30 Thread Richard W.M. Jones
is case you're leaping into something .. fabrics, LIO, backstores, target solutions, ... aargh. Explain what you mean by each term and how it all fits together. Thanks, Rich. [1] https://en.wikipedia.org/wiki/In_medias_res [2] http://www.economist.com/styleguide/introduction -- Richard Jones,

Re: [RFC 1/2] target: Add documentation on the target userspace pass-through driver

2014-08-31 Thread Richard W.M. Jones
es, but not all. One new > use case that other non-kernel target solutions, such as tgt, are able > to support is using Gluster's GLFS or Ceph's RBD as a backstore. The > target then serves as a translator, allowing initiators to store data > in these non-traditional networke

Increased memory usage with scsi-mq

2017-08-04 Thread Richard W.M. Jones
: 1755 disks I don't know why the ratio is almost exactly 10 times. I read your slides about scsi-mq and it seems like a significant benefit to large machines, but could the out of the box defaults be made more friendly for small memory machines? Thanks, Rich. -- Richard Jones, Virtualiz

Re: Increased memory usage with scsi-mq

2017-08-05 Thread Richard W.M. Jones
On Sat, Aug 05, 2017 at 10:44:36AM +0200, Christoph Hellwig wrote: > On Fri, Aug 04, 2017 at 10:00:47PM +0100, Richard W.M. Jones wrote: > > I read your slides about scsi-mq and it seems like a significant > > benefit to large machines, but could the out of the box defaults b

Re: Increased memory usage with scsi-mq

2017-08-05 Thread Richard W.M. Jones
are necessary. The kernel behaves exactly the same way with or without the third hunk (ie. num_queues must already be 1). Can I infer from this that qemu needs a way to specify the can_queue setting to the virtio-scsi driver in the guest kernel? Rich. -- Richard Jones, Virtualization Group, Red Ha

Re: Increased memory usage with scsi-mq

2017-08-07 Thread Richard W.M. Jones
cmd_per_lun = virtscsi_config_get(vdev, cmd_per_lun) ?: 1; shost->cmd_per_lun = min_t(u32, cmd_per_lun, shost->can_queue); but setting cmd_per_lun (as a qemu virtio-scsi-pci parameter) didn't seem to make any difference to memory usage. Rich. -- Richard Jones, Virtualization Group, Re

Re: Increased memory usage with scsi-mq

2017-08-10 Thread Richard W.M. Jones
the limits be? Rich. >From e923e49846189b2f55f3f02b70a290d4be237ed5 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Thu, 10 Aug 2017 12:21:47 +0100 Subject: [PATCH] scsi: virtio_scsi: Set can_queue based on cmd_per_lun passed by hypervisor. Signed-off-by: Richard W

Re: Increased memory usage with scsi-mq

2017-08-10 Thread Richard W.M. Jones
g VirtIOSCSIConfig; struct VirtIOSCSIConf { uint32_t num_queues; +uint32_t virtqueue_size; uint32_t max_sectors; uint32_t cmd_per_lun; #ifdef CONFIG_VHOST_SCSI -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html

Re: Increased memory usage with scsi-mq

2017-08-10 Thread Richard W.M. Jones
ct VirtIOSCSIConf { uint32_t num_queues; +uint32_t virtqueue_size; uint32_t max_sectors; uint32_t cmd_per_lun; #ifdef CONFIG_VHOST_SCSI -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http:/

[PATCH 2/2] virtio: virtio_scsi: Set can_queue to the length of the virtqueue.

2017-08-10 Thread Richard W.M. Jones
ichard W.M. Jones --- drivers/scsi/virtio_scsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 9be211d68b15..d6b4ff634c0d 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -972,6 +972,8 @@ static int virt

[PATCH 1/2] virtio: Reduce BUG if total_sg > virtqueue size to WARN.

2017-08-10 Thread Richard W.M. Jones
If using indirect descriptors, you can make the total_sg as large as you want. If not, BUG is too serious because the function later returns -ENOSPC. Thanks Paolo Bonzini, Christoph Hellwig. Signed-off-by: Richard W.M. Jones --- drivers/virtio/virtio_ring.c | 5 +++-- 1 file changed, 3

[PATCH 0/2] virtio_scsi: Set can_queue based on size of virtqueue.

2017-08-10 Thread Richard W.M. Jones
Earlier discussion: https://lkml.org/lkml/2017/8/4/601 "Increased memory usage with scsi-mq" Downstream bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1478201

[PATCH v2 0/2] virtio_scsi: Set can_queue based on size of virtqueue.

2017-08-10 Thread Richard W.M. Jones
v1 was here: https://lkml.org/lkml/2017/8/10/689 v1 -> v2: Remove .can_queue field from the templates. Rich.

[PATCH v2 2/2] virtio: virtio_scsi: Set can_queue to the length of the virtqueue.

2017-08-10 Thread Richard W.M. Jones
ichard W.M. Jones --- drivers/scsi/virtio_scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 9be211d68b15..7c28e8d4955a 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -818,7 +818,6

[PATCH v2 1/2] virtio: Reduce BUG if total_sg > virtqueue size to WARN.

2017-08-10 Thread Richard W.M. Jones
If using indirect descriptors, you can make the total_sg as large as you want. If not, BUG is too serious because the function later returns -ENOSPC. Thanks Paolo Bonzini, Christoph Hellwig. Signed-off-by: Richard W.M. Jones Reviewed-by: Paolo Bonzini --- drivers/virtio/virtio_ring.c | 5

Re: [PATCH 1/2] virtio: Reduce BUG if total_sg > virtqueue size to WARN.

2017-08-10 Thread Richard W.M. Jones
On Fri, Aug 11, 2017 at 12:21:16AM +0300, Michael S. Tsirkin wrote: > On Thu, Aug 10, 2017 at 05:40:34PM +0100, Richard W.M. Jones wrote: > > If using indirect descriptors, you can make the total_sg as large as > > you want. > > That would be a spec violation though, even if

Re: [PATCH 1/2] virtio: Reduce BUG if total_sg > virtqueue size to WARN.

2017-08-10 Thread Richard W.M. Jones
On Fri, Aug 11, 2017 at 12:31:44AM +0300, Michael S. Tsirkin wrote: > Then we probably should fail probe if vq size is too small. What does this mean? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: h

Re: [PATCH 1/2] virtio: Reduce BUG if total_sg > virtqueue size to WARN.

2017-08-10 Thread Richard W.M. Jones
On Fri, Aug 11, 2017 at 12:41:47AM +0300, Michael S. Tsirkin wrote: > On Thu, Aug 10, 2017 at 10:35:11PM +0100, Richard W.M. Jones wrote: > > On Fri, Aug 11, 2017 at 12:31:44AM +0300, Michael S. Tsirkin wrote: > > > Then we probably should fail probe if vq size is too small.

[PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.

2012-08-20 Thread Richard W.M. Jones
From: "Richard W.M. Jones" The sg struct is used without being initialized. https://bugzilla.redhat.com/show_bug.cgi?id=847548 Signed-off-by: Richard W.M. Jones --- drivers/scsi/virtio_scsi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/virti

Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.

2012-10-01 Thread Richard W.M. Jones
On Mon, Oct 01, 2012 at 03:13:01PM +0200, Paolo Bonzini wrote: > Il 20/08/2012 16:05, Paolo Bonzini ha scritto: > > Il 20/08/2012 16:04, Richard W.M. Jones ha scritto: > >> From: "Richard W.M. Jones" > >> > >> The sg struct is used without being init

Attn Beneficiary,

2017-05-16 Thread Mrs. Linda Jones
Attn Beneficiary, We have deposited the check of your fund ($2.5m USD) through western union money transfer department after our finally meeting today regarding your fund, Now all you will do is to contact western union director Mis Rose Kelly ,And She will give you the direction on how you wil