Re: [PATCH] scsi: wd719x: Use module_pci_driver

t wd719x_exit(void) > -{ > - pci_unregister_driver(&wd719x_pci_driver); > -} > - > -module_init(wd719x_init); > -module_exit(wd719x_exit); > +module_pci_driver(wd719x_pci_driver); >   >  MODULE_DESCRIPTION("Western Digital WD7193/7197/7296 SCSI driver"); >  MODULE_AUTHO

Re: [PATCH] scsi: restart list search after unlock in scsi_remove_target

On Mon, 2015-10-19 at 16:35 +0200, Christoph Hellwig wrote: > When dropping a lock while iterating a list we must restart the > search > as other threads could have manipulated the list under us.  Without > this > we can get stuck in an endless loop. > > Reported-by: Johanne

Re: [PATCH 3/3] megaraid_sas: return -ENOMEM when create DMA pool for cmd frames failed

frame to each cmd >    */ >   if (megasas_create_frame_pool(instance)) { > - dev_dbg(&instance->pdev->dev, "Error creating frame > DMA pool\n"); > + dev_err(&instance->pdev->dev, "Error creating frame > DMA pool\n&qu

Re: [PATCH 2/3] megaraid_sas: Convert printk to printk_

pr_debug("megasas: failed to open device node\n"); >   return rval; >   } >   > @@ -6752,7 +6752,7 @@ static int __init megasas_init(void) >   rval = pci_register_driver(&megasas_pci_driver); >   >   if (rval) { > - printk(KERN_DEBUG "megasas: PCI hotplug registration > failed \n"); > + pr_debug("megasas: PCI hotplug registration failed > \n"); >   goto err_pcidrv; >   } >   Reviewed-by: Johannes Thumshirn -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_

, >   &instance- > >evt_detail_h); >   >   if (!instance->evt_detail) { > - dev_printk(KERN_DEBUG, &pdev->dev, "Failed to > allocate memory for " > + dev_dbg(&pdev->dev, "Failed to allocate memory for " >      "event detail structure\n"); >   goto fail_alloc_dma_buf; >   } > @@ -5397,7 +5397,7 @@ static int megasas_probe_one(struct pci_dev > *pdev, >    * Initiate AEN (Asynchronous Event Notification) >    */ >   if (megasas_start_aen(instance)) { > - dev_printk(KERN_DEBUG, &pdev->dev, "start aen > failed\n"); > + dev_dbg(&pdev->dev, "start aen failed\n"); >   goto fail_start_aen; >   } >   > @@ -5973,14 +5973,14 @@ megasas_mgmt_fw_ioctl(struct megasas_instance > *instance, >   memset(kbuff_arr, 0, sizeof(kbuff_arr)); >   >   if (ioc->sge_count > MAX_IOCTL_SGE) { > - dev_printk(KERN_DEBUG, &instance->pdev->dev, "SGE > count [%d] >  max limit [%d]\n", > + dev_dbg(&instance->pdev->dev, "SGE count [%d] >  max > limit [%d]\n", >      ioc->sge_count, MAX_IOCTL_SGE); >   return -EINVAL; >   } >   >   cmd = megasas_get_cmd(instance); >   if (!cmd) { > - dev_printk(KERN_DEBUG, &instance->pdev->dev, "Failed > to get a cmd packet\n"); > + dev_dbg(&instance->pdev->dev, "Failed to get a cmd > packet\n"); >   return -ENOMEM; >   } >   > @@ -6025,7 +6025,7 @@ megasas_mgmt_fw_ioctl(struct megasas_instance > *instance, >   ioc- > >sgl[i].iov_len, >   &buf_handle, > GFP_KERNEL); >   if (!kbuff_arr[i]) { > - dev_printk(KERN_DEBUG, &instance->pdev->dev, > "Failed to alloc " > + dev_dbg(&instance->pdev->dev, "Failed to > alloc " >      "kernel SGL buffer for IOCTL\n"); >   error = -ENOMEM; >   goto out; > @@ -6111,7 +6111,7 @@ megasas_mgmt_fw_ioctl(struct megasas_instance > *instance, >    */ >   if (copy_to_user(&user_ioc->frame.hdr.cmd_status, >    &cmd->frame->hdr.cmd_status, sizeof(u8))) { > - dev_printk(KERN_DEBUG, &instance->pdev->dev, "Error > copying out cmd_status\n"); > + dev_dbg(&instance->pdev->dev, "Error copying out > cmd_status\n"); >   error = -EFAULT; >   } >   Reviewed-by: Johannes Thumshirn -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: restart list search after unlock in scsi_remove_target

On Mon, 2015-10-19 at 16:35 +0200, Christoph Hellwig wrote: > When dropping a lock while iterating a list we must restart the > search > as other threads could have manipulated the list under us.  Without > this > we can get stuck in an endless loop. > > Reported-by: Johanne

Re: [PATCH] scsi: restart list search after unlock in scsi_remove_target

Hi Bart, On Tue, 2015-10-27 at 13:14 -0700, Bart Van Assche wrote: > On 10/26/2015 01:35 AM, Johannes Thumshirn wrote: > > I haven't heard anything from the original reporter of the lockup > > but > > my test's went all O.K., so > > > > Tested-by: Jo

Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval

et_real_seconds, which returns a 64-bit seconds value. Thanks for the conversion. Can you please check if other (scsi) drivers have the same y2038 issues? A quick "git grep do_gettimeofday drivers/scsi/  | wc -l" reveals 30 occurrences (of cause not all are problematic). Other than that

Re: [RESEND PATCH] qla2xxx: Remove use of 'struct timeval'

beyond. > The patch uses ktime_get_real_seconds() which returns a 64-bit > seconds value. > > Signed-off-by: Tina Ruchandani Reviewed-by: Johannes Thumshirn > --- >  drivers/scsi/qla2xxx/qla_mr.c | 5 ++--- >  1 file changed, 2 insertions(+), 3 deletions(-) > > di

Re: [RESEND PATCH] [SCSI] mvumi: 64bit value for seconds_since1970

year 2038. > This patch uses ktime_get_real_seconds() instead since it provides a > 64-bit seconds value, which is 2038 safe. > > Signed-off-by: Tina Ruchandani Reviewed-by: Johannes Thumshirn > --- >  drivers/scsi/mvumi.c | 10 +- >  1 file changed, 5 insertions(+), 5 del

[PATCH RESEND] scsi: Export SCSI Inquiry data to sysfs

2020 2020 010 4551 554d 4420 4456 522d 4d4f 2020 2020 020 2e32 2e33 024 Signed-off-by: Johannes Thumshirn Reviewed-by: Hannes Reinecke --- drivers/scsi/scsi_sysfs.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi

Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

Hi Tim, tim.gard...@canonical.com writes: > From: Tim Gardner > > drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': > drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied > to the left hand side of comparison [-Wlogical-not-parentheses] > WARN_ON

[PATCH RESEND] scsi: Export SCSI Inquiry data to sysfs

2020 2020 010 4551 554d 4420 4456 522d 4d4f 2020 2020 020 2e32 2e33 024 Signed-off-by: Johannes Thumshirn Reviewed-by: Hannes Reinecke --- 1st sent on Aug. 14 2015 1st resend on Oct. 30 2015 drivers/scsi/scsi_sysfs.c | 24 1 file changed, 24 insertions

Re: [patch] hpsa: logical vs bitwise AND typo

sa.c > @@ -8671,7 +8671,7 @@ static void hpsa_disable_rld_caching(struct > ctlr_info *h) >   if ((rc != 0)  || (c->err_info->CommandStatus != 0)) >   goto errout; >   > - if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING) > + if (*options &

Re: dm-multipath test scripts

On Wed, 2015-10-07 at 05:39 +, Junichi Nomura wrote: > This is a set of scripts for kernel-side dm-multipath testing. > Current > set of scripts are stress testing of extreme situation and its > coverage > is limited. But recently found dm-mpath regressions should be > detectable > with this. I

Re: [PATCH V2] st: fix potential null pointer dereference.

t; @@ -4110,8 +4110,9 @@ static int create_one_cdev(struct scsi_tape > *tape, int mode, int rew) >   return 0; >  out_free: >   cdev_del(STm->cdevs[rew]); > - STm->cdevs[rew] = NULL; >  out: > + STm->cdevs[rew] = NULL; > + STm->devs[rew] = NULL;

[RFC PATCH] lpfc: Add lockdep assertions

Several functions in lpfc have comments stating that the function must be called with the hbalock (or hostlock, or ringlock) held. Add lockdep_assert_held() annotations to these functions, so one can actually verify the locks are held. Signed-off-by: Johannes Thumshirn --- I'm not sure if

Re: [PATCH 01/18] scsi_dh: move 'dh_state' sysfs attribute to generic code

sdev_printk(KERN_WARNING, sdev, > + "can't detach handler %s.\n", > + sdev->handler->name); > + err = -EINVAL; > + } > + > + return err < 0 ? err : count; > +} > + > +static DEVICE_ATTR(d

Re: [PATCH 02/18] scsi: ignore errors from scsi_dh_add_device()

+  * device_handler is optional, so any error can be > ignored > +  */ >   sdev_printk(KERN_INFO, sdev, >   "failed to add device handler: > %d\n", error); > - return error; > - } >   >   device_enable_async_suspend(&sde

Re: [PATCH 03/18] scsi_dh_alua: Disable ALUA handling for non-disk devices

; + sdev_printk(KERN_INFO, sdev, > + "%s: disable for non-disk devices\n", > + ALUA_DH_NAME); > + return SCSI_DH_DEV_UNSUPP; > + } > + >   h->tpgs = scsi_device_tpgs(sdev); >   swi

Re: [PATCH 04/18] scsi_dh_alua: Use vpd_pg83 information

"%s: port group %02x rel port %02x\n", > - ALUA_DH_NAME, h->group_id, h->rel_port); > + return SCSI_DH_DEV_UNSUPP; >   } > + sdev_printk(KERN_INFO, sdev, > + "%s: port group %02x rel port %02x\n", >

Re: [PATCH 05/18] scsi_dh_alua: improved logging

SCSI_DH_DEV_UNSUPP; >   break; > + default: > + sdev_printk(KERN_INFO, sdev, > + "%s: unsupported TPGS setting %d\n", > + ALUA_DH_NAME, h->tpgs); > + h->tpgs = TPGS_MODE_NONE;

Re: [PATCH 06/18] scsi_dh_alua: sanitze sense code handling

: >   err = submit_rtpg(sdev, h, rtpg_ext_hdr_req); >   > - if (err == SCSI_DH_IO && h->senselen > 0) { > - err = scsi_normalize_sense(h->sense, > SCSI_SENSE_BUFFERSIZE, > -    &sense_hdr); > -

Re: [PATCH 07/18] scsi_dh_alua: use standard logging functions

t;%s: rtpg sense code %02x/%02x/%02x\n", > - ALUA_DH_NAME, sense_hdr.sense_key, > - sense_hdr.asc, sense_hdr.ascq); > - err = SCSI_DH_IO; > + } > + sdev_printk(KERN_ERR, sdev, "%s: rtpg failed\n", > +   

Re: [PATCH 13/18] scsi_dh_alua: rework alua_check_tpgs() to return the tpgs mode

- int err; > + int err = SCSI_DH_DEV_UNSUPP; >   > - err = alua_check_tpgs(sdev, h); > - if (err != SCSI_DH_OK) > + h->tpgs = alua_check_tpgs(sdev); > + if (h->tpgs == TPGS_MODE_NONE) >   goto out; >   >   err = alua_check_vpd(sdev, h); Reviewed-by: Johannes Thumshirn -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 08/18] scsi_dh_alua: return standard SCSI return codes in submit_rtpg

} >   >   /* >    * submit_rtpg() has failed on existing arrays > @@ -539,8 +542,6 @@ static int alua_rtpg(struct scsi_device *sdev, > struct alua_dh_data *h, int wait_ >   scsi_print_sense_hdr(sdev, ALUA_DH_NAME, > &sense_hdr); >

Re: [PATCH 11/18] scsi_dh_alua: use flag for RTPG extended header

;flags & ALUA_RTPG_EXT_HDR_UNSUPP) && >   sense_hdr.sense_key == ILLEGAL_REQUEST && >   sense_hdr.asc == 0x24 && sense_hdr.ascq == 0) { > - rtpg_ext_hdr_req = 0; > + h->flags |= ALUA_RTPG_EXT_HDR_UNSUPP; >   goto retry; >   } >   Reviewed-by: Johannes Thumshirn -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 09/18] scsi_dh_alua: fixup description of stpg_endio()

- * Send a SET TARGET GROUP STATES command to the device. > - * We only have to test here if we should resubmit the command; > - * any other error is assumed as a failure. > + * Evaluate a SET TARGET GROUP STATES command response. >   */ >  static void stpg_endio(struct request *req, i

Re: [PATCH 12/18] scsi_dh_alua: use unaligned access macros

lt; 24) + (h->buff[1] << 16) + > - (h->buff[2] << 8) + h->buff[3] + 4; > + len = get_unaligned_be32(&h->buff[0]) + 4; >   >   if (len > h->bufflen) { >   /* Resubmit with the correct length */ > @@ -576,7 +569,7 @@ static int alua_rtpg(struc

Re: [PATCH 10/18] scsi: remove scsi_show_sense_hdr()

*, > - const struct scsi_sense_hdr *); >  extern void scsi_print_sense_hdr(const struct scsi_device *, const > char *, >    const struct scsi_sense_hdr *); >  extern void scsi_print_sense(const struct scsi_cmnd *); Reviewed-by: Jo

Re: [PATCH 14/18] scsi_dh_alua: simplify sense code handling

 */ > + if (sense_hdr.sense_key == NOT_READY && > + sense_hdr.asc == 0x04 && sense_hdr.ascq == 0x0a) > + err = SCSI_DH_RETRY; > + else if (sense_hdr.sense_key == UNIT_ATTENTION) > + err = SCSI_DH_RETRY; > +

Re: [PATCH 16/18] scsi: export 'device_id' to sysfs

gt; + >  #ifdef CONFIG_SCSI_DH >  static ssize_t >  sdev_show_dh_state(struct device *dev, struct device_attribute > *attr, > @@ -1026,6 +1042,7 @@ static struct attribute *scsi_sdev_attrs[] = { >   &dev_attr_modalias.attr, >   &dev_attr_queue_depth.attr, >  

Re: [PATCH 15/18] scsi: Add scsi_vpd_lun_id()

break; > + default: > + break; > + } > +next_desig: > + d += d[3] + 4; > + } > + rcu_read_unlock(); > + > + return id_size; > +} > +EXPORT_SYMBOL(scsi_vpd_lun_id); > diff --git a/includ

Re: [PATCH 17/18] scsi: Add scsi_vpd_tpg_id()

ice *sdev, >  extern void sdev_disable_disk_events(struct scsi_device *sdev); >  extern void sdev_enable_disk_events(struct scsi_device *sdev); >  extern int scsi_vpd_lun_id(struct scsi_device *, char *, size_t); > +extern int scsi_vpd_tpg_id(struct scsi_device *, int *); >   >  #ifdef CONFIG_PM >  extern int scsi_autopm_get_device(struct scsi_device *); Reviewed-by: Johannes Thumshirn -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 18/18] scsi_dh_alua: use scsi_vpd_tpg_id()

; > - h->state = TPGS_STATE_OPTIMIZED; > - h->tpgs = TPGS_MODE_NONE; >   return SCSI_DH_DEV_UNSUPP; >   } > + h->rel_port = rel_port; > + h->group_id = group_id; > + >   sdev_printk(KERN_INFO, sdev, >  

Re: [PATCH 1/2] scsi_transport_fc: Introduce scsi_host_{get,put}()

- > >vport list */ >   fc_host->npiv_vports_inuse--; >   spin_unlock_irqrestore(shost->host_lock, flags); >   put_device(dev->parent); > @@ -3504,7 +3504,7 @@ fc_vport_terminate(struct fc_vport *vport) >   vport->flags |= FC_VPORT_DELETED; >  

Re: [PATCH 3/3] MAINTAINERS: Add myself as co-maintainer of the SCSI subsystem.

tin K. Petersen" > +T: git > git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git > +L: linux-scsi@vger.kernel.org >  S: Maintained >  F: drivers/scsi/ >  F: include/scsi/ Reviewed-by: Johannes Thumshirn -- To unsubscribe from this list: send the line "uns

Re: [PATCH] scsi: use sector_div instead of do_div

csi_debug_unmap_granularity); >   >   return lba; >  } > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.htm

Re: [RFC PATCH scsi] aacraid: aac_release_resources() can be static

; +static void aac_release_resources(struct aac_dev *aac) >  { >   int i; >   > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at  http://vger.kernel.

Re: [PATCH 1/3] sd: Make discard granularity match logical block size when LBPRZ=1

= sdkp->unmap_alignment > * > + logical_block_size; > + q->limits.discard_granularity = > + max(sdkp->physical_block_size, > + sdkp->unmap_granularity * > logical_block_size); > + } >   >  

Re: [PATCH] Fix a memory leak in scsi_host_dev_release()

; +  * scsi_host_add() nor scsi_host_remove() has been > called. > +  * This avoids that the memory allocated for the > shost_dev > +  * name is leaked. > +  */ > + kfree(dev_name(&shost->shost_dev)); > + } > + >  

Re: [PATCH v2 2/3] arcmsr: adds code for support areca new adapter ARC1203

On Wed, 2015-11-25 at 11:25 +0800, Ching Huang wrote: > From: Ching Huang > > Support areca new PCIe to SATA RAID adapter ARC1203 > > Signed-of-by: Ching Huang > > --- > > diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h > --- a/drivers/scsi/arcmsr/arcmsr.h2015-11-2

iSCSI and scsi-mq

Hi iSCSI experts, I've been starting to research possible implementations of a scsi-mq capable iSCSI. With my research I found the following thread https://groups.google.com/ forum/#!msg/open-iscsi/qLaXJh2Gqt4/A2NIDZ0fT9oJ and wondered what happened to the efforts layed out there (and what have be

Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

*/ > - acb->firm_sdram_size = readl(®->msgcode_rwbuffer[4]); > + acb->firm_sdram_size = readl(®->msgcode_rwbuffer[3]); >   /*firm_sdram_size,3,12-15*/ > - acb->firm_hd_channels = readl(®->msgcode_rwbuffer[5]); > + acb->firm_hd_channels = readl(

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

free_dma: > + dma_free_coherent(&acb->pdev->dev, acb->roundup_ccbsize, > + acb->dma_coherent2, acb->dma_coherent_handle2); > + return false; >  } >   >  static bool arcmsr_hbaC_get_config(struct AdapterControlBlock *pACB) > > Reviewed-

Re: [PATCH v3 3/5] arcmsr: modifies codes for more readable

reg->message_wbuffer = MEM_BASE1(ARCMSR_MESSAGE_WBUFFER); > + reg->message_rbuffer =  MEM_BASE1(ARCMSR_MESSAGE_RBUFFER); > + reg->message_rwbuffer = MEM_BASE1(ARCMSR_MESSAGE_RWBUFFER); >   iop_firm_model = (char __iomem *)(®->message_rwbuffer[15]); > /*fi

Re: [PATCH v3 4/5] arcmsr: adds code for support areca new adapter ARC1203

); >   if (!arcmsr_hbaB_wait_msgint_ready(acb)) { >   printk(KERN_NOTICE "arcmsr%d: wait 'get adapter firmware \ > @@ -4002,6 +4018,7 @@ static const char *arcmsr_info(struct Sc >   case PCI_DEVICE_ID_ARECA_1160: >   case PCI_DEVICE_ID_ARECA_1170: >   case PCI_DEVICE_ID_ARECA_1201: > + case PCI_DEVICE_ID_ARECA_1203: >   case PCI_DEVICE_ID_ARECA_1220: >   case PCI_DEVICE_ID_ARECA_1230: >   case PCI_DEVICE_ID_ARECA_1260: > > Reviewed-by: Johannes Thumshirn -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 5/5] arcmsr: changes driver version number

> 512 >  #define ARCMSR_MAX_XFER_SECTORS_B > 4096 > > Reviewed-by: Johannes Thumshirn -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] target: use offset_in_page macro

page_addr = to; > - to += mem_off & ~PAGE_MASK; > + to += offset_in_page(mem_off); >   tlen = min(tlen, (size_t)(PAGE_SIZE - > -   (mem_off & ~PAGE_MASK))); > +   offset_in_page(mem_off))

Re: [PATCH 1/6] scsi: hpsa: Add function to check if device is a disk or a zoned device

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH -next] scsi: fcoe: remove set but not used variable 'port'

I somehow have a deja vu feeling I have already acked it, but anyways: Acked-by: Johannes Thumshirn

Re: [PATCH] fcoe: make use of fip_mode enum complete

urn FIP_MODE_FABRIC; case FIP_ST_VMMP_START: return FIP_MODE_VN2VN; default: WARN(1, "Invalid FIP state"); } return FIP_ST_AUTO; } Byte, Johannes -- Johannes ThumshirnSUSE Labs Filesystems jthum

Re: [PATCH 2/7] scsi: csiostor: no need to check return value of debugfs_create functions

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284

Re: [PATCH] libsas: Remove scsi_to_u32()

Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg

Re: [PATCH V2 1/3] megaraid_sas: Rework code to get PD and LD list

o start your kerneldoc comments with '/**' (i.e. one asterisk is missing on your side). -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imend

[PATCH] MAINTAINERS: Move FCoE to Hannes Reinecke

I'll be moving on to different things in the storage stack and Hannes agreed to take over FCoE. Cc: Hannes Reinecke Signed-off-by: Johannes Thumshirn --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9f64f8d3740e..49b8297

Re: [LSF/MM TOPIC] : blktests: status, an expansion plan for the storage stack test framework

e also lacking tests for things like ioprio, persistent reservation, bcache and so on. Adding support for collecting gcov information after running a test case would also be awesome (this is missing in xfstests as well). So I think a session on blktests can help us get the gap closed. Byte,

Re: [RESEND] [PATCH] Hold back_lock when calling iscsi_complete_task

help others understand when back_lock must be held. You're missing a S-o-b here. Byte, Johannes -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F

Re: [PATCH 01/11] Declare wwn_to_u64() argument const

Fair enough, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG

Re: [PATCH] lpfc: correct sg_seg_cnt attribute min vs default

Thanks a lot, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284

Re: [PATCH] scsi: remove extra white space at the end of the line

> Martin, > > What about a (may be big) whitespace-only patch to clean up all the scsi > code and finally get checkpatch to stop screaming at us if we touch a > line near one with whitespaces (which can happen a lot...) ? +1 Please let's get rid of this whitespace mess. -- Johanne

Re: [PATCH] scsi: remove extra white space at the end of the line

l in all I'm so much in favour of this cleanup patch (and even would apprechiate more of these, especailly getting rid of all those camelCase foo we have in the scsi hba drivers). Let's see how Martin and James deceide about it. Byte, Johannes -- Johannes Thumshirn

Re: [PATCH] scsi: scsi_transport_fc: fix typos on 64/128 GBit define names

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] scsi: lpfc: don't dereference localport before it has been null checked

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] scsi: remove extra white space at the end of the line

ve-by whitespace patches. I have no interest in wasting cycles on > that. I generally only take arbitrary 3rd party cleanups if a driver is > actively maintained and the maintainer specifically acks the change. Agreed > PS. I'll at least partially unbreak sd.c as part of the series

Re: [RFC 1/2] mpt3sas/megaraid_sas : irq poll to avoid CPU hard and soft lockups

On Mon, Jan 15, 2018 at 05:42:35PM +0530, Kashyap Desai wrote: > Patch for Fix-1 explained in PATCH 0. Ahm, PATCH 0 a.k.a the cover letter doesn't get merged so the git history won't have an explanation at all. Please write a proper commit message. Thanks, Johannes

Re: [PATCH] scsi_dh: Document alua_rtpg_queue() arguments

Looks good, Reviewed-by: Johannes Thumshirn

Re: [PATCH] qla2xxx: Fix memory corruption during hba reset test

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] [SCSI] sym53c8xx_2: iterator underflow in sym_getsync()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] mptfusion: Add bounds check in mptctl_hp_targetinfo()

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [LSF/MM TOPIC] Two blk-mq related topics

as we where considering to flip the config option for SLES and it showed several road blocks. I'm not sure whether he re-evaluated 4.13/4.14 on his grid though. But I'm definitively interested in this discussion and can even possibly share some benchmark results we did in our FC Lab.

Re: [PATCH] scsi: libfc: remove redundant initialization of 'disc'

Looks good, Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 01/13] lpfc: Rework lpfc to allow different sli4 cq and eq handlers

callsites, but then you'd have to change the callsites anyways as the function prototype will need to change. So looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911

Re: [PATCH v2 02/13] lpfc: Rework sli4 doorbell infrastructure

; /* CQ_DOORBELL register */ > + void __iomem *EQDBregaddr; /* EQ_DOORBELL register */ > void __iomem *MQDBregaddr; /* MQ_DOORBELL register */ > void __iomem *BMBXregaddr; /* BootStrap MBX register */ Reviewed-by: Johannes Thumshirn Although CQDBregaddr, EQDBr

Re: [PATCH v2 03/13] lpfc: Add SLI-4 if_type=6 support to the code base

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 04/13] lpfc: Add push-to-adapter support to sli4

} > +#else > + phba->cfg_enable_dpp = 0; > +#endif > + } else > + wq->db_regaddr = phba->sli4_hba.WQDBregaddr; I don't really like the set_memory_wc() call here. Neither do I like the ifdef CONFIG_X86 special casing.

Re: [PATCH v2 05/13] lpfc: Add PCI Ids for if_type=6 hardware

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 06/13] lpfc: Add 64G link speed support

ribute cannot be set to %d, " "allowed values are [%s]\n", val, LPFC_LINK_SPEED_STRING); And possible have the whole quoted string on one line for easier grepping. checkplatch.pl should've told you that. Thanks,

Re: [PATCH v2 07/13] lpfc: Add if_type=6 support for cycling valid bits

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 08/13] lpfc: Enable fw download on if_type=6 devices

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 09/13] lpfc: Add embedded data pointers for enhanced performance

On Tue, Feb 06, 2018 at 06:28:47PM -0800, James Smart wrote: > + if (do_pbde && (i == 0)) { Nit: if (do_pde && i == 0) { Else: Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage

Re: [PATCH v2 04/13] lpfc: Add push-to-adapter support to sli4

On Wed, Feb 07, 2018 at 10:51:57AM +0100, Johannes Thumshirn wrote: > > + /* Enable combined writes for DPP aperture */ > > + pg_addr = (unsigned long)(wq->dpp_regaddr) & PAGE_MASK; > > +#ifdef CONFIG_X86 > > +

Re: [PATCH v2 10/13] lpfc: Fix nvme embedded io length on new hardware

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 12/13] lpfc: update driver version to 12.0.0.0

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 11/13] lpfc: Work around NVME cmd iu SGL type

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v2 13/13] lpfc: Update 12.0.0.0 modified files for 2018 Copyright

Looks good, Reviewed-by: Johannes Thumshirn Although I'd change the subject to: "lpfc: Change Copyright of Update 12.0.0.0 modified files to 2018" Reads easier for the non-native english speaker (like me). -- Johannes Thumshirn

Re: [PATCH v2 06/13] lpfc: Add 64G link speed support

On Wed, Feb 07, 2018 at 07:38:39AM -0800, James Smart wrote: > On 2/7/2018 1:58 AM, Johannes Thumshirn wrote: > > On Tue, Feb 06, 2018 at 06:28:44PM -0800, James Smart wrote: > > > lpfc_printf_log(phba, KERN_ERR, LOG_INIT, > > > - "0469 lpfc_link_

Re: [PATCH] Move the eh_deadline module parameter definition to the top of hosts.c

Thanks Bart, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn                                          Storage jthu msh...@suse.de                                +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

Thanks Himanshu, Reviewed-by: Johannes Thumshirn Do you happen to know which commit it actually fixes? -- Johannes Thumshirn                                          Storage jthu msh...@suse.de                                +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF

Re: [PATCH] qla2xxx: Fix NULL pointer crash due to active timer for ABTS

having a  Fixes: 4440e46d5db7 ("[SCSI] qla2xxx: Add IOCB Abort command asynchronous handling.") line is extremly valuable as many distributions have automation in place to check whether a fix for a backport arrived upstream. Thanks, Johannes -- Johannes Thumshirn                        

Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

for (i = 0; i < q->entry_size; i += sizeof(uint32_t)) > + writel(*((uint32_t *)(tmp + i)), q->dpp_regaddr + i); > +#endif > + } > + /* ensure WQE bcopy and DPP flushed before doorbell write */ Any reason you can't use writeq() on 32 B

Re: [PATCH v3 05/13] lpfc: Add PCI Ids for if_type=6 hardware

Thanks, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v3 06/13] lpfc: Add 64G link speed support

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v3 11/13] lpfc: Work around NVME cmd iu SGL type

Thanks, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH v3 09/13] lpfc: Add embedded data pointers for enhanced performance

Thanks James, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284

Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

(especially architecture specific ones) in driver code should be avoided. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Ime

Re: [PATCH v3 04/13] lpfc: Add push-to-adapter support to sli4

a > simple "it works", I don't believe this is one that I want to be "generic" > on. Hmmm OK, but this won't make out ARM and PPC teams very happy. Well let's see, Johannes -- Johannes Thumshirn Storage jthumsh

Re: [PATCH v5 04/13] lpfc: Add push-to-adapter support to sli4

Thanks, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

Re: [PATCH] scsi: lpfc: use memcpy_toio instead of writeq

> - for (i = 0; i < q->entry_size; i += sizeof(uint64_t)) > - writeq(*((uint64_t *)(tmp + i)), q->dpp_regaddr + i); > - } > + memcpy_toio(tmp, q->dpp_regaddr, q->entry_size); > + > /* ensure WQE bcopy and DPP flush

Re: [PATCH] lpfc: correct writeq failures on 32-bit architectures

Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

<    3   4   5   6   7   8   9   10   11   12   >