Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use
helper variables bsg_request and bsg_reply. This will be helpfull when
transitioning to bsg-lib.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/libfc/fc_lport.c | 23 +--
1 file changed, 13 inser
Use fc_bsg_jobdone() directly instead of the struct bsg_job::job_done()
callback.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/qla2xxx/qla_bsg.c | 44 +-
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_bsg.c
Use fc_bsg_jobdone() directly instead of the struct bsg_job::job_done()
callback.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/libfc/fc_lport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c
index
Use fc_bsg_jobdone() directly instead of the struct bsg_job::job_done()
callback.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/lpfc/lpfc_bsg.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b
Provide fc_bsg_to_shost() helper that will become handy when we're moving from
struct fc_bsg_job to a plain struct bsg_job.
Signed-off-by: Johannes Thumshirn
---
include/scsi/scsi_transport_fc.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/scsi/scsi_transport_fc.h b/in
struct fc_bsg_buffer is just a clone of struct bsg_buffer from bsg-lib,
so use this one instead.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/lpfc/lpfc_bsg.c | 3 ++-
drivers/scsi/scsi_transport_fc.c | 2 +-
include/scsi/scsi_transport_fc.h | 12 +++-
3 files changed, 6
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use
helper variables bsg_request and bsg_reply. This will be helpfull when
transitioning to bsg-lib.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/scsi_transport_fc.c | 37 +++--
1
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use
helper variables bsg_request and bsg_reply. This will be helpfull when
transitioning to bsg-lib.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/qla2xxx/qla_bsg.c | 264 +++-
dr
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use
helper variables bsg_request and bsg_reply. This will be helpfull when
transitioning to bsg-lib.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/ibmvscsi/ibmvfc.c | 22 --
1 file changed, 12 inser
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use
helper variables bsg_request and bsg_reply. This will be helpfull when
transitioning to bsg-lib.
Signed-off-by: Johannes Thumshirn
---
drivers/s390/scsi/zfcp_fc.c | 9 ++---
1 file changed, 6 insertions(+), 3 dele
Use fc_bsg_jobdone() directly instead of the struct bsg_job::job_done()
callback.
Signed-off-by: Johannes Thumshirn
---
drivers/s390/scsi/zfcp_fc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/scsi/zfcp_fc.c b/drivers/s390/scsi/zfcp_fc.c
index 4c4023f
Use fc_bsg_jobdone() directly instead of the struct bsg_job::job_done()
callback.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/bfa/bfad_bsg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
index 48366d8
ruct fc_bsg_job' to 'struct bsg_job' and corresponding changes in order
to get the series bisectable.
The idea for this change arose when discussing racy sysfs handling the FC
bsg code with Christoph and is a next step in moving all bsg clients to
bsg-lib to eventually clean up the i
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use
helper variables bsg_request and bsg_reply. This will be helpfull when
transitioning to bsg-lib.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/bfa/bfad_bsg.c | 40 +++-
1 file ch
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use
helper variables bsg_request and bsg_reply. This will be helpfull when
transitioning to bsg-lib.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/lpfc/lpfc_bsg.c | 194 +++
1
Unify the interfaces of fc_bsg_jobdone and bsg_job_done. This will reduce the
diff when moving from 'struct fc_bsg_job' to a plain 'struct bsg_job' later
on.
Signed-off-by: Johannes Thumshirn
---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers/scsi/bfa/bfad_bsg.c |
nk 44 patches is a bit huge. Especially given the 0day bot
fallout it generated. Let me see how I can slim it down.
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr.
ff-by: Johannes Thumshirn
---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers/scsi/bfa/bfad_bsg.c | 4 ++--
drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
drivers/scsi/libfc/fc_lport.c| 4 ++--
drivers/scsi/lpfc/lpfc_bsg.c | 38 +-
drivers/scsi/qla2xxx/qla_
Implement kref backed reference counting instead of rolling our own. This
elimnates the need of the following fields in 'struct fc_bsg_job':
* ref_cnt
* state_flags
* job_lock
bringing us close to unification of 'struct fc_bsg_job' and 'struct bsg_job'.
Sig
Provide fc_bsg_to_shost() helper that will become handy when we're moving from
struct fc_bsg_job to a plain struct bsg_job. Also use this little helper in
the LLDDs.
Signed-off-by: Johannes Thumshirn
---
drivers/s390/scsi/zfcp_fc.c | 4 +--
drivers/scsi/bfa/bfad_bsg.c
Add reference counting to 'struct bsg_job' so we can implement a reuqest
timeout handler for bsg_jobs, which is needed for Fibre Channel.
Signed-off-by: Johannes Thumshirn
---
block/bsg-lib.c | 7 +--
include/linux/bsg-lib.h | 2 ++
2 files changed, 7 insertions(+), 2
Change FC drivers to use 'struct bsg_job' from bsg-lib.h instead of 'struct
fc_bsg_job' from scsi_transport_fc.h and remove 'struct fc_bsg_job'.
Signed-off-by: Johannes Thumshirn
---
drivers/s390/scsi/zfcp_ext.h | 4 +--
drivers/s390/scsi/zfcp_fc.c |
Provide fc_bsg_to_rport() helper that will become handy when we're moving
from struct fc_bsg_job to a plain struct bsg_job. Also move all LLDDs to use
the new helper.
Signed-off-by: Johannes Thumshirn
---
drivers/s390/scsi/zfcp_fc.c | 5 +++--
drivers/scsi/ibmvscsi/ibmvfc.c
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use
helper variables bsg_request and bsg_reply. This will be helpfull when
transitioning to bsg-lib.
Signed-off-by: Johannes Thumshirn
---
drivers/s390/scsi/zfcp_fc.c | 9 +-
drivers/scsi/bfa/bfad_bsg.c
Unify the interfaces of fc_bsg_jobdone and bsg_job_done. This will reduce the
diff when moving from 'struct fc_bsg_job' to a plain 'struct bsg_job' later
on.
Signed-off-by: Johannes Thumshirn
---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers/scsi/bfa/bfad_bsg.c |
fc_bsg_jobdone() and bsg_job_done() are 1:1 copies now so use the bsg-lib one
instead of the FC private implementation.
Signed-off-by: Johannes Thumshirn
---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers/scsi/bfa/bfad_bsg.c | 4 ++--
drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
drivers
struct fc_bsg_buffer is just a clone of struct bsg_buffer from bsg-lib,
so use this one instead.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/lpfc/lpfc_bsg.c | 3 ++-
drivers/scsi/scsi_transport_fc.c | 2 +-
include/scsi/scsi_transport_fc.h | 12 +++-
3 files changed, 6
.
[1] http://marc.info/?l=linux-scsi&m=131149780921009&w=2
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/Kconfig | 1 +
drivers/scsi/scsi_transport_fc.c | 287 ++-
2 files changed, 44 insertions(+), 244 deletions(-)
diff --git a
BSGLIB
* Make bsg_job_get() call kref_get_unless_zero() and use it in
scsi_transport_fc.c
Johannes Thumshirn (16):
scsi: Get rid of struct fc_bsg_buffer
scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly
scsi: fc: Export fc_bsg_jobdone and use it in FC drivers
scsi: Unif
Don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() as
fc_bsg_jobdone() calls blk_complete_requeust() which raises a soft-IRQ that
ends up in fc_bsg_sofirq_done() and fc_bsg_softirq_done() sets the
FC_RQST_STATE_DONE flag.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/
Add bsg_job_put() and bsg_job_get() so don't need to export
bsg_destroy_job() any more.
Signed-off-by: Johannes Thumshirn
---
block/bsg-lib.c | 17 ++---
drivers/scsi/scsi_transport_fc.c | 4 ++--
include/linux/bsg-lib.h | 3 ++-
3 files change
fc_destroy_bsgjob() and bsg_destroy_job() are now 1:1 copies, so use the
later.
Signed-off-by: Johannes Thumshirn
---
block/bsg-lib.c | 3 ++-
drivers/scsi/scsi_transport_fc.c | 20 ++--
include/linux/bsg-lib.h | 1 +
3 files changed, 5 insertions
bsg_softirq_done() and fc_bsg_softirq_done() are copies of each other, so
ditch the fc specific one.
Signed-off-by: Johannes Thumshirn
---
block/bsg-lib.c | 3 ++-
drivers/scsi/scsi_transport_fc.c | 16 ++--
include/linux/bsg-lib.h | 1 +
3 files changed
Unexport bsg_softirq_done() again, we don't need it outside of bsg-lib.c
anymore now that scsi_transport_fc is a pure bsg-lib client.
Signed-off-by: Johannes Thumshirn
---
block/bsg-lib.c | 3 +--
include/linux/bsg-lib.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff
ine after the Signed-off-bys.
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
Otherwise,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE L
ed per review:
> Revised lpfc_send_taskmgmt() to check rdata
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
> drivers/scsi/lpfc/lpfc_scsi.c | 22 +-
> 1 file changed, 13 insertions(+), 9 deletions(-)
>
Looks good,
Reviewed
On Wed, Oct 12, 2016 at 01:14:04PM -0700, James Smart wrote:
>
> From: "Milan P. Gandhi"
>
> This patch does a cleanup and fixes few small typos in lpfc_scsi.c
>
> Signed-off-by: Milan P. Gandhi
> Signed-off-by: James Smart
> ---
>
Looks
s an unfortunate collision with my bsg rewrite series. Please remind me
of that fact when your patches are merged and mine aren't yet. But it's a
nice test case :-).
> +{
> + struct lpfc_vport *vport = (struct lpfc_vport *)job->shost->hostdata;
Please use shost_priv() here
11 insertions(+), 7 deletions(-)
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smitha
"3022 Invalid FW image found. "
"Magic:%x Type:%x ID:%x Size %d %ld\n",
lpfc_grp_hdr_file_type,
lpfc_grp_hdr_id, size, fw->size);
rc = -EINVAL;
goto release_out
On Wed, Oct 12, 2016 at 05:54:45PM +0200, Steffen Maier wrote:
> Hi Johannes,
>
> On 10/12/2016 03:06 PM, Johannes Thumshirn wrote:
> > This series converts the current bsg usage in the FibreChannel drivers over
> > to use bsg-lib. SAS will follow once FC is in a good enough
On Thu, Oct 13, 2016 at 03:10:57PM +0200, Hannes Reinecke wrote:
> The 'enabled' sysfs attribute only accepts the values '0' and '1',
> so we should error out any other values.
>
> Signed-off-by: Hannes Reinecke
> ---
Acked-by
cke
> ---
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nü
d-by: Ewan Milne
> Suggested-by: Curtis Taylor
> Tested-by: Laurence Oberman
> Signed-off-by: Laurence Oberman
>
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053
e need to disable target functionality.
>
> Signed-off-by: Hannes Reinecke
> ---
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nür
On Thu, Oct 13, 2016 at 03:10:48PM +0200, Hannes Reinecke wrote:
> When the queue depth is reduced we should print out the reason
> for this; it might be due to a queue full condition.
>
> Signed-off-by: Hannes Reinecke
> ---
Acked-by: Johannes Thumshirn
--
Joh
On Thu, Oct 13, 2016 at 01:42:06PM +0200, Hannes Reinecke wrote:
> On 10/12/2016 03:06 PM, Johannes Thumshirn wrote:
> > Implement kref backed reference counting instead of rolling our own. This
> > elimnates the need of the following fields in 'struct fc_bsg_job':
> &
Don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() as
fc_bsg_jobdone() calls blk_complete_requeust() which raises a soft-IRQ that
ends up in fc_bsg_sofirq_done() and fc_bsg_softirq_done() sets the
FC_RQST_STATE_DONE flag.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Rei
Now that all conversions are done, move the FibreChannel bsg code over to the
bsg library.
This patch is derived from work done by Mike Christie in 2011 [1] but only the
iscsi parts got merged back then.
[1] http://marc.info/?l=linux-scsi&m=131149780921009&w=2
Signed-off-by: Johannes T
Unexport bsg_softirq_done() again, we don't need it outside of bsg-lib.c
anymore now that scsi_transport_fc is a pure bsg-lib client.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 3 +--
include/linux/bsg-lib.h | 1 -
2 files changed, 1 inse
fc_destroy_bsgjob() and bsg_destroy_job() are now 1:1 copies, so use the
later. As bsg_destroy_job() comes from bsg-lib we need to select it in Kconfig
once CONFOG_SCSI_FC_ATTRS is active.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 7
Add bsg_job_put() and bsg_job_get() so don't need to export
bsg_destroy_job() any more.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 17 ++---
drivers/scsi/scsi_transport_fc.c | 4 ++--
include/linux/bsg-lib.h
Provide fc_bsg_to_rport() helper that will become handy when we're moving
from struct fc_bsg_job to a plain struct bsg_job. Also move all LLDDs to use
the new helper.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/s390/scsi/zfcp_fc.c | 5 +++--
drivers
Add reference counting to 'struct bsg_job' so we can implement a reuqest
timeout handler for bsg_jobs, which is needed for Fibre Channel.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 7 +--
include/linux/bsg-lib.h | 2 ++
2 files
Provide fc_bsg_to_shost() helper that will become handy when we're moving from
struct fc_bsg_job to a plain struct bsg_job. Also use this little helper in
the LLDDs.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/s390/scsi/zfcp_fc.c | 4 +--
drivers/scs
fc_bsg_jobdone() and bsg_job_done() are 1:1 copies now so use the bsg-lib one
instead of the FC private implementation.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers/scsi/bfa/bfad_bsg.c | 4 ++--
drivers/scsi/ibmvscsi
Implement kref backed reference counting instead of rolling our own. This
elimnates the need of the following fields in 'struct fc_bsg_job':
* ref_cnt
* state_flags
* job_lock
bringing us close to unification of 'struct fc_bsg_job' and 'struct bsg_job'.
Sig
Change FC drivers to use 'struct bsg_job' from bsg-lib.h instead of 'struct
fc_bsg_job' from scsi_transport_fc.h and remove 'struct fc_bsg_job'.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/s390/scsi/zfcp_ext.h | 4 +--
drivers
bsg_softirq_done() and fc_bsg_softirq_done() are copies of each other, so
ditch the fc specific one.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
block/bsg-lib.c | 3 ++-
drivers/scsi/scsi_transport_fc.c | 15 ++-
include/linux/bsg-lib.h
ff-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers/scsi/bfa/bfad_bsg.c | 4 ++--
drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
drivers/scsi/libfc/fc_lport.c| 4 ++--
drivers/scsi/lpfc/lpfc_bsg.c
BSGLIB
* Make bsg_job_get() call kref_get_unless_zero() and use it in
scsi_transport_fc.c
Changes to v2:
* Add Hannes' Reviewd-by tags
* Address Hannes' comment about kref handling in 8/16
* Move CONFIG_BLK_DEV_BSGLIB dependency to patch 12/16 as per 0day results
Johannes Thumshirn
Don't use fc_bsg_job::request and fc_bsg_job::reply directly, but use
helper variables bsg_request and bsg_reply. This will be helpfull when
transitioning to bsg-lib.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/s390/scsi/zfcp_fc.c | 9 +-
drivers/scs
Unify the interfaces of fc_bsg_jobdone and bsg_job_done. This will reduce the
diff when moving from 'struct fc_bsg_job' to a plain 'struct bsg_job' later
on.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/s390/scsi/zfcp_fc.c | 2 +-
drivers
struct fc_bsg_buffer is just a clone of struct bsg_buffer from bsg-lib,
so use this one instead.
Signed-off-by: Johannes Thumshirn
Reviewed-by: Hannes Reinecke
---
drivers/scsi/lpfc/lpfc_bsg.c | 3 ++-
drivers/scsi/scsi_transport_fc.c | 2 +-
include/scsi/scsi_transport_fc.h | 12
scsi: Get rid of struct
> fc_bsg_buffer
> > $ git bisect good
> > 3087864ce3d7282f59021245d8a5f83ef1caef18 is the first bad commit
> > commit 3087864ce3d7282f59021245d8a5f83ef1caef18
> > Author: Johannes Thumshirn
> > Date: Wed Oct 12 15:06:28 2016 +0200
> >
> > scsi: don't u
On Thu, Oct 13, 2016 at 05:55:11PM +0200, Steffen Maier wrote:
> Hm, still behaves for me like I reported for v2:
> http://marc.info/?l=linux-scsi&m=147637177902937&w=2
>
Well given what you've wrote for v2 it's kinda expected.
Byte,
Johan
x27;re assigning
job->request as req->cmd and job->request_len = req->cmd_len. But without
checkinf job->request_len we don't know whether we're save to touch
job->request (a.k.a. bsg_request).
In the meanwhile I try to reproduce your report here.
Thanks,
Johannes
--
ide the settings with its own if instructed by
> user space (via bsg), with the new values being picked up by the
> boot driver.
>
> Signed-off-by: Dick Kennedy
> Signed-off-by: James Smart
> ---
> v3 mods:
> parens cleanup
> use shost_priv() on new code
>
Tha
Kennedy
> Signed-off-by: James Smart
> ---
> v3 mods:
> code cleanup: parsing image header fields
Thanks,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
S
ag_set *set)
> free_cpumask_var(cpus);
> return 0;
> }
> +EXPORT_SYMBOL_GPL(blk_mq_map_queues);
>
> /*
> * We have no quick way of doing reverse lookups. This is only used at
Shouldn't this hunk go into the previous patch?
t blk_mq_reinit_tagset(struct blk_mq_tag_set *set);
>
> +int blk_mq_map_queues(struct blk_mq_tag_set *set);
> void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int
> nr_hw_queues);
>
> /*
> --
> 2.1.4
See comment on patch 2, otherwise
Reviewed-by:
On Sat, Oct 15, 2016 at 10:47:21AM +0200, Christoph Hellwig wrote:
> Which cleans up a lot of the MSI-X handling, and allows us to use the
> PCI IRQ layer provided vector mapping, which we can then expose to blk-mq.
>
> Signed-off-by: Christoph Hellwig
> ---
Reviewed-by: Joh
er is what the standard expects to be
> used here, and this shuts up the warning.
>
> Fixes: 679053c651fb ("scsi: lpfc: Fix fw download on SLI-4 FC adapters")
> Signed-off-by: Arnd Bergmann
> ---
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn
ich
commit introduces this?
Thanks,
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnber
[+Cc Robert LeBlanc and full quote for context ]
On Mon, Oct 17, 2016 at 10:57:55PM -0700, Nicholas A. Bellinger wrote:
> Hello Johannes,
>
> Apologies for the extended delayed follow-up on this bug report.
>
> On Fri, 2016-09-02 at 16:14 +0200, Johannes Thumshirn wrote:
&g
On Tue, Oct 18, 2016 at 08:39:16AM +0200, Hannes Reinecke wrote:
> Found by 0-day robot.
>
> Fixes: a99ac6e715bc ("scsi: fcoe: set default TC priority")
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
On Tue, Oct 18, 2016 at 10:01:35AM +0200, Hannes Reinecke wrote:
> The 'seq_els_rsp_send' callback only ever had one implementation,
> so we might as well drop it and use the function directly.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes
On Tue, Oct 18, 2016 at 10:01:35AM +0200, Hannes Reinecke wrote:
> The 'seq_els_rsp_send' callback only ever had one implementation,
> so we might as well drop it and use the function directly.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes
On Tue, Oct 18, 2016 at 10:01:36AM +0200, Hannes Reinecke wrote:
> The ->lport_reset callback only ever had one implementation,
> which already is exported. So remove it and use the function
> directly.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-b
On Tue, Oct 18, 2016 at 10:01:37AM +0200, Hannes Reinecke wrote:
> The ->lport_recv callback only ever had one implementation,
> so call the function directly and remove the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
On Tue, Oct 18, 2016 at 10:01:38AM +0200, Hannes Reinecke wrote:
> The ->exch_seq_send callback only ever had one implementation,
> so we can call the function directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumsh
On Tue, Oct 18, 2016 at 10:01:39AM +0200, Hannes Reinecke wrote:
> The ->rport_destroy callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumsh
On Tue, Oct 18, 2016 at 10:01:40AM +0200, Hannes Reinecke wrote:
> The ->rport_lookup callback only ever had a single implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumsh
fc_rport_create() with fc_remote_port_create()
so the scsi_transport_fc.c patch isn't needed?
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer,
On Tue, Oct 18, 2016 at 10:01:43AM +0200, Hannes Reinecke wrote:
> The ->rport_login callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
On Tue, Oct 18, 2016 at 10:01:44AM +0200, Hannes Reinecke wrote:
> The ->rport_logoff callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
On Tue, Oct 18, 2016 at 10:01:45AM +0200, Hannes Reinecke wrote:
> The ->rport_recv_req callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumsh
On Tue, Oct 18, 2016 at 10:01:46AM +0200, Hannes Reinecke wrote:
> The ->rport_flush_queue callback only ever had a single
> implementation, so we can as well call it directly and
> drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-b
On Tue, Oct 18, 2016 at 10:01:47AM +0200, Hannes Reinecke wrote:
> Function is empty now and can be removed.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthums
On Tue, Oct 18, 2016 at 10:01:48AM +0200, Hannes Reinecke wrote:
> The ->seq_send callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
On Tue, Oct 18, 2016 at 10:01:49AM +0200, Hannes Reinecke wrote:
> The ->seq_exch_abort callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumsh
On Tue, Oct 18, 2016 at 10:01:50AM +0200, Hannes Reinecke wrote:
> The ->exch_done callback only ever had one implementation,
> so we can as well call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
On Tue, Oct 18, 2016 at 10:01:51AM +0200, Hannes Reinecke wrote:
> The ->seq_start_next callback only ever had one implementation,
> so call the function directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
On Tue, Oct 18, 2016 at 10:01:53AM +0200, Hannes Reinecke wrote:
> The ->seq_assign callback only ever had one implementation,
> so call the function directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
On Tue, Oct 18, 2016 at 10:01:52AM +0200, Hannes Reinecke wrote:
> The ->seq_set_resp callback only ever had one implementation,
> so call it directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
On Tue, Oct 18, 2016 at 10:01:54AM +0200, Hannes Reinecke wrote:
> The ->seq_release callback only ever had one implementation,
> so call the function directly and drop the callback.
>
> Signed-off-by: Hannes Reinecke
> ---
Looks good,
Acked-by: Johannes Thumshirn
--
On Tue, Oct 18, 2016 at 12:23:22PM +0200, Hannes Reinecke wrote:
> On 10/18/2016 10:54 AM, Johannes Thumshirn wrote:
> > On Tue, Oct 18, 2016 at 10:01:42AM +0200, Hannes Reinecke wrote:
> >> The ->rport_create callback only ever had a single implementation,
> >> so w
On Tue, Oct 18, 2016 at 10:01:41AM +0200, Hannes Reinecke wrote:
> Required for the next patch.
>
> Signed-off-by: Hannes Reinecke
> ---
Given the comment on the next patch,
Acked-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthums
On Tue, Oct 18, 2016 at 09:01:34AM +0200, Johannes Thumshirn wrote:
[...]
> >
> > This is likely the missing SCF_ACK_KREF assignment in >= v4.1.y:
> >
> > http://www.spinics.net/lists/target-devel/msg13530.html
Sorry to disappoint you but it didn't fix my issu
"Failed to allocate tasks information\n");
> + qed_iscsi_stop(cdev);
> + return -ENOMEM;
> + }
> +
> + rc = qed_cxt_get_tid_mem_info(QED_LEADING_HWFN(cdev),
> +
101 - 200 of 1576 matches
Mail list logo
