If we successfully allocate 'fw_event' but subsequently fail to
allocate 'fw_event->event_data' then we'll return from the function
without properly freeing 'fw_event'.
This patch takes care of that leak.
Signed-off-by: Jesper Juhl
---
drivers/scsi/mpt3sa
If kzalloc() or csio_hw_check_fwconfig() fail we may leave the
csio_hw_flash_config() function without freeing allocated memory or
firmware. This should take care of the leaks.
Signed-off-by: Jesper Juhl
---
drivers/scsi/csiostor/csio_hw.c | 15 +--
1 files changed, 9 insertions
The file uses nothing from the header, so remove it.
Signed-off-by: Jesper Juhl
---
drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c
b/drivers/scsi/mpt3sas/mpt3sas_trigger_diag.c
From: Jesper Juhl <[EMAIL PROTECTED]>
in sas_get_phy_change_count(), the line
disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE);
will allocate 56 bytes due to this define:
#define DISCOVER_RESP_SIZE 56
But, the struct is actually 60 bytes in size.
So change the define
On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote:
> > From: Jesper Juhl <[EMAIL PROTECTED]>
> >
> > in sas_get_phy_change_count(), the line
> > disc_resp = alloc_smp_resp(DISCOVER_RESP_S
On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Mon, 2007-11-12 at 01:13 +0100, Jesper Juhl wrote:
> > On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote:
> > > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote:
> > >
On 09/07/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
I just experienced a long hang and a lot of unpleasant messages in dmesg
while building randconfig kernels in a loop.
It just happened again without me doing anything special, just normal
desktop use, surfing the net, reading email etc
Hi,
This patch cleans up duplicate includes in
drivers/scsi/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/drivers/scsi/NCR_D700.c b/drivers/scsi/NCR_D700.c
index 3a80897..e0f1991 100644
--- a/drivers/scsi/NCR_D700.c
+++ b/drivers/scsi/NCR_D700.c
@@ -97,7
d, I'll test patches,
suggestions etc.
Any ideas people?
On Sunday 15 July 2007 04:04:50 Jesper Juhl wrote:
> On 09/07/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> > I just experienced a long hang and a lot of unpleasant messages in dmesg
> > while building randconfi
.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/scsi/libsas/sas_expander.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libsas/sas_expander.c
b/drivers/scsi/libsas/sas_expander.c
index b500f0c..7871406 100644
--- a/drivers/scsi/
other memory allocation in that
function.
This patch reworks the memory allocation a bit to deal with it
(compile tested only).
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/scsi/libsas/sas_expander.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff -
On 28/07/07, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Fri, 2007-07-27 at 23:27 +0200, Jesper Juhl wrote:
> > In sas_smp_get_phy_events() we never test if the call to
> > alloc_smp_req(RPEL_REQ_SIZE) succeeds or fails. That means we run
> > the risk of derefer
compile tested only.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/message/fusion/mptbase.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index e866dac..f9bb705 100644
---
On 02/08/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Thu, 2 Aug 2007 01:55:33 +0200
> Jesper Juhl <[EMAIL PROTECTED]> wrote:
>
[snip]
> > +++ b/drivers/message/fusion/mptbase.c
> > @@ -1393,18 +1393,18 @@ mpt_attach(struct pci_dev *pdev, const struct
> &
dummy_column = 0;
> cur_column = &dummy_column;
> }
>
> and then stripping out the cur_column == NULL checks in the routine.
>
Thank you for that info.
James, if that sounds like a better way to deal with it to you, then
here's a patch to implement i
On 04/08/07, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Sat, 2007-08-04 at 20:30 +0200, Jesper Juhl wrote:
> > (resend of patch previously submitted on 28-Jul-2007 23:06)
> >
> >
> > Ehlo,
> >
> > The Coverity checker noticed that we have a pot
#x27;
into 'hbqno >= LPFC_MAX_HBQS' as a possible fix.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/scsi/lpfc/lpfc_sli.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index ce5ff2b..
: [40] Power Management version 2
If you need anything else (like my .config etc), just ask.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from
snd_page_alloc snd_util_mem agpgart
sg snd_hwdep evdev ehci_hcd via_rhine k8temp
I've also attached a complete build log. If you need any further details, just
ask.
Kind regards,
Jesper Juhl
config.24.gz
Description: GNU Zip compressed data
build.log.24.gz
Description: GNU Zip compressed data
r way to deal with
that is, so I'll just report it so hopefully someone else can fix it.
By the way; I'm building current Linus git tree, head at commit
ac07860264bd2b18834d3fa3be47032115524cea
Kind regards,
Jesper Juhl
-
To unsubscribe from this list: send the line "unsub
(whoops, forgot to add maintainer to Cc - now added)
On 12/08/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I've been building some randconfig kernels lately and I've noticed
> this in a few builds :
>
> drivers/block/cciss.c:2614: warning: right shif
On 12/08/07, Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> On Sun, Aug 12, 2007 at 01:43:16AM +0200, Jesper Juhl wrote:
> > Trying to build current Linus git tree (head at
> > ac07860264bd2b18834d3fa3be47032115524cea) using the attached config
> > file (generated by &
the 'hbqno > LPFC_MAX_HBQS'
into 'hbqno >= LPFC_MAX_HBQS' as a possible fix.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
Acked-by: James Smart <[EMAIL PROTECTED]>
---
drivers/scsi/lpfc/lpfc_sli.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
I assumed it had not been merged.
I just looked again, at the source this time, up-to-date mainline git
tree, and I still see
hbqno = tag >> 16;
if (hbqno > LPFC_MAX_HBQS)
return NULL;
in drivers/scsi/lpfc/lpfc_sli.c
???
> -- james s
>
> Jespe
range check.
>
> Since this really is just something to keep the tools happy - I'll recind the
> NACK.
> I'll worry about simply removing this if-check later...
>
> James/Andrew, accept this patch - ACK.
>
--
Jesper Juhl <[EMAIL PROTECTED]>
Don
On 13/08/07, Michal Piotrowski <[EMAIL PROTECTED]> wrote:
> Hi Jesper,
>
> On 11/08/07, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
> > I just noticed this in dmesg :
> >
> > [ 3216.262987] (scsi0:A:4:0): Unexpected busfree in M
[kv]alloc() return void *. No need to cast the return value.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/scsi/osst.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index 08060fb..3ad9d49 100644
There's no reason to cast void pointers returned by the generic
memory allocation functions.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/scsi/advansys.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/advansys.c b/d
On 24/08/07, Rolf Eike Beer <[EMAIL PROTECTED]> wrote:
> Jesper Juhl wrote:
> > [kv]alloc() return void *. No need to cast the return value.
>
> > @@ -5756,7 +5756,7 @@ static int osst_probe(struct device *dev)
> > write_lock(&os_scsi_tapes_lock);
&
On 24/08/07, Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> On Fri, Aug 24, 2007 at 02:16:12AM +0200, Jesper Juhl wrote:
> > There's no reason to cast void pointers returned by the generic
> > memory allocation functions.
>
> I think I fixed all these already; please c
On Sunday 02 September 2007 22:13:49 Satyam Sharma wrote:
>
> drivers/scsi/ips.c: In function ‘ips_register_scsi’:
> drivers/scsi/ips.c:6869:
> warning: ignoring return value of ‘scsi_add_host’, declared with attribute
> warn_unused_result
>
> scsi_add_host() is __must_check, so let's check it's
On 05/10/2007, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2007-10-02 at 14:38 -0700, [EMAIL PROTECTED] wrote:
> > From: Jesper Juhl <[EMAIL PROTECTED]>
> >
> > The Coverity checker noticed that we have a potential NULL pointer
> > deref
lences the warning.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
--- linux-2.6.11-rc2-bk7-orig/drivers/scsi/gdth.c 2005-01-22
21:59:46.0 +0100
+++ linux-2.6.11-rc2-bk7/drivers/scsi/gdth.c2005-01-30 16:52:45.0
+0100
@@ -642,7 +642,7 @@ static int probe_eisa_isa
On Sun, 30 Jan 2005, Randy.Dunlap wrote:
> Jesper Juhl wrote:
> > This little warning made me take a closer look : drivers/scsi/gdth.c:645:
> > warning: return from incompatible pointer type
> >
> > And line 645 looks like this :
> >
> > module_param(irq
Hi,
I hope I got all relevant info included in the text below, but if you lack
something just ask. If you want me to test patches or try and revert
patches, then just let me know - I can do all the testing you need me to.
[1.] One line summary of the problem:
Playing audio CD's in SCSI playe
On Mon, 31 Jan 2005, James Bottomley wrote:
> On Tue, 2005-02-01 at 00:22 +0100, Jesper Juhl wrote:
> > audio
> Could you try the attached?
> James
>
I applied the patch to 2.6.11-rc2-bk9, rebuild, rebooted and now
everything is just fine.
Thank you.
--
Jesper Juhl
-
T
gh to be sure.
The patch below makes the change to test if it's > 0, but if the code in
the 'if' really wants to run if it's >= 0, then we might as well just
remove the 'if'.
In any case, the current code looks fishy.
Signed-off-by: Jesper Juhl <[EMAIL PRO
7;t need it, and it adds a help text.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/scsi/qla2xxx/Kconfig |6 +-
1 files changed, 5 insertions(+), 1 deletion(-)
--- linux-2.6.13-rc3-mm1-orig/drivers/scsi/qla2xxx/Kconfig 2005-07-17
04:39:52.0 +0200
+++ linux
gic ISP24xx host adapter family support"
> depends on SCSI_QLA2XXX
> -select SCSI_FC_ATTRS
> + select SCSI_FC_ATTRS
> + select FW_LOADER
> ---help---
> This driver supports the QLogic 24xx (ISP2422 and ISP2432) host
>
er branch is to call
kfree(ulFibreFrame); , so instead of having the call in both branches
you might as well just have one call before the if(). Ohh and this
looks like it could do with a CodingStyle cleanup as well.
kfree(ulFibreFrame);
if (fchs->pl[0] == ELS_LILP_FRAME)
return 1; /* fo
On 8/4/05, Jesper Juhl <[EMAIL PROTECTED]> wrote:
> On 8/4/05, Saripalli, Venkata Ramanamurthy (STSD) <[EMAIL PROTECTED]> wrote:
> > Patch 1 of 2
> >
> > This patch fixes the "#error this is too much stack" in 2.6 kernel.
> > Using kmallo
Fix compiler warning in drivers/scsi/aic7xxx/aic7770.c :
drivers/scsi/aic7xxx/aic7770.c:129: warning: unused variable `l'
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
drivers/scsi/aic7xxx/aic7770.c |1 -
1 files changed, 1 deletion(-)
--- linux-2.6.13-orig/drivers/s
On 8/30/05, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> On Tue, Aug 30, 2005 at 01:15:36AM +0200, Jesper Juhl wrote:
>
> > Fix compiler warning in drivers/scsi/aic7xxx/aic7770.c :
> >drivers/scsi/aic7xxx/aic7770.c:129: warning: unused variable `l'
> >...
>
Vendor: IBM Model: SERVERAIDRev: 1.00
Type: ProcessorANSI SCSI revision: 02
Host: scsi2 Channel: 01 Id: 15 Lun: 00
Vendor: IBM Model: EXP400 S320Rev: D110
Type: ProcessorANSI SCSI revision: 03
--
Kind regards,
Jesper
44 matches
Mail list logo
