Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread Jan Beulich
>>> On 29.11.16 at 11:50, wrote: > --- a/drivers/scsi/xen-scsifront.c > +++ b/drivers/scsi/xen-scsifront.c > @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifront_pre_req(struct > vscsifrnt_info *info) > > ring_req = RING_GET_REQUEST(&(info->ring), ring->req_prod_pvt); > > -

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread Jan Beulich
>>> On 29.11.16 at 12:19, wrote: > On 29/11/16 12:14, Jan Beulich wrote: >>>>> On 29.11.16 at 11:50, wrote: >>> --- a/drivers/scsi/xen-scsifront.c >>> +++ b/drivers/scsi/xen-scsifront.c >>> @@ -184,8 +184,6 @@ static struct vscsiif_req

Re: [Xen-devel] [PATCH V3 1/4] Add XEN pvSCSI protocol description

2014-08-04 Thread Jan Beulich
>>> On 04.08.14 at 10:27, wrote: > +/* Requests from the frontend to the backend */ > + > +/* > + * Request a SCSI operation specified via a CDB in vscsiif_request.cmnd. > + * The target is specified via channel, id and lun. > + */ > +#define VSCSIIF_ACT_SCSI_CDB 1 > + > +/* > + * Request

[PATCH] fix buffer leak after "scsi: saner replacements for ->proc_info()"

2013-05-29 Thread Jan Beulich
That patch failed to set proc_scsi_fops' .release method. Signed-off-by: Jan Beulich --- drivers/scsi/scsi_proc.c |1 + 1 file changed, 1 insertion(+) --- 3.10-rc3/drivers/scsi/scsi_proc.c +++ 3.10-rc3-scsi-proc-leak/drivers/scsi/scsi_proc.c @@ -84,6 +84,7 @@ stati

Re: [Xen-devel] [PATCH 1/4] Add XEN pvSCSI protocol description

2014-06-30 Thread Jan Beulich
>>> On 27.06.14 at 19:11, wrote: > On Fri, Jun 27, 2014 at 04:34:33PM +0200, jgr...@suse.com wrote: >> +/* >> + * Maximum scatter/gather segments per request. >> + * >> + * Considering balance between allocating at least 16 "vscsiif_request" >> + * structures on one page (4096 bytes) and the numbe

Re: [Xen-devel] [PATCH 1/4] Add XEN pvSCSI protocol description

2014-06-30 Thread Jan Beulich
>>> On 30.06.14 at 13:18, wrote: > On 06/30/2014 01:02 PM, Jan Beulich wrote: >>>>> On 27.06.14 at 19:11, wrote: >>> On Fri, Jun 27, 2014 at 04:34:33PM +0200, jgr...@suse.com wrote: >>>> +/* >>>> + * Maximum scatter/gather segment

[PATCH] xen-scsiback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Jan Beulich
Only a positive return value indicates success. Signed-off-by: Jan Beulich --- drivers/xen/xen-scsiback.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 4.7-rc6-xenbus_scanf.orig/drivers/xen/xen-scsiback.c +++ 4.7-rc6-xenbus_scanf/drivers/xen/xen-scsiback.c @@ -1071,7 +1071,7

[PATCH] xen-scsiback: prefer xenbus_write() over xenbus_printf() where possible

2016-07-07 Thread Jan Beulich
... as being the simpler variant. Signed-off-by: Jan Beulich --- drivers/xen/xen-scsiback.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 4.7-rc6-prefer-xenbus_write.orig/drivers/xen/xen-scsiback.c +++ 4.7-rc6-prefer-xenbus_write/drivers/xen/xen-scsiback.c @@ -1260,8 +1260,8

[PATCH] xen-scsifront: correct return value checks on xenbus_scanf()

2016-07-07 Thread Jan Beulich
Only a positive return value indicates success. Signed-off-by: Jan Beulich --- drivers/scsi/xen-scsifront.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 4.7-rc6-xenbus_scanf.orig/drivers/scsi/xen-scsifront.c +++ 4.7-rc6-xenbus_scanf/drivers/scsi/xen-scsifront.c @@ -1000,14