Re: [PATCH 0/2] target: Fixes for AllRegistrants reservation handling

2014-12-18 Thread Ilias Tsitsimpis
On Tue, Dec 16, 2014 at 12:09AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi all, > > This series addresses two issues raised recently by Ilias wrt > AllRegistrants reservation handling in target code that does not > adhere to SPC-4 specification requirements. > > This first

Re: [PATCH] target/user: Fix possible overwrite of t_data_sg's lastiov[]

2017-03-09 Thread Ilias Tsitsimpis
Hi Andy, Xiubo, On Fri, Mar 03, 2017 at 11:00AM, Andy Grover wrote: > On 02/27/2017 09:47 PM, lixi...@cmss.chinamobile.com wrote: > > From: Xiubo Li > > > > If there has BIDI data, its first iov[] will overwrite the last > > iov[] for se_cmd->t_data_sg. > > (+CCing orig BIDI and data block code

Re: [PATCH] target/user: Fix possible overwrite of t_data_sg'slastiov[]

2017-03-09 Thread Ilias Tsitsimpis
On Thu, Mar 09, 2017 at 10:08PM, 李秀波 wrote: > Any other advice about this change for your case? I took a look at the patch you sent and it seems reasonable to me. I didn't have the time to test it, but I will try to update to the latest version (probably by next week) and report back. Thanks for

Re: [PATCHv4 0/4] tcmu: bug fix and dynamic growing data area support

2017-03-23 Thread Ilias Tsitsimpis
Hi Xiubo, On Tue, Mar 21, 2017 at 04:36PM, lixi...@cmss.chinamobile.com wrote: > [...] > tcmu: Fix possible overwrite of t_data_sg's last iov[] > tcmu: Fix wrongly calculating of the base_command_size I tested these two patches, which try to fix the broken support for BIDI commands in target/

Re: [PATCHv4 0/4] tcmu: bug fix and dynamic growing data area support

2017-03-25 Thread Ilias Tsitsimpis
On Fri, Mar 24, 2017 at 02:45AM, 李秀波 wrote: > IliasTsitsimpis 写到: > >Could you please validate the above snippet, and update your patches to > >include it? > > They are actually two separate issues, but all for BIDI case. > > I'll merged into my patch. Since these are two separate issues, I woul

Re: [PATCH] tcmu: Skip Data-Out blocks before gathering Data-In buffer for BIDI case

2017-03-31 Thread Ilias Tsitsimpis
ip the Data-Out ones, or the device > supporting BIDI commands won't work. > > Fixed: 26418649eead ("target/user: Introduce data_bitmap, replace > data_length/data_head/data_tail") > Reported-by: Ilias Tsitsimpis > Signed-off-by: Xiubo Li Thanks