On Fri, Apr 26, 2013 at 09:10:44AM -0700, James Bottomley wrote:
> On Fri, 2013-04-26 at 17:44 +0200, Steffen Maier wrote:
> > On 04/26/2013 05:10 PM, James Bottomley wrote:
> > > On Fri, 2013-04-26 at 16:13 +0200, Steffen Maier wrote:
> > >> James,
> > >>
> > >> here is a series of zfcp features a
> +static void zfcp_fsf_req_latency(struct zfcp_fsf_req *fsf_req)
> +{
> + struct fsf_qual_latency_info *lat_inf;
> + struct zfcp_unit *unit;
> +
> + lat_inf = &fsf_req->qtcb->prefix.prot_status_qual.latency_info;
> + unit = fsf_req->unit;
> +
> + switch (fsf_req->qtcb->bottom.i
> > + if (!(adapter->adapter_features & FSF_FEATURE_MEASUREMENT_DATA)) {
> > + ZFCP_LOG_NORMAL("error: Enhanced measurement feature not "
> > + "supported");
> > + return -EOPNOTSUPP;
> > + }
Btw. any user can flood the console with these messages
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2, or (at your option)
> - * any later version.
> - *
> - * This program is distribute
> /*
> - * function:
> + * function:
> *
> - * purpose:
> + * purpose:
> *
> * returns:
If you do a whitespace cleanup you might as well kill these lines.
They don't contain that much information... ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of
>> +dev_set_drvdata(&adapter->stat_services, adapter);
>> +
>> +if (device_register(&adapter->stat_services))
>> +goto services_failed;
>> +
>> +if (zfcp_sysfs_statistic_services_create_files(&adapter->stat_services))
>> +{
>> +device_unregister(&adapter->sta
gt; select VIRT_CPU_ACCOUNTING
> select VIRT_TO_BUS
> + select ARCH_HAS_SG_CHAIN
>
Acked-by: Heiko Carstens
FWIW, it would have been nice to keep the list of selected configs sorted.
However no need to resend.
--
To unsubscribe from this list: send the line "unsubscr
On Wed, Feb 07, 2007 at 05:06:43PM +0100, Andreas Herrmann wrote:
> On Wed, Feb 07, 2007 at 01:17:57PM +0100, Swen Schillig wrote:
> > From: Swen Schillig <[EMAIL PROTECTED]>
> >
> > Invalid locking order. Kernel hangs after trying to take two locks
> > which are dependend on each other. Introduci
From: Heiko Carstens <[EMAIL PROTECTED]>
zfcp_fsf_protstatus_eval() takes always the 'wrong' branch.
Likely Profiling Results
-
[+- ] Type | # True | # False | Function:[EMAIL PROTECTED]
+unlikely |
schedule_work(), adapter gets
shut down, call to fc_remort_port_delete(), port->rport gets deleted,
then zfcp_erp_scsi_scan() gets called and tries to derefence port->rport
which is NULL. Addressing exception is the result.
The patch below should fix that, but it change
On Fri, May 11, 2007 at 01:33:41PM -0500, James Bottomley wrote:
> It strikes me that in all of this, we could also consider doing the DMA
> mapping inside the mid layer (instead of in every driver). This is
> essentially what libata is already doing ... leading to confusion in
> SCSI drivers that
On Mon, Jun 18, 2007 at 10:47:28AM +0200, Hannes Reinecke wrote:
> James Bottomley wrote:
> > On Tue, 2007-05-29 at 15:29 +0200, Swen Schillig wrote:
> >> From: Christof Schmitt <[EMAIL PROTECTED]>
> >>
> >> zfcp reported units to the SCSI stack starting
> >> with number 0. LUN 0 reported to the S
the init section. So this
patch only removes the compile time warning.
Signed-off-by: Heiko Carstens
---
drivers/scsi/fcoe/fcoe_sysfs.c |2 +-
drivers/scsi/fcoe/fcoe_transport.c |4 ++--
include/scsi/fcoe_sysfs.h |2 +-
3 files changed, 4 insertions(+), 4 deletions
On Thu, Jul 12, 2012 at 07:59:12PM +, Rustad, Mark D wrote:
> On Jul 11, 2012, at 4:02 AM, Heiko Carstens wrote:
>
> > Fix this warning:
> >
> > WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x7c):
> > Section mismatch in reference from the function ini
On Thu, Nov 16, 2017 at 01:38:18PM +0100, Steffen Maier wrote:
> If this has not been picked/merged yet (it's not in Linus' tree yet),
> could you please drop it because it's buggy?
>
> This would buy me time to come up with a proper solution,
> otherwise I would be forced to fix it within 4.15-rc
Hi James,
could you please apply the patch below?
Thanks,
Heiko
From: Heiko Carstens <[EMAIL PROTECTED]>
From: Andreas Herrmann <[EMAIL PROTECTED]>
From: Maxim Shchetynin <[EMAIL PROTECTED]>
zfcp changes:
- revert kfree patch leftovers
- don't call del_timer_sync
> > void
> > -zfcp_dummy_release(struct device *dev)
> > +zfcp_generic_services_release(struct device *dev)
> > {
> > - return;
> > + kfree(dev);
> > }
> >
> > /*
>
> I thought that having release methods that just called kfree() were
> also verboten?
We do a kmalloc(sizeof(struce device
> > > I thought that having release methods that just called kfree() were
> > > also verboten?
> > We do a kmalloc(sizeof(struce device),...) somewhere and this
> > is how we get rid of it again.
> > How are we supposed to free this object otherwise? The release
> > function gets called when there
ount handling for data underruns
- mark LUN as ACCESS_DENIED on status LUN_SHARING_VIOLATION
Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
zfcp_erp.c |6 +++---
zfcp_fsf.c | 37 ++---
2 files changed, 21 insertions(+), 22 deletions(-)
diff -
Hi James,
unfortunately the last zfcp patch introduces a bug and the driver doesn't
compile anymore in addition. If possible the patch below should go into 2.6.13.
Thanks,
Heiko
From: Heiko Carstens <[EMAIL PROTECTED]>
Bugfix (usage of uninitialized pointer in zfcp_port_dequeue)
On Fri, Dec 15, 2006 at 01:50:14PM -0600, James Bottomley wrote:
> On Mon, 2006-12-04 at 15:18 -0800, [EMAIL PROTECTED] wrote:
> > From: Heiko Carstens <[EMAIL PROTECTED]>
> >
> > Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]>
> > Signed-off-by: Andre
21 matches
Mail list logo
