On 11/07/2016 04:15 PM, Chris Leech wrote:
> Hi,
>
> I'm kicking this old thread because I don't think this ever got
> resolved. I wish I had more info, but it seems to involve target
> specific behavior that hasn't come up in our test labs.
Thanks very much for reopening this thread! We have th
On 11/09/2016 03:21 AM, Chris Leech wrote:
> On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote:
>>
>> Sure! Count on us to test any patches. I guess the first step is to
>> reproduce on upstream right? We haven't tested specifically this
>> sce
leted 4096 of 4096 bytes
> [...] sd 0:0:0:0: [sda] tag#0 8 sectors total, 3072 bytes done.
> [...] sd 0:0:0:0: [sda] tag#0 checking 3072 bytes for alignment
> (sector size 4096, remainder 3072, resid 1024)
> [...] sd 0:0:0:0: [sda] tag#0 sd_done: completed
: Guilherme G. Piccoli
Signed-off-by: Ram Pai
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index b5c966e..55332a3 100644
--- a/drivers/scsi/mpt3sas
On 01/23/2017 07:05 AM, Sreekanth Reddy wrote:
> On Wed, Dec 28, 2016 at 6:21 PM, Guilherme G. Piccoli
> wrote:
>> From: Ram Pai
>>
>> The firmware or device, possibly under a heavy I/O load, can return
>> on a partial unaligned boundary. Scsi-ml expects these req
: Guilherme G. Piccoli
Signed-off-by: Ram Pai
---
v1->v2:
* Improved printk, by showing some variables too [suggested by Sreekanth].
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
b/drivers/s
On 01/25/2017 09:46 PM, Martin K. Petersen wrote:
>>>>>> "Guilherme" == Guilherme G Piccoli writes:
>
> Hi Guilherme,
Hi Martin, thanks for the review!
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> b/drivers/scsi/mpt3sas/mpt3sas_scsi
: Guilherme G. Piccoli
Signed-off-by: Ram Pai
Acked-by: Sreekanth Reddy
---
v2->v3:
* Changed division to round_down() [suggestion by Martin].
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
b/driv
On 01/26/2017 03:02 PM, Ram Pai wrote:
> On Thu, Jan 26, 2017 at 11:31:53AM -0200, Guilherme G. Piccoli wrote:
>> On 01/25/2017 09:46 PM, Martin K. Petersen wrote:
>>>>>>>> "Guilherme" == Guilherme G Piccoli
>>>>>>>> w
On 01/02/2017 01:34, Martin K. Petersen wrote:
>>>>>> "Guilherme" == Guilherme G Piccoli writes:
>
> Guilherme> The firmware or device, possibly under a heavy I/O load, can
> Guilherme> return on a partial unaligned boundary. Scsi-ml expects these
On 06/02/2017 15:27, Chris Leech wrote:
> - Original Message -
>> On 09/11/2016 03:21, Chris Leech wrote:
>>> On Mon, Nov 07, 2016 at 04:23:10PM -0200, Guilherme G. Piccoli wrote:
>>>>
>>>> Sure! Count on us to test any patches. I guess the first s
On 15/02/2017 05:06, Ram Pai wrote:
> On Wed, Feb 15, 2017 at 03:48:52PM +0900, Damien Le Moal wrote:
>> Christoph,
>>
>> On 2/15/17 15:34, Christoph Hellwig wrote:
>>> this looks reasonable, but we should ask Guilherme and Ram to confirm
>>> it fixes their originally reported issue. I've added th
below, most nitpicks heheh
Feel free to accept or not the suggestions!
Also, you can add my:
Reviewed-by: Guilherme G. Piccoli
>
> - Chris Leech
>
> - Original Message -
>> There's a rather long standing regression from commit
>> 659743b [SCSI] libiscs
Thanks very much Chris, really good patch. Hopefully it can reach 4.11!
Cheers,
Guilherme
Looks good, thanks for the patch.
Reviewed-by: Guilherme G. Piccoli
Cheers,
Guilherme
1dd532901e (scsi: aacraid: Reload offlined drives after
> controller reset)
> Cc:
> Reported-by: Guilherme G. Piccoli
> Tested-by: Guilherme G. Piccoli
> Fixes: a2d0321dd532901e (scsi: aacraid: Reload offlined drives after
> controller reset)
> Signed-off-
On 12/21/2017 03:33 PM, Raghava Aditya Renukunta wrote:
> This patchset primarily lays the foundation for adding sas transport
> support to the aacraid driver. Being said these patches are mainly code
> refactors, bug fixes and improvements.
I was thinking...if possible, and just in case you plan
1dd532901e (scsi: aacraid: Reload offlined drives after
> controller reset)
> Cc:
> Reported-by: Guilherme G. Piccoli
(Sorry in advance for flooding the thread heheh)
I guess it'd be more appropriate to:
Reported-by: Douglas Miller
Although I've tested it, Doug isolated
On 12/26/2017 11:27 PM, Raghava Aditya Renukunta wrote:
> [...]
>> I was thinking...if possible, and just in case you plan to send a V2
>> after Bart's comments (or any other future reviews this patchset gets),
>> how about splitting in 2 patchsets, one for bug fixes and the other for
>> improvemen
Hi Christoph, thanks for the fix. I just faced a crash[0] booting
v5.3-rc1 in a KVM guest, and your patch fixed it.
Feel free to add:
Tested-by: Guilherme G. Piccoli
Cheers,
Guilherme
[0]
BUG: kernel NULL pointer dereference, address:
#PF: supervisor read access in kernel
We observed that it's possible to perform partition operations in both
nvmf target and initiator block devices, like creating and deleting
partitions.
But there is no sync mechanism between target and initiator regarding
the partitions operations. After creating a partition on initiator, for
examp
Thanks for your feedback Hannes, agreed!
Cheers,
Guilherme
On 08/10/2017 06:16 AM, Christoph Hellwig wrote:
> On Mon, Aug 07, 2017 at 02:29:47PM -0300, Guilherme G. Piccoli wrote:
>> Thanks for your feedback Hannes, agreed!
>
> And btw, you'll see similar results with the SCSI target or nbd,
> so it's not really nvme specific
procedure was able to recover fine.
Fixes: 5c63f7f710bd ("aacraid: Added EEH support")
Cc: sta...@vger.kernel.org # v4.6+
Signed-off-by: Guilherme G. Piccoli
---
drivers/scsi/aacraid/aacraid.h | 11 ---
drivers/scsi/aacraid/commsup.c | 3 ++-
2 files changed, 10 insertions(+), 4
Hi James and Dick, thanks for this patch. We were investigating a pretty
similar issue, and we raised a patch that looks like yours.
Since you sent this one, we reviewed and seems it's missing a hunk to
prevent the issue we are dealing here, in PCI error recovery.
Please see the attached patch. Ba
estroy the queues on adapter resets, like in PCI error
recovery path, we need the validation present on this patch in order
to avoid a NULL pointer dereference when trying to flush commands of
ELS wq, after it has been destroyed (which would lead to a kernel oops).
Tested-by: Raphael Silva
Signed
On 05/17/2017 03:49 PM, James Smart wrote:
> Your patch is still needed. Can you repost your patch with a new
> subject and add my signature:
>
> Signed-off-by: James Smart
>
> Sorry, I didn't see it to roll it into the set.
No problem James, already sent it to linux-scsi:
https://marc.info/?
On 05/17/2017 09:21 PM, Martin K. Petersen wrote:
>
> Guilherme,
>
>> Recent commit on patchset "lpfc updates for 11.2.0.14" fixed an issue
>> about dereferencing a NULL pointer on port reset. The specific commit,
>> named "lpfc: Fix system crash when port is reset.", is missing a check
>> agains
the queue in case of a NULL pring.
Also, this patch converts return type of lpfc_els_abort() from int
to void, since it's not checked anywhere.
Reported-by: Harsha Thyagaraja
Reported-by: Naresh Bannoth
Tested-by: Raphael Silva
Signed-off-by: Guilherme G. Piccoli
---
* This patch was re
refactor made on
commit 895427bd012c ("scsi: lpfc: NVME Initiator: Base modifications").
Fixes: 895427bd012c ("scsi: lpfc: NVME Initiator: Base modifications")
Reported-by: Naresh Bannoth
Signed-off-by: Guilherme G. Piccoli
---
This patch was rebased against Martin's 4.12/s
Hello, we've noticed an interesting behavior when using a raid-0 md
array. Suppose we have a 2-disk raid-0 array that has a mount point
set - in our tests, we've used ext4 filesystem. If we remove one of
the component disks via sysfs[0], userspace is notified, but mdadm tool
fails to stop the array
Thanks for your quick reply Anthony!
Inline comments below:
On 27/04/2018 19:11, Wols Lists wrote:
> On 27/04/18 22:49, Guilherme G. Piccoli wrote:
> [...]
> Sounds like you're not using mdadm to remove the disk. So why do you
> expect mdadm to stop the array immediately
On 09/04/2017 05:44 PM, Guilherme G. Piccoli wrote:
> [Hopefully this messages gets threaded properly...]
And of course, I forgot to CC linux-scsi heheh
Sorry!
>
> Chaitra, the following 4 patches fix this issue (the last one is really
> the fix, the others are part of
Add periodic checks to see IOP reset
status")
Cc: sta...@vger.kernel.org # v4.13+
Signed-off-by: Guilherme G. Piccoli
---
drivers/scsi/aacraid/src.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
index 48c2b2b34b72..0c9361c87ec
On 09/19/2017 12:37 PM, Christoph Hellwig wrote:
> On Tue, Sep 19, 2017 at 12:11:55PM -0300, Guilherme G. Piccoli wrote:
>> src_writel(dev, MUnit.IDR, IOP_SRC_RESET_MASK);
>> +
>> +msleep(5000);
>
> src_writel is a writel, and thus a posted MMIO write. You&
On 09/19/2017 12:52 PM, Christoph Hellwig wrote:
> On Tue, Sep 19, 2017 at 12:49:21PM -0300, Guilherme G. Piccoli wrote:
>> On 09/19/2017 12:37 PM, Christoph Hellwig wrote:
>>> On Tue, Sep 19, 2017 at 12:11:55PM -0300, Guilherme G. Piccoli wrote:
>>>>
On 09/19/2017 02:05 PM, James Bottomley wrote:
> Actually, the whole problem sounds like a posted write. Likely the
> write that causes the reset doesn't get flushed until the read checking
> if the reset has succeeded, which might explain the 100% initial
> failure. Why not throw away that first
On 09/21/2017 01:19 PM, Dave Carroll wrote:
>> [...]
>> ---
> Acked-by: Dave Carroll
>
Thanks Dave!
James/Martin, am I expected to send a v2 with some change? Perhaps with
Dave's ack?
Sorry to annoy, thanks in advance for any advice!
Cheers,
Guilherme
e IRQ,
then we free other resources. No functional change intended.
Signed-off-by: Guilherme G. Piccoli
---
drivers/scsi/aacraid/commsup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 2abe8fd83494..bec9f31
on-dependent of arch configs - also, it makes
the code cleaner.
Signed-off-by: Guilherme G. Piccoli
---
drivers/scsi/aacraid/commsup.c | 33 ++---
1 file changed, 2 insertions(+), 31 deletions(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.
case of scsi EH path, this
patch adds a field to aac_dev struct to keep per-adapter track of the
init reset request - once it's done, we set it to false and don't
proactively reset anymore in case of reinitializations.
Signed-off-by: Guilherme G. Piccoli
---
drivers/scsi/aacraid/aacra
This series presents 3 small fixes for aacraid driver.
The most important is the crash prevention, IMHO.
Tested them against v4.14.
Guilherme G. Piccoli (3):
scsi: aacraid: Check for PCI state of device in a generic way
scsi: aacraid: Perform initialization reset only once
scsi: aacraid
42 matches
Mail list logo
