[PATCH -next] advansys: Add missing include file

2015-06-05 Thread Guenter Roeck
Use dma_pool for sg elements") Cc: Hannes Reinecke Signed-off-by: Guenter Roeck --- drivers/scsi/advansys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 14d3aa54daa5..af2cb5e9e3f7 100644 --- a/drivers/scsi/advansys.c +++ b/dri

[PATCH] scsi: Fix qemu boot hang problem

2014-08-10 Thread Guenter Roeck
was reversed. Changing this expression to '!atomic_read(&sdev->device_busy)' fixes the problem. Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Webb Scales Cc: Jens Axboe Signed-off-by: Guenter Roeck --- drivers/scsi/scsi_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH] scsi: Fix qemu boot hang problem

2014-08-11 Thread Guenter Roeck
On 08/11/2014 08:33 AM, Venkatesh Srinivas wrote: Should we wrap the sdev->device_busy read and test in a new scsi_device_busy(), so as to preserve the old polarity? I don't see a difference in polarity, or at least replacing '== 0' with '!' is not a reverse in polarity for me. Anyway, I don't

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Guenter Roeck
On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote: > spin_is_locked() always return false in uniprocessor configuration and > therefore it > would be advise to repalce with assert_spin_locked(). > > Signed-off-by: Sanjeev Sharma > --- > drivers/usb/storage/uas.c | 8 > 1 f

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Guenter Roeck
On Mon, Aug 11, 2014 at 08:55:07PM +0200, Hans de Goede wrote: > Hi, > > On 08/11/2014 08:19 PM, Guenter Roeck wrote: > > On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote: > >> spin_is_locked() always return false in uniprocessor configuration and > &g

Re: [PATCH v2] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-08-11 Thread Guenter Roeck
On Tue, Aug 12, 2014 at 02:01:53PM +0800, Greg KH wrote: > On Tue, Aug 12, 2014 at 11:38:37AM +0530, Sanjeev Sharma wrote: > > spin_is_locked() always return false in uniprocessor configuration and > > therefore it > > would be advise to replace with lockdep_assert_held(). > > Add "on some archit

Re: [PATCH] scsi: Fix qemu boot hang problem

2014-08-15 Thread Guenter Roeck
ping ... the problem fixed by this patch still affects the upstream kernel (v3.16-11383-gc9d2642) as well as -next (20140815). Guenter On 08/10/2014 05:54 AM, Guenter Roeck wrote: The latest kernel fails to boot qemu arm images when using scsi for disk access. Boot gets stuck after the

Re: [PATCH] scsi: Fix qemu boot hang problem

2014-08-15 Thread Guenter Roeck
On 08/15/2014 12:22 PM, Christoph Hellwig wrote: On Fri, Aug 15, 2014 at 12:34:22PM -0600, Jens Axboe wrote: On 2014-08-15 12:22, Guenter Roeck wrote: ping ... the problem fixed by this patch still affects the upstream kernel (v3.16-11383-gc9d2642) as well as -next (20140815). James, could

Re: [PATCH 0/2] scsi: two SG_CHAIN related fixes

2019-06-04 Thread Guenter Roeck
On Tue, Jun 04, 2019 at 04:23:06PM +0800, Ming Lei wrote: > Hi, > > Guenter reported scsi boot issue caused by commit c3288dd8c232 > ("scsi: core: avoid pre-allocating big SGL for data"). > > Turns out there are at least two issues. > > The 1st patch fixes issue in case that NO_SG_CHAIN on some

Re: [PATCH 2/2] scsi: esp: make it working on SG_CHAIN

2019-06-04 Thread Guenter Roeck
Milne > Cc: Hannes Reinecke > Cc: Guenter Roeck > Reported-by: Guenter Roeck > Signed-off-by: Ming Lei Tested-by: Guenter Roeck > --- > drivers/scsi/esp_scsi.c | 32 +--- > 1 file changed, 25 insertions(+), 7 deletions(-) > > diff -

Re: [PATCH 1/2] scsi: core: don't pre-allocate small SGL in case of NO_SG_CHAIN

2019-06-04 Thread Guenter Roeck
> NO_SG_CHAIN. > > Cc: Christoph Hellwig > Cc: Bart Van Assche > Cc: Ewan D. Milne > Cc: Hannes Reinecke > Cc: Guenter Roeck > Fixes: c3288dd8c232 ("scsi: core: avoid pre-allocating big SGL for data") > Reported-by: Guenter Roeck > Signed-off-by: Ming Lei alp

Re: [PATCH 0/2] scsi: two SG_CHAIN related fixes

2019-06-04 Thread Guenter Roeck
On Tue, Jun 04, 2019 at 11:18:44PM +0800, Ming Lei wrote: > Hi Guenter, > > Thanks for your test and report! > > On Tue, Jun 04, 2019 at 06:38:49AM -0700, Guenter Roeck wrote: > > On Tue, Jun 04, 2019 at 04:23:06PM +0800, Ming Lei wrote: > > > Hi, > > >

Re: [PATCH V2 0/3] scsi: three SG_CHAIN related fixes

2019-06-05 Thread Guenter Roeck
On Wed, Jun 05, 2019 at 09:06:20AM +0800, Ming Lei wrote: > Hi, > > Guenter reported scsi boot issue caused by commit c3288dd8c232 > ("scsi: core: avoid pre-allocating big SGL for data"). > > Turns out there are at least three issues. > > The 1st patch fixes sg_alloc_table_chained() which may tr

Re: [PATCH V2 0/3] scsi: three SG_CHAIN related fixes

2019-06-05 Thread Guenter Roeck
On Wed, Jun 05, 2019 at 09:25:37AM -0700, Guenter Roeck wrote: > On Wed, Jun 05, 2019 at 09:06:20AM +0800, Ming Lei wrote: > > Hi, > > > > Guenter reported scsi boot issue caused by commit c3288dd8c232 > > ("scsi: core: avoid pre-allocating big SGL for data&qu

Re: [PATCH 15/22] hwmon: applesmc: fix format string overflow

2017-07-14 Thread Guenter Roeck
On 07/14/2017 05:07 AM, Arnd Bergmann wrote: gcc-7 warns that the key might exceed five bytes for lage index values: drivers/hwmon/applesmc.c: In function 'applesmc_show_fan_position': drivers/hwmon/applesmc.c:906:18: error: '%d' directive writing between 1 and 5 bytes into a region of size 4 [

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-22 Thread Guenter Roeck
[-cc] Hi Linus, On 11/22/18 5:49 AM, Linus Walleij wrote: [ ... ] (It's also worth noting that HDD temperature sensors are notoriously unreliable). I am sorry if you think that D-Link does bad engineering, what I am trying to achieve is upstream support for this device, without any out-of-tre

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-23 Thread Guenter Roeck
On 11/23/18 12:18 AM, Linus Walleij wrote: On Thu, Nov 22, 2018 at 9:00 PM Guenter Roeck wrote: Can you possibly extract this as pure hwmon driver outside scsi control ? I'll be happy to accept it as standalone hwmon driver. That should be last resort, what the SCSI people want is

kobject lifetime issues in blk-mq

2018-11-09 Thread Guenter Roeck
Hi, Images with CONFIG_DEBUG_KOBJECT=y, CONFIG_DEBUG_KOBJECT_RELEASE=y enabled report kobject lifetime issues when booting an image in qemu using virtio-scsi-pci. Bisect points to two different commits, depending on the kernel configuration. 1st configuration: defconfig plus: CONFIG_VIRTIO_BLK=

Re: kobject lifetime issues in blk-mq

2018-11-12 Thread Guenter Roeck
On Mon, Nov 12, 2018 at 05:20:52PM +0800, Ming Lei wrote: > On Fri, Nov 09, 2018 at 12:35:18PM -0800, Guenter Roeck wrote: > > Hi, > > > > Images with CONFIG_DEBUG_KOBJECT=y, CONFIG_DEBUG_KOBJECT_RELEASE=y > > enabled report kobject lifetime issues when booting an ima

Re: kobject lifetime issues in blk-mq

2018-11-12 Thread Guenter Roeck
On Mon, Nov 12, 2018 at 05:44:07PM +0800, Ming Lei wrote: > On Mon, Nov 12, 2018 at 05:20:51PM +0800, Ming Lei wrote: > > On Fri, Nov 09, 2018 at 12:35:18PM -0800, Guenter Roeck wrote: > > > Hi, > > > > > > Images with CONFIG_DEBUG_KOBJECT=y, CONFIG_DEBUG_KO

Re: BUG in scsi_lib.c due to a bad commit

2014-11-11 Thread Guenter Roeck
gigabyte GA-P31-DS3L, and IDE disk on a JMicron JMB363/368 Sata/IDE PCIe card ), every 5~10 boots the boot stops suddenly because of this commit, If I revert this commit then the bug is gone, more details can be found here, where I created a patch who reverts commit 045065d8 : https://bugzilla.ke

[PATCH] cxlflash: Select IRQ_POLL

2017-05-05 Thread Guenter Roeck
vers/scsi/cxlflash/cxlflash.ko] undefined! ERROR: ".irq_poll_init" [drivers/scsi/cxlflash/cxlflash.ko] undefined! Fixes: cba06e6de403 ("scsi: cxlflash: Implement IRQ polling for RRQ processing") Signed-off-by: Guenter Roeck --- drivers/scsi/cxlflash/Kconfig | 1 + 1 file

Re: [PATCH 09/13] timer: Remove users of expire and data arguments to DEFINE_TIMER

2017-10-04 Thread Guenter Roeck
Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc: Geert Uytterhoeven Cc: linux-m...@linux-mips.org Cc: linux-watch...@vger.kernel.org Signed-off-by: Kees Cook For watchdog: Acked-by: Guenter Roeck --- arch/mips/mti-malta/malta-display.c | 6 +++--- drivers/watchdog/alim7101_wdt.c | 4

Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-04 Thread Guenter Roeck
Kees Cook Acked-by: Geert Uytterhoeven # for m68k parts For watchdog: Acked-by: Guenter Roeck --- arch/arm/mach-ixp4xx/dsmg600-setup.c | 2 +- arch/arm/mach-ixp4xx/nas100d-setup.c | 2 +- arch/m68k/amiga/amisound.c| 2 +- arch/m68k/mac/macboing.c