> +++ b/drivers/scsi/esp_scsi.h
> @@ -540,6 +540,8 @@ struct esp {
>
> void*dma;
> int dmarev;
> +
> + int send_cmd_residual;
unsigned int?
Gr{oetje,eeting}s,
Geert
-
g
> +++ b/drivers/scsi/Kconfig
> @@ -42,6 +42,10 @@ config SCSI_DMA
> bool
> default n
>
> +config SCSI_ESP_PIO
> + bool
> + default n
"default n" is the default, so please drop this line.
Gr{oetje,eeting}s,
l.
"-v" to prefix all patches with version number ,
"--cover" to have a "[PATCH 0/]" prefix in the cover letter.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In person
Hi Christoph,
On Fri, Oct 19, 2018 at 9:00 AM Christoph Hellwig wrote:
> On Wed, Oct 17, 2018 at 10:30:49AM +0200, Geert Uytterhoeven wrote:
> > Please use "git format-patch -v --cover" to prepare patch series
> > for sending with git-send-email.
> >
> > &q
Hi Christoph,
On Fri, Oct 19, 2018 at 9:10 AM Christoph Hellwig wrote:
> On Fri, Oct 19, 2018 at 09:07:51AM +0200, Geert Uytterhoeven wrote:
> > Without this:
> > - It's hard to visually match your untagged cover letter with the
> > actual patches,
> > -
, though; such bugs will be fixed more quickly if any interested
| parties submit patches to that effect.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people,
).
>
> Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
> Cc: Geert Uytterhoeven <[EMAIL PROTECTED]>
> Cc: James Bottomley <[EMAIL PROTECTED]>
Seems to (still) work fine..
James: as you're scripts seem to be waiting for an ack from me, and it's not
really
q_len - act_len);
> + scsi_set_resid(cmd, scsi_bufflen(cmd) - act_len);
> return 0;
> }
My 2 comments:
- The variable buflen already contains scsi_bufflen(cmd),
- We no longer need to calculate the data length of the whole scatterlist.
I'll follow up to this email with a replaceme
able buflen already contains scsi_bufflen(cmd)]
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PROTECTED]>
---
drivers/scsi/ps3rom.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
drivers/scsi/ps3rom.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
--- a/drivers/scsi/ps3rom.c
+++ b/drivers/scsi/ps3rom.c
@@ -95,7 +95,7 @@ static int ps3rom_slave_configure(struct
*/
stat
On Tue, 26 Feb 2008, FUJITA Tomonori wrote:
> On Mon, 25 Feb 2008 14:24:31 +0100 (CET)
> Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
>
> > Subject: [PATCH] ps3rom: Simplify fill_from_dev_buffer()
> >
> > As we no longer need to calculate the data length of
; running userspace startup scripts. But let that be another issue at the
> moment.
Switching from uint16_t to __le16 but _removing_ cpu_to_le16() operations
looks indeed very fishy.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia3
als and consuming power.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I
PAGE_SIZE - 1,
Likewise
According to the Sun-3 Architecture Manual v2.0 (May 1985), end should
be 0x0014001f.
I guess the resource length is 0x20 for VME SCSI, too?
> + },
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia3
the arch/m68k changes in v2 (modulo the PAGE_SIZE
comment on Sun-3), so please add my
Acked-by: Geert Uytterhoeven
after fixing that one.
As I'm not afraid of merge conflicts, I think this can go in through the SCSI
tree? James?
Note that there's still room for improvement in the individ
s) which I
> think equals 0x22:
IC.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journ
; + irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!irq || !mem)
> + return -ENODEV;
> +
> + ioaddr = ioremap(mem->start, PAGE_SIZE);
and here.
Gr{oetje,eeting}s,
Signed-off-by: Geert Uytterhoeven
Cc: Hannes Reinecke
Cc: linux-scsi@vger.kernel.org
---
drivers/scsi/aic7xxx/aic79xx_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c
b/drivers/scsi/aic7xxx/aic79xx_core.c
index 0bcacf71aef814fe
(esp->num_tags >= ESP_MAX_TAG)
drivers/scsi/esp_scsi.c: In function ‘scsi_esp_register’:
drivers/scsi/esp_scsi.c:2399: warning: comparison is always false due
to limited range of data type
ESP_MAX_TAG is 256, num_tags is u8.
> + esp->num_tags = ESP_MAX_TAG - 1;
Gr{oetj
If CONFIG_SCSI_GENERIC_NCR5380=y:
drivers/scsi/g_NCR5380.c:727: warning: ‘id_table’ defined but not used
In the non-modular case, MODULE_DEVICE_TABLE() expands to nothing, and
id_table is not referenced.
Correct the existing #ifdef to fix this.
Signed-off-by: Geert Uytterhoeven
---
drivers
emoval
> fallout"), except for the remaining two mentions that are removed here.
>
> Signed-off-by: Finn Thain
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In
cmd->SCp.this_residual,
> -
> hostdata->accesses_per_ms / 2);
> +
> hostdata->accesses_per_ms >> 2);
I think it's easier to read if you use "/ 4".
#x27; declared inline
> after being called
> drivers/scsi/NCR5380.h:295: warning: previous declaration of
> `NCR5380_poll_politely' was here
>
> Avoid this by defining NCR5380_poll_politely() in NCR5380.h.
>
> Suggested-by: Geert Uytterhoeven
> Signed-off-by: Fin
_NCR5380 on x86) was not tested but 5380 ISA cards
> Finn> generally use PDMA and not PIO.
>
> Geert?
No comments from my side.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m
y
> problems caused by adding 'const' to a definition will be seen by build
> errors or warnings.
Unfortunately in this particular case they could lead to failures that can only
be detected at runtime, when failing o write to a read-only piece of memory,
due to the casting aw
differences, the pointer to the feature struct is what most DT
drivers use (of_device_id.data is a const void *).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical
ry) due to almost no new
Zorro boards being made, unlike for PCI, where keeping an in-kernel list
is a lot of work, and not desirable.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conv
Hi Michael,
On Tue, Apr 10, 2018 at 11:50 PM, Michael Schmitz wrote:
> On Tue, Apr 10, 2018 at 8:18 PM, Geert Uytterhoeven
> wrote:
>> On Tue, Apr 10, 2018 at 4:16 AM, Michael Schmitz
>> wrote:
>>> On Mon, Apr 9, 2018 at 7:50 PM, Christoph Hellwig
>>> wr
Hi Adrian,
On Wed, Apr 11, 2018 at 9:59 AM, John Paul Adrian Glaubitz
wrote:
> On 04/11/2018 08:51 AM, Geert Uytterhoeven wrote:
>> I don't have a preference. If you think it makes the driver easier to
>> read,
>> go for it.
>
> That would be cool. Would that sti
Hi Christoph,
On Wed, Apr 11, 2018 at 10:11 AM, Christoph Hellwig wrote:
> On Wed, Apr 11, 2018 at 10:03:12AM +0200, Geert Uytterhoeven wrote:
>> > That would be cool. Would that still be in time for the 4.17 merge?
>>
>> Nope, as new drivers need to be in linux-next
t;driver_data == (unsigned
> long)ZORRO_BLZ1230II) {
likewise
> + if (zep->zorro3 && ent->driver_data == (unsigned
> long)ZORRO_BLZ1230II) {
one more
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@l
|| COMPILE_TEST
> * drivers/spi/spi-ti-qspi.c - likewise
I haven't checked the others, but probably you want to disable COMPILE_TEST
to make more educated guesses about driver usage on x86.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lot
ESP_regs *eregs)
> {
> volatile unchar trash;
>
This change breaks the Amiga Oktagon SCSI driver (drivers/scsi/oktagon_esp.c),
which calls esp_bootup_reset().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots o
On Mon, 17 Jan 2005, Adrian Bunk wrote:
> On Mon, Jan 17, 2005 at 01:41:29PM +0100, Geert Uytterhoeven wrote:
> > On Tue, 21 Dec 2004, Linux Kernel Mailing List wrote:
> > > ChangeSet 1.2034.61.36, 2004/12/21 09:41:18-06:00, [EMAIL PROTECTED]
> > >
> > > [P
On Mon, 17 Jan 2005, Geert Uytterhoeven wrote:
> On Mon, 17 Jan 2005, Adrian Bunk wrote:
> > On Mon, Jan 17, 2005 at 01:41:29PM +0100, Geert Uytterhoeven wrote:
> > > On Tue, 21 Dec 2004, Linux Kernel Mailing List wrote:
> > > > ChangeSet 1.2034.61.36, 2004/12/21 09
Mac NCR5380 SCSI: Fix bus error by passing the correct instance pointer to
request_irq()
Signed-off-by: Finn Thain <[EMAIL PROTECTED]>
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1/drivers/scsi/mac_scsi.c2005-03-09 22:21:01.369397570
+1100
+++ linux
_RESET_SUCCESS
- SCSI_RESET_BUS_RESET
causing the driver to fail to build in 2.6.12-rc3. What should I replace them
by?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [EMAIL PROTECTED]
In personal co
From: Sam Creasey <[EMAIL PROTECTED]>
Make sun3 scsi drivers compile/work again (though with way too many warnings...)
Tested on 3/50, 3/60.
Signed-off-by: Sam Creasey <[EMAIL PROTECTED]>
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
drivers/scsi/Kconfig
iff
m68k-mvme-scsi-rename.diff
m68k-53c700-scsi.diff
from http://linux-m68k-cvs.ubb.ca/~geert/linux-m68k-2.6.x-merging/. These are
against 2.6.19.
BTW, are you interested in more Scsi_Cmnd -> struct scsi_cmnd patches? I have a
few of them lying around.
Gr{oetje,eeting}s,
201 - 239 of 239 matches
Mail list logo
