Signed-off-by: Geert Uytterhoeven
---
drivers/scsi/lpfc/lpfc_debugfs.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index 513edcb0c2dae379..25aa9b98d53aa345 100644
--- a/drivers/scsi/lpfc
12) {
>> > > - /* only legitimate sector_size here is 256 */
>> > > - start_lba <<= 1;
>> > > - end_lba <<= 1;
>> > > - } else {
>> > > - /* be careful ... don't want any overflows */
>
("advansys: use DMA-API for mapping sense buffer")
Signed-off-by: Geert Uytterhoeven
---
drivers/scsi/advansys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 4305178e4e0147ba..1c1cd657c380c2e0 100644
--- a/dr
share_irq are indeed not initialized.
Pre-initialize them to zero, and drop the now superfluous setting of
share_irq to zero.
Note that this is sort-of a false positive, as apparently
ASC_NARROW_BOARD(boardp) can only be false for PCI boards, e.g. if
CONFIG_PCI=y.
Signed-off-by: Geert
ces.
> -*/
> +#define TAG_NONE 0xff
>
> /*
> * These are "special" values for the irq and dma_channel fields of the
> @@ -323,7 +320,7 @@ static irqreturn_t NCR5380_intr(int irq,
Gr{oetje,eeting}s,
Geert
--
Ge
t some drivers do
#ifndef NO_IRQ
#define NO_IRQ (-1)
#endif
and others do
#ifndef NO_IRQ
#define NO_IRQ 0
#endif
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technica
"");
> + hostdata->info[sizeof(hostdata->info) - 1] = '\0';
snprintf() will make sure the string is zero-terminated, so doing this manually
is not needed.
This applies to all three occurrences.
> }
Gr{oetje,eeting}s,
Geert
--
Geert
hich is related to irqreturn_t).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journa
IA1_BASE + 0x1;
> + mac_scsi_drq = (unsigned char *) VIA1_BASE + 0x6000;
> + mac_scsi_nodrq = (unsigned char *) VIA1_BASE + 0x12000;
> }
>
> if (! setup_use_pdma)
I don't think the above chunk belongs in this patch.
Gr{oetje,eeting}s,
* not make use of its DMA or hardware handshaking logic.
> +*/
> + mac_scsi_0_pdev.num_resources--;
> + platform_device_register(&mac_scsi_0_pdev);
What about removing the static mac_scsi_0_pdev and mac_scsi_1_pdev,
and calling platform_device
local_irq_restore(flags);
return res;
}
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when
*/
> + if (MACH_IS_MEDUSA)
> + atari_read_overruns = 4;
> +#endif
> + } else {
> + /* Nothing to do for the interrupt: the ST-DMA is initialized
> +* already.
> +*/
> +#ifdef RE
On Fri, Oct 3, 2014 at 12:49 PM, Finn Thain wrote:
> On Fri, 3 Oct 2014, Geert Uytterhoeven wrote:
>> On Thu, Oct 2, 2014 at 8:56 AM, Finn Thain
>> wrote:
>> > Allow mac_scsi to be built as a module. Replace the old validation of
>> > __setup options with co
gt; > would like to hear Michael's views.
>> >
>>
>> The IRQ is a good candidate to be passed via platform data.
>
> Geert didn't say so, but after thinking about his review comments I
> imagine that he wants all the Atari IRQ numbers kept in one place
, HZ / 64)) {
> + CP_IO_TO_MEM(s, d, n);
This is now before the inclusion of NCR5380.c, causing
In file included from drivers/scsi/mac_scsi.c:335:
drivers/scsi/NCR5380.h:295: warning: ‘NCR5380_poll_politely’ declared
inline after being called
drivers/scsi/NCR5380.h:295: warning
Hi Finn,
On Thu, May 19, 2016 at 2:02 PM, Finn Thain wrote:
> On Thu, 19 May 2016, Geert Uytterhoeven wrote:
>> In file included from drivers/scsi/mac_scsi.c:335:
>> drivers/scsi/NCR5380.h:295: warning: `NCR5380_poll_politely' declared inline
>> after being called
>
Submitters of device tree binding documentation may forget to CC
the subsystem maintainer if this is missing.
Signed-off-by: Geert Uytterhoeven
Cc: James E.J. Bottomley
Cc: Martin K. Petersen
Cc: linux-scsi@vger.kernel.org
---
Please apply this patch directly if you want to be involved in
Signed-off-by: Geert Uytterhoeven
---
drivers/scsi/aic7xxx_old/aic7xxx.seq |2 +-
drivers/scsi/scsi_error.c|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aic7xxx_old/aic7xxx.seq
b/drivers/scsi/aic7xxx_old/aic7xxx.seq
index 823ff28..dc3bb81
On Tue, Aug 13, 2013 at 6:32 PM, Geert Uytterhoeven
wrote:
> On Fri, 9 Aug 2013, Zach Brown wrote:
>> On Fri, Aug 09, 2013 at 02:26:36PM +0200, Andreas Schwab wrote:
>> > Josef Bacik writes:
>> >
>> > > So stripe_len shouldn't be 0, if it is you h
On Wed, Aug 14, 2013 at 10:40 AM, Geert Uytterhoeven
wrote:
> On Tue, Aug 13, 2013 at 6:32 PM, Geert Uytterhoeven
> wrote:
>> On Fri, 9 Aug 2013, Zach Brown wrote:
>>> On Fri, Aug 09, 2013 at 02:26:36PM +0200, Andreas Schwab wrote:
>>> > Josef Bacik writes:
>
he value
> we currently have for I/O
> timeout.
So you want to replace it by "180 * HZ", which is ... another magic number?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal co
se_hdr - 774+774
proc_keys_show - 770+770
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technica
Hi Hannes,
On Sat, Feb 14, 2015 at 3:29 PM, Hannes Reinecke wrote:
> @jejb, hch: should I do a new patch or update the existing one?
As the existing one is already upstream, you should send a new patch.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoe
Signed-off-by: Geert Uytterhoeven
---
drivers/target/target_core_pr.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c
index e35dbf8..c2e8026 100644
--- a/drivers/target/target_core_pr.c
+++ b/driv
_unregister(&amiga_a3000_scsi_driver);
>> -}
>> -module_exit(amiga_a3000_scsi_exit);
>> +module_platform_driver_probe(amiga_a3000_scsi_driver,
>> amiga_a3000_scsi_probe);
>>
>> MODULE_DESCRIPTION("Amiga 3000 built-in SCSI");
>> MODULE_LICENSE(&q
Based on Al's changes to atari_scsi.
Signed-off-by: Geert Uytterhoeven
---
http://kisskb.ellerman.id.au/kisskb/buildresult/8543326/
drivers/scsi/sun3_NCR5380.c | 185 ++
drivers/scsi/sun3_scsi.c|2 +-
drivers/scsi/sun3_scsi.h|2
Signed-off-by: Geert Uytterhoeven
---
drivers/scsi/sun3_scsi.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/sun3_scsi.c b/drivers/scsi/sun3_scsi.c
index 6e25889..b0dc034 100644
--- a/drivers/scsi/sun3_scsi.c
+++ b/drivers/scsi/sun3_scsi.c
@@ -626,6 +626,7
Ping?
Now the build failure is also in Linus' tree:
http://kisskb.ellerman.id.au/kisskb/buildresult/8674437/
BTW, this patch depends on "[PATCH 1/2] sun3_scsi: Fill in missing
scsi_host_template.proc_info method"
On Wed, Apr 10, 2013 at 1:52 PM, Geert Uytterhoeven
wrote:
,
0, NULL, (u8 *)header_digest);
and
pr_debug("Built Reject PDU StatSN: 0x%08x, Reason: 0x%02x,"
" CID: %hu\n", ntohl(hdr->statsn), hdr->reason, conn->cid);
Gr{oetje,eeting}s,
Geert
--
Make the "buf" input param of iscsit_do_crypto_hash_buf() "const void *".
This allows to remove lots of casts in its callers.
Signed-off-by: Geert Uytterhoeven
---
drivers/target/iscsi/iscsi_target.c | 57 ++-
1 files changed, 23 inserti
On Fri, May 3, 2013 at 11:15 PM, Geert Uytterhoeven
wrote:
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -3585,9 +3575,8 @@ static int iscsit_send_reject(
> }
>
> if (conn->
use u8 data_crc[ISCSI_DIGEST_SIZE] and
> pad_bytes[ISCSI_PAD_LEN] now, and will post a patch soon.
That's another good idea.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In per
fs/ufshcd.c:1498: undefined reference to `scsi_dma_unmap'
drivers/built-in.o: In function `ufshcd_device_reset':
drivers/scsi/ufs/ufshcd.c:1436: undefined reference to `scsi_dma_unmap'
Signed-off-by: Geert Uytterhoeven
Cc: Vinayak Holikatti
Cc: James E.J. Bottomley
Cc: linux-sc
On Thu, May 2, 2013 at 8:30 AM, Jingoo Han wrote:
> This patch uses module_platform_driver_probe() macro which makes
> the code smaller and simpler.
>
> Acked-by: Geert Uytterhoeven
> Signed-off-by: Jingoo Han
James, will you take this one? Or shall I queue it in the m68k tree?
jiffies, end);
And a similar loop for "Busy-wait for up to 20 ms".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalis
Hi Finn,
On Sun, Nov 29, 2015 at 11:25 AM, Finn Thain wrote:
> On Sun, 29 Nov 2015, Geert Uytterhoeven wrote:
>> This still heavily depends on the processing time spent in
>> NCR5380_read(). You should never use a value derived from
>> loops_per_jiffy for a non-empty loop,
hould appear on the next line where it is more visible.
And adding a cpu_relax() to the empty loop body is another good visual cue.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations
f you store the number of accesses per jiffy
instead of per ms.
Unlike the historical calibrating-delay-loop code, you don't wait for a jiffy
change before starting the calibration. At first I thought that was OK, but on
some platforms, HZ can be as low as 24, which means the result can vary by
shost_printk(KERN_ERR, instance,
@@ -1297,10 +1293,6 @@ static struct scsi_cmnd *NCR5380_select(struct
Scsi_Host *instance,
spin_lock_irq(&hostdata->lock);
- /* NCR5380_reselect() clears MODE_REG after a reselection interrupt */
- if (!(NCR5380_read(MODE_REG) &a
Hi Finn,
On Mon, Jan 25, 2016 at 3:45 AM, Finn Thain wrote:
> On Sun, 24 Jan 2016, Geert Uytterhoeven wrote:
>> On Sun, Jan 3, 2016 at 6:05 AM, Finn Thain
>> wrote:
>> > Allow target selection to fail with a timeout instead of waiting in
>> > infinite l
Hi Finn,
On Tue, Jan 26, 2016 at 1:18 AM, Finn Thain wrote:
> On Mon, 25 Jan 2016, Geert Uytterhoeven wrote:
>> > In principle I think that Linux drivers should not carry workarounds
>> > for emulators.
>>
>> Please consider ARAnyM is the current m68k workhorse,
On Mon, Nov 2, 2015 at 12:26 PM, Geert Uytterhoeven
wrote:
> JFYI, when comparing v4.3[1] to v4.3-rc7[3], the summaries are:
> - build errors: +4/-7
+ /home/kisskb/slave/src/drivers/scsi/advansys.c: error: implicit
declaration of function 'free_dma'
[-Werror=implicit-func
Its last user was removed 10 years ago, in commit
8b05b773b6030de5 ("[SCSI] convert st to use scsi_execute_async").
Signed-off-by: Geert Uytterhoeven
---
drivers/scsi/st.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/st.h b/drivers/scsi/st.h
index b6486b
warning on all big endian
platforms.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists
oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
On Wed, 24 Oct 2007, Adrian Bunk wrote:
> This patch does some additional cleanups after the 53c7xx removal.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
> ---
>
> Documentation/dontdiff|2
On Wed, 24 Oct 2007, Adrian Bunk wrote:
> After the APUS removal, some code can be removed.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
> ---
>
> arch/m68k/amiga/chipram.c |2
> drivers/i
u32 _padding; /* align to quadword boundary */
> + u32 _padding[128/4 - 3];/* align to biggest cache line size */
^
(128 - sizeof(struct hpc_dma_desc))/4?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- T
todate, num_sectors)) {
> - add_disk_randomness(req->rq_disk);
> - blkdev_dequeue_request(req);
> - end_that_request_last(req, uptodate);
> - }
> + __blk_end_request(req, uptodate, num_sectors << 9);
^
With kind regards,
Geert Uytterhoeven
S
river or
> are you looking for anybody who has a packed 'wait_queue_head_t' and
> submitting a patch to fix it?
Alpha is little endian.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [EMAIL P
rs and has
hardware to test (some of) them? I don't think we can afford losing one
third of our SCSI drivers...
You can use the following as guidance:
commit 5ff263667798946abc15314eae3f341345877d7a
Author: Thomas Bogendoerfer <[EMAIL PROTECTED]>
Date: Tue May 22 17:03:44 2007 -0700
[SCSI] jazz_esp: Converted to
On Thu, 3 Jan 2008, David Miller wrote:
> From: Geert Uytterhoeven <[EMAIL PROTECTED]>
> > On Thu, 3 Jan 2008, James Bottomley wrote:
> > > On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote:
> > > > As recommended by Christoph Hellwig. There is no use
>
;ses->sg_table, sizeof(scmd->sg_table));
> scmd->resid = ses->resid;
> scmd->result = ses->result;
> }
> diff --git a/include/scsi/scsi_eh.h b/include/scsi/scsi_eh.h
> index d21b891..d43dc83 100644
> --- a/include/scsi/scsi_eh.h
> +++ b/incl
find where it handles conversion from CD data frame sizes to
512-byte sectors.
Am I missing something?
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone:+32 (0)
should be using
> > scsi_execute_async(), what's the actual problem use case?
> >
>
> The problem case is a SCSI Target Mode engine that receives a 2048 Byte
> single sector ATAPI READ_10 request from the storage fabric, and uses
> scsi_execute_async() (the only op
On Thu, 31 Jan 2008, James Bottomley wrote:
> On Thu, 2008-01-31 at 18:41 +0100, Geert Uytterhoeven wrote:
> > James, do you have any comment about the first email in this thread,
> > increasing
> > scsi_host_template.max_sectors?
>
> Assuming your BOUNCE_SIZE is in
s was allowed to be calcuated in non 512 byte sectors,
> so please disregard my patch.
>
> Geert, .max_sectors for ps3rom.c using 512 byte sectors ends up being
> 128, yes.?
Yes.
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and Software Technology Center Europe
On Thu, 31 Jan 2008, James Bottomley wrote:
> On Mon, 2008-01-07 at 07:07 +0100, Kars de Jong wrote:
> > On do, 2008-01-03 at 20:05 +0100, Geert Uytterhoeven wrote:
> > > On Thu, 3 Jan 2008, James Bottomley wrote:
> > > > On Thu, 2008-01-03 at 17:40 +0200, Bo
ds CPU hotplug.
Thank you for giving an exhaustive list of classes of machines Linux runs on!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [EMAIL PROTECTED]
In personal conversations with technic
s used, which limited
/sys/block/sr0/queue/max_sectors_kb to 16 KiB (32 sectors).
Signed-off-by: Aegis Lin <[EMAIL PROTECTED]>
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
drivers/scsi/ps3rom.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/s
iller <[EMAIL PROTECTED]>
> > Christoph Hellwig <[EMAIL PROTECTED]>
>
> Not immediately ... I anticipate a few "where'd my driver go?" type
> questions from m68k for which this provides a useful reference to point
> to ...
Don't bother, we'
should be unsigned
int, too.
Signed-off-by: Geert Uytterhoeven
---
drivers/scsi/sd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 5693f6d7eddb..d6645c70cceb 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1607
Many error messages have been added since Linux-0.99.12 (August 14, 1993)
Signed-off-by: Geert Uytterhoeven
---
drivers/scsi/Kconfig |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index fe25677a5511..8024add2375f 100644
gt;
> //
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
>
> //
>
> Signed-off-by
uggest making core_alua_state_nonoptimized() return void, too.
Currently it always returns zero.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. Bu
ntainers can
take them if they prefer, which apparently already happened for 01/16.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm
f-by: Arnd Bergmann
> Acked-by: Michael Schmitz
> Cc: Geert Uytterhoeven
> Cc: James E.J. Bottomley
> Cc: linux-scsi@vger.kernel.org
Thanks, applied with original authorship attribution, original subject
matching SCSI oneline summary style, and proper SoB.
Will queue for 3.15
On Wed, 4 Jul 2007, Geert Uytterhoeven wrote:
> This is the fourth submission of the new PS3 storage drivers:
> [1] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver
> [2] ps3: Storage Driver Core
> [3] ps3: Storage device registration routines.
> [4] ps
On Fri, 13 Jul 2007, Jens Axboe wrote:
> On Fri, Jul 13 2007, James Bottomley wrote:
> > On Wed, 2007-07-04 at 15:22 +0200, Geert Uytterhoeven wrote:
> > > + kaddr = kmap_atomic(sgpnt->page, KM_USER0);
> > > +
On Fri, 13 Jul 2007, James Bottomley wrote:
> On Fri, 2007-07-13 at 15:25 +0200, Geert Uytterhoeven wrote:
> > kmap() just returns page_address() on ppc64, as there's no highmem.
> > kunmap() is a no-op.
>
> > So technically I could just use page_address() direc
Debian
etch/lenny/sid) and kernel 2.6.22-g77320894.
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone:+32 (0)2 700 8453
Fax: +32 (0)2 700 8622
On Tue, 10 Jul 2007, Geert Uytterhoeven wrote:
> On Wed, 4 Jul 2007, Geert Uytterhoeven wrote:
> > This is the fourth submission of the new PS3 storage drivers:
> > [1] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver
> > [2] ps3: Storage Driver Core
&
sh_kernel_dcache_page()?
`git grep' finds it in the following files only:
Documentation/cachetlb.txt
arch/parisc/kernel/cache.c
arch/parisc/kernel/pacache.S
include/asm-parisc/cacheflush.h
include/linux/highmem.h
With kind regards,
Geert Uytterhoeven
Software Architect
Son
On Fri, 13 Jul 2007, James Bottomley wrote:
> On Fri, 2007-07-13 at 17:10 +0200, Geert Uytterhoeven wrote:
> > On Fri, 13 Jul 2007, Arnd Bergmann wrote:
> > > On Friday 13 July 2007, James Bottomley wrote:
> > > > > IC.
> > > > >
> > &
On Fri, 13 Jul 2007, Geert Uytterhoeven wrote:
> Ah, that explains it. flush_dcache_page() is used in some drivers.
> I'll update my patches. Thanks for the comments!
Does this look OK?
- Replaced KM_USER0 by KM_IRQ0 (all routines are either called from an
interrupt ha
On Mon, 16 Jul 2007, Jens Axboe wrote:
> On Mon, Jul 16 2007, Geert Uytterhoeven wrote:
> > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote:
> > > Ah, that explains it. flush_dcache_page() is used in some drivers.
> > > I'll update my patches. Thanks for the comm
On Mon, 16 Jul 2007, Geert Uytterhoeven wrote:
> On Mon, 16 Jul 2007, Jens Axboe wrote:
> > On Mon, Jul 16 2007, Geert Uytterhoeven wrote:
> > > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote:
> > > > Ah, that explains it. flush_dcache_page() is used in some drivers.
On Mon, 16 Jul 2007, Jens Axboe wrote:
> On Mon, Jul 16 2007, James Bottomley wrote:
> > On Mon, 2007-07-16 at 14:16 +0200, Jens Axboe wrote:
> > > On Mon, Jul 16 2007, Geert Uytterhoeven wrote:
> > > > On Fri, 13 Jul 2007, Geert Uytterhoeven wrote:
e the kmap updates, as
requested by Jens Axboe and James E.J. Bottomley.
I didn't hear anything from the misc device maintainer (for the FLASH ROM
Storage Driver).
Paulus, please apply. Thanks in advance!
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and Soft
From: Geert Uytterhoeven <[EMAIL PROTECTED]>
Add a FLASH ROM Storage Driver for the PS3:
- Implemented as a misc character device driver
- Uses a fixed 256 KiB buffer allocated from boot memory as the hypervisor
requires the writing of aligned 256 KiB blocks
CC: Geoff Levand &
From: Geert Uytterhoeven <[EMAIL PROTECTED]>
Add a Disk Storage Driver for the PS3:
- Implemented as a block device driver with a dynamic major
- Disk names (and partitions) are of the format ps3d%c(%u)
- Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor
d
From: Geert Uytterhoeven <[EMAIL PROTECTED]>
Add a BD/DVD/CD-ROM Storage Driver for the PS3:
- Implemented as a SCSI device driver
- Uses software scatter-gather with a 64 KiB bounce buffer as the hypervisor
doesn't support scatter-gather
CC: Geoff Levand <[EMAIL PROTECTE
Don't define an empty struct bsg_class_device if !CONFIG_BLK_DEV_BSG.
It's embedded in struct request_queue, but there we have
#if defined(CONFIG_BLK_DEV_BSG)
struct bsg_class_device bsg_dev;
#endif
anyway.
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
At fi
On Wed, 18 Jul 2007, Jan Engelhardt wrote:
> On Jul 16 2007 18:15, Geert Uytterhoeven wrote:
> >Add a Disk Storage Driver for the PS3:
> > - Implemented as a block device driver with a dynamic major
> > - Disk names (and partitions) are of the format ps3d%c(%u)
> &g
v->bounce_buf+offset, buf, size);
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone:+32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: [EMA
On Thu, 19 Jul 2007, Jens Axboe wrote:
> On Wed, Jul 18 2007, Andrew Morton wrote:
> > On Mon, 16 Jul 2007 18:15:40 +0200
> > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
> >
> > > From: Geert Uytterhoeven <[EMAIL PROTECTED]>
> > >
> &g
Hi Andrew,
On Wed, 18 Jul 2007, Andrew Morton wrote:
> On Mon, 16 Jul 2007 18:15:40 +0200
> Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
>
> > From: Geert Uytterhoeven <[EMAIL PROTECTED]>
> >
> > Add a Disk Storage Driver for the PS3:
>
> Y
least. If it can fail on any other
> arch then we have a biiiiig problem. (Multiple instances of this)
Thanks, fixed!
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zave
On Thu, 19 Jul 2007, Cornelia Huck wrote:
> On Thu, 19 Jul 2007 10:57:53 +0200 (CEST),
> Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
>
> > Were .probe()/.remove() made concurrent again? I thought that idea was
> > dropped
> > because it caused too many proble
On Thu, 19 Jul 2007, Andrew Morton wrote:
> On Thu, 19 Jul 2007 11:02:07 +0200 (CEST) Geert Uytterhoeven <[EMAIL
> PROTECTED]> wrote:
>
> > On Wed, 18 Jul 2007, Andrew Morton wrote:
> > > > +struct ps3rom_private {
> > > > + struct ps3_storage_
deeply-embedded return points in this function.
Will change to `goto fail' and common error return.
> > + if (*pos+count > size) {
>
> checkpatch missed stuff here.
Checkpatch is silent...
> > + dev_dbg(&dev->sbd.core,
> > +
On Thu, 19 Jul 2007, Cornelia Huck wrote:
> On Thu, 19 Jul 2007 11:36:31 +0200 (CEST),
> Geert Uytterhoeven <[EMAIL PROTECTED]> wrote:
>
> > We have a probe thread that checks for new storage devices and adds them to
> > the
> > bus with ps3_system_b
Hi Andrew,
On Thu, 19 Jul 2007, Andrew Morton wrote:
> On Thu, 19 Jul 2007 10:57:53 +0200 (CEST) Geert Uytterhoeven <[EMAIL
> PROTECTED]> wrote:
> > On Wed, 18 Jul 2007, Andrew Morton wrote:
> > > Your patchset significantly hits powerpc, scsi and block. So w
ps3disk: use correct bio vector size
This fixes the O_DIRECT corruptions, as reported by Olaf Hering (triggered by
e.g. parted >= 1.8.0).
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
drivers/block/ps3disk.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
---
mask
o Minor coding style fixes not reported by checkpatch
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
drivers/block/ps3disk.c | 44 +---
1 files changed, 25 insertions(+), 19 deletions(-)
--- a/drivers/block/ps3disk.c
+++ b/drivers/blo
ps3rom: updates after final review:
o Kill confusing ps3rom_priv() macro, open code it instead
o kmap_atomic() cannot fail
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
drivers/scsi/ps3rom.c | 15 +--
1 files changed, 5 insertions(+), 10 deletions(-)
--- a/d
fixes not reported by checkpatch
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
drivers/char/ps3flash.c | 59
1 files changed, 35 insertions(+), 24 deletions(-)
--- a/drivers/char/ps3flash.c
+++ b/drivers/char/ps3flash.c
@@ -34,7
driver still compiles on MIPS (CONFIG_SGIWD93_SCSI=y)
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
drivers/scsi/wd33c93.c |2 ++
1 file changed, 2 insertions(+)
--- a/drivers/scsi/wd33c93.c
+++ b/drivers/scsi/wd33c93.c
@@ -89,6 +89,8 @@
#include
#include
+#include
On Fri, 20 Jul 2007, James Bottomley wrote:
> On Fri, 2007-07-20 at 18:40 +0200, Geert Uytterhoeven wrote:
> > plain text document attachment (m68k-wd33c93-needs-asm-irq.diff)
> > wd33c93 SCSI needs on m68k
> >
> > drivers/scsi/wd33c93.c: In function 'wd33c
is converts ps3rom driver to use the new accessors for the sg lists
> and the parameters.
>
> Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]>
Acked-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and
1 - 100 of 239 matches
Mail list logo
