Re: [PATCH v3 17/20] usb: gadget: pch_udc: Replace PCI pool old API

Fine by me: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH net-next 4/5] treewide: replace dev->trans_start update with helper

t; Cc: linux-blueto...@vger.kernel.org > Signed-off-by: Florian Westphal > --- for u_ether.c: Acked-by: Felipe Balbi > diff --git a/drivers/usb/gadget/function/u_ether.c > b/drivers/usb/gadget/function/u_ether.c > index 637809e..a3f7e7c 100644 > --- a/drivers/usb/gadget/fun

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

m within its callbacks, which may be called during the musb > device probing. > > Signed-off-by: Russell King you want me to carry this one through my tree or you prefer getting my Acked-by ? Either way works for me: Acked-by: Felipe Balbi there's also the third option of me set

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

Hi, On Fri, Sep 20, 2013 at 02:49:38PM +0100, Russell King - ARM Linux wrote: > On Fri, Sep 20, 2013 at 08:11:25AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Fri, Sep 20, 2013 at 12:14:38AM +0100, Russell King wrote: > > > Use platform_device_register_full() f

Re: SYSFS "errors"

Hi, On Mon, Feb 18, 2013 at 09:49:16AM -0800, Greg KH wrote: > > Input/output error - /sys/devices/cpu/power/autosuspend_delay_ms > > The issue with this file is, if the power.use_autosuspend flag is not > set for the device, then it can't be read or written to. This flag > changes dynamically wi

Re: SYSFS "errors"

Hi, On Mon, Feb 18, 2013 at 04:46:38PM -0300, Mauro Carvalho Chehab wrote: > > > > No such device - /sys/devices/system/edac/mc/mc0/sdram_scrub_rate > > > > > > Odd, go ask the edac developers > > > > will do ;-) > > Well, the question is missing ;) /me assumes that you want to talk about > sus

Re: SYSFS "errors"

On Mon, Feb 18, 2013 at 04:48:06PM -0500, Alan Stern wrote: > On Mon, 18 Feb 2013, Felipe Balbi wrote: > > > Hi, On Mon, Feb 18, 2013 at 09:49:16AM -0800, Greg KH wrote: > > > > Input/output error - /sys/devices/cpu/power/autosuspend_delay_ms > > > > >

Re: SYSFS "errors"

Hi, On Tue, Feb 19, 2013 at 07:03:10AM -0300, Mauro Carvalho Chehab wrote: > > But my gut feeling says to stay concervative and not touch this code - > > we don't know what uses it and how much we would break by "fixing" it. > > The current situation is not that big of a deal IMVHO and I'd be will

Re: SYSFS "errors"

On Tue, Feb 19, 2013 at 02:06:26PM +0100, Borislav Petkov wrote: > On Tue, Feb 19, 2013 at 09:46:40AM -0300, Mauro Carvalho Chehab wrote: > > Ah, now I see what you're meaning. That would require to dynamically > > create a per-mci DEVICE_ATTR(). > > Dude, look at the code, we do that already. And

Re: SYSFS "errors"

Hi, On Tue, Feb 19, 2013 at 02:28:54PM +0100, Borislav Petkov wrote: > On Tue, Feb 19, 2013 at 03:15:00PM +0200, Felipe Balbi wrote: > > what's the problem with that ? > > Not a problem - simply annoying. > > $ ./test.sh > cat: /path/to/file/that/doesnt/exist.t

Re: SYSFS "errors"

Hi, On Tue, Feb 19, 2013 at 11:14:40AM -0300, Mauro Carvalho Chehab wrote: > > Please consider adding a default attribute which return '-EINVAL' or > > somesuch when the function pointers are not set. > > But _not_ adding it via device_create_file(). That's evil. > > This thread started with Fel

Re: SYSFS "errors"

On Tue, Feb 19, 2013 at 11:35:21AM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 19 Feb 2013 14:50:56 +0100 > Borislav Petkov escreveu: > > > On Tue, Feb 19, 2013 at 03:38:09PM +0200, Felipe Balbi wrote: > > > because changing the permission will cause the same issue: &

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

Hi, On Thu, Feb 27, 2014 at 11:14:05AM -0700, Loc Ho wrote: > This patch adds function set_speed to the generic PHY framework operation > structure. This function can be called to instruct the PHY underlying layer > at specified lane to configure for specified speed in hertz. why ? looks like clk

Re: [PATCH v12 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

Hi, On Thu, Feb 27, 2014 at 11:14:07AM -0700, Loc Ho wrote: > +/* > + * This function is used to configure the PHY to operation as either SATA > Gen1 > + * or Gen2 speed. > + */ > +static void xgene_phy_sata_force_gen(struct xgene_phy_ctx *ctx, > + int lane, int g

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

Hi, On Thu, Feb 27, 2014 at 11:57:44AM -0800, Loc Ho wrote: > > On Thu, Feb 27, 2014 at 11:14:05AM -0700, Loc Ho wrote: > >> This patch adds function set_speed to the generic PHY framework operation > >> structure. This function can be called to instruct the PHY underlying layer > >> at specified

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

Hi, On Thu, Feb 27, 2014 at 01:09:57PM -0800, Loc Ho wrote: > >> >> This patch adds function set_speed to the generic PHY framework > >> >> operation > >> >> structure. This function can be called to instruct the PHY underlying > >> >> layer > >> >> at specified lane to configure for specified s

Re: [PATCH v18 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

On Mon, Apr 28, 2014 at 04:12:02PM -0700, Loc Ho wrote: > Hi Kishon/Felipe, > > > >> This patch adds support for the APM X-Gene SoC AHCI SATA host controller > > >> driver. It requires the corresponding APM X-Gene SoC PHY driver. This > > >> initial version only supports Gen3 speed. > > > > > > Th

Re: [-next PATCH 0/4] sysfs and DEVICE_ATTR_

Hi, Joe Perches writes: > drivers/usb/phy/phy-tahvo.c| 2 +- Acked-by: Felipe Balbi -- balbi

Re: [PATCH/RFC 6/6] Treewide: Remove depends on HAS_DMA in case of platform dependency

cted from > SND_SOC_APQ8016_SBC. > > Signed-off-by: Geert Uytterhoeven for drivers/usb/gadget/: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH/RFC 3/6] usb: gadget: Add NO_DMA dummies for DMA mapping API

hould I take this or is it going with the rest of the series? If you wanna take it through Trivial or something like that: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers

her architectures, compat_ptr() > does not do anything, but using the new generic_compat_ioctl_ptrarg > helper makes it more correct in theory, and simplifies the code. > > Signed-off-by: Arnd Bergmann Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH] Try #3: Use SCSI read/write(16) with > 32-bit LBA drives

Hi, On Wed, Nov 14, 2012 at 08:06:20PM -0500, Jason J. Herne wrote: > On Wed, Nov 14, 2012 at 5:22 PM, Sergei Shtylyov wrote: > > Hello. > > > > > > On 15-11-2012 2:03, Jason J. Herne wrote: > > > >> From: "Jason J. Herne" > > > > > > You have already posted Try #3. And preferrably, informatio

Re: [PATCH] cleanup on stack DECLARE_COMPLETIONs

On Tue, Dec 23, 2014 at 06:34:08PM +0100, Nicholas Mc Guire wrote: > fixups for incorrect use of DECLARE_COMPLETION. see also commit > 6e9a4738 ("completions: lockdep annotate on stack completions") > The only somewhat special case being > drivers/misc/sgi-gru/grukservices.c:quicktest2 > which had

Re: [PATCH 00/26] constify local structures

Hi, Jarkko Sakkinen writes: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: >> >> >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: >> >> > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: >> > > Constify local structures. >> > > >> > > The semantic patch that makes

Re: [PATCH 1/2] Convert target drivers to use sbitmap

ff-by: Matthew Wilcox > --- [...] > drivers/usb/gadget/function/f_tcm.c | 8 +++--- for drivers/usb/gadget/function/f_tcm.c Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 02/15] usb: gadget: make config_item_type structures const

patches into a series. I'm assuming this depends on patch 1 of the series. In that case: Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH v2 07/15] usb: gadget: configfs: make config_item_type const

Bhumika Goyal writes: > Make config_item_type structures const as they are either passed to a > function having the argument as const or stored in the const "ci_type" > field of a config_item structure. > > Done using Coccinelle. > > Signed-off-by: Bhumika