Re: stex driver panic in kernel 2.6.23

2008-01-09 Thread Ed Lin
>On Wed, Oct 24 2007, James Bottomley wrote: >> On Wed, 2007-10-24 at 12:17 -0700, Andrew Morton wrote: >> > On Wed, 24 Oct 2007 11:59:30 -0700 "Ed Lin" <[EMAIL PROTECTED]> wrote: >> > >> > > The shared tag issue was not fixed yet. Kernel

stex driver panic in kernel 2.6.23

2008-01-09 Thread Ed Lin
. Ed Lin Panic 1 Unable to handle kernel NULL pointer dereference at 0038 RIP: [] cfq_remove_request+0x18/0x1ac PGD 1545f067 PUD 233d9067 PMD 0 Oops: [1] SMP CPU 1 Modules linked in: e1000 stex ata_piix libata Pid: 80, comm: kblockd/1 Not tainted 2.6.23 #2 RIP: 0010

[patch] scsi: use lock per host instead of per device for shared queue tag host

2007-01-23 Thread Ed Lin
blk_queue_end_tag of ll_rw_blk.c) when accessing different devices simultaneously (e.g. copying big file from one device to another in smp kernels). This is against kernel 2.6.20-rc5. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- drivers/scsi/scsi_lib.c |2 +- drivers/scsi/

RE: [patch] scsi: use lock per host instead of per device for shared queue tag host

2007-01-24 Thread Ed Lin
> -Original Message- > From: Michael Reed [mailto:[EMAIL PROTECTED] > Sent: Wednesday, January 24, 2007 7:59 AM > To: Ed Lin > Cc: linux-scsi; linux-kernel; james.Bottomley; jeff; Promise_Linux > Subject: Re: [patch] scsi: use lock per host instead of per > device

RE: [patch] scsi: use lock per host instead of per device for shared queue tag host

2007-01-24 Thread Ed Lin
> -Original Message- > From: David Somayajulu [mailto:[EMAIL PROTECTED] > Sent: Wednesday, January 24, 2007 5:03 PM > To: Ed Lin; Michael Reed > Cc: linux-scsi; linux-kernel; james.Bottomley; jeff; > Promise_Linux; Jens Axboe > Subject: RE: [patch] scsi: use loc

RE: [patch] scsi: use lock per host instead of per device forshared queue tag host

2007-01-24 Thread Ed Lin
> -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Wednesday, January 24, 2007 9:00 AM > To: Ed Lin > Cc: linux-scsi; linux-kernel; jeff; Promise_Linux > Subject: Re: [patch] scsi: use lock per host instead of per > device for

RE: [patch] scsi: use lock per host instead of per device for shared queue tag host

2007-01-25 Thread Ed Lin
> -Original Message- > From: Jens Axboe [mailto:[EMAIL PROTECTED] > Sent: Thursday, January 25, 2007 7:48 AM > To: Ed Lin > Cc: David Somayajulu; Michael Reed; linux-scsi; linux-kernel; > james.Bottomley; jeff; Promise_Linux > Subject: Re: [patch] scsi: use lock pe

[PATCH 1/4] [SCSI]stex: fix id mapping issue

2007-03-30 Thread Ed Lin
ber of 128. The RAID console only interfaces to scsi mid layer and is always mapped at channel:0, id:16, lun:0. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 69be132..4d68533 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.

[PATCH 3/4] [SCSI]stex: fix reset recovery for console device

2007-03-30 Thread Ed Lin
This will make the console to be offlined right after reset. Add the handling in driver to fix this problem. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 1e8d7ac..9465f35 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/

[PATCH 2/4] [SCSI]stex: extend hard reset wait time

2007-03-30 Thread Ed Lin
During hard bus reset of st_shasta controllers, 1 ms is not enough for 16-port controllers, although it's good for 8-port controllers. Extend the wait time to 100 ms to allow bus resets finish successfully. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.

[PATCH 4/4] [SCSI]stex: minor cleanup and version update

2007-03-30 Thread Ed Lin
Add debug information into abort and host_reset routine. Change ioremap to ioremap_nocache. Version updated to 3.6..1. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 9465f35..5a10cfa 100644 --- a/drivers/scsi/stex.c +++ b/d

RE: [PATCH 1/4] [SCSI]stex: fix id mapping issue

2007-04-02 Thread Ed Lin
> -Original Message- > From: Christoph Hellwig [mailto:[EMAIL PROTECTED] > Sent: Saturday, March 31, 2007 2:27 AM > To: Ed Lin > Cc: linux-scsi; linux-kernel; james.Bottomley; jeff; Promise_Linux > Subject: Re: [PATCH 1/4] [SCSI]stex: fix id mapping issue > > &

RE: [PATCH 1/4] [SCSI]stex: fix id mapping issue

2007-04-02 Thread Ed Lin
> -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Saturday, March 31, 2007 7:22 AM > To: Ed Lin > Cc: linux-scsi; linux-kernel; jeff; Promise_Linux > Subject: Re: [PATCH 1/4] [SCSI]stex: fix id mapping issue > > > On Fri, 2007-0

RE: [PATCH 3/4] [SCSI]stex: fix reset recovery for console device

2007-04-02 Thread Ed Lin
> -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Saturday, March 31, 2007 11:46 AM > To: Ed Lin > Cc: linux-scsi; linux-kernel; jeff; Promise_Linux > Subject: Re: [PATCH 3/4] [SCSI]stex: fix reset recovery for > console device > &g

RE: [PATCH 4/4] [SCSI]stex: minor cleanup and version update

2007-04-02 Thread Ed Lin
> -Original Message- > From: Brian King [mailto:[EMAIL PROTECTED] > Sent: Monday, April 02, 2007 9:05 AM > To: Ed Lin > Cc: linux-scsi; linux-kernel; james.Bottomley; jeff; Promise_Linux > Subject: Re: [PATCH 4/4] [SCSI]stex: minor cleanup and version update &g

RE: [PATCH 1/4] [SCSI]stex: fix id mapping issue

2007-04-02 Thread Ed Lin
> -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Saturday, March 31, 2007 7:22 AM > To: Ed Lin > Cc: linux-scsi; linux-kernel; jeff; Promise_Linux > Subject: Re: [PATCH 1/4] [SCSI]stex: fix id mapping issue > > > On Fri, 2007-0

RE: [PATCH 3/4] [SCSI]stex: fix reset recovery for console device

2007-04-02 Thread Ed Lin
> -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Monday, April 02, 2007 11:28 AM > To: Ed Lin > Cc: linux-scsi; linux-kernel; jeff; Promise_Linux > Subject: RE: [PATCH 3/4] [SCSI]stex: fix reset recovery for > console device > &g

RE: [PATCH 1/4] [SCSI]stex: fix id mapping issue

2007-04-04 Thread Ed Lin
> -Original Message- > From: Ed Lin > Sent: Monday, April 02, 2007 4:01 PM > To: 'James Bottomley' > Cc: linux-scsi; linux-kernel; jeff; Promise_Linux > Subject: RE: [PATCH 1/4] [SCSI]stex: fix id mapping issue > > > > > > -Original

RE: [PATCH 3/4] [SCSI]stex: fix reset recovery for console device

2007-04-04 Thread Ed Lin
> -Original Message- > From: Ed Lin > Sent: Monday, April 02, 2007 4:02 PM > To: James Bottomley > Cc: linux-scsi; linux-kernel; jeff; Promise_Linux > Subject: RE: [PATCH 3/4] [SCSI]stex: fix reset recovery for > console device > > > > > > ---

RE: [PATCH 1/4] [SCSI]stex: fix id mapping issue

2007-04-04 Thread Ed Lin
> -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Wednesday, April 04, 2007 10:36 AM > To: Ed Lin > Cc: linux-scsi; linux-kernel; jeff; Promise_Linux > Subject: RE: [PATCH 1/4] [SCSI]stex: fix id mapping issue > > > On Wed, 20

[PATCH 1/4] stex: fix id mapping issue(v3)

2007-04-04 Thread Ed Lin
be ignored/skipped in no circumstances, we report that the max_id for LD is 128, then when commands are sent out by scsi mid layer, we map id/lun pair based on controller type. Please consider the situation, and apply the patch. Thanks. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --gi

RE: [PATCH 1/4] stex: fix id mapping issue(v3)

2007-04-16 Thread Ed Lin
> -Original Message- > From: James Bottomley [mailto:[EMAIL PROTECTED] > Sent: Thursday, April 05, 2007 6:58 AM > To: Christoph Hellwig > Cc: Ed Lin; linux-scsi; jeff; Promise_Linux > Subject: Re: [PATCH 1/4] stex: fix id mapping issue(v3) > > > On Thu

[PATCH 1/4] stex: fix id mapping issue

2007-05-09 Thread Ed Lin
handling of REPORT_LUNS command for st_yosemite, as there is no translation mapping now Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c index ce63044..18dd5cc 100644 --- a/drivers/scsi/scsi_devinfo.c +++ b/driver

[PATCH 2/4] stex: extend hard reset wait time

2007-05-09 Thread Ed Lin
During hard bus reset of st_shasta controllers, 1 ms is not enough for 16-port controllers, although it's good for 8-port controllers. Extend the wait time to 100 ms to allow bus resets finish successfully. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/sc

[PATCH 3/4] stex: fix reset recovery for console device

2007-05-09 Thread Ed Lin
console to be offlined right after reset. Add the handling in driver to fix this problem. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 81dd3b7..47c2ef9 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @

[PATCH 4/4] stex: minor cleanup and version update

2007-05-09 Thread Ed Lin
Add debug information into abort and host_reset routine. Change ioremap to ioremap_nocache. Version updated to 3.6..1. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 47c2ef9..9ac83ab 100644 --- a/drivers/scsi/stex.c +++ b/d

RE: [PATCH 3/3] Farther clean up of stex.c driver

2007-06-14 Thread Ed Lin
> -Original Message- > From: Boaz Harrosh [mailto:[EMAIL PROTECTED] > Sent: Thursday, June 14, 2007 9:34 AM > To: FUJITA Tomonori; Ed Lin; Guennadi Liakhovetski > Cc: linux-scsi@vger.kernel.org > Subject: Re: [PATCH 3/3] Farther clean up of stex.c d

RE: [PATCH 3/3] Farther clean up of stex.c driver

2007-06-14 Thread Ed Lin
> -Original Message- > From: FUJITA Tomonori [mailto:[EMAIL PROTECTED] > Sent: Thursday, June 14, 2007 3:21 PM > To: Ed Lin > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; linux-scsi@vger.kernel.org > Subject: RE: [PATCH 3/3] Farther clea

[PATCH] stex: use resid for xfer len information

2007-07-05 Thread Ed Lin
The original implementation in stex_ys_commands() is inappropriate. For xfer len information, we should use resid instead. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index adda296..72f6d80 100644 --- a/drivers/scsi/stex.c +++ b/d

RE: [PATCH 1/2] stex: stex_direct_copy shouldn't call dma_map_sg

2008-02-22 Thread Ed Lin
>-Original Message- >From: fujita [mailto:[EMAIL PROTECTED] On Behalf Of FUJITA Tomonori >Sent: Friday, February 22, 2008 6:11 AM >To: linux-scsi@vger.kernel.org >Cc: FUJITA Tomonori; Ed Lin; James Bottomley >Subject: [PATCH 1/2] stex: stex_direct_copy shouldn

[PATCH 5/8] stex: update device id info

2006-12-01 Thread Ed Lin
Update pci device id and Kconfig help information. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 1301d52..fb55373 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -968,8 +968,16 @@ config SCSI_STEX tr

[PATCH 4/8] stex: adjust default queue length

2006-12-01 Thread Ed Lin
Firmware of new version may adjust default queue length. It is backward compatible. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 92dbac0..a20cbd9 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -78,6 +78,7 @

[PATCH 7/8] stex: version update

2006-12-01 Thread Ed Lin
Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index ce7edf5..9cbc047 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -11,8 +11,6 @@ * Written By: * Ed Lin <[EMAIL PROTECTED]> * - * Vers

[PATCH 3/8] stex: add value check in hard reset routine

2006-12-01 Thread Ed Lin
During hard reset, an all-1 value from PCI_COMMAND should be invalid. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index ea0d824..92dbac0 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -1041,7 +1041,7 @@ stati

[PATCH 1/8] stex: fix biosparam calculation

2006-12-01 Thread Ed Lin
Fix biosparam calculation. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 185c270..91d484c 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -1100,18 +1100,18 @@ static int stex_reset(struct scsi_cmnd * stat

[PATCH 8/8] stex: change wait loop code

2006-12-01 Thread Ed Lin
The original wait loop may be much longer than intended time. Use more accurate timer_after for it. Also adjust wait value to avoid unnecessary long waiting. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 9cbc047..df35e91 100644

[PATCH 6/8] stex: add new device type support

2006-12-01 Thread Ed Lin
Add support for st_vsc1 type device (st_vsc0 is ok because it does not require extra buffer). Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index c4ee038..ce7edf5 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -152,6

[PATCH 2/8] stex: fix controller_info command handling

2006-12-01 Thread Ed Lin
This command needs information from both firmware and driver. First copy information from firmware to buffer, then fill in driver information. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 91d484c..ea0d824 100644 --- a/driver

Re: [PATCH 5/8] stex: update device id info

2006-12-04 Thread Ed Lin
>-Original Message- >From: Jeff Garzik [mailto:[EMAIL PROTECTED] >Sent: Friday, December 01, 2006 9:10 PM >To: Ed Lin >Cc: linux-scsi; James.Bottomley; Promise_Linux >Subject: Re: [PATCH 5/8] stex: update device id info > > >Ed Lin wrote: >> Upda

[repost][PATCH 2/8] stex: fix controller_info command handling

2006-12-04 Thread Ed Lin
This command needs information from both firmware and driver. First copy information from firmware to buffer, then fill in driver information. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 91d484c..ea0d824 100644 --- a/driver

[repost][PATCH 6/8] stex: add new device type support

2006-12-04 Thread Ed Lin
Add support for st_vsc1 type device (st_vsc is ok because it does not require extra buffer). Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 0fd115c..bfd7983 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -121,7

[repost][PATCH 4/8] stex: adjust default queue length

2006-12-04 Thread Ed Lin
Firmware of new version may adjust default queue length. It is backward compatible. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 92dbac0..a20cbd9 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -78,6 +78,7 @

[repost][PATCH 3/8] stex: add value check in hard reset routine

2006-12-04 Thread Ed Lin
During hard reset, an all-1 value from PCI_COMMAND should be invalid. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index ea0d824..92dbac0 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -1041,7 +1041,7 @@ stati

[repost][PATCH 1/8] stex: fix biosparam calculation

2006-12-04 Thread Ed Lin
Fix biosparam calculation. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 185c270..91d484c 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -1100,18 +1100,18 @@ static int stex_reset(struct scsi_cmnd * stat

[repost][PATCH 5/8] stex: update device id info

2006-12-04 Thread Ed Lin
- add comments for various devices - remove unused device ids(0xf350, 0x4301, 0x8301, 0x8302) - add new device id(0xe350) - fix vendor id of st_vsc - modify Kconfig help info Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 1

[repost][PATCH 8/8] stex: version update

2006-12-04 Thread Ed Lin
Update version to 3.1.0.1 Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 7edbcc9..ba6bcda 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c @@ -11,8 +11,6 @@ * Written By: * Ed Lin <[EMAIL

[repost][PATCH 7/8] stex: change wait loop code

2006-12-04 Thread Ed Lin
The original wait loop may be much longer than intended time. Use more accurate timer_after for it. Also adjust wait value to avoid unnecessary long waiting. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index bfd7983..7edbcc9 100644