Re: [PATCH] scsi: ufs: Consider device limitations for dma_mask

2019-01-11 Thread Doug Anderson
Hi, On Fri, Jan 11, 2019 at 2:54 PM Bjorn Andersson wrote: > > On Qualcomm SDM845 the capabilities of the UFS MEM controller states > that it's capable of dealing with 64 bit addresses, but DMA addresses > are truncated causing IOMMU faults when trying to issue operations. > > Limit the DMA mask

Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

2019-01-14 Thread Doug Anderson
Hi, On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen wrote: > > > Evan, > > > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that > > this was the only possible PHY driver Qualcomm's UFS controller > > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, > > and ph

Re: [PATCH v4] scsi: ufs: Make sysfs attributes writable

2018-09-25 Thread Doug Anderson
Hi, On Tue, Sep 4, 2018 at 3:29 AM Adrian Hunter wrote: > > On 22/08/18 14:00, Adrian Hunter wrote: > > On 09/08/18 01:44, Evan Green wrote: > >> This change makes the UFS controller's sysfs attributes writable, which > >> will enable users to provision unprovisioned UFS devices, or > >> re-provi

Re: [PATCH v4] scsi: ufs: Make sysfs attributes writable

2018-09-25 Thread Doug Anderson
Martin, On Tue, Sep 25, 2018 at 6:08 PM Martin K. Petersen wrote: > > Doug, > > > I came across this patch and Evan's other one and noticed that they > > haven't been applied though a batch of other SCSI patches for 4.20 > > were applied about a week ago. Martin: is there something about these >

Re: [PATCH 1/1] scsi: ufs: make UFS Tx lane1 clock optional

2018-10-09 Thread Doug Anderson
Hi, On Sun, Oct 7, 2018 at 9:34 PM Can Guo wrote: > > From: Venkat Gopalakrishnan > > The UFS Tx lane1 clock could be muxed, hence keep it optional by ignoring > it if it is not provided in device tree. Thanks for the updated commit message. This makes much more sense now! :-) > @@ -113,10

Re: [PATCH v2 1/1] scsi: ufs: make UFS Tx lane1 clock optional for QCOM platforms

2018-10-11 Thread Doug Anderson
Hi, On Thu, Oct 11, 2018 at 5:33 AM Can Guo wrote: > static int ufs_qcom_host_clk_get(struct device *dev, > - const char *name, struct clk **clk_out) > + const char *name, struct clk **clk_out, bool optional) > { > struct clk *clk; > int err = 0; > >

Re: [PATCH v3 1/1] scsi: ufs: make UFS Tx lane1 clock optional for QCOM platforms

2018-10-12 Thread Doug Anderson
Hi, On Thu, Oct 11, 2018 at 6:12 PM Can Guo wrote: > + if (err != -EPROBE_DEFER) > + dev_err(dev, "failed to get %s err %d", > + name, err); I wouldn't spin just for this, but if you spin for some other reason you could move the above "dev_err" o

Re: [PATCH V14 1/2] scsi: ufs: set the device reference clock setting

2018-10-12 Thread Doug Anderson
Hi, On Sun, Sep 23, 2018 at 11:29 PM Sayali Lokhande wrote: > +static struct ufs_ref_clk ufs_ref_clk_freqs[] = { > + {1920, REF_CLK_FREQ_19_2_MHZ}, > + {2600, REF_CLK_FREQ_26_MHZ}, > + {3840, REF_CLK_FREQ_38_4_MHZ}, > + {5200, REF_CLK_FREQ_52_MHZ}, > +

Re: [PATCH] scsi: ufs: Schedule clk gating work on correct queue

2018-10-17 Thread Doug Anderson
Hi, On Fri, Oct 5, 2018 at 10:28 AM Evan Green wrote: > > With commit 10e5e37581fc ("scsi: ufs: Add clock ungating to a separate > workqueue"), clock gating work was moved to a > separate work queue with WQ_MEM_RECLAIM set, since clock > gating could occur from a memory reclaim context. Unfortuna