>
>
> Hi.
>
> There is a bug with handling of adaptec raid cards (in my case it is Adaptec
> 3405) where kernel logs hundreds of "AAC: Host adapter dead -1"
> messages.
>
> Bug was reported previously on lkml but there was no progres in solving it.
>
> There is also bugzilla entry:
> https://b
.org
Fixes: 78cbccd3bd683c295a44af8050797dc4a41376ff
Reported-by: Arkadiusz Miskiewicz
Signed-off-by: Dave Carroll
Reviewed-by: Raghava Aditya Renukunta
---
drivers/scsi/aacraid/comminit.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aacraid/comminit.c b/drivers/sc
> -Original Message-
> From: Raghava Aditya Renukunta
> [mailto:raghavaaditya.renuku...@microsemi.com]
> Sent: Wednesday, February 22, 2017 8:23 AM
> To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux-
> s...@vger.kernel.org
> Cc: Dave Carroll; Gana S
o check and also the dead-code non-zero case too.
>
> Detected by CoverityScan, CID#1411632 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King
> ---
> drivers/scsi/aacraid/commsup.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
Acked-by: Dave Carroll
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Dan Carpenter
> Sent: Monday, February 27, 2017 8:32 AM
> To: Raghava Aditya Renukunta
> Cc: linux-scsi@vger.kernel.org
> Subject: [bug report] scsi: aacraid: Reorder Adap
rpenter
> Signed-off-by: Raghava Aditya Renukunta
>
> ---
> drivers/scsi/aacraid/src.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Dave Carroll
There are a few windows during AER/EEH when we
can access PCIe I/O mapped registers. This will harden
the access to insure we do not allow PCIe access during errors
Signed-off-by: Dave Carroll
Reviewed-by: Sagar Biradar
---
drivers/scsi/aacraid/aacraid.h | 7 ++-
drivers/scsi/aacraid
ed-off-by: Raghava Aditya Renukunta
>
> ---
> drivers/scsi/aacraid/aacraid.h | 4 +
> drivers/scsi/aacraid/src.c | 167
> +++++++--
> 2 files changed, 163 insertions(+), 8 deletions(-)
Reviewed-by: Dave Carroll
igned-off-by: Prasad B Munirathnam
> Signed-off-by: Raghava Aditya Renukunta
>
> ---
> drivers/scsi/aacraid/src.c | 22 ++++++
> 1 file changed, 22 insertions(+)
>
Reviewed-by: Dave Carroll
the MSIx register and check if
> it indicates command completion, set controller MSIx enabled flag.
>
> Signed-off-by: Prasad B Munirathnam
> Signed-off-by: Raghava Aditya Renukunta
>
> ---
Reviewed-by: Dave Carroll
ix it by returning error from aac_probe_one() when card-specific init
> function
> fails.
>
> This fixes reboot on my HP NetRAID-4M with dead battery.
>
> Signed-off-by: Meelis Roos
Reviewed-by: Dave Carroll
by: Colin Ian King
> ---
> drivers/scsi/aacraid/commctrl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Dave Carroll
-Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
> Sent: Friday, June 23, 2017 7:03 AM
> To: Martin K. Petersen
> Cc: Christoph Hellwig ; James Bottomley
> ; linux-scsi@vger.kernel.org;
> Hannes Reinecke
>
>
> When sending a reset fib we shouldn't rely on the scsi command, but rather set
> the TMF status in the map_info->reset_state variable.
> That allows us to send a TMF independent on a scsi command.
>
> Signed-off-by: Hannes Reinecke
> ---
> /*
> * aac_eh_dev_reset- Device r
>
> Dan,
>
> > "qd.id" comes directly from the copy_from_user() on the line before so
> > we should verify that it's within bounds.
>
> Applied to 4.13/scsi-fixes. Thanks!
>
> --
> Martin K. Petersen Oracle Linux Engineering
Acked-by: Dave Carroll
>
> Dan,
>
> > We're putting a NUL terminator one character beyond the end of the
> > struct and that's obviously wrong. On the other hand, I'm not
> > positive this is the correct fix. This change was added deliberately
> > and was mentioned in the changlog of commit b836439faf04 ("aacraid:
>
> Dave,
>
> > The issue is that we are making an inquiry response from
> > container/RAID info. We could also have included a "pad" byte to
> > terminate the string, as the fib data is 512 bytes. My assumption is
> > that somehow back in the day, someone managed to get odd characters
> > into the
ers aac_pci_err_handler = {
> .error_detected = aac_pci_error_detected,
> .mmio_enabled = aac_pci_mmio_enabled,
> .slot_reset = aac_pci_slot_reset,
Acked-by: Dave Carroll
exact data pattern of
> AAC_OWNER_FIRMWARE and it was at the same offset that aacraid writes,
> which is scsicmd->SCp.phase. The patch below resolves this issue.
>
> Cc: stable
> Signed-off-by: Brian King
> ---
>
Reviewed-by: Dave Carroll
Update the email address for AACRAID from Adaptec to Microsemi
Signed-off-by: Dave Carroll
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2ebe195..a327ba2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -213,7 +213,7 @@ S
#x27;[SCSI] 2.6 aacraid: Variable FIB size (updated patch)'
Cc: sta...@vger.kernel.org
Signed-off-by: Dave Carroll
---
drivers/scsi/aacraid/commctrl.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/comm
#x27;[SCSI] 2.6 aacraid: Variable FIB size (updated patch)'
Cc: sta...@vger.kernel.org
Signed-off-by: Dave Carroll
---
drivers/scsi/aacraid/commctrl.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/comm
> -Original Message-
> From: Raghava Aditya Renukunta
> [mailto:raghavaaditya.renuku...@microsemi.com]
> Sent: Tuesday, March 14, 2017 10:20 AM
> To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux-
> s...@vger.kernel.org
> Cc: Dave Carroll; Gana Sridaran
1-rc5 in PowerPC ppc64le architecture with adapter 9005:028d
> (VID:DID) - the error recovery procedure was able to recover fine.
>
> Fixes: 5c63f7f710bd ("aacraid: Added EEH support")
> Cc: sta...@vger.kernel.org # v4.6+
> Signed-off-by: Guilherme G. Piccoli
> ---
Reviewed-by: Dave Carroll
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Tuesday, April 25, 2017 12:07 AM
> To: Mahesh Rajashekhara
> Cc: Dave Carroll ; linux-scsi@vger.kernel.org;
> j...@linux.vnet.ibm.com; martin.peter...@oracle.com; dl-esc-Aacraid Linux
&
> -Original Message-
> From: Raghava Aditya Renukunta
> [mailto:raghavaaditya.renuku...@microsemi.com]
> Sent: Wednesday, May 10, 2017 10:40 AM
> To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux-
> s...@vger.kernel.org
> Cc: Dave Carroll ; Gana Srid
> -Original Message-
> From: Raghava Aditya Renukunta
> [mailto:raghavaaditya.renuku...@microsemi.com]
> Sent: Wednesday, May 10, 2017 10:40 AM
> To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux-
> s...@vger.kernel.org
> Cc: Dave Carroll ; Gana Srid
> -Original Message-
> From: Raghava Aditya Renukunta
> [mailto:raghavaaditya.renuku...@microsemi.com]
> Sent: Wednesday, May 10, 2017 10:40 AM
> To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux-
> s...@vger.kernel.org
> Cc: Dave Carroll ; Gana Srid
thread is stopped by setting the thread pointer to NULL.
Signed-off-by: Dave Carroll
---
drivers/scsi/aacraid/commsup.c | 4 +++-
drivers/scsi/aacraid/linit.c | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
> -Original Message-
> From: Hans de Goede [mailto:hdego...@redhat.com]
> Sent: Thursday, March 29, 2018 8:51 AM
> To: dl-esc-Aacraid Linux Driver ; James E.J.
> Bottomley ; Martin K. Petersen
> ; SCSI development list s...@vger.kernel.org>; Linux Kernel Mailing List
>
> Subject: aacraid
es a fault.
Include iu_type prior to determining the validity of the command
Reported-by: Noah Misner
Fixes: b60710ec7d7ab ("aacraid: enable sending of TMFs from aac_hba_send()")
Fixes: 423400e64d377 ("aacraid: Include HBA direct interface")
Tested-by: Noah Misner
cc: sta...@vger.
Hi Emmanual,
> [ 346.869001] scsi host6: aacraid
> [ 346.869500] scsi 6:0:2:0: Direct-Access ASR8885 raid3V1.0
> PQ: 0
> ANSI: 2
> [ 346.869692] sd 6:0:2:0: [sdb] Very big device. Trying to use READ
> CAPACITY(16).
> [ 346.869712] sd 6:0:2:0: [sdb] 632763166720 512-byte logic
> -Original Message-
> From: Dave Carroll
> Sent: Wednesday, June 27, 2018 12:46 PM
> To: Emmanuel Florac ; linux-scsi@vger.kernel.org
> Cc: dl-esc-Aacraid Linux Driver
> Subject: RE: aacraid driver, kernel 4.14 and up, ASR8xxx controller : doesn't
> After a very long time, it finally boots up and sees the disks, but
> here's the output from dmesg | grep aacraid:
>
> [1.357760] Adaptec aacraid driver 1.2.1[50877]-custom
> [1.388119] aacraid: Comm Interface type2 enabled
> [3.405113] scsi host0: aacraid
> [ 50.156024] aacraid:
> I have already set up many drives of this size previously, using
> ASR8xx5 controllers, without any problem.
>
> On another machine with a simple 8x1TB array, it doesn't work any better,
> while
> an older kernel works perfectly fine too:
>
> 4.14.48 :
>
> [ 61.069190] Adaptec aacraid dri
: Dave Carroll
---
drivers/scsi/aacraid/aachba.c | 12 ++--
drivers/scsi/aacraid/aacraid.h | 5 +
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index 4591113..18a1a1f 100644
--- a/drivers/scsi/aacraid
-
> drivers/scsi/aacraid/linit.c | 20
> 1 file changed, 12 insertions(+), 8 deletions(-)
Reviewed-by: Dave Carroll
Hi Christoph,
> > + if ((le32_to_cpu(dresp->status) == ST_OK) &&
> > + (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE)) {
> > + _aac_probe_container2(context, fibptr);
> > + return;
>
> if (dresp->status == cpu_to
> Dave,
>
> > Hi Christoph,
> >
> >> > + if ((le32_to_cpu(dresp->status) == ST_OK) &&
> >> > + (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE)) {
> >> > + _aac_probe_container2(context, fibptr);
> >> > + return;
> >>
> >>
> From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com]
> Sent: Tuesday, September 19, 2017 9:12 AM
> To: dl-esc-Aacraid Linux Driver ; linux-
> s...@vger.kernel.org
> Cc: gpicc...@linux.vnet.ibm.com; Raghava Aditya Renukunta
> ; Dave Carroll
> ; brk...@linux.
>
>
> Guilherme,
>
> > James/Martin, am I expected to send a v2 with some change? Perhaps
> > with Dave's ack? Sorry to annoy, thanks in advance for any advice!
>
> I was just about to mail Dave and ask for confirmation that your
> interpretation
> of the controller behavior is correct.
>
>
y about aacraid by that time.
>
> Signed-off-by: Arnd Bergmann
> ---
Reviewed-by: Dave Carroll
ch makes use of generic PCI state checks, which are
> lightweight and non-dependent of arch configs - also, it makes
> the code cleaner.
>
> Signed-off-by: Guilherme G. Piccoli
> ---
Reviewed-by: Dave Carroll
43 matches
Mail list logo
