Re: [PATCH 1/3] libsas: modify SATA error handler

2014-06-03 Thread Dan Williams
Hi, some notes below: On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu wrote: > Add support for SATA port softreset and port multiplier error > handling. Some more detailed notes about the approach and any caveats would be appreciated. > > Signed-off-by: Xiangliang Yu > --- > drivers/scsi/libsa

[PATCH RFC 1/2] iop13xx: add base support for the imu

2007-01-24 Thread Dan Williams
From: Greg Tucker <[EMAIL PROTECTED]> The interprocessor messaging unit supports mailbox style communication between the two Xscale cores on iop342. Signed-off-by: Greg Tucker <[EMAIL PROTECTED]> Signed-off-by: Dan Williams <[EMAIL PROTECTED]> --- arch/arm/ma

[PATCH RFC 2/2] iop13xx: imu scsi driver

2007-01-24 Thread Dan Williams
From: Greg Tucker <[EMAIL PROTECTED]> Enable Linux to access the other core as if it were a scsi target. Signed-off-by: Greg Tucker <[EMAIL PROTECTED]> Signed-off-by: Dan Williams <[EMAIL PROTECTED]> --- arch/arm/mach-iop13xx/imu/Kconfig |7 drivers/scsi/Makefile

[PATCH 2.6.20 0/2] imu-scsi for iop13xx

2007-02-13 Thread Dan Williams
Here is the iop13xx imu-scsi driver with the recommended scsi changes and some additional cleanups. I will submit both patches to Russell's tracker once the scsi bits achieve your sign-off James. Any objections, comments? Dan [ note: [EMAIL PROTECTED] is subscriber only ] - To unsubscribe fro

[PATCH 2.6.20 1/2] iop13xx: add base support for the imu

2007-02-13 Thread Dan Williams
From: Greg Tucker <[EMAIL PROTECTED]> The interprocessor messaging unit supports mailbox style communication between the two Xscale cores on iop342. Changelog: * cleaned up static functions and exports Signed-off-by: Greg Tucker <[EMAIL PROTECTED]> Signed-off-by: Dan Will

[PATCH 2.6.20 2/2] iop13xx: imu scsi driver

2007-02-13 Thread Dan Williams
PROTECTED]> Signed-off-by: Dan Williams <[EMAIL PROTECTED]> --- arch/arm/mach-iop13xx/imu/Kconfig |7 drivers/scsi/Makefile |1 drivers/scsi/iop13xx-imu-scsi.c | 607 + 3 files changed, 615 insertions(+), 0 deletions(-) diff --g

[PATCH 10/18] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-05 Thread Dan Williams
t; Cc: linux-scsi@vger.kernel.org Signed-off-by: Elena Reshetova Signed-off-by: Dan Williams --- drivers/scsi/qla2xxx/qla_mr.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index d5da3981cefe..1

[PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-05 Thread Dan Williams
x86, barrier: stop speculation for failed access_ok Dan Williams (13): x86: implement nospec_barrier() [media] uvcvideo: prevent bounds-check bypass via speculative execution carl9170: prevent bounds-check bypass via speculative execution p54: prevent bounds-check bypass

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-05 Thread Dan Williams
On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman wrote: > Dan Williams writes: > >> Quoting Mark's original RFC: >> >> "Recently, Google Project Zero discovered several classes of attack >> against speculative execution. One of these, known as variant-1

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-06 Thread Dan Williams
On Fri, Jan 5, 2018 at 5:09 PM, Dan Williams wrote: > Quoting Mark's original RFC: > > "Recently, Google Project Zero discovered several classes of attack > against speculative execution. One of these, known as variant-1, allows > explicit bounds checks to be bypassed und

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-06 Thread Dan Williams
On Sat, Jan 6, 2018 at 11:37 AM, Dan Williams wrote: > On Fri, Jan 5, 2018 at 5:09 PM, Dan Williams wrote: >> Quoting Mark's original RFC: >> >> "Recently, Google Project Zero discovered several classes of attack >> against speculative execution. One

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-09 Thread Dan Williams
On Tue, Jan 9, 2018 at 11:34 AM, Jiri Kosina wrote: > On Fri, 5 Jan 2018, Dan Williams wrote: > > [ ... snip ... ] >> Andi Kleen (1): >> x86, barrier: stop speculation for failed access_ok >> >> Dan Williams (13): >> x86: implement nospec_barri

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
On Thu, Jan 11, 2018 at 1:54 AM, Jiri Kosina wrote: > On Tue, 9 Jan 2018, Josh Poimboeuf wrote: > >> On Tue, Jan 09, 2018 at 11:44:05AM -0800, Dan Williams wrote: >> > On Tue, Jan 9, 2018 at 11:34 AM, Jiri Kosina wrote: >> > > On Fri, 5 Jan 2018, Dan William

Re: [PATCH 10/18] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
On Sat, Jan 6, 2018 at 1:03 AM, Greg KH wrote: > On Fri, Jan 05, 2018 at 05:10:48PM -0800, Dan Williams wrote: >> Static analysis reports that 'handle' may be a user controlled value >> that is used as a data dependency to read 'sp' from the >> 're

[PATCH v2 17/19] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
l patch by Elena Reshetova. Cc: qla2xxx-upstr...@qlogic.com Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org Signed-off-by: Elena Reshetova Signed-off-by: Dan Williams --- drivers/scsi/qla2xxx/qla_mr.c | 17 +++-- 1 file chan

[PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
git branch here: git://git.kernel.org/pub/scm/linux/kernel/git/djbw/linux nospec-v2 Note that the BPF fix for Spectre variant1 is merged in the bpf.git tree [4], and is not included in this branch. [2]: https://googleprojectzero.blogspot.co.uk/2018/01/reading-privileged-memor

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
On Thu, Jan 11, 2018 at 5:19 PM, Linus Torvalds wrote: > On Thu, Jan 11, 2018 at 4:46 PM, Dan Williams > wrote: >> >> This series incorporates Mark Rutland's latest ARM changes and adds >> the x86 specific implementation of 'ifence_array_ptr'. That ifence

Re: [PATCH v2 17/19] qla2xxx: prevent bounds-check bypass via speculative execution

2018-01-11 Thread Dan Williams
On Thu, Jan 11, 2018 at 5:19 PM, James Bottomley wrote: > On Thu, 2018-01-11 at 16:47 -0800, Dan Williams wrote: >> Static analysis reports that 'handle' may be a user controlled value >> that is used as a data dependency to read 'sp' from the >> '

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-18 Thread Dan Williams
On Thu, Jan 18, 2018 at 5:18 AM, Will Deacon wrote: > Hi Dan, Linus, > > On Thu, Jan 11, 2018 at 05:41:08PM -0800, Dan Williams wrote: >> On Thu, Jan 11, 2018 at 5:19 PM, Linus Torvalds >> wrote: >> > On Thu, Jan 11, 2018 at 4:46 PM, Dan Williams >&

Re: [PATCH] scsi: libsas: defer ata device eh commands to libata

2018-03-06 Thread Dan Williams
On Tue, Mar 6, 2018 at 10:04 AM, Martin K. Petersen wrote: > >> When ata device doing EH, some commands still attached with tasks are not >> passed to libata when abort failed or recover failed, so libata did not >> handle these commands. After these commands done, sas task is freed, but >> ata qc

Re: [PATCH v2] scsi: libsas: defer ata device eh commands to libata

2018-03-07 Thread Dan Williams
8 > [] ret_from_fork+0x10/0x18 > > If ata qc leaked too many, ata tag allocation will fail and io blocked > for ever. > > As suggested by Dan Williams, defer ata device commands to libata and > merge sas_eh_finish_cmd() with sas_eh_defer_cmd(). libata will handle > ata qcs cor

Re: [PATCH v3] scsi: libsas: defer ata device eh commands to libata

2018-03-07 Thread Dan Williams
8 > [] ret_from_fork+0x10/0x18 > > If ata qc leaked too many, ata tag allocation will fail and io blocked > for ever. > > As suggested by Dan Williams, defer ata device commands to libata and > merge sas_eh_finish_cmd() with sas_eh_defer_cmd(). libata will handle > ata qcs cor

Re: [PATCH] scsi: libsas: add transport class for ATA devices

2018-03-26 Thread Dan Williams
On Mon, Mar 26, 2018 at 2:27 AM, Jason Yan wrote: > Now ata devices attached with sas controller do not have transport > class, so that we can not see any information of these ata devices in > /sys/class/ata_port(or ata_link or ata_device). > > Add transport class for the ata devices attached with

Re: [PATCH v2 3/7] drivers/base: Probe devices concurrently if requested by the driver

2018-10-17 Thread Dan Williams
erlain > Cc: Johannes Thumshirn > Cc: Christoph Hellwig > Cc: Greg Kroah-Hartman > Cc: Dan Williams > Signed-off-by: Bart Van Assche > --- > drivers/base/bus.c | 3 +-- > drivers/base/dd.c | 49 ++ > 2 files changed, 50

[set4 resend PATCH 0/5] libsas, libata: suspend / resume and "reset once"

2012-07-09 Thread Dan Williams
effort for known well-behaved devices. These have been in -next for the past couple kernel cycles. --- Artur Wojcik (1): isci: implement suspend/resume support Dan Williams (4): libata: reset once libata: export ata_port suspend/resume infrastructure for sas libsa

[set4 resend PATCH 1/5] async: introduce 'async_domain' type

2012-07-09 Thread Dan Williams
: Dan Williams --- drivers/regulator/core.c |2 +- drivers/scsi/libsas/sas_ata.c |2 +- drivers/scsi/scsi.c |3 ++- drivers/scsi/scsi_priv.h |2 +- include/linux/async.h | 35 +++ kernel/async.c| 35

[set4 resend PATCH 2/5] async: make async_synchronize_full() flush all work regardless of domain

2012-07-09 Thread Dan Williams
es with pending async_synchronize_full waiters at module removal time. Cc: Len Brown Cc: Rafael J. Wysocki Cc: James Bottomley Acked-by: Arjan van de Ven Reported-by: Meelis Roos Reported-by: Eldad Zack Tested-by: Eldad Zack Signed-off-by: Dan Williams --- drivers/scsi/scsi.c |1 + includ

[set4 resend PATCH 3/5] scsi: queue async scan work to an async_schedule domain

2012-07-09 Thread Dan Williams
-off-by: Dan Williams --- drivers/scsi/scsi_scan.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index f55e5f1..dff17c1 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1845,14 +1845,13

[set4 resend PATCH 4/5] scsi: cleanup usages of scsi_complete_async_scans

2012-07-09 Thread Dan Williams
Now that scsi registers its async scan work with the async subsystem, wait_for_device_probe() is sufficient for ensuring all scanning is complete. Cc: Arjan van de Ven Cc: Len Brown Cc: Rafael J. Wysocki Cc: James Bottomley Tested-by: Eldad Zack Signed-off-by: Dan Williams --- drivers/scsi

[set4 resend PATCH 5/5] Revert "[SCSI] fix async probe regression"

2012-07-09 Thread Dan Williams
: Eldad Zack Signed-off-by: Dan Williams --- drivers/scsi/scsi_scan.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index a0bc663..56a9379 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c

Re: [set4 resend PATCH 0/5] libsas, libata: suspend / resume and "reset once"

2012-07-09 Thread Dan Williams
the domain specific async schedules, which isn't true." ...and this set aims to make that assumption true, but also with the ability to opt-out for "private" async work. --- Dan Williams (5): async: introduce 'async_domain' type async: ma

[resend PATCH 0/5] libsas, libata: suspend / resume and "reset once"

2012-07-09 Thread Dan Williams
effort for known well-behaved devices. These have been in -next for the past couple kernel cycles. --- Artur Wojcik (1): isci: implement suspend/resume support Dan Williams (4): libata: reset once libata: export ata_port suspend/resume infrastructure for sas libsas: suspen

[resend PATCH 2/5] libata: export ata_port suspend/resume infrastructure for sas

2012-07-09 Thread Dan Williams
c-ata probe implmentation). Async operation is determined by having an external, rather than stack based, location for storing the result of the operation. Reviewed-by: Jacek Danecki Signed-off-by: Dan Williams --- drivers/ata/libata-core.c | 58 - in

[resend PATCH 4/5] isci: implement suspend/resume support

2012-07-09 Thread Dan Williams
nks should be back up. libsas is in charge of handling links that did not resume, or resumed out of order. Signed-off-by: Artur Wojcik Signed-off-by: Jacek Danecki Signed-off-by: Dan Williams --- drivers/scsi/isci/host.c |2 +- drivers/scsi/isci/host.h |2 +- drivers/scsi/isci/ini

[resend PATCH 3/5] libsas: suspend / resume support

2012-07-09 Thread Dan Williams
: Alan Stern Reviewed-by: Jacek Danecki Tested-by: Maciej Patelczyk Signed-off-by: Dan Williams --- drivers/scsi/libsas/sas_ata.c | 86 ++ drivers/scsi/libsas/sas_discover.c | 69 drivers/scsi/libsas/sas_dump.c |

[resend PATCH 5/5] libsas, ipr: cleanup ata_host flags initialization via ata_host_init

2012-07-09 Thread Dan Williams
(1 << 7), /* PIO cmds via DMA */ ATA_FLAG_NCQ= (1 << 10), /* host supports NCQ */ The only one that aliases is ATA_HOST_STARTED which is a 'don't care' in the libsas and ipr cases since ata_hosts from these sources are not registered with libata. Cc: Brian King

[resend PATCH 1/5] libata: reset once

2012-07-09 Thread Dan Williams
Hotplug testing with libsas currently encounters a 55 second wait for link recovery to give up. In the case where the user trusts the response time of their devices permit the recovery attempts to be limited to one. Signed-off-by: Dan Williams --- Documentation/kernel-parameters.txt |3

[GIT PATCH 0/4] isci update for 3.6

2012-07-11 Thread Dan Williams
from Dan Carpenter Dan Carpenter (2): isci: make function declaration match implementation isci: add a couple __iomem annotations Dan Williams (1): isci: fix isci_pci_probe() generates warning on efi failure path

[PATCH 1/4] isci: fix isci_pci_probe() generates warning on efi failure path

2012-07-11 Thread Dan Williams
ameters is unlikely and we keep the memory around in the success case just defer all de-allocation to devm. Cc: Reported-by: Don Morris Signed-off-by: Dan Williams --- drivers/scsi/isci/init.c |1 - drivers/scsi/isci/probe_roms.c |1 - 2 files changed, 2 deletions(-) diff --git

[PATCH 2/4] isci: fix COMSAS negation timout workaround for WD SAS drives

2012-07-11 Thread Dan Williams
: Dave Maurer Signed-off-by: Dan Williams --- drivers/scsi/isci/phy.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci/phy.c index 18f43d4..ebb8f53 100644 --- a/drivers/scsi/isci/phy.c +++ b/drivers/scsi/isci/phy.c @@ -1205,6 +1205,7 @@ static

[PATCH 4/4] isci: add a couple __iomem annotations

2012-07-11 Thread Dan Williams
From: Dan Carpenter These are __iomem. Sparse complains if we don't have that. drivers/scsi/isci/phy.c +149 70: warning: incorrect type in initializer (different address spaces) Signed-off-by: Dan Carpenter Signed-off-by: Dan Williams --- drivers/scsi/isci/host.c |2 +- dr

[PATCH 3/4] isci: make function declaration match implementation

2012-07-11 Thread Dan Williams
From: Dan Carpenter Sparse complains that we redeclare this with a different type, because in the .c file we use an enum and in the .h file we declare the parameter as a u32. Probably it's best to use an enum in both places. Signed-off-by: Dan Carpenter Signed-off-by: Dan Wil

Re: [Bug 44771] [REGRESSION] a7a20d103994fd760766e6c9d494daa569cbfe06 makes kernel 3.5 unbootable on an Intel chipset based motherboard

2012-07-18 Thread Dan Williams
On Wed, Jul 18, 2012 at 1:25 PM, Alan Stern wrote: > On Tue, 17 Jul 2012, James Bottomley wrote: > >> On Tue, 2012-07-17 at 12:51 -0700, Linus Torvalds wrote: >> > Wrong people cc'd, it looks like. >> > >> > Guys, commit a7a20d103994 ("sd: limit the scope of the async probe >> > domain") is causin

[PATCH] MAINTAINERS: update address for Dan Williams

2012-08-15 Thread Dan Williams
Moved to d...@fb.com Cc: Dave Jiang Cc: Vinod Koul Signed-off-by: Dan Williams --- MAINTAINERS | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 94b823f..a728dc0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: Possible mptsas regression post 3.5.0

2012-08-27 Thread Dan Williams
e the bug in my test setup. > > [ 339.406778] BUG: soft lockup - CPU#2 stuck for 23s! [kworker/u:8:2202] [..] > [ 339.415268] [] scsi_remove_target+0xda/0x1f0 I wonder if we are preventing scsi_device_dev_release_usercontext() from making forward progress? ...the attached patch

Re: Possible mptsas regression post 3.5.0

2012-08-28 Thread Dan Williams
218] scsi_remove_target[0]: reap 0:0 state: 2 reap: 1 dev_del: 1 Thanks! Does the attached patch fix the issue for you? -- Dan scsi_remove_target: fix softlockup condition From: Dan Williams Don't restart lookup of stargets in the multi-target case, just arrange to traverse the list onc

[PATCH] scsi_remove_target: fix softlockup regression on hot remove

2012-08-28 Thread Dan Williams
eap() so we can end up spinning if we restart. LKML-Reference: Reported-by: John Drescher Tested-by: John Drescher Signed-off-by: Dan Williams --- drivers/scsi/scsi_sysfs.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/scsi_sy

[resend PATCH] scsi_remove_target: fix softlockup regression on hot remove

2012-08-28 Thread Dan Williams
eap() so we can end up spinning if we restart. Cc: Acked-by: Jack Wang LKML-Reference: Reported-by: John Drescher Tested-by: John Drescher Signed-off-by: Dan Williams --- Jack, thanks for the reminder to cc stable! drivers/scsi/scsi_sysfs.c | 30 ++ 1 f

Re: [resend PATCH] scsi_remove_target: fix softlockup regression on hot remove

2012-08-29 Thread Dan Williams
On Wed, 2012-08-29 at 06:50 +, Bart Van Assche wrote: > On 08/29/12 05:12, Dan Williams wrote: > > John reports: > > BUG: soft lockup - CPU#2 stuck for 23s! [kworker/u:8:2202] > > [..] > > Call Trace: > > [] scsi_remove_target+0xda/0x1f0 &

Re: [resend PATCH] scsi_remove_target: fix softlockup regression on hot remove

2012-09-04 Thread Dan Williams
On Tue, Sep 4, 2012 at 7:02 AM, John Drescher wrote: > On Wed, Aug 29, 2012 at 10:59 AM, Dan Williams wrote: >> On Wed, 2012-08-29 at 06:50 +, Bart Van Assche wrote: >>> On 08/29/12 05:12, Dan Williams wrote: >>> > John reports: >>> > BUG: soft

Re: 4 isci patches from isci-for-3.6 tag?

2012-09-11 Thread Dan Williams
WD SAS drives >> 6d70a74ffd616073a68ae0974d98819bfa8e6da6 isci: fix isci_pci_probe() >> generates warning on efi failure path >> (by: Dan Carpenter, Dave Maurer and Dan Williams) >> >> We hope they will get to the upstream kernel soon... > > They were tagged for -nex

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-28 Thread Dan Williams
On Wed, Sep 26, 2012 at 7:20 PM, Martin K. Petersen wrote: >> "James" == James Bottomley >> writes: > > James> On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: >>> >>> drivers/scsi/sd.c | 4 drivers/scsi/sd.h | 2 +- 2 files changed, >>> 5 insertions(+), 1 deletion(-) > > James>

Re: [PATCH 3/3] Make blk_cleanup_queue() wait until request_fn finished

2012-10-01 Thread Dan Williams
On Thu, Sep 27, 2012 at 9:39 AM, Bart Van Assche wrote: > Some request_fn implementations, e.g. scsi_request_fn(), unlock > the queue lock. Make sure that blk_cleanup_queue() waits until all > active request_fn invocations have finished. This fixes a potential > use-after-free at the end of scsi_r

Re: [PATCH 0/3] Insert ATA transport objects in SCSI syfs topology.

2012-10-01 Thread Dan Williams
On Mon, Oct 1, 2012 at 11:22 AM, Gwendal Grignou wrote: > This set of patches improve ATA transport classes integration with SCSI > objects. > > Before [2.6.x] > > Ata and scsi transport class where separated: > `--:09:00.0 > | `--ata1 > | | `--port_port > | | `--link1 > | | | `--dev1.

Re: [PATCH 0/3] Insert ATA transport objects in SCSI syfs topology.

2012-10-07 Thread Dan Williams
On Thu, Oct 4, 2012 at 9:56 AM, Gwendal Grignou wrote: >> What's the benefit of this? > + To unify ata transport sysfs topology with other scsi transport. My concern is the thrash and breakage to switch the ordering around given the (minor) growing pains injecting an ata_port into the device path

Re: [RFC] drop libsas task collector mode?

2014-11-04 Thread Dan Williams
On Tue, Nov 4, 2014 at 10:58 AM, Christoph Hellwig wrote: > The task collector mode in libsas implements internal queueing in > libsas, which is somethign we usualy try to avoid, and doesn't seem > to get much exposure as it's only supported as a non-default option > in two drivers. > > If there's

Re: [PATCH] libsas: remove task_collector mode

2014-11-24 Thread Dan Williams
ter optimizations for scsi-mq > in the future. > > Signed-off-by: Christoph Hellwig Acked-by: Dan Williams -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2 resend] libata:fix kernel panic when hotplug

2016-06-20 Thread Dan Williams
On Mon, Jun 20, 2016 at 6:22 PM, Martin K. Petersen wrote: >> "Tejun" == Tejun Heo writes: > >>> In fact,we don't need libata to deal with hotplug in sas environment. >>> So we can't run ata hotplug task when ata port is sas host. > > Tejun> Martin, can you please confirm whether the above is

Time to make dynamically allocated devt the default for scsi disks?

2016-08-12 Thread Dan Williams
...or, for that matter, any block device driver on a bus that supports hotplug? In 4.8 Jens merged the following fix for a crash that was triggered by repeatedly reconfiguring a libnvdimm namespace causing it to destroy and create disks (rapid hotplug). df08c32ce3be block: fix bdi vs gendisk

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-12 Thread Dan Williams
On Fri, Aug 12, 2016 at 2:35 PM, Bart Van Assche wrote: > On 08/12/2016 02:29 PM, Dan Williams wrote: >> >> ...or, for that matter, any block device driver on a bus that supports >> hotplug? >> >> In 4.8 Jens merged the following fix for a crash that was triggered

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-12 Thread Dan Williams
On Fri, Aug 12, 2016 at 5:17 PM, James Bottomley wrote: > On Fri, 2016-08-12 at 14:29 -0700, Dan Williams wrote: >> Before spending effort trying to flush the destruction of old bdi >> instances before new ones are registered, is it rather time to >> complete the convers

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-12 Thread Dan Williams
On Fri, Aug 12, 2016 at 5:29 PM, Dan Williams wrote: > On Fri, Aug 12, 2016 at 5:17 PM, James Bottomley > wrote: >> On Fri, 2016-08-12 at 14:29 -0700, Dan Williams wrote: >>> Before spending effort trying to flush the destruction of old bdi >>> instances before

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-13 Thread Dan Williams
On Sat, Aug 13, 2016 at 8:23 AM, James Bottomley wrote: > On Fri, 2016-08-12 at 21:57 -0700, Dan Williams wrote: >> On Fri, Aug 12, 2016 at 5:29 PM, Dan Williams < >> dan.j.willi...@intel.com> wrote: >> > On Fri, Aug 12, 2016 at 5:17 PM, James Bottomley >> &g

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-14 Thread Dan Williams
On Sat, Aug 13, 2016 at 11:27 AM, Dan Williams wrote: > On Sat, Aug 13, 2016 at 10:43 AM, James Bottomley [..] >> Um, so this patch doesn't fix the problem. It merely makes the lifetime >> rules correct so the problem can then be fixed at the scsi level. > > You're

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-14 Thread Dan Williams
On Sat, Aug 13, 2016 at 10:43 AM, James Bottomley wrote: > On Sat, 2016-08-13 at 09:29 -0700, Dan Williams wrote: >> On Sat, Aug 13, 2016 at 8:23 AM, James Bottomley >> wrote: >> > It does? The race is the fact that the parent can be removed >> > before the ch

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-14 Thread Dan Williams
On Sun, Aug 14, 2016 at 10:20 AM, James Bottomley wrote: > On Sat, 2016-08-13 at 11:27 -0700, Dan Williams wrote: >> On Sat, Aug 13, 2016 at 10:43 AM, James Bottomley >> wrote: >> > On Sat, 2016-08-13 at 09:29 -0700, Dan Williams wrote: >> > > On Sat, Aug

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-14 Thread Dan Williams
[ adding Bart back to the cc ] On Sun, Aug 14, 2016 at 11:08 AM, Dan Williams wrote: > On Sun, Aug 14, 2016 at 10:20 AM, James Bottomley > wrote: [..] > I like it. I still think the bdi registration code should be in > charge of taking the extra reference on the disk device

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-30 Thread Dan Williams
On Mon, Aug 29, 2016 at 11:16 AM, Bart Van Assche wrote: > On 08/14/2016 10:21 AM, James Bottomley wrote: >> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c >> index d3e852a..222771d 100644 >> --- a/drivers/scsi/sd.c >> +++ b/drivers/scsi/sd.c >> @@ -3000,7 +3000,13 @@ static void sd_probe_asyn

Re: [PATCH 4/4] Revert "scsi, block: fix duplicate bdi name registration crashes"

2017-03-08 Thread Dan Williams
.info/?l=linux-block&m=148554717109098&w=2 > > Signed-off-by: Jan Kara Acked-by: Dan Williams

Re: [RFC 5/8] scatterlist: Modify SG copy functions to support io memory.

2017-04-03 Thread Dan Williams
On Mon, Apr 3, 2017 at 2:20 PM, Logan Gunthorpe wrote: > Hi Christoph, > > What are your thoughts on an approach like the following untested > draft patch. > > The patch (if fleshed out) makes it so iomem can be used in an sgl > and WARN_ONs will occur in places where drivers attempt to access > i

Re: [RFC 5/8] scatterlist: Modify SG copy functions to support io memory.

2017-04-03 Thread Dan Williams
On Mon, Apr 3, 2017 at 3:10 PM, Logan Gunthorpe wrote: > > > On 03/04/17 03:44 PM, Dan Williams wrote: >> On Mon, Apr 3, 2017 at 2:20 PM, Logan Gunthorpe wrote: >>> Hi Christoph, >>> >>> What are your thoughts on an approach like the following untes

Re: [RFC 5/8] scatterlist: Modify SG copy functions to support io memory.

2017-04-03 Thread Dan Williams
On Mon, Apr 3, 2017 at 4:12 PM, Logan Gunthorpe wrote: > > > On 03/04/17 04:47 PM, Dan Williams wrote: >> I wouldn't necessarily conflate supporting pfn_t in the scatterlist >> with the stalled stuct-page-less DMA effor. A pfn_t_to_page() >> conversion will sti

Re: [PATCH] scsi: ses: don't get power status of SES device slot on probe

2017-04-04 Thread Dan Williams
On Wed, Mar 29, 2017 at 6:02 PM, Mauricio Faria de Oliveira wrote: > The commit 08024885a2a3 ("ses: Add power_status to SES device slot") > introduced the 'power_status' attribute to enclosure components and > the associated callbacks. > > There are 2 callbacks available to get the power status of

Re: [PATCH] scsi: ses: don't get power status of SES device slot on probe

2017-04-05 Thread Dan Williams
On Wed, Apr 5, 2017 at 6:13 AM, Mauricio Faria de Oliveira wrote: > Hi Dan, > > Thanks for reviewing. > > On 04/04/2017 06:07 PM, Dan Williams wrote: >>> >>> @@ -594,6 +594,10 @@ static ssize_t get_component_power_status(struct >>> device *cdev, >

Re: [PATCH v2] scsi: ses: don't get power status of SES device slot on probe

2017-04-05 Thread Dan Williams
would be curious. > > Well, to handle that more properly, set the initial power state > value to '-1' (i.e., uninitialized) instead of '1' (power 'on'), > and check for it in that callback which may do an direct access > to the field value _if_ a callback function is not defined. > > Signed-off-by: Mauricio Faria de Oliveira > Fixes: 08024885a2a3 ("ses: Add power_status to SES device slot") Reviewed-by: Dan Williams

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-15 Thread Dan Williams
On Sat, Apr 15, 2017 at 10:41 AM, Logan Gunthorpe wrote: > Thanks, Benjamin, for the summary of some of the issues. > > On 14/04/17 04:07 PM, Benjamin Herrenschmidt wrote >> So I assume the p2p code provides a way to address that too via special >> dma_ops ? Or wrappers ? > > Not at this time. We

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-16 Thread Dan Williams
On Sat, Apr 15, 2017 at 10:36 PM, Logan Gunthorpe wrote: > > > On 15/04/17 04:17 PM, Benjamin Herrenschmidt wrote: >> You can't. If the iommu is on, everything is remapped. Or do you mean >> to have dma_map_* not do a remapping ? > > Well, yes, you'd have to change the code so that iomem pages do

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-16 Thread Dan Williams
On Sat, Apr 15, 2017 at 8:01 PM, Benjamin Herrenschmidt wrote: > On Sat, 2017-04-15 at 15:09 -0700, Dan Williams wrote: >> I'm wondering, since this is limited to support behind a single >> switch, if you could have a software-iommu hanging off that switch >> device obje

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-17 Thread Dan Williams
On Mon, Apr 17, 2017 at 9:52 AM, Logan Gunthorpe wrote: > > > On 17/04/17 01:20 AM, Benjamin Herrenschmidt wrote: >> But is it ? For example take a GPU, does it, in your scheme, need an >> additional "p2pmem" child ? Why can't the GPU driver just use some >> helper to instantiate the necessary str

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 9:45 AM, Jason Gunthorpe wrote: > On Mon, Apr 17, 2017 at 08:23:16AM +1000, Benjamin Herrenschmidt wrote: > >> Thanks :-) There's a reason why I'm insisting on this. We have constant >> requests for this today. We have hacks in the GPU drivers to do it for >> GPUs behind a

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 11:00 AM, Jason Gunthorpe wrote: > On Tue, Apr 18, 2017 at 10:27:47AM -0700, Dan Williams wrote: >> > FWIW, RDMA probably wouldn't want to use a p2mem device either, we >> > already have APIs that map BAR memory to user space, and would like

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 12:35 PM, Logan Gunthorpe wrote: > > > On 18/04/17 01:01 PM, Jason Gunthorpe wrote: >> Ultimately every dma_ops will need special code to support P2P with >> the special hardware that ops is controlling, so it makes some sense >> to start by pushing the check down there in

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 1:29 PM, Jerome Glisse wrote: >> On Tue, Apr 18, 2017 at 12:35 PM, Logan Gunthorpe >> wrote: >> > >> > >> > On 18/04/17 01:01 PM, Jason Gunthorpe wrote: >> >> Ultimately every dma_ops will need special code to support P2P with >> >> the special hardware that ops is control

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 2:03 PM, Jason Gunthorpe wrote: > On Tue, Apr 18, 2017 at 12:48:35PM -0700, Dan Williams wrote: > >> > Yes, I noticed this problem too and that makes sense. It just means >> > every dma_ops will probably need to be modified to either support p2p &g

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 2:22 PM, Jason Gunthorpe wrote: > On Tue, Apr 18, 2017 at 02:11:33PM -0700, Dan Williams wrote: >> > I think this opens an even bigger can of worms.. >> >> No, I don't think it does. You'd only shim when the target page is >> back

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 3:15 PM, Logan Gunthorpe wrote: > > > On 18/04/17 03:36 PM, Dan Williams wrote: >> On Tue, Apr 18, 2017 at 2:22 PM, Jason Gunthorpe >> wrote: >>> On Tue, Apr 18, 2017 at 02:11:33PM -0700, Dan Williams wrote: >>>>> I

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 3:48 PM, Logan Gunthorpe wrote: > > > On 18/04/17 04:28 PM, Dan Williams wrote: >> Unlike the pci bus address offset case which I think is fundamental to >> support since shipping archs do this today, I think it is ok to say >> p2p is restricte

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 3:42 PM, Jason Gunthorpe wrote: > On Tue, Apr 18, 2017 at 03:28:17PM -0700, Dan Williams wrote: > >> Unlike the pci bus address offset case which I think is fundamental to >> support since shipping archs do this toda > > But we can support this b

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 3:46 PM, Benjamin Herrenschmidt wrote: > On Tue, 2017-04-18 at 10:27 -0700, Dan Williams wrote: >> > FWIW, RDMA probably wouldn't want to use a p2mem device either, we >> > already have APIs that map BAR memory to user space, and would like

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-18 Thread Dan Williams
On Tue, Apr 18, 2017 at 3:56 PM, Logan Gunthorpe wrote: > > > On 18/04/17 04:50 PM, Dan Williams wrote: >> On Tue, Apr 18, 2017 at 3:48 PM, Logan Gunthorpe wrote: >>> >>> >>> On 18/04/17 04:28 PM, Dan Williams wrote: >>>> Unlike the pci b

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Dan Williams
On Wed, Apr 19, 2017 at 9:48 AM, Logan Gunthorpe wrote: > > > On 19/04/17 09:55 AM, Jason Gunthorpe wrote: >> I was thinking only this one would be supported with a core code >> helper.. > > Pivoting slightly: I was looking at how HMM uses ZONE_DEVICE. They add a > type flag to the dev_pagemap str

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Dan Williams
On Wed, Apr 19, 2017 at 10:32 AM, Jerome Glisse wrote: > On Wed, Apr 19, 2017 at 10:01:23AM -0700, Dan Williams wrote: >> On Wed, Apr 19, 2017 at 9:48 AM, Logan Gunthorpe wrote: >> > >> > >> > On 19/04/17 09:55 AM, Jason Gunthorpe wrote: >> >> I wa

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Dan Williams
On Wed, Apr 19, 2017 at 11:19 AM, Logan Gunthorpe wrote: > > > On 19/04/17 12:11 PM, Logan Gunthorpe wrote: >> >> >> On 19/04/17 11:41 AM, Dan Williams wrote: >>> No, not quite ;-). I still don't think we should require the non-HMM >>> to pass

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Dan Williams
On Wed, Apr 19, 2017 at 11:41 AM, Logan Gunthorpe wrote: > > > On 19/04/17 12:30 PM, Dan Williams wrote: >> Letting others users do the container_of() arrangement means that >> struct page_map needs to become public and move into struct >> dev_pagemap directly. >

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Dan Williams
On Wed, Apr 19, 2017 at 3:55 PM, Logan Gunthorpe wrote: > > > On 19/04/17 02:48 PM, Jason Gunthorpe wrote: >> On Wed, Apr 19, 2017 at 01:41:49PM -0600, Logan Gunthorpe wrote: >> But.. it could point to a GPU and the GPU struct device could have a proxy dma_ops like Dan pointed out. >>> >

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-20 Thread Dan Williams
On Thu, Apr 20, 2017 at 1:43 PM, Stephen Bates wrote: > >> Yes, this makes sense I think we really just want to distinguish host >> memory or not in terms of the dev_pagemap type. > > I would like to see mutually exclusive flags for host memory (or not) and > persistence (or not). > Why persist

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-20 Thread Dan Williams
On Thu, Apr 20, 2017 at 4:07 PM, Stephen Bates wrote: >>> Yes, this makes sense I think we really just want to distinguish host >>> memory or not in terms of the dev_pagemap type. >> >>> I would like to see mutually exclusive flags for host memory (or not) and >>> persistence (or not). >>> >> >>

Re: [PATCH 1/2] libsas: Don't process sas events in static works

2017-05-20 Thread Dan Williams
On Fri, May 19, 2017 at 11:39 PM, Yijing Wang wrote: > Now libsas hotplug work is static, LLDD driver queue > the hotplug work into shost->work_q. If LLDD driver > burst post lots hotplug events to libsas, the hotplug > events may pending in the workqueue like > > shost->work_q > new work[PORTE_BY

Re: [PATCH 0/2 REPOST] remove unneded irq save

2018-06-12 Thread Dan Williams
On Tue, Jun 12, 2018 at 8:04 AM, John Garry wrote: > On 12/06/2018 15:31, Sebastian Andrzej Siewior wrote: >> >> On 2018-06-12 13:54:36 [+0100], John Garry wrote: >>> >>> +Dan >>> >>> On 11/06/2018 19:23, Sebastian Andrzej Siewior wrote: On 2018-06-11 18:12:55 [+0100], John Garry wrote:

Re: [PATCH 0/2 REPOST] remove unneded irq save

2018-06-14 Thread Dan Williams
On Thu, Jun 14, 2018 at 7:30 AM, Sebastian Andrzej Siewior wrote: > On 2018-06-12 08:46:38 [-0700], Dan Williams wrote: >> On Tue, Jun 12, 2018 at 8:04 AM, John Garry wrote: >> >> We had this comment for 6 years or so and nothing happend. What makes >> >> you

<    1   2   3   >