s now exposes this problem. Libsas should delete
all the devices from rphy down before deleting the parent port.
Cc:
Reported-by: Praveen Murali
Tested-by: Praveen Murali
Signed-off-by: Dan Williams
---
drivers/scsi/libsas/sas_discover.c |6 +++---
drivers/scsi/libsas/sas_port.c |1
this problem. Libsas should delete
all the devices from rphy down before deleting the parent port.
Cc:
Reported-by: Praveen Murali
Tested-by: Praveen Murali
Signed-off-by: Dan Williams
---
v2: drop the "---" separators that will confuse git-am. Thanks Luis!
drivers/scsi/
he devices from rphy down before deleting the parent port.
Cc:
Reported-by: Praveen Murali
Tested-by: Praveen Murali
Signed-off-by: Dan Williams
---
drivers/scsi/libsas/sas_discover.c |6 +++---
drivers/scsi/libsas/sas_port.c |1 -
2 files changed, 3 insertions(+), 4 deletio
he devices from rphy down before deleting the parent port.
Cc:
Reported-by: Praveen Murali
Tested-by: Praveen Murali
Reviewed-by: Hannes Reinecke
Signed-off-by: Dan Williams
---
Hi Andrew,
Can you take this through -mm. It's been on linux-scsi for a couple
months, and Hanne
On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley
wrote:
> On Wed, 2015-06-17 at 23:22 -0400, Dan Williams wrote:
>> Praveen reports:
>>
>> After some debugging this is what I have found
>>
>> sas_phye_loss_of_signal gets
On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley
wrote:
> On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote:
>> On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley
>> wrote:
>> >
>> >> }
>> >>
>> >> void sas_device_set_phy(struct d
On Mon, Jul 27, 2015 at 10:11 AM, James Bottomley
wrote:
> On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote:
>> On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley
>> wrote:
>> > On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote:
>> >> On Wed, Jul 2
On Mon, Jul 27, 2015 at 11:07 AM, James Bottomley
wrote:
> On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote:
>> On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley
>> wrote:
>> > On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote:
>> >> I don't
On Mon, Jul 27, 2015 at 11:38 AM, James Bottomley
wrote:
> No, that seems to be the intent of the prior code. The reason port
> visibility goes immediately (along with all associated phys), is that
> the port is ready for reuse as soon as sas_deform_port() returns.
> Destroying the subtree is lef
he most straightforward solution seems to be to invert the ordering of
> the set_current_state and kthread_should_stop.
>
> The issue has been noticed during reboot test on a 3.0 based kernel but
> the current code seems to be affected in the same way.
>
> Cc: stable # 3.6+
> R
On Thu, Oct 13, 2016 at 12:53 PM, Adam Manzanares
wrote:
> Patch adds an association between iocontext ioprio and the ioprio of a
> request. This value is set in blk_rq_set_prio which takes the request and
> the ioc as arguments. If the ioc is valid in blk_rq_set_prio then the
> iopriority of the
On Thu, Oct 13, 2016 at 1:09 PM, Jens Axboe wrote:
> On 10/13/2016 02:06 PM, Dan Williams wrote:
>>
>> On Thu, Oct 13, 2016 at 12:53 PM, Adam Manzanares
>> wrote:
>>>
>>> Patch adds an association between iocontext ioprio and the ioprio of a
>>&g
On Thu, Oct 13, 2016 at 1:24 PM, Jens Axboe wrote:
> On 10/13/2016 02:19 PM, Dan Williams wrote:
>>
>> On Thu, Oct 13, 2016 at 1:09 PM, Jens Axboe wrote:
>>>
>>> On 10/13/2016 02:06 PM, Dan Williams wrote:
>>>>
>>>>
>>&
On Wed, Nov 9, 2016 at 9:36 AM, John Garry wrote:
> On 09/11/2016 12:28, John Garry wrote:
>>
>> On 03/11/2016 14:58, John Garry wrote:
>>>
>>> The following patch introduces an annoying WARN
>>> when a device is removed from the SAS topology:
>>> [SCSI] libsas: prevent domain rediscovery competin
On Wed, Nov 9, 2016 at 11:09 AM, Dan Williams wrote:
> On Wed, Nov 9, 2016 at 9:36 AM, John Garry wrote:
>> On 09/11/2016 12:28, John Garry wrote:
>>>
>>> On 03/11/2016 14:58, John Garry wrote:
>>>>
>>>> The following patch introduces an annoy
On Thu, Nov 17, 2016 at 7:23 AM, John Garry wrote:
> On 11/11/2016 08:49, wangyijing wrote:
>
> I have not seen the flutter issue. I am just trying to solve the
> horrible WARN dump.
> However I do understand that there may be a issue related to how we
> queue the events; there
On Fri, Nov 18, 2016 at 1:00 AM, John Garry wrote:
> On 18/11/2016 01:53, Dan Williams wrote:
>>
>> On Thu, Nov 17, 2016 at 7:23 AM, John Garry wrote:
>>>
>>> On 11/11/2016 08:49, wangyijing wrote:
>>>>>>>
>>>>>>&g
On Mon, Nov 21, 2016 at 7:16 AM, John Garry wrote:
> @Maintainers, would you be willing to accept this patch as an interim
> fix
> for the dastardly WARN while we try to fix the flutter issue?
To me this adds a bug to quiet a benign, albeit noisy, warning.
>>>
o/?l=linux-scsi&m=147116857810716&w=4
[2]: http://marc.info/?l=linux-block&m=148554717109098&w=2
Cc: James Bottomley
Cc: Bart Van Assche
Cc: "Martin K. Petersen"
Cc: Christoph Hellwig
Cc: Jens Axboe
Reported-by: Omar Sandoval
Signed-off-by: Dan Williams
---
block/blk-
On Sun, Jan 29, 2017 at 11:22 PM, Omar Sandoval wrote:
> On Mon, Jan 30, 2017 at 08:05:52AM +0100, Hannes Reinecke wrote:
>> On 01/29/2017 05:58 AM, Dan Williams wrote:
>> > Warnings of the following form occur because scsi reuses a devt number
>> > while the block la
On Mon, Jan 30, 2017 at 4:24 AM, Christoph Hellwig wrote:
> Hi Dan,
>
> this looks mostly fine to me. A few code comments below, but except
> for this there is another issue with it: We still have drivers
> that share a single request_queue for multiple gendisks, so I wonder
>
> Also I think you
On Mon, Jan 30, 2017 at 4:24 AM, Christoph Hellwig wrote:
> Hi Dan,
>
> this looks mostly fine to me. A few code comments below, but except
> for this there is another issue with it: We still have drivers
> that share a single request_queue for multiple gendisks, so I wonder
scsi drivers or oth
o/?l=linux-scsi&m=147116857810716&w=4
[2]: http://marc.info/?l=linux-block&m=148554717109098&w=2
Cc: James Bottomley
Cc: Bart Van Assche
Cc: "Martin K. Petersen"
Cc: Christoph Hellwig
Cc: Jens Axboe
Cc: Jan Kara
Reported-by: Omar Sandoval
Signed-off-by: Dan Williams
o/?l=linux-scsi&m=147116857810716&w=4
[2]: http://marc.info/?l=linux-block&m=148554717109098&w=2
Cc: James Bottomley
Cc: Bart Van Assche
Cc: "Martin K. Petersen"
Cc: Christoph Hellwig
Cc: Jens Axboe
Cc: Jan Kara
Reported-by: Omar Sandoval
Tested-by: Omar Sandoval
Sign
On Wed, Feb 1, 2017 at 2:35 PM, Jens Axboe wrote:
> On 02/01/2017 02:05 PM, Dan Williams wrote:
>> Warnings of the following form occur because scsi reuses a devt number
>> while the block layer still has it referenced as the name of the bdi
>> [1]:
>>
>> WA
On Mon, Feb 6, 2017 at 8:09 PM, Jens Axboe wrote:
> On 02/06/2017 05:14 PM, James Bottomley wrote:
>> On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
>>> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig wrote:
>>>> Dan,
>>>>
>>>&g
On Wed, Feb 8, 2017 at 4:08 PM, James Bottomley
wrote:
> On Mon, 2017-02-06 at 21:42 -0800, Dan Williams wrote:
[..]
>> ...but it reproduces on current mainline with the same config. I
>> haven't spotted what makes scsi_debug behave like this.
>
> Looking at the config
On Wed, Aug 6, 2014 at 3:50 AM, Xiangliang Yu wrote:
> Hi, Dan & James
> How about the patches about support for PM?
> Two months had passed since I submitted the patches.
> Thanks!
>
Did you address my review comments?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
t
[ adding yuxia...@marvell.com ]
On Tue, Jun 3, 2014 at 6:41 PM, Dan Williams wrote:
> Hi, some notes below:
>
> On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu wrote:
>> Add support for SATA port softreset and port multiplier error
>> handling.
>
> Some more detailed n
Some more comments below.
[..]
>>> +
>>> + pmp = sata_srst_pmp(link);
>>> +
>>> + msecs = 0;
>>> + now = jiffies;
>>> + if (time_after(deadline, now))
>>> + msecs = jiffies_to_msecs(deadline - now);
>>> +
>>> + memset(&tf, 0, sizeof(struct ata_taskfile))
#x27;t be handled forever.
>
> Use atomic type for ->host_failed to fix this race.
>
> This fixes the problem introduced in
> commit 50824d6c5657 ("[SCSI] libsas: async ata-eh").
>
> Reviewed-by: Christoph Hellwig
> Signed-off-by: Wei Fang
Acked-by: Dan Willia
On Tue, May 31, 2016 at 8:21 PM, Dan Williams wrote:
> On Tue, May 31, 2016 at 1:38 AM, Wei Fang wrote:
>> sas_ata_strategy_handler() adds the works of the ata error handler
>> to system_unbound_wq. This workqueue asynchronously runs work items,
>> so the ata error hand
On Tue, Dec 8, 2015 at 1:08 PM, Verma, Vishal L
wrote:
> On Wed, 2015-12-09 at 08:03 +1100, NeilBrown wrote:
>> On Sat, Dec 05 2015, Verma, Vishal L wrote:
>> > >
>> > > > +int badblocks_clear(struct badblocks *bb, sector_t s, int
>> > > > sectors)
>> > > > +{
>> > > [...]
>> > > > +#define DO_DEB
Hi Jens,
Are you on-board with this approach? Any concerns with me carrying
this through the nvdimm tree along with our other pending
error-handling enabling?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majord
On Mon, Oct 19, 2015 at 8:56 AM, Christoph Hellwig wrote:
> On Mon, Oct 19, 2015 at 08:36:23AM -0700, Bart Van Assche wrote:
>> Thanks for looking into this. However, I think we need a motivation in the
>> patch description why this patch does not reintroduce the soft lockup
>> documented in patch
On Wed, Nov 4, 2015 at 2:44 PM, James Bottomley
wrote:
[..]
> The fundamental problem with this is how have the conditions that caused
> us to move away from list restart:
>
> commit bc3f02a795d3b4faa99d37390174be2a75d091bd
> Author: Dan Williams
> Date: Tue Aug 28 2
On Tue, Nov 24, 2015 at 12:10 PM, Verma, Vishal L
wrote:
> On Tue, 2015-11-24 at 14:14 -0500, Jeff Moyer wrote:
>>
>> I'm not sure whether it makes sense to continue without badblock
>> management for the RAID code. I was hoping Neil would comment on
>> that.
>>
>> -Jeff
>
> Not sure I follow? I
On Tue, Oct 15, 2013 at 5:15 PM, Praveen Murali wrote:
> Dan/James,
> Can you please take a look at this and let me know if I am at the right
> place? Or point me in the right direction? As I understand, this deost not
> look like an mvsas driver issue.
>
Looks like a latent bug in libsas to me.
On Thu, Jun 21, 2012 at 10:05 AM, Praveen Murali wrote:
> here is the updated patch.
>
> On Thu, 2012-06-21 at 09:48 -0700, Dan Williams wrote:
>> On Thu, Jun 21, 2012 at 9:41 AM, Praveen Murali wrote:
>> > Ok, do you want me to regenerate the patch?
>>
&g
On Wed, Oct 16, 2013 at 10:28 AM, Praveen Murali wrote:
>> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
>> index 161c98efade9..d0fb99d5da95 100644
>> --- a/drivers/scsi/libsas/sas_ata.c
>> +++ b/drivers/scsi/libsas/sas_ata.c
>> @@ -211,7 +211,7 @@ static unsigned int
Murali
Tested-by: Praveen Murali
Signed-off-by: Dan Williams
---
drivers/scsi/libsas/sas_ata.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index 161c98efade9..d0fb99d5da95 100644
--- a/drivers/scsi/libsas/sa
On Fri, Oct 25, 2013 at 5:47 PM, Amit Uttamchandani
wrote:
> Hello,
>
> Tested kernel 3.4.62, which introduces:
>
> libsas error handling + discovery patch set
>
> http://lwn.net/Articles/476986/
>
> Is it advisable for me to backport this to v3.2.51?
>
If you need reliable ata error handling v
sted-by: Xun Ni
Signed-off-by: Dan Williams
---
drivers/scsi/isci/port_config.c |5 -
drivers/scsi/isci/task.c|2 +-
2 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/isci/port_config.c b/drivers/scsi/isci/port_config.c
index 85c77f6b802b..4b84d204db
On Thu, Jan 2, 2014 at 2:31 AM, Suresh Thiagarajan
wrote:
>
>
> On Fri, Dec 27, 2013 at 9:48 PM, Oleg Nesterov wrote:
>> On 12/24, Suresh Thiagarajan wrote:
>>>
>>> Below is a small pseudo code on protecting/serializing the flag for global
>>> access.
>>> struct temp
>>> {
>>> ...
>>>
ink it must indicate to
libata that recovery ends by returning -ENODEV from
->lldd_I_T_nexus_reset().
Cc:
Cc: Maciej Patelczyk
Cc: Dave Jiang
Acked-by: Lukasz Dorau
Reported-by: David Milburn
Reported-by: Xun Ni
Tested-by: Xun Ni
Signed-off-by: Dan Williams
---
v2: Dave reported the build
On Mon, Dec 16, 2013 at 3:30 PM, Phillip Susi wrote:
> Don't block the resume path waiting for the disk to
> spin up.
> ---
> drivers/ata/libata-core.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index
On Fri, Jan 10, 2014 at 6:25 PM, Phillip Susi wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> On 01/10/2014 05:26 PM, Dan Williams wrote:
>> I was going to comment that this leaves us open to a race to
>> submit new i/o before recovery starts, but scsi_sched
On Fri, Jan 10, 2014 at 6:13 PM, Phillip Susi wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> On 01/10/2014 06:11 PM, Brandt, Todd E wrote:
>> Yes yours is simpler, but it also opens a potential memory issue
>> by passing a static int as the return location for the error value.
>> I
On Mon, Jan 13, 2014 at 12:06 PM, Todd E Brandt
wrote:
> On Fri, Jan 10, 2014 at 07:13:11PM -0800, Dan Williams wrote:
>> On Fri, Jan 10, 2014 at 6:13 PM, Phillip Susi wrote:
>> > -BEGIN PGP SIGNED MESSAGE-
>> > Hash: SHA512
>> >
>> >
On Mon, Jan 13, 2014 at 3:51 PM, Todd E Brandt
wrote:
> On Mon, Jan 13, 2014 at 12:37:01PM -0800, Dan Williams wrote:
>> On Mon, Jan 13, 2014 at 12:06 PM, Todd E Brandt
>> > Actually there's one other reason. In the ata_port_request_pm function it
>> > checks to
On Fri, Jan 17, 2014 at 6:57 AM, Alan Stern wrote:
> On Thu, 16 Jan 2014, Todd E Brandt wrote:
>> My patch makes ata port and scsi disk resume 'non-blocking' (asynchronous
>> with respect to system resume). Which means once they're called the power
>> manager pays no more attention to them and wil
On Fri, Jan 17, 2014 at 12:49 PM, Phillip Susi wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 1/17/2014 2:31 PM, Dan Williams wrote:
>> Once dpm_resume of the disk is asynchronous, is there much
>> incremental gain by further deferring spin up? The drawba
On Wed, Jan 15, 2014 at 8:38 PM, Todd E Brandt
wrote:
> On resume, the ATA port driver currently waits until the AHCI controller
> finishes executing the port wakeup command. This patch changes the
> ata_port_resume callback to issue the wakeup and then return immediately,
> thus allowing the next
On Fri, Jan 17, 2014 at 5:41 PM, Alan Stern wrote:
> On Fri, 17 Jan 2014, Tejun Heo wrote:
>
>> On Fri, Jan 17, 2014 at 03:15:54PM -0500, Alan Stern wrote:
>> > You will have to argue this point with Phillip.
>> >
>> > If necessary, we could add a sysfs attribute to force a spin-up during
>> > sys
On Fri, Jan 17, 2014 at 7:18 PM, Phillip Susi wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> On 01/17/2014 05:17 PM, Dan Williams wrote:
>> Well, "at all" is overstating it. The system was idle and now
>> it's being woken up to do some work
;
> The loop has been corrected.
> This patch fixes the above oops.
>
> Signed-off-by: Lukasz Dorau
> Reviewed-by: Maciej Patelczyk
> Tested-by: Lukasz Dorau
> Cc: Dan Williams
> Cc: Dave Jiang
> Cc:
> ---
> drivers/scsi/isci/host.h |6 +++---
> 1 file
On Sat, Jan 18, 2014 at 6:08 AM, Alan Stern wrote:
> On Fri, 17 Jan 2014, Dan Williams wrote:
>
>> I think it's a bit of an interface surprise to have pm_runtime disable
>> have side effects only for scsi_disk devices. I think lazy_resume
>> needs to be an explici
On Tue, Jan 21, 2014 at 7:44 AM, Alan Stern wrote:
> On Tue, 21 Jan 2014, Dan Williams wrote:
>
>> On Sat, Jan 18, 2014 at 6:08 AM, Alan Stern
>> wrote:
>> > On Fri, 17 Jan 2014, Dan Williams wrote:
>> >
>> >> I think it's a bit of an int
On Tue, Jan 21, 2014 at 8:18 AM, Dan Williams wrote:
> On Tue, Jan 21, 2014 at 7:44 AM, Alan Stern wrote:
>> On Tue, 21 Jan 2014, Dan Williams wrote:
>>
>>> On Sat, Jan 18, 2014 at 6:08 AM, Alan Stern
>>> wrote:
>>> > On Fri, 17 Jan 2014, Dan Willi
In addition to disk drives with internally tiered-storage (solid-state
+ magnetic media) the kernel has also grown native I/O-caching /
tiered-storage implementations in bcache and dm-cache.
Currently, all these solutions depend on heuristics to determine what
tier the data referenced in an I/O be
On Tue, Jan 28, 2014 at 2:57 PM, Dan Williams wrote:
> In addition to disk drives with internally tiered-storage (solid-state
> + magnetic media) the kernel has also grown native I/O-caching /
> tiered-storage implementations in bcache and dm-cache.
>
> Currently, all these solu
On Tue, Jul 16, 2013 at 7:54 PM, Xinghai Yu wrote:
> It seems the "phy_index++;" have been placed in wrong place, without it
> the while circle up will do a infinite loop.
>
> Signed-off-by: Xinghai Yu
> ---
> drivers/scsi/isci/port_config.c |2 +-
> 1 files changed, 1 insertions(+), 1 delet
dev->sata_dev.fis[2] = ATA_ERR;
The end effect is that isci is needlessly triggering hard resets when
they are not necessary.
Cc:
Reported-by: Xun Ni
Tested-by: Nelson Cheng
Acked-by: Lukasz Dorau
Signed-off-by: Dan Williams
---
drivers/scsi/isci/request.c |8 ++--
1 files
Hi James,
Here are some collected fixes. All but patch 2 are tagged for -stable.
Patch 1 and 4 have been on the list since before the 3.14 merge window,
patch 2 and 3 are new.
Please apply, thank you.
[PATCH 1/4] isci: fix reset timeout handling
[PATCH 2/4] scsi, libsas: introduce scmd_dbg() t
Kumar Santhanam
Cc: Sangeetha Gnanasekaran
Cc: Nikith Ganigarakoppal
Reported-by: Xun Ni
Tested-by: Nelson Cheng
Acked-by: Lukasz Dorau
Signed-off-by: Dan Williams
---
drivers/scsi/libsas/sas_scsi_host.c |2 +-
include/scsi/scsi_device.h | 12
2 files changed,
0x1b
The loop has been corrected.
This patch fixes kernel panic during entering the S3 state
and the above oops.
Signed-off-by: Lukasz Dorau
Reviewed-by: Maciej Patelczyk
Tested-by: Lukasz Dorau
Cc: Dave Jiang
Cc:
Signed-off-by: Dan Williams
---
drivers/scsi/isci/host.h |5 ++---
1 files cha
ink it must indicate to
libata that recovery ends by returning -ENODEV from
->lldd_I_T_nexus_reset().
Cc:
Cc: Maciej Patelczyk
Cc: Dave Jiang
Acked-by: Lukasz Dorau
Reported-by: David Milburn
Reported-by: Xun Ni
Tested-by: Xun Ni
Signed-off-by: Dan Williams
---
drivers/scsi/is
- sas_bsg_remove(shost, rphy);
> -
> transport_destroy_device(dev);
>
> put_device(dev);
> @@ -1681,6 +1679,7 @@ sas_rphy_remove(struct sas_rphy *rphy)
> }
>
> sas_rphy_unlink(rphy);
> + sas_bsg_remove(NULL, rphy);
> transport_rem
On Wed, Feb 12, 2014 at 9:41 AM, Richard Yao wrote:
> You should use `git send-email` to send the patch to all of the people
> listed by get_maintainer.pl:
I see nothing wrong with the patch Joe originally submitted:
http://marc.info/?l=linux-scsi&m=138609455422179&w=2
>
> richard@desktop ~/deve
On Sun, Feb 23, 2014 at 12:12 PM, James Bottomley
wrote:
>
> On Thu, 2014-02-06 at 12:22 -0800, Dan Williams wrote:
>> Hi James,
>>
>> Here are some collected fixes. All but patch 2 are tagged for -stable.
>>
>> Patch 1 and 4 have been on the list since befo
-scsi&m=138995409532286&w=2
Cc: Phillip Susi
Cc: Alan Stern
Suggested-by: Tejun Heo
Signed-off-by: Todd Brandt
Signed-off-by: Dan Williams
---
drivers/ata/libata-core.c | 75 +++--
drivers/ata/libata-eh.c | 13 +--
drivers/scsi/libsa
the async queue]
Signed-off-by: Dan Williams
---
drivers/scsi/scsi.c |3 +
drivers/scsi/scsi_pm.c | 115 --
drivers/scsi/scsi_priv.h |1
drivers/scsi/sd.c|1
4 files changed, 95 insertions(+), 25 deletions(-)
diff --git
info/?l=linux-ide&m=138984698103487&w=2
[PATCH v4 1/2] http://marc.info/?l=linux-ide&m=138984713203515&w=2
[PATCH v4 2/2] http://marc.info/?l=linux-ide&m=138984722003539&w=2
---
Dan Williams (2):
libata, libsas: kill pm_result and related cleanup
scsi: async sd
starts on the given
ata_port.
Reference:
https://01.org/suspendresume/blogs/tebrandt/2013/hard-disk-resume-optimization-simpler-approach
Cc: Len Brown
Cc: Phillip Susi
Cc: Alan Stern
Signed-off-by: Todd Brandt
[djbw: rebase on cleanup patch, changelog wordsmithing]
Signed-off-by: Dan Williams
mann
> Tested-by: Daniel Mack
> CC: Oliver Neukum
> CC:
> ---
> Hi,
>
> this patch has been around for awhile, but hasn't gained much
> attraction, and hasn't been merged anywhere yet. Which is sad,
> as it fixes a bug on real hardware when going to suspend :
On Fri, Mar 7, 2014 at 7:42 AM, Alan Stern wrote:
> On Wed, 5 Mar 2014, Dan Williams wrote:
>
>> async_schedule() sd resume work to allow disks and other devices to
>> resume in parallel.
>>
>> This moves the entirety of scsi_device resume to an async context to
>
one
> function call.
[..]
> Given that this function is used in only one place; I would put it
> inline.
>
Ended up putting the dev->driver->pm lookup into scsi_dev_type_{suspend|
resume} directly, and open coding the pm->op is NULL check.
Moved the lookup of the async functi
On Mon, Mar 10, 2014 at 1:43 PM, Tejun Heo wrote:
> On Fri, Mar 07, 2014 at 06:52:06PM -0800, Dan Williams wrote:
>> From: Dan Williams
>>
>> async_schedule() sd resume work to allow disks and other devices to
>> resume in parallel.
>>
>> This moves the ent
On Mon, Mar 10, 2014 at 1:59 PM, Alan Stern wrote:
> On Mon, 10 Mar 2014, Dan Williams wrote:
>
>> > The only thing which is a bit concerning is that this doesn't have any
>> > throttling mechanism for simultaneous wakeups. Would this be able to
>> > blow
On Mon, Mar 10, 2014 at 9:19 PM, James Bottomley
wrote:
> On Mon, 2014-03-10 at 16:59 -0400, Alan Stern wrote:
>> On Mon, 10 Mar 2014, Dan Williams wrote:
>>
>> > > The only thing which is a bit concerning is that this doesn't have any
>> > > throttlin
On Mon, Mar 10, 2014 at 10:16 PM, James Bottomley
wrote:
> On Mon, 2014-03-10 at 21:47 -0700, Dan Williams wrote:
>> On Mon, Mar 10, 2014 at 9:19 PM, James Bottomley
>> wrote:
>> > On Mon, 2014-03-10 at 16:59 -0400, Alan Stern wrote:
>> >> On
On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley
wrote:
>> > In the long game, though this whole debate is moot: setups with hard
>> > wired start times adhere to them regardless of what the system does, so
>> > they ignore start unit commands. Systems without hard wired start times
>> > can usu
org/suspendresume/blogs/tebrandt/2013/hard-disk-resume-optimization-simpler-approach
[2]: Todd's v4 patchset:
[PATCH v4 0/2] http://marc.info/?l=linux-ide&m=138984698103487&w=2
[PATCH v4 1/2] http://marc.info/?l=linux-ide&m=138984713203515&w=2
[PATCH v4 2/2] http://marc.info/?l=
starts on the given
ata_port.
Reference:
https://01.org/suspendresume/blogs/tebrandt/2013/hard-disk-resume-optimization-simpler-approach
Cc: Len Brown
Cc: Phillip Susi
Cc: Alan Stern
Signed-off-by: Todd Brandt
[djbw: rebase on cleanup patch, changelog wordsmithing]
Signed-off-by: Dan Williams
g fix and clean up suggestion]
Acked-by: Alan Stern
Suggested-by: Todd Brandt
[djbw: kick all resume work to the async queue]
Signed-off-by: Dan Williams
---
drivers/scsi/Kconfig |3 +
drivers/scsi/scsi.c |3 +
drivers/scsi/scsi_pm.c |
532286&w=2
Cc: Phillip Susi
Cc: Alan Stern
Suggested-by: Tejun Heo
Signed-off-by: Todd Brandt
Signed-off-by: Dan Williams
---
drivers/ata/libata-core.c | 135 ++---
drivers/ata/libata-eh.c | 13 +---
drivers/scsi/libsas/sas_ata.c | 35 +
On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley
wrote:
> On Fri, 2014-03-14 at 13:11 -0700, Dan Williams wrote:
>> On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley
>> wrote:
>> >> > In the long game, though this whole debate is moot: setups with hard
>> &
On Sun, 2014-03-16 at 11:21 -0700, James Bottomley wrote:
> On Sat, 2014-03-15 at 16:35 -0700, Dan Williams wrote:
> > On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley
> > wrote:
> > > On Fri, 2014-03-14 at 13:11 -0700, Dan Williams wrote:
> > >> On Mon, Mar 1
On Tue, Mar 18, 2014 at 9:03 AM, Tejun Heo wrote:
> On Fri, Mar 14, 2014 at 01:52:48PM -0700, Dan Williams wrote:
>> Tejun says:
>> "At least for libata, worrying about suspend/resume failures don't make
>>whole lot of sense. If suspend failed, just proc
msleep(struct ata_port *ap, unsigned int msecs);
>
> Applied to libata/for-3.15.
>
> Thanks.
Agh, my mistake... one more incremental fixlet:
8<--
Subject: libata: remove unused ata_sas_port_async_resume() stub
From: Dan Williams
Commit bc6e7c4b0d1a "libata, l
On Wed, Mar 19, 2014 at 1:31 PM, Alan Stern wrote:
> On Wed, 19 Mar 2014, Andreas Reis wrote:
>
>> I've uploaded a dmesg with the new debugging patch to bugzilla:
>> https://bugzilla.kernel.org/attachment.cgi?id=130041
>
> Thanks. I have now managed to reproduce many of the features of this
> pro
On Mon, 2014-03-17 at 11:20 -0700, Dan Williams wrote:
> On Sun, 2014-03-16 at 11:21 -0700, James Bottomley wrote:
> > On Sat, 2014-03-15 at 16:35 -0700, Dan Williams wrote:
> > > On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley
> > > > Hm, OK, if this is tied at the
c-scsi-resume
for you to fetch changes up to 3c31b52f96f7b559d950b16113c0f68c72a1985e:
scsi: async sd resume (2014-04-10 15:30:35 -0700)
--------
Dan Williams (1):
scsi: async sd resume
drivers/scsi/Kconfig | 3 ++
drivers/sc
On Fri, Apr 11, 2014 at 11:20 AM, James Bottomley
wrote:
> On Thu, 2014-04-10 at 18:24 -0700, Dan Williams wrote:
>> Hi Linus,
>>
>> James might still be in the process of sending this your way. However,
>> given the proximity to -rc1, my reasoning for sending th
On Wed, Apr 16, 2014 at 8:07 PM, xiangliang yu wrote:
> hi,
>
> The patch is support SATA PM device and can find all devices that is
> attached to PM.
> Until now, i have tested the identified, hot-plug and IO function and
> result is ok except one mvsas timeout issue.
> i'll continue to debug mv
On Thu, Apr 17, 2014 at 9:03 AM, Dan Williams wrote:
> On Wed, Apr 16, 2014 at 8:07 PM, xiangliang yu wrote:
>> hi,
>>
>> The patch is support SATA PM device and can find all devices that is
>> attached to PM.
>> Until now, i have tested the identified, hot-plug
[ adding Ben ]
On Mon, Apr 28, 2014 at 10:22 AM, Ondrej Zary
wrote:
> On Monday 28 April 2014 18:51:44 Jiang, Dave wrote:
>> On Mon, 2014-04-28 at 16:28 +, Ondrej Zary wrote:
>> > On Monday 28 April 2014 17:50:29 Jiang, Dave wrote:
>> > > On Mon, 2014-04-28 at 13:03 +0200, Ondrej Zary wrote:
On Fri, May 2, 2014 at 8:36 AM, Tejun Heo wrote:
> On Thu, Apr 24, 2014 at 09:27:03PM +0800, Xiangliang Yu wrote:
>> This patch set will support SATA port multiplier(PM) in LIBSAS.
>>
>> LIBSAS is need to implement several key handling to support SATA PM:
>> First,low level driver notify libsas th
t found for kobject on mpt2sas unload
>> http://marc.info/?t=13849746004
>>
>> (patch + ACK + comments)
>> http://marc.info/?t=13860945551
>>
>> (gentoo, LSI repro)
>> mpt2sas driver barfs when force removing a drive on 3.13.1
>> ht
On Tue, Jun 3, 2014 at 12:13 AM, Xiangliang Yu wrote:
> Hi,
>
> How about the patch?
>
I'll take a look today. Sorry for the latency.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger
1 - 100 of 201 matches
Mail list logo
