[PATCH] scsi:gdth.c: fix compilation warning

2012-12-03 Thread Cong Ding
We do not allow old-style function definition. Always spell foo(void) if a function does not take any parameters. Signed-off-by: Cong Ding --- drivers/scsi/gdth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index 5d72274

Re: [PATCH] scsi:gdth.c: fix compilation warning

2012-12-09 Thread Cong Ding
ping! - cong On Mon, Dec 03, 2012 at 10:19:09AM +, Cong Ding wrote: > We do not allow old-style function definition. Always spell foo(void) if > a function does not take any parameters. > > Signed-off-by: Cong Ding > --- > drivers/scsi/gdth.c |2 +- > 1 files

Re: [PATCH] scsi:gdth.c: fix compilation warning

2013-01-18 Thread Cong Ding
Hi all, is this still in the queue or...? - cong On Mon, Dec 3, 2012 at 11:19 AM, Cong Ding wrote: > We do not allow old-style function definition. Always spell foo(void) if > a function does not take any parameters. > > Signed-off-by: Cong Ding > --- > drivers/scsi/gdt

[PATCH] scsi: qla2xxx/qla_attr.c: fix undefined behavior in using snprintf

2013-02-07 Thread Cong Ding
The original code snprintf(buf, PAGE_SIZE, "%s\n", buf); uses buf as both source and destination string, which is undefined behavior based on C11: If copying takes place between objects that overlap, the behavior is undefined. Signed-off-by: Cong Ding --- dr