Re: [PATCH v2 5/6] phy: mediatek: Add UFS M-PHY driver

Hi Stanley, On Mon, 2019-02-25 at 17:24 +0800, stanley@mediatek.com wrote: > From: Stanley Chu > > Add UFS M-PHY driver on Mediatek chipsets. > > Signed-off-by: Stanley Chu > --- > drivers/phy/mediatek/Kconfig| 29 ++-- > drivers/phy/mediatek/Makefile | 2 + > dri

Re: [PATCH v3 6/7] phy: mediatek: Add UFS M-PHY driver

return PTR_ERR(phy->mmio); > + > + phy->dev = dev; > + > + ret = ufs_mtk_phy_clk_init(phy); > + if (ret) > + return ret; > + > + generic_phy = devm_phy_create(dev, NULL, &ufs_mtk_phy_ops); > + if (IS_ERR(generic_phy)) > + return PTR_ERR(generic_phy); > + > + phy_set_drvdata(generic_phy, phy); > + > + phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > + > + return PTR_ERR_OR_ZERO(phy_provider); > +} > + > +static const struct of_device_id ufs_mtk_phy_of_match[] = { > + {.compatible = "mediatek,ufs-mphy"}, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, ufs_mtk_phy_of_match); > + > +static struct platform_driver ufs_mtk_phy_driver = { > + .probe = ufs_mtk_phy_probe, > + .driver = { > + .of_match_table = ufs_mtk_phy_of_match, > + .name = "ufs_mtk_phy", > + }, > +}; > +module_platform_driver(ufs_mtk_phy_driver); > + > +MODULE_DESCRIPTION("Universal Flash Storage (UFS) MediaTek MPHY"); > +MODULE_AUTHOR("Stanley Chu "); > +MODULE_LICENSE("GPL v2"); > + Reviewed-by: Chunfeng Yun