[PATCH] drivers/target/target_core_transport.c: Fix typo issue to use 'buf' instead of 'len'

2014-09-03 Thread Chen Gang
from include/linux/net.h:25, from drivers/target/target_core_transport.c:26: include/linux/string.h:83:24: note: expected ‘const char *’ but argument is of type ‘int’ extern __kernel_size_t strlen(const char *); ^ Signed-off-by: Chen Gang

[PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-26 Thread Chen Gang
let 'err' be 0. And also need change the related comments for xenbus_switch_state(). Signed-off-by: Chen Gang --- drivers/block/xen-blkback/xenbus.c | 9 ++--- drivers/net/xen-netback/xenbus.c | 5 + drivers/pci/xen-pcifront.c | 15 ++- drivers/x

Re: [Xen-devel] [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-27 Thread Chen Gang
On 09/27/2014 02:07 AM, David Vrabel wrote: > On 26/09/14 17:36, Chen Gang wrote: >> When xenbus_switch_state() fails, it will call xenbus_switch_fatal() >> internally, so need not return any status value, then use 'void' instead >> of 'int' for xenbus

Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-30 Thread Chen Gang
On 9/29/14 22:02, Konrad Rzeszutek Wilk wrote: > On Sat, Sep 27, 2014 at 12:36:42AM +0800, Chen Gang wrote: >> When xenbus_switch_state() fails, it will call xenbus_switch_fatal() > > Only on the first depth, not on the subsequent ones (as in if > the first xenbus_switch_fail f

Re: [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-30 Thread Chen Gang
On 9/30/14 17:55, David Vrabel wrote: > On 26/09/14 17:36, Chen Gang wrote: >> When xenbus_switch_state() fails, it will call xenbus_switch_fatal() >> internally, so need not return any status value, then use 'void' instead >> of 'int' for xenbus

[Suggestion] drivers/target/sbp/ : set tport->tpg to NULL when clean up for failure.

2012-12-05 Thread Chen Gang
Hello Maintainers: in drivers/target/sbp/sbp_target.c: tport->tpg must be NULL before process it in function sbp_make_tpg. (line 2185..2188) tport->tpg assigned a ptr (line 2198) if processing failed, not set tport->tpg = NULL (line 2208..2212, 2217..2221) we have done: when free t

Re: [Suggestion] drivers/target/sbp/ : set tport->tpg to NULL when clean up for failure.

2012-12-06 Thread Chen Gang
于 2012年12月06日 16:34, Chris Boot 写道: > On 06/12/12 04:24, Chen Gang wrote: >> Hello Maintainers: >> >> in drivers/target/sbp/sbp_target.c: >> >>tport->tpg must be NULL before process it in function sbp_make_tpg. (line >> 2185..2188) >>

Re: [Suggestion] drivers/target/sbp/ : set tport->tpg to NULL when clean up for failure.

2012-12-09 Thread Chen Gang
Hello Chris Boot: need I send the relative patch ? Regards gchen. 于 2012年12月06日 16:40, Chen Gang 写道: > 于 2012年12月06日 16:34, Chris Boot 写道: >> On 06/12/12 04:24, Chen Gang wrote: >>> Hello Maintainers: >>> >>> in drivers/target/sbp/sbp_target.c: >&

Re: [Suggestion] drivers/target/sbp/ : set tport->tpg to NULL when clean up for failure.

2012-12-10 Thread Chen Gang
于 2012年12月10日 16:02, Chris Boot 写道: > On 10/12/12 02:39, Chen Gang wrote: >> Hello Chris Boot: >> >> need I send the relative patch ? > > Hi Chen, > > Sorry, life got in the way this weekend. I'll try to get the patch sent > out today. > > Che

Re: [Suggestion] drivers/target/sbp/ : set tport->tpg to NULL when clean up for failure.

2012-12-13 Thread Chen Gang
于 2012年12月10日 16:02, Chris Boot 写道: > On 10/12/12 02:39, Chen Gang wrote: >> Hello Chris Boot: >> >> need I send the relative patch ? > > Hi Chen, > > Sorry, life got in the way this weekend. I'll try to get the patch sent > out today. > H

Re: [Suggestion] drivers/target/sbp/ : set tport->tpg to NULL when clean up for failure.

2012-12-13 Thread Chen Gang
于 2012年12月14日 14:57, Stefan Richter 写道: > On Dec 14 Chen Gang wrote: >> 于 2012年12月10日 16:02, Chris Boot 写道: >>> On 10/12/12 02:39, Chen Gang wrote: >>>> Hello Chris Boot: >>>> >>>> need I send the relative patch ? >>> >>> H

Re: [Suggestion] drivers/target/sbp/ : set tport->tpg to NULL when clean up for failure.

2012-12-14 Thread Chen Gang
于 2012年12月15日 08:33, Nicholas A. Bellinger 写道: > > FYI folks, this fix from Chris was included in the [GIT PULL] request > for v3.8-rc1 sent out today. > thanks and now I am in target-de...@vger.kernel.org, too. :-) > Thanks! > > --nab > > > --

[PATCH] drivers/scsi/cxgbi: correcting the include path, so can pass compiling.

2013-01-12 Thread Chen Gang
correct the include path, or the compiler will report can not find "common.h"... both cxgb3/ and cxgb4/ sub directly have l2t.h (they are different). so it is not suitable to '-I' sub-directy, directly. Signed-off-by: Chen Gang --- drivers/scsi/cxgbi/Ma

Re: [PATCH] drivers/scsi/cxgbi: correcting the include path, so can pass compiling.

2013-01-19 Thread Chen Gang
Hello jbottom...@parallels.com when you have free time, could you give a glance for this patch ? thanks. gchen. 于 2013年01月12日 20:42, Chen Gang 写道: > > correct the include path, > or the compiler will report can not find "common.h"... > > both cxgb3/ and

Re: [PATCH] drivers/scsi/cxgbi: correcting the include path, so can pass compiling.

2013-01-28 Thread Chen Gang
) thanks. by the way: I get the sending mail address from ./script/get_maintainer.pl. if I sent to an incorrect member, please tell me. thanks. gchen. 于 2013年01月20日 15:18, Chen Gang 写道: > Hello jbottom...@parallels.com > > when you have free time, could you give a glance

Re: [PATCH] drivers/scsi/cxgbi: correcting the include path, so can pass compiling.

2013-02-27 Thread Chen Gang
have time. thanks. :-) gchen. 于 2013年01月29日 15:35, Chen Gang 写道: > Hello jbottom...@parallels.com > > have you already fixed it by another patches ? > > if so: > better to let me know about it, so I should not bother you, again. > else > please giv

Re: [PATCH] drivers/scsi/cxgbi: correcting the include path, so can pass compiling.

2013-02-27 Thread Chen Gang
1766 "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement ->{$flag}); I need send new patch for it. welcome any members to provide additional suggestions or completions. thanks.

[PATCH] drivers/scsi/cxgbi: using ccflags-y instead of EXTRA_CFLAGS in Kbuild

2013-02-27 Thread Chen Gang
need using ccflags-y instead of EXTRA_CFLAGS can reference scripts/checkpatch.pl (1755..1766) when make EXTRA_CFLAGS=-W, the compiling issue will be occured. Signed-off-by: Chen Gang --- drivers/scsi/cxgbi/cxgb3i/Kbuild |2 +- drivers/scsi/cxgbi/cxgb4i/Kbuild |2 +- 2 files

Re: [PATCH] drivers/scsi/cxgbi: using ccflags-y instead of EXTRA_CFLAGS in Kbuild

2013-04-06 Thread Chen Gang
Hello Maintainers: please help check it when you have time. thanks. gchen. On 2013年02月28日 14:34, Chen Gang wrote: > > need using ccflags-y instead of EXTRA_CFLAGS > can reference scripts/checkpatch.pl (1755..1766) > > when make EXTRA_CFLAGS=-W, the compiling issue

[PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-11-26 Thread Chen Gang
arch/hexagon/include/uapi/asm/registers.h:9:0: note: this is the location of the previous definition Signed-off-by: Chen Gang --- drivers/scsi/scsi_lib.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c in

Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-12-01 Thread Chen Gang
On 12/02/2013 12:17 AM, Bart Van Assche wrote: > On 11/27/13 03:29, Chen Gang wrote: >> the macro "SP" is too common to make conflict with some architectures, >> so recommend to add prefix for it. >> >> The related warning (with allmodconfig for hexagon): >

Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-12-02 Thread Chen Gang
On 12/02/2013 08:49 AM, James Bottomley wrote: > On Mon, 2013-12-02 at 08:34 +0800, Chen Gang wrote: >> On 12/02/2013 12:17 AM, Bart Van Assche wrote: >>> On 11/27/13 03:29, Chen Gang wrote: >>>> the macro "SP" is too common to make conflict with some archit

Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

2013-12-03 Thread Chen Gang
On 12/03/2013 05:32 AM, rkuo wrote: > On Mon, Dec 02, 2013 at 06:14:33PM +0800, Chen Gang wrote: >> If one issue occurs, normally, both sides need improvement. >> >> For our issue: >> >> - need try to keep uapi no touch ("arch/hexagon/uapi/asm/registers.h&qu

[PATCH v2] drivers: scsi: scsi_lib.c: use SG_POOL instead of SP

2013-12-03 Thread Chen Gang
/scsi_lib.c:46:0: warning: "SP" redefined [enabled by default] arch/hexagon/include/uapi/asm/registers.h:9:0: note: this is the location of the previous definition Signed-off-by: Chen Gang --- drivers/scsi/scsi_lib.c | 16 1 files changed, 8 insertions(+), 8 deletion

[PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-20 Thread Chen Gang
32 variable, or will cause type overflow issue. Signed-off-by: Chen Gang --- drivers/target/target_core_alua.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c index dc0d399..ff2aadc 100644

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-22 Thread Chen Gang
On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: > Hi Chen, > > On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: >> In kernel, need use div64_u64_rem() instead of operator '%' for u64, or >> can not pass compiling (with allmodconfig under metag): >> &

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-23 Thread Chen Gang
On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: > On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: >> On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: >>> Hi Chen, >>> >>> On Sat, 2013-12-21 at 10:08 +0800, Chen Gang wrote: >>>> In kern

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-08 Thread Chen Gang
On 01/08/2014 03:32 PM, Hannes Reinecke wrote: > On 12/24/2013 04:35 AM, Chen Gang wrote: >> On 12/23/2013 02:51 PM, Nicholas A. Bellinger wrote: >>> On Sun, 2013-12-22 at 17:17 +0800, Chen Gang wrote: >>>> On 12/22/2013 10:56 AM, Nicholas A. Bellinger wrote: >

Re: [PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2014-01-10 Thread Chen Gang
had been calculated with the >> original fix) is immaterial here. >> >> Sorry for this. The email thread just flew past me during Xmas >> with me not paying real attention. >> > > Applied + squashed. Apologies for the initial pre-holiday BUG.. > > Thanks Hannes! > Thank all of you. -- Chen Gang Open, share and attitude like air, water and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] drivers: scsi: mvsas: fix compiling issue by adding 'MVS_' for "enum pci_interrupt_cause"

2014-05-08 Thread Chen Gang
/mvsas/mv_94xx.h:176: error: expected identifier before numeric constant And "enum pci_interrupt_cause" may will be useful for kernel drivers, although at present, it is not used in kernel. So add 'MVS_' for it. Signed-off-by: Chen Gang --- drivers/scsi/

Re: [PATCH] drivers: scsi: mvsas: fix compiling issue by adding 'MVS_' for "enum pci_interrupt_cause"

2014-05-08 Thread Chen Gang
Oh, sorry, this patch is incorrect: IRQ_SAS_A and IRQ_SAS_B are used as 'u32' (although they are members of "enum pci_interrupt_cause"). I will send patch v2 for it. On 05/09/2014 07:45 AM, Chen Gang wrote: > The direct cause is IRQ_SPI is already defined as a macro in u

[PATCH v2] [PATCH] drivers: scsi: mvsas: fix compiling issue by adding 'MVS_' for "enum pci_interrupt_cause"

2014-05-08 Thread Chen Gang
/mvsas/mv_94xx.h:176: error: expected identifier before numeric constant And IRQ_SAS_A and IRQ_SAS_B are used as 'u32' (although "enum pci_interrupt_cause" is not used directly, now). All together, need add 'MVS_' for "enum pci_interrupt_cause". Signed-of

Re: [PATCH v2] [PATCH] drivers: scsi: mvsas: fix compiling issue by adding 'MVS_' for "enum pci_interrupt_cause"

2014-05-19 Thread Chen Gang
On 05/20/2014 01:18 AM, Christoph Hellwig wrote: > Looks good to me, > > Reviewed-by: Christoph Hellwig > OK, thanks. And I shall continue, and should finish allmodconfig for unicore32 within this month (which I already delayed one month more). Thanks. -- Chen Gang Open

[PATCH] drivers: scsi: qla2xxx: Remove redundant declaration in 'qla_gbl.h'

2014-11-01 Thread Chen Gang
e void qla8044_set_qsnt_ready(struct scsi_qla_host *vha); ^ Signed-off-by: Chen Gang --- drivers/scsi/qla2xxx/qla_gbl.h | 2 -- drivers/scsi/qla2xxx/qla_nx2.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/drivers/scsi/qla

[PATCH] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-11-09 Thread Chen Gang
's or ld's issue), the related error (with allmodconfig under tile): MODPOST 4002 modules ERROR: "megasas_return_cmd" [drivers/scsi/megaraid/megaraid_sas.ko] undefined! ERROR: "megasas_is_ldio" [drivers/scsi/megaraid/megaraid_sas.ko] undefined! Signed-off-b

[PATCH] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-11-09 Thread Chen Gang
's or ld's issue), the related error (with allmodconfig under tile): MODPOST 4002 modules ERROR: "megasas_return_cmd" [drivers/scsi/megaraid/megaraid_sas.ko] undefined! ERROR: "megasas_is_ldio" [drivers/scsi/megaraid/megaraid_sas.ko] undefined! Signed-off-b

RE: [PATCH] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-11-17 Thread Chen Gang
OK, I will send patch v2 for it. I sent this patch based on Linux next tree, please tell me the tree location (git address) which I shall base on for sending patch v2. Thanks. Send from Lenovo A788t. Sumit Saxena wrote: >>-Original Message- >>From: Chen Gang [mailto

Re: [PATCH] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-11-29 Thread Chen Gang
On 11/17/14 19:51, Sumit Saxena wrote: >> -Original Message- >> From: Chen Gang [mailto:gang.chen.5...@gmail.com] >> Sent: Monday, November 17, 2014 5:17 PM >> To: Sumit Saxena >> Cc: megaraidli...@lsi.com; linux-scsi@vger.kernel.org; linux- >> ker...@vg

Re: [PATCH] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-12-10 Thread Chen Gang
On 12/10/14 16:47, Sumit Saxena wrote: >> From: Chen Gang [mailto:gang.chen.5...@gmail.com] >> Sent: Sunday, November 30, 2014 8:37 AM >> >> Is it OK? or if possible, please help rebase and send the patch for it >> based on >> the related branches and patches.

[PATCH v2] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-12-14 Thread Chen Gang
For shared inline functions crossed source files, better to let it as "static inline" in a header file. For extern functions, better to declare them in header file. Signed-off-by: Chen Gang --- drivers/scsi/megaraid/megaraid_sas_base.c | 76 + drivers/scs

Re: [PATCH v2] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2015-01-02 Thread Chen Gang
Could you provide more detail for it, then I can make patch v3 (or I have no any idea about it). Thanks 发自我的 iPad > 在 2014年12月30日,下午8:45,Christoph Hellwig 写道: > >> On Mon, Dec 15, 2014 at 12:05:22AM +0800, Chen Gang wrote: >> For shared inline functions crossed source fi

[PATCH] scsi: bfa: bfad_bsg: Avoid memory overflow in bfad_iocmd_ioc_get_info()

2015-01-02 Thread Chen Gang
undefined statement is here for (i = 0; iocmd->adapter_hwpath[i] != ':' && i < BFA_STRING_32; i++) ^ Signed-off-by: Chen Gang --- drivers/scsi/bfa/bfad_bsg.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/bfa/bfa