Commit 8de580742fee ("scsi: storvsc: Fix a bug in
copy_from_bounce_buffer()"), actually modified the function
copy_to_bounce_buffer(). Is the commit message wrong, or was the patch
applied to the wrong function?
Ben.
--
Ben Hutchings
Computers are not intelligent. They only thin
On Sun, 2015-08-09 at 02:01 +, KY Srinivasan wrote:
>
> > -Original Message-
> > From: KY Srinivasan
> > Sent: Saturday, August 8, 2015 7:55 AM
> > To: 'Ben Hutchings'
> > Cc: Long Li ; linux-scsi
> > Subject: RE: [PATCH] sc
Reinecke
Signed-off-by: Martin K. Petersen
Signed-off-by: Ben Hutchings
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -1625,7 +1625,10
On !x86 we currently don't read the existing support flags:
/home/benh/linux-3.14.13/drivers/scsi/hpsa.c:4375:17: warning: 'driver_support'
is used uninitialized in this function [-Wuninitialized]
driver_support |= ENABLE_UNIT_ATTN;
^
Signed-off-by: Ben H
On Sun, 2014-07-20 at 17:42 -0700, Christoph Hellwig wrote:
> On Mon, Jul 21, 2014 at 01:09:17AM +0100, Ben Hutchings wrote:
> > On !x86 we currently don't read the existing support flags:
>
> Arnd already sent this and I've included it in the for-3.17 queue.
Thanks.
5 17:52:02 2016 -0500
sd: Fix discard granularity when LBPRZ=1
)
Ben.
--
Ben Hutchings
When in doubt, use brute force. - Ken Thompson
signature.asc
Description: This is a digitally signed message part
static
array so that sizeof() does what was intended.
Compile-tested only.
Signed-off-by: Ben Hutchings
Cc: sta...@vger.kernel.org
---
drivers/scsi/sd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index c1c5552..6f6a1b4 100644
--- a/dri
The ufs driver doesn't build on s390 with CONFIG_PCI disabled as it
requires MMIO functions.
Marking for 3.9-stable only as CONFIG_SCSI_UFSHCD was previously
dependent on CONFIG_PCI.
Signed-off-by: Ben Hutchings
Cc: sta...@vger.kernel.org # 3.9
---
--- a/drivers/scsi/ufs/Kconfig
+++ b/dr
security issue, but I don't know whether that's
true in this case.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
signature.asc
Description: This is a digitally signed message part
On Wed, 2013-07-24 at 16:20 +0200, Andi Kleen wrote:
> On Wed, Jul 24, 2013 at 04:42:42AM +0100, Ben Hutchings wrote:
> > This looks like a candidate for stable:
>
> Don't know if it's a security issue, but should be fine for stable.
OK, I've queued it
:9485]
[...]
Add it to the device table as chip_9485.
Reported-by: Matt Taggart
Tested-by: Matt Taggart
Signed-off-by: Ben Hutchings
---
drivers/scsi/mvsas/mv_init.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
index 7b
f. I would
suggest:
"The coherent mask can always be set to the same or a smaller mask than
the streaming mask."
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare pr
ct2fw-3.2.1.1.bin | Bin 0 -> 582440 bytes
> ctfw-3.2.1.1.bin | Bin 0 -> 537160 bytes
> 4 files changed, 27 insertions(+)
> create mode 100644 cbfw-3.2.1.1.bin
> create mode 100644 ct2fw-3.2.1.1.bin
> create mode 100644 ctfw-3.2.1.1.bin
[...]
Applied, thanks. Sorry fo
describing why in this
> commit would be nice.
[...]
This function was already treating that error as fatal, and freeing the
MSIs. The change in behaviour is that it now returns the error code in
this case, rather than 0. This is obviously correct and properly
described by the one-line su
CI_MSI
> +static inline int pci_get_msi_cap(struct pci_dev *dev)
> +{
> + return -1;
[...]
Shouldn't this also return -EINVAL?
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Sol
Your patch 7 removes that. pci_enable_msi_block()
unfortunately doesn't appear to do this.
It seems to me that a more useful interface would take a minimum and
maximum number of vectors from the driver. This wouldn't allow the
driver to specify that it could only accept, say, any even
On Fri, 2013-10-04 at 10:29 +0200, Alexander Gordeev wrote:
> On Thu, Oct 03, 2013 at 11:49:45PM +0100, Ben Hutchings wrote:
> > On Wed, 2013-10-02 at 12:48 +0200, Alexander Gordeev wrote:
> > > This update converts pci_enable_msix() and pci_enable_msi_block()
> > > int
ards,
> Jonathan
>
> [1]
> http://alioth.debian.org/~jrnieder-guest/temp/driver-test/megaraid-driver-backport.mbox
I've committed these, but we should really get some more users of both
old and new hardware to test the result.
Ben.
--
Ben Hutchings
Always try to do things in c
i_sna_gte(cmd->stat_sn, conn->sess->exp_cmd_sn)) {
> list_del(&cmd->i_conn_node);
> spin_unlock_bh(&conn->cmd_lock);
> iscsit_free_cmd(cmd);
[...]
This changes cmd->cmd_sn to cmd->stat_sn, but the commit message
n function 'aac_src_deliver_message':
drivers/scsi/aacraid/src.c:410:3: warning: right shift count >= width of type
[enabled by default]
drivers/scsi/aacraid/src.c:434:2: warning: right shift count >= width of type
[enabled by default]
Signed-off-by: Ben Hutchings
Cc: stable # v3.6+
---
T
queued up for 4.3
(though it's already in 4.4 which I'll probably upload to unstable soon).
Ben.
--
Ben Hutchings
Design a system any fool can use, and only a fool will want to use it.
signature.asc
Description: This is a digitally signed message part
000 0001 fff5 f6a7d150 f6a30cd8 f6a30d3c
> > f6989bbc c1390cb7 f6a30cd8 f8334660 f6989bd0 c1390d0f f6a30cd8
> > f8334660 f6989c0c c13916cb f694a614 f68dd040 0000 0008
> > Call Trace:
> > […] ? scsi_runtime_suspend+0x63/0x
ith 0..nvec-1 in order, but not always.
And the IRQ numbers returned aren't usually contiguous either, on x86.
Ben.
> And for the cleanup ... well that's what the "pcim" functions are for,
> we can just make MSI-X variants.
--
Ben Hutchings, Staff Engineer, Solarflare
Not
ctions should be implemented using the same loop that
drivers are expected to use now.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubs
left shift count >= width of type
[enabled by default]
addr = bfa_sgaddr_le(sg_dma_address(sg));
^
drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: right shift count >= width of
type [enabled by default]
Avoid this by adding casts to u64 in bfa_swap_words().
Compile-tested only.
Signed-off
;offs' has not been initialised.
Since asd_common_setup() already sets default PHY settings, there
seems to be no need to repeat them here, and we can just return 0.
Compile-tested only.
Signed-off-by: Ben Hutchings
---
drivers/scsi/aic94xx/aic94xx_sds.c | 18 ++
1 file
Various bits of code are mixing making assumptions about the size of
dma_addr_t or resource_size_t, or mixing up pointer and integer types.
All these fixes are based on compiler warnings and so far as I can see
the bugs are practically harmless.
Ben.
Ben Hutchings (8):
IB/cxgb4: Fix
err = vm_insert_page(vma, addr, page);
if (err)
return err;
--
Ben Hutchings
If at first you don't succeed, you're doing about average.
signature.asc
Description: This is a digitally signed message part
ULT;
--
Ben Hutchings
If at first you don't succeed, you're doing about average.
signature.asc
Description: This is a digitally signed message part
:9485]
[...]
Add it to the device table as chip_9485.
Reported-by: Matt Taggart
Tested-by: Matt Taggart
Signed-off-by: Ben Hutchings
---
drivers/scsi/mvsas/mv_init.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
index 7b
4 -> 265420 bytes
> 4 files changed, 28 insertions(+), 36 deletions(-)
[...]
Applied, thanks.
Ben.
--
Ben Hutchings
Q. Which is the greater problem in the world today, ignorance or apathy?
A. I don't know and I couldn't care less.
signature.asc
Description: This is a digitally signed message part
am -s
~/tmp/\[net-next_1_1\]_linux-firmware\:_3.2.23.0_Firmware_for_Brocade_Adapters.mbox
Applying: linux-firmware: 3.2.23.0 Firmware for Brocade Adapters
error: corrupt binary patch at line 13542: znHIKNgBV5>FJqIQgo|#@us1Wq_D(J
Please re-send (but not to the mailing lists; it's pointl
| Bin 0 -> 583688 bytes
> ctfw-3.2.3.0.bin | Bin 0 -> 538712 bytes
> 4 files changed, 3 insertions(+)
> create mode 100644 cbfw-3.2.3.0.bin
> create mode 100644 ct2fw-3.2.3.0.bin
> create mode 100644 ctfw-3.2.3.0.bin
[...]
Applied, thanks.
Ben.
--
Ben Hutchings
It is
apparently now called 3 times during
probe. Which is quite ridiculous.
And I wonder whether this situation (no caching mode page) is really
serious enough to deserve logging at ERR severity?
Ben.
--
Ben Hutchings
Logic doesn't apply to the real world. - Marvin Minsky
signature.asc
Description: This is a digitally signed message part
:9485]
[...]
Add it to the device table as chip_9485.
Reported-by: Matt Taggart
Tested-by: Matt Taggart
Signed-off-by: Ben Hutchings
---
drivers/scsi/mvsas/mv_init.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
index 7b
udelay() does not work on some architectures for values above
2000, in particular on ARM:
ERROR: "__bad_udelay" [drivers/scsi/bfa/bfa.ko] undefined!
Reported-by: Vagrant Cascadian
Signed-off-by: Ben Hutchings
---
drivers/scsi/bfa/bfa_ioc.c | 2 +-
1 file changed, 1 insertion(+),
t; [ 34.694597] [] ? SyS_finit_module+0x6d/0x70
> [ 34.706285] [] ? system_call_fastpath+0x16/0x1b
> [ 34.718018] Code: 00 00 48 89 e6 4c 89 f7 e8 35 56 bf ff e9 40 ff ff ff b8
> 01 00 00 00 e9 87 fe ff ff 66 0f 1f 44 00 00 53 48 89 fb e8 57 e4 ff ff
> ff 0b 79 08 48 89 df e8 3
I'm adding this revert to 3.2.58, taking your 'drop commit 584ec1226519'
as an ack.
Ben.
---
From: Ben Hutchings
Date: Wed, 30 Apr 2014 13:22:22 +0100
Subject: Revert "isci: fix reset timeout handling"
This reverts commit 584ec12265192bf49dfa270d517380f67
left shift count >= width of type
[enabled by default]
addr = bfa_sgaddr_le(sg_dma_address(sg));
^
drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: right shift count >= width of
type [enabled by default]
Avoid this by adding casts to u64 in bfa_swap_words().
Compile-tested only.
Signed-off
;offs' has not been initialised.
Since asd_common_setup() already sets default PHY settings, there
seems to be no need to repeat them here, and we can just return 0.
Compile-tested only.
Signed-off-by: Ben Hutchings
---
drivers/scsi/aic94xx/aic94xx_sds.c | 18 ++
1 file
left shift count >= width of type
[enabled by default]
addr = bfa_sgaddr_le(sg_dma_address(sg));
^
drivers/scsi/bfa/bfa_fcpim.c:2509:4: warning: right shift count >= width of
type [enabled by default]
Avoid this by adding casts to u64 in bfa_swap_words().
Compile-tested only.
Signed-off
On Wed, 2014-06-25 at 22:44 -0400, Martin K. Petersen wrote:
> >>>>> "Christoph" == Christoph Hellwig writes:
>
> Christoph> On Sun, Jun 08, 2014 at 11:37:44PM +0100, Ben Hutchings wrote:
> >> asd_process_ctrl_a_user() attempts to find user sett
27;ve got
> it by running qemu with default flags...
If the bug is in libata then it's not on Doug to fix it since he's only
maintaining sg.
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
ynchronous ...")
Fixes: 1514839b3664 ("scsi: qla2xxx: Fix NULL pointer crash due to active ...")
Signed-off-by: Ben Hutchings
---
drivers/scsi/qla2xxx/qla_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi
completion structure
needed by the timeout function, so move the call to add_timer() after
that.
Signed-off-by: Ben Hutchings
Cc: sta...@vger.kernel.org
---
drivers/scsi/qla2xxx/qla_gs.c | 12 +++-
drivers/scsi/qla2xxx/qla_init.c | 37 +++--
drivers
completion structure
needed by the timeout function, so move the call to add_timer() after
that.
Signed-off-by: Ben Hutchings
---
Changes from v1:
Rebased to remove textual dependency on a patch I haven't yet sent
(oops).
Ben.
drivers/scsi/qla2xxx/qla_gs.c | 12 +++-
drivers
the timer, and dropped either at the end
of the timer function or after the timer is cancelled
- One reference is held by the completion path, and dropped by
qla2x00_sp_free()
Signed-off-by: Ben Hutchings
---
This probably isn't quite right, since it's based on only a brief code
rev
On Wed, 2018-03-21 at 17:17 +, Madhani, Himanshu wrote:
> Hi Ben,
>
> > On Mar 20, 2018, at 2:36 PM, Ben Hutchings
> > wrote:
> >
> > qla2x00_init_timer() calls add_timer() on the iocb timeout timer,
> > which means the timeout function pointer and an
On Wed, 2018-03-21 at 17:55 +, Madhani, Himanshu wrote:
> Hi Ben,
>
> > On Mar 21, 2018, at 10:45 AM, Ben Hutchings
> > wrote:
> >
> > On Wed, 2018-03-21 at 17:17 +, Madhani, Himanshu wrote:
> > > Hi Ben,
> > >
> > > >
n handling
> flag bits.
>
> I have tested the patch on my workstation. QEMU would not crash any more.
>
> Signed-off-by: Wang Sen
[...]
This is not the correct way to submit a change for stable. See
Documentation/stable_kernel_rules.txt.
Ben.
--
Ben Hutchings
If more than o
gt;
> > This is similar to existing round_up() in kernel.h could you use that?
> >
> I will replace it with round_up() if it serves the same purpose. Thanks.
Stephen is probably thinking of DIV_ROUND_UP(). round_up() does
something different.
Ben.
--
Ben Hutchings, Staff Engine
[SCSI] hpsa: dial down lockup detection during firmware flash
Ben.
--
Ben Hutchings
Who are all these weirdos? - David Bowie, about L-Space IRC channel #afp
signature.asc
Description: This is a digitally signed message part
On Wed, 2012-10-10 at 09:18 -0500, scame...@beardog.cce.hp.com wrote:
> Yes, I think so. Thanks.
I've queued this up for 3.2, thanks.
Ben.
> -- steve
>
> On Wed, Oct 10, 2012 at 04:47:38AM +0100, Ben Hutchings wrote:
> > Should this fix for hpsa be included in stable
;offs' has not been initialised.
Since asd_common_setup() already sets default PHY settings, there
seems to be no need to repeat them here, and we can just return 0.
This matches what is done if any empty user settings area is found.
Signed-off-by: Ben Hutchings
---
Compile-tested only.
Ben.
can't
think why.
Signed-off-by: Ben Hutchings
---
drivers/scsi/mvsas/mv_sas.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index a3776d6..9f91359 100644
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/scsi/
ue that we have run into a couple of times.
>
> Many thanks,
> Masoud Sharbiani
>
> PS: Apologies for duplicate message that may have been captured in
> your spam folder.
I've queued this up for 3.2, thanks.
Ben.
--
Ben Hutchings
Kids! Bringing about Armageddon can be
: Ben Hutchings
---
block/scsi_ioctl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@ -505,7 +505,7 @@ int sg_scsi_ioctl(struct request_queue *
if (bytes && blk_rq_map_kern(q, rq, buffer, bytes, __GFP_WAIT)) {
h_dir)
> {
> int err, i;
> - u32 offs, size;
> + u32 offs = 0, size;
> struct asd_ll_el *el;
> struct asd_ctrla_phy_settings *ps;
> struct asd_ctrla_phy_settings dflt_ps;
--
Ben Hutchings
Life would be so much easier if we could look at the source
d-off-by: Paolo Bonzini
Signed-off-by: Martin K. Petersen
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings
---
drivers/scsi/virtio_scsi.c | 12
1 file changed, 12 insertions(+)
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi
> -Support flow ID in aRFS flow.
>
> Signed-off-by: Rahul Verma
> ---
> qed/qed_init_values_zipped-8.30.16.0.bin | Bin 0 -> 837008 bytes
> 1 file changed, 0 insertions(+), 0 deletions(-)
> create mode 100755 qed/qed_init_values_zipped-8.30.16.0.bin
[...]
The new fil
()") moved that code, and reintroduced the
bug (perhaps due to a botched rebase). Fix it again.
Fixes: 4759df905a47 ("scsi: sg: factor out sg_fill_request_table()")
Cc: sta...@vger.kernel.org
Signed-off-by: Ben Hutchings
---
drivers/scsi/sg.c | 2 +-
1 file changed, 1 insertion
unsigned 32-bit time_t overflow in y2106 */
> + disable_req.tv_sec = be32_to_cpu(ktime_get_real_seconds());
> bfa_ioc_mbox_send(ioc, &disable_req, sizeof(struct bfi_ioc_ctrl_req_s));
> }
>
--
Ben Hutchings
Software Developer, Codethink Ltd.
00755 qed/qed_init_values_zipped-8.33.1.0.bin
[...]
Applied; sorry for the delay.
Ben.
--
Ben Hutchings
When in doubt, use brute force. - Ken Thompson
signature.asc
Description: This is a digitally signed message part
63 matches
Mail list logo
