Re: isci, INTx mode, race condition

2015-08-24 Thread Artur Paszkiewicz
hedule the handling tasklet. In the tasklet (see > sci_controller_completion_handler), the interrupts are unmasked again. > > Please let me know if you need any other information. > > Kind Regards, > > Stefan > Hi Stefan, I tried to reproduce this issue using just t

Re: [PATCH] isci: switch to pci_alloc_irq_vectors

2016-11-30 Thread Artur Paszkiewicz
On 11/18/2016 07:10 AM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/isci/host.h | 1 - > drivers/scsi/isci/init.c | 21 + > 2 files changed, 9 insertions(+), 13 deletions(-) > > diff --git a/drivers/scsi/isci/host.h b/drivers/scsi/isci/ho

Re: [PATCH v2] isci: switch to pci_alloc_irq_vectors

2016-11-30 Thread Artur Paszkiewicz
On 11/30/2016 05:21 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Reviewed-by: Artur Paszkiewicz Thanks, Artur -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] isci: fix two comment typos

2015-10-05 Thread Artur Paszkiewicz
failure code. > + * SCI_SUCCESS on successful completion, or specific failure code. > */ > static enum sci_status isci_io_request_build(struct isci_host *ihost, > struct isci_request *request, > Acked-by: Artur Paszkiewicz Thanks

Re: [PATCH v2 RESEND 08/23] isci: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-16 Thread Artur Paszkiewicz
pci_info->msix_entries, num_msix); > if (err) > goto intx; > > Looks good. Acked-by: Artur Paszkiewicz Thanks, Artur -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 17/41] scsi: isci: phy: Mark expected switch fall-through

2018-12-20 Thread Artur Paszkiewicz
On 11/28/18 5:29 AM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 703127 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Acked-by: Artur Paszkiewicz

Re: [PATCH 20/41] scsi: isci: request: mark expected switch fall-through

2018-12-20 Thread Artur Paszkiewicz
annotation from the rest of the > comment on the same line, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Artur Paszkiewicz

Re: [PATCH 19/41] scsi: isci: remote_node_context: mark expected switch fall-throughs

2018-12-20 Thread Artur Paszkiewicz
annotations from the rest of > the comment on the same line, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Artur Paszkiewicz

Re: [PATCH 18/41] scsi: isci: remote_device: Mark expected switch fall-throughs

2018-12-20 Thread Artur Paszkiewicz
annotations from the rest of > the comment on the same line, which is what GCC is expecting to find. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Artur Paszkiewicz

Re: [PATCH] scsi: isci: Convert timers to use timer_setup()

2017-10-06 Thread Artur Paszkiewicz
On 10/05/2017 02:48 AM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Intel SCU Linux support > Cc: