Re: [PATCH v4 2/4] Documentation: Add APM X-Gene SoC 15Gbps Multi-purpose PHY driver binding documentation

2013-12-12 Thread Arnd Bergmann
On Thursday 12 December 2013, Loc Ho wrote: > +- reg : First PHY memory resource is the SDS PHY access > + resource. > + Second PHY memory resoruce is the clock and reset > + resources. > +

Re: [PATCH v4 2/4] Documentation: Add APM X-Gene SoC 15Gbps Multi-purpose PHY driver binding documentation

2013-12-12 Thread Arnd Bergmann
On Thursday 12 December 2013, Douglas Gilbert wrote: > > > >> +- apm,tx-speed : Tx operating speed. One set of 3-tuple for > >> + Gen1 (0x1), Gen2 (0x3), and Gen3 (0x7). Default is > >> + 0x7. > > > > I'm completely confused by this description

Re: [PATCH v4 2/4] Documentation: Add APM X-Gene SoC 15Gbps Multi-purpose PHY driver binding documentation

2013-12-12 Thread Arnd Bergmann
On Thursday 12 December 2013, James Bottomley wrote: > > > I'm completely confused by this description. Can you rephrase this? > > > It sounds like the only possible values are <1 3 7> for this property. > > > > Most likely Gen1, Gen2 and Gen3 are SATA-speak corresponding to SAS's > > G1, G2 and G

Re: [PATCH v4 2/4] Documentation: Add APM X-Gene SoC 15Gbps Multi-purpose PHY driver binding documentation

2013-12-12 Thread Arnd Bergmann
On Thursday 12 December 2013, Loc Ho wrote: > Hi, > > > On Thursday 12 December 2013, Loc Ho wrote: > >> +- reg : First PHY memory resource is the SDS PHY access > >> + resource. > >> + Second PHY memory resoruce is the clock and res

[PATCH, RFC 02/30] scsi: atari_scsi: fix sleep_on race

2014-01-02 Thread Arnd Bergmann
when no other thread holds the same lock or tries to get it, and we no longer schedule with irqs disabled. Signed-off-by: Arnd Bergmann Cc: Geert Uytterhoeven Cc: James E.J. Bottomley Cc: linux-scsi@vger.kernel.org --- drivers/scsi/atari_scsi.c | 12 +--- 1 file changed, 9 insertions(

[PATCH, RFC 00/30] sleep_on removal

2014-01-02 Thread Arnd Bergmann
carefully. I'm definitely happy for any patches to go into maintainer trees right away. Obviously the final patch cannot go in until everything else gets merged first and I suspect there will be a series of patches for maintainerless drivers that will go along with it. Arnd Ar

Re: [PATCH v7 4/4] arm64: Add APM X-Gene SoC SATA host controller DTS entries

2014-01-03 Thread Arnd Bergmann
On Friday 03 January 2014, Loc Ho wrote: > + sata23clk: sata23clk@1f22c000 { > + compatible = "apm,xgene-device-clock"; > + #clock-cells = <1>; > + clocks = <&socplldiv2 0>; > +

Re: [PATCH v7 3/4] ata: Add APM X-Gene SoC SATA host controller driver

2014-01-03 Thread Arnd Bergmann
On Friday 03 January 2014, Loc Ho wrote: > + > +/* Controller who PHY shared with SGMII Ethernet PHY */ > +#define XGENE_AHCI_SGMII_DTS "apm,xgene-ahci-sgmii" > + > +/* Controller who PHY (internal reference clock macro) shared with PCIe */ > +#define XGENE_AHCI_PCIE_DTS "apm,xgene

Re: [PATCH v7 4/4] arm64: Add APM X-Gene SoC SATA host controller DTS entries

2014-01-03 Thread Arnd Bergmann
On Friday 03 January 2014, Loc Ho wrote: > Okay I miss understood this... I will need to fix the X-Gene device > parent clocks as well in an separate patch to the clock driver owner. Ok, thanks! Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: [PATCH v9 2/4] Documentation: Add documentation for APM X-Gene SoC SATA host controller DTS binding

2014-01-15 Thread Arnd Bergmann
On Wednesday 15 January 2014 12:04:02 Loc Ho wrote: > > >> +- clocks : Reference to the clock entry. > >> +- phys : PHY reference with parameter 0. > > > > The specific value of the phy-specifier shouldn't matter to this > > binding. What should matter is what it

Re: [PATCH v9 2/4] Documentation: Add documentation for APM X-Gene SoC SATA host controller DTS binding

2014-01-15 Thread Arnd Bergmann
On Wednesday 15 January 2014 13:08:47 Loc Ho wrote: > >> >> +- clocks : Reference to the clock entry. > >> >> +- phys : PHY reference with parameter 0. > >> > > >> > The specific value of the phy-specifier shouldn't matter to this > >> > binding. What should matter

Re: [PATCH v9 2/4] Documentation: Add documentation for APM X-Gene SoC SATA host controller DTS binding

2014-01-16 Thread Arnd Bergmann
On Wednesday 15 January 2014 15:59:27 Loc Ho wrote: > > May be I misread what Mark mentioned. The binding documentation should > not specify the requirement of 0. And the binding of the dts should be > as is: > > phy1 { >#phy-cells = <1>; > }; > > sata1 { >::: >phys = <&phy1 0>;

[PATCH 00/16] sleep_on removal, second try

2014-02-26 Thread Arnd Bergmann
.@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: net...@vger.kernel.org Arnd Bergmann (16): ataflop: fix sleep_on races scsi: atari_scsi: fix sleep_on race DAC960: remove sleep_on usage swim3: fix interruptible_sleep_on race [media] omap_vout: avoid sleep_on race [media] usbvision

[PATCH 02/16] scsi: atari_scsi: fix sleep_on race

2014-02-26 Thread Arnd Bergmann
when no other thread holds the same lock or tries to get it, and we no longer schedule with irqs disabled. Signed-off-by: Arnd Bergmann Cc: Michael Schmitz Cc: Geert Uytterhoeven Cc: James E.J. Bottomley Cc: linux-scsi@vger.kernel.org --- drivers/scsi/atari_scsi.c | 12 +--- 1 file ch

Re: [PATCH 02/16] scsi: atari_scsi: fix sleep_on race

2014-02-27 Thread Arnd Bergmann
On Thursday 27 February 2014, Michael Schmitz wrote: > Arnd Bergmann wrote: > > > Nack - the completion condition in the first hunk has its logic > reversed. Try this instead (while() loops while condition true, do {} > until () loops while condition false, no?) Sorry a

Re: [PATCH 1/3] m68k/atari - convert atari_scsi falcon_get_lock() to use wait_event()

2014-03-01 Thread Arnd Bergmann
t; scheme in general, but at least prevents falcon_get_lock from going to > sleep when no other thread holds the same lock or tries to get it, > and we no longer schedule with irqs disabled. > > MSch: fixed completion conditions missed in Arnds' original RFC patch. > > Signed

Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-13 Thread Arnd Bergmann
On Friday 13 July 2007, James Bottomley wrote: > > > IC. > > > >   - flush_kernel_dcache_page() is a no-op on ppc64 > >     (ARCH_HAS_FLUSH_KERNEL_DCACHE_PAGE is defined on parisc only). > > > >   - For reference, drivers/scsi/ipr.c (another ppc64 driver) just uses a > > plain > >     kmap/memc

Re: [PATCH v17 1/4] arm64: Add APM X-Gene SoC 15Gbps Multi-purpose PHY DTS entries

2014-03-14 Thread Arnd Bergmann
On Wednesday 12 March 2014, Loc Ho wrote: > + sataphy1clk: sataphy1clk@1f21c000 { > + compatible = "apm,xgene-device-clock"; > + #clock-cells = <1>; > + clocks = <&socplldiv2 0>; > +

Re: [PATCH v17 2/4] Documentation: Add documentation for the APM X-Gene SoC SATA host controller DTS binding

2014-03-14 Thread Arnd Bergmann
On Wednesday 12 March 2014, Loc Ho wrote: > +- clocks : Reference to the clock entry. > +- phys : A list of phandles + phy-specifiers, one for each > + entry in phy-names. > +- phy-names: Should contain: > + * "sata-6g" for the SATA

Re: [PATCH v17 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-14 Thread Arnd Bergmann
On Wednesday 12 March 2014, Loc Ho wrote: > This patch adds support for the APM X-Gene SoC AHCI SATA host controller > driver. It requires the corresponding APM X-Gene SoC PHY driver. This > initial version only supports Gen3 speed. > > Signed-off-by: Loc Ho > Signed-off-by: Tuan Phan > Signed-o

Re: [PATCH v17 4/4] arm64: Add APM X-Gene SoC AHCI SATA host controller DTS entries

2014-03-14 Thread Arnd Bergmann
On Wednesday 12 March 2014, Loc Ho wrote: > + sata01clk: sata01clk@1f21c000 { > + compatible = "apm,xgene-device-clock"; > + #clock-cells = <1>; > + clocks = <&socplldiv2 0>; > +

Re: [PATCH v17 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-14 Thread Arnd Bergmann
On Friday 14 March 2014, Loc Ho wrote: > > On Wednesday 12 March 2014, Loc Ho wrote: > > gets called. Can you clarify what this register access does? > > If it's just setting a index into a mux output, would it make > > sense to have an optional DT property containing an integer with > > the mux s

Re: [PATCH v17 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-14 Thread Arnd Bergmann
On Friday 14 March 2014, Loc Ho wrote: > Hi, > > >> > gets called. Can you clarify what this register access does? > >> > If it's just setting a index into a mux output, would it make > >> > sense to have an optional DT property containing an integer with > >> > the mux setting you want to set? Th

Re: [PATCH v17 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-15 Thread Arnd Bergmann
On Friday 14 March 2014, Loc Ho wrote: > > I still think it's rather unlikely that we will actually see ACPI support > > on your platform, btw. > > > > I'm willing to look at the patches you need for it, but I'm not very > > optimistic, in particular because of the kind of hacks you need > > for r

Re: [PATCH v18 1/4] arm64: Add APM X-Gene SoC 15Gbps Multi-purpose PHY DTS entries

2014-03-15 Thread Arnd Bergmann
On Saturday 15 March 2014, Loc Ho wrote: > This patch adds the DTS entries for the APM X-Gene SoC 15Gbps Multi-purpose > PHY driver. The PHY for SATA controller 2 and 3 are enabled by default. > > Signed-off-by: Loc Ho > Signed-off-by: Tuan Phan > Signed-off-by: Suman Tripath

Re: [PATCH v18 2/4] Documentation: Add documentation for the APM X-Gene SoC SATA host controller DTS binding

2014-03-15 Thread Arnd Bergmann
On Saturday 15 March 2014, Loc Ho wrote: > This patch adds documentation for the APM X-Gene SoC SATA host controller DTS > binding. > > Signed-off-by: Loc Ho > Signed-off-by: Tuan Phan > Signed-off-by: Suman Tripathi Acked-by: Arnd Bergmann -- To unsubscribe from this l

Re: [PATCH v18 4/4] arm64: Add APM X-Gene SoC AHCI SATA host controller DTS entries

2014-03-15 Thread Arnd Bergmann
On Saturday 15 March 2014, Loc Ho wrote: > This patch adds APM X-Gene SoC AHCI SATA host controller DTS entries. > > Signed-off-by: Loc Ho > Signed-off-by: Tuan Phan > Signed-off-by: Suman Tripathi Acked-by: Arnd Bergmann -- To unsubscribe from this list: send the line &qu

Re: [PATCH v18 3/4] ata: Add APM X-Gene SoC AHCI SATA host controller driver

2014-03-15 Thread Arnd Bergmann
On Saturday 15 March 2014, Loc Ho wrote: > This patch adds support for the APM X-Gene SoC AHCI SATA host controller > driver. It requires the corresponding APM X-Gene SoC PHY driver. This > initial version only supports Gen3 speed. This version seems workable, thanks for the quick follow-up. The

[RFC 00/32] making inode time stamps y2038 ready

2014-05-30 Thread Arnd Bergmann
of times we want to cover. c) Should we continue this way for all 32-bit platforms for consistency, including future ones, or should we go to different 64-bit types right away? My feeling is that the second approach would complicate this work. Arnd [1] http://kernelnewbies.org/

[RFC 31/32] scsi: fnic: use current_kernel_time() for timestamp

2014-05-30 Thread Arnd Bergmann
The fnic driver currently uses the CURRENT_TIME macro to generate a timestamp. Since this is otherwise used only in file system code and we want to change the type, it's better for this driver to use the equivalent function that continues to return a struct timespec. Signed-off-by: Arnd Ber

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-05-31 Thread Arnd Bergmann
On Saturday 31 May 2014 16:51:15 Richard Cochran wrote: > On Fri, May 30, 2014 at 10:01:24PM +0200, Arnd Bergmann wrote: > > > > I picked this because it is a fairly isolated problem, as the > > inode time stamps are rarely assigned to any other time values. > > As

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-02 Thread Arnd Bergmann
On Monday 02 June 2014 13:52:19 Joseph S. Myers wrote: > On Fri, 30 May 2014, Arnd Bergmann wrote: > > > a) is this the right approach in general? The previous discussion > >pointed this way, but there may be other opinions. > > The syscall changes seem like the

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-02 Thread Arnd Bergmann
On Monday 02 June 2014 12:26:22 H. Peter Anvin wrote: > On 06/02/2014 12:19 PM, Arnd Bergmann wrote: > > On Monday 02 June 2014 13:52:19 Joseph S. Myers wrote: > >> On Fri, 30 May 2014, Arnd Bergmann wrote: > >> > >>> a) is this the right appro

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-03 Thread Arnd Bergmann
On Saturday 31 May 2014 18:30:49 Vyacheslav Dubeyko wrote: > By the way, what about NILFS2? Is NILFS2 ready for suggested approach > without any changes? nilfs2 and a lot of other file systems don't need any changes for this, because they don't assign the inode time stamp fields to a 'struct times

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-03 Thread Arnd Bergmann
On Monday 02 June 2014 14:57:26 H. Peter Anvin wrote: > On 06/02/2014 12:55 PM, Arnd Bergmann wrote: > >> > >> The bit that is really going to hurt is every single ioctl that uses a > >> timespec. > >> > >> Honestly, though, I really don't un

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-03 Thread Arnd Bergmann
On Tuesday 03 June 2014 14:33:10 Joseph S. Myers wrote: > On Tue, 3 Jun 2014, Arnd Bergmann wrote: > > > I think John Stultz and Thomas Gleixner have already started looking > > at how the timekeeping code can be updated. Once that is done, we should > > be able to

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-04 Thread Arnd Bergmann
On Monday 02 June 2014, Joseph S. Myers wrote: > On Mon, 2 Jun 2014, Arnd Bergmann wrote: > > > Ok. Sorry about missing linux-api, I confused it with linux-arch, which > > may not be as relevant here, except for the one question whether we > > actually want to have t

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-04 Thread Arnd Bergmann
On Tuesday 03 June 2014, Dave Chinner wrote: > On Tue, Jun 03, 2014 at 04:22:19PM +0200, Arnd Bergmann wrote: > > On Monday 02 June 2014 14:57:26 H. Peter Anvin wrote: > > > On 06/02/2014 12:55 PM, Arnd Bergmann wrote: > > The possible uses I can see for non-ktime_t

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-04 Thread Arnd Bergmann
On Wednesday 04 June 2014 13:30:32 Nicolas Pitre wrote: > On Wed, 4 Jun 2014, Arnd Bergmann wrote: > > > On Tuesday 03 June 2014, Dave Chinner wrote: > > > Just ot be pedantic, inodes don't need 96 bit timestamps - some > > > filesystems can *support up t

[PATCH 4/4] [SCSI] NCR53c406a: don't call free_dma() by default

2014-06-05 Thread Arnd Bergmann
aration of function 'free_dma' [-Werror=implicit-function-declaration] free_dma(shost->dma_channel); ^ This changes the code to use #if USE_DMA, to match the rest of the file, which seems to be what the author intended. Signed-off-by: Arnd Bergmann --- drivers/scsi/NCR53c406a.c |

[PATCH 1/4] [SCSI] Don't build AdvanSys on ARM

2014-06-05 Thread Arnd Bergmann
: implicit declaration of function 'dma_cache_sync' [-Werror=implicit-function-declaration] dma_cache_sync(board->dev, scp->sense_buffer, ^ It seems nobody has missed this driver so far, so let's just disable it for ARM to help randconfig builds. Signed-off-by: Ar

[PATCH 3/4] [SCSI] qlogicfas: don't call free_dma()

2014-06-05 Thread Arnd Bergmann
the incorrect function calls should be the obvious fix for this, with no downsides. Signed-off-by: Arnd Bergmann --- drivers/scsi/qlogicfas.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/qlogicfas.c b/drivers/scsi/qlogicfas.c index 13d628b..a22bb1b 100644 --- a/drivers

[PATCH 2/4] [SCSI] pas16: don't call free_dma()

2014-06-05 Thread Arnd Bergmann
ion calls should be the obvious fix for this, with no downsides. Signed-off-by: Arnd Bergmann Cc: Finn Thain Cc: Michael Schmitz --- drivers/scsi/pas16.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/pas16.c b/drivers/scsi/pas16.c index 0d78a4d..80bacb5 100644 --- a/dri

[PATCH 0/4] ARM randconfig fixes for SCSI

2014-06-05 Thread Arnd Bergmann
Hi James, These are some fixes for ancient randconfig build bugs I ran into on ARM. Clearly none of these are urgent, but it would be nice to have them merged for 3.17 if they look good to you. Arnd Bergmann (4): [SCSI] Don't build AdvanSys on ARM [SCSI] pas16: don't call free_dma

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-10 Thread Arnd Bergmann
On Wednesday 04 June 2014 17:10:24 H. Peter Anvin wrote: > On 06/04/2014 12:24 PM, Arnd Bergmann wrote: > > > > For other timekeeping stuff in the kernel, I agree that using some > > 64-bit representation (nanoseconds, 32/32 unsigned seconds/nanoseconds, > > ...) has

[PATCH] [scsi] 3w-xxxx: fix mis-aligned struct accesses

2014-06-26 Thread Arnd Bergmann
-sas and 3w-9xxx, but has been fixed in the past. This patch uses the same fix by moving the pragma in front of the TW_Device_Extension definition, so it only covers hardware structures. Signed-off-by: Arnd Bergmann Cc: Adam Radford --- diff --git a/drivers/scsi/3w-.h b/drivers/scsi/3w-

[PATCH] [SCSI] hpsa: fix non-x86 builds

2014-06-26 Thread Arnd Bergmann
s conditional on x86, not also reading the initial register contents. Signed-off-by: Arnd Bergmann Fixes: 28e134464734 "[SCSI] hpsa: enable unit attention reporting" Cc: Stephen M. Cameron Cc: sta...@vger.kernel.org # v3.14+ diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 31

Re: [patch 4/6] ps3: Disk Storage Driver

2007-06-15 Thread Arnd Bergmann
On Friday 15 June 2007, David Woodhouse wrote: > > On Fri, 2007-06-15 at 13:39 +0200, Geert Uytterhoeven wrote: > > Add a Disk Storage Driver for the PS3: > >   - Implemented as a block device driver with a dynamic major > >   - Disk names (and partitions) are of the format ps3d%c(%u) > >   - Uses

[PATCH 2/7] scsi: raid_attrs: fix unused variable warning

2018-12-14 Thread Arnd Bergmann
roblem that for some reason was very hard to run into, but it is very easy to fix, by replacing the incorrect #ifdef with a simpler IS_ENABLED() check. Fixes: fac829fdcaf4 ("[SCSI] raid_attrs: fix dependency problems") Signed-off-by: Arnd Bergmann Signed-off-by: Martin K. Petersen ---

[PATCH 0/7] v4.19-stable randconfig fixes

2018-12-14 Thread Arnd Bergmann
warning by fixing the code correctly in each of these cases, but if you disagree, applying the mainline change should work equally well, so decide for yourself. Arnd Arnd Bergmann (5): scsi: raid_attrs: fix unused variable warning slimbus: ngd: mark PM functions as __maybe_unused [st

Re: [PATCH v8 01/25] scsi/atari_scsi: Don't select CONFIG_NVRAM

2018-12-29 Thread Arnd Bergmann
On Sat, Dec 29, 2018 at 3:51 AM Michael Schmitz wrote: > > Hi Finn, > > Am 29.12.2018 um 15:34 schrieb Finn Thain: > > On Sat, 29 Dec 2018, Michael Schmitz wrote: > > > >> > >> IS_BUILTIN(CONFIG_NVRAM) is probably what Christophe really meant to > >> suggest. > >> > >> Or (really going out on a l

[PATCH 2/4] scsi: lpfc: fix 32-bit format string warning

2019-03-04 Thread Arnd Bergmann
type 'long int', but argument 5 has type 'unsigned int' [-Werror=format=] This is harmless, but portable code should just use %zd to avoid the warning. Fixes: 0794d601d174 ("scsi: lpfc: Implement common IO buffers between NVME and SCSI") Signed-off-by: Arnd Bergmann

[PATCH 1/4] scsi: lpfc: fix unused variable warning

2019-03-04 Thread Arnd Bergmann
x27; [-Werror=unused-variable] uint32_t code, status, idx, cpu; Move the declaration into the same block to avoid the warning. Fixes: 63df6d637e33 ("scsi: lpfc: Adapt cpucheck debugfs logic to Hardware Queues") Signed-off-by: Arnd Bergmann --- drivers/scsi/lpfc/lpfc_nvme.c | 3

[PATCH 3/4] scsi: qla2xxx: avoid printf format warning

2019-03-04 Thread Arnd Bergmann
boundary in physical addresses would still be mapped into dma addresses within the low 4GB space, so I suspect that we actually want to check sg_dma_address() instead of sg_phys() here. Fixes: 50b812755e97 ("scsi: qla2xxx: Fix DMA error when the DIF sg buffer crosses 4GB boundary") Sig

[PATCH 4/4] scsi: ufs: hisi: fix ufs_hba_variant_ops passing

2019-03-04 Thread Arnd Bergmann
e] Rework this code to pass the data directly, and while we're at it, correctly handle the const pointers. Fixes: 653fcb07d95e ("scsi: ufs: Add HI3670 SoC UFS driver support") Signed-off-by: Arnd Bergmann --- drivers/scsi/ufs/ufs-hisi.c | 11 --- drivers/scsi/ufs/uf

Re: [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy()

2018-01-08 Thread Arnd Bergmann
d 100 equals destination size [-Wstringop-truncation] > > We need to use strlcpy() to make sure the dest string is > nul-terminated. > > Signed-off-by: Xiongfeng Wang Looks correct to me, Acked-by: Arnd Bergmann

[PATCH] [RESEND] megaraid: use ktime_get_real for firmware time

2018-01-17 Thread Arnd Bergmann
do_gettimeofday() overflows in 2038 on 32-bit architectures and is deprecated, so convert this driver to call ktime_get_real() directly. This also simplifies the calculation. Signed-off-by: Arnd Bergmann --- Sent originally in Nov 2017, no comments. Please apply --- drivers/scsi/megaraid

[PATCH] [RESEND] scsi: ips: fix firmware timestamps for 32-bit

2018-01-17 Thread Arnd Bergmann
right format also has the advantage of greatly simplifying the time management code. Signed-off-by: Arnd Bergmann --- Submitted originally in November 2017. The aacr...@adaptec.com apparently bounced. Trying again now with a few people on Cc that previously reviewed patches to this driver

[PATCH] [RESEND] scsi: esas2r: use ktime_get_real_seconds()

2018-01-17 Thread Arnd Bergmann
. This changes do_gettimeofday() to ktime_get_real_seconds(), which at least simplifies the code a bit, and avoids the deprecated interface. I'm adding a comment about the overflow to document what happens. Signed-off-by: Arnd Bergmann --- Originally submitted in November 2017, no reply s

[PATCH] [RESEND] scsi: fnic: use 64-bit timestamps

2018-01-17 Thread Arnd Bergmann
struct timespec is deprecated since it overflows in 2038 on 32-bit architectures, so we should use timespec64 consistently. I'm slightly adapting the format strings here, to make sure we print the nanoseconds with the correct number of leading zeroes. Signed-off-by: Arnd Bergmann --- Origi

[PATCH] scsi: fas216: fix sense buffer initialization

2018-01-18 Thread Arnd Bergmann
check whether we actually need to initialize the buffer here, but it's clear that if we do it, we should use the correct size. Fixes: de25deb18016 ("[SCSI] use dynamically allocated sense buffer") Signed-off-by: Arnd Bergmann --- drivers/scsi/arm/fas216.c | 2 +- 1 file changed

Re: [PATCH] [RESEND] scsi: ips: fix firmware timestamps for 32-bit

2018-01-18 Thread Arnd Bergmann
On Thu, Jan 18, 2018 at 10:35 AM, Finn Thain wrote: > On Wed, 17 Jan 2018, Arnd Bergmann wrote: > >> do_gettimeofday() is deprecated since it will stop working in 2038 on >> 32-bit platforms. The firmware interface here actually supports times >> until year 25500,

[PATCH] scsi: arcmsr: avoid do_gettimeofday

2018-01-21 Thread Arnd Bergmann
l adjustment. Fixes: b416c099472a ("scsi: arcmsr: Add a function to set date and time to firmware") Signed-off-by: Arnd Bergmann --- drivers/scsi/arcmsr/arcmsr_hba.c | 37 ++--- 1 file changed, 10 insertions(+), 27 deletions(-) diff --git a/drivers/scsi/arcm

[PATCH 0/6] scsi: fixes for building with LTO

2018-02-02 Thread Arnd Bergmann
I experimented with link time optimization after Nico's article at https://lwn.net/Articles/744507/ Here is a set of patches that came out of it for the scsi subsystem. Arnd Bergmann (6): scsi: fc_encode: work around strncpy size warnings scsi: NCR53c406a: avoid section mismatch wit

[PATCH 1/6] scsi: fc_encode: work around strncpy size warnings

2018-02-02 Thread Arnd Bergmann
o a region of size 1 overflows the destination [-Werror=stringop-overflow=] strncpy((char *)&entry->value, ^ No idea what the right fix is. Signed-off-by: Arnd Bergmann --- include/scsi/fc/fc_ms.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/scsi/f

[PATCH 2/6] scsi: NCR53c406a: avoid section mismatch with LTO

2018-02-02 Thread Arnd Bergmann
he annotation here to kill off the warning instead of doing a larger rework. Signed-off-by: Arnd Bergmann --- drivers/scsi/NCR53c406a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/NCR53c406a.c b/drivers/scsi/NCR53c406a.c index 6e110c630d2c..44b09870bf51 100644

[PATCH 4/6] scsi: qedf: fix LTO-enabled build

2018-02-02 Thread Arnd Bergmann
ile where it belongs. The file operations can also be marked 'const' like the qedf_debugfs_ops. Signed-off-by: Arnd Bergmann --- drivers/scsi/qedf/qedf_dbg.h | 17 ++--- drivers/scsi/qedf/qedf_debugfs.c | 6 +++--- drivers/scsi/qedf/qedf_main.c| 8 +++- 3 files

[PATCH 5/6] scsi: qedi: fix building with LTO

2018-02-02 Thread Arnd Bergmann
{ This changes the declaration to match the definition, and adapts the users as necessary. Since both array can be constant here, I'm adding the 'const' everywhere for consistency. Signed-off-by: Arnd Bergmann --- drivers/scsi/qedi/qedi_dbg.h | 2 +- drivers/scsi/qedi/qedi_d

[PATCH 3/6] scsi: sym53c416: avoid section mismatch with LTO

2018-02-02 Thread Arnd Bergmann
he annotation here to kill off the warning instead of doing a larger rework. Signed-off-by: Arnd Bergmann --- drivers/scsi/sym53c416.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/sym53c416.c b/drivers/scsi/sym53c416.c index 5bdcbe8fa958..e68bcdc75bc3 100644 --- a

[PATCH 6/6] scsi: qedf: use correct strncpy() size

2018-02-02 Thread Arnd Bergmann
length of the source argument [-Werror=stringop-overflow=] This changes it to strscpy() with the correct length, guaranteeing a properly nul-terminated string of the right size. Signed-off-by: Arnd Bergmann --- drivers/scsi/qedf/qedf_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH/RFC 0/6] Allow compile-testing NO_DMA

2018-02-06 Thread Arnd Bergmann
On Tue, Feb 6, 2018 at 11:14 AM, Geert Uytterhoeven wrote: > Hi all, > > If NO_DMA=y, get_dma_ops() returns a reference to the non-existing > symbol bad_dma_ops, thus causing a link failure if it is ever used. > > The intention of this is twofold: > 1. To catch users of the DMA API on sy

Re: [PATCH/RFC 0/6] Allow compile-testing NO_DMA

2018-02-06 Thread Arnd Bergmann
On Tue, Feb 6, 2018 at 2:05 PM, Robin Murphy wrote: > > It looks like we have only one real arch (score) without IOMEM, and two > (s390 and tile) where it is possible to configure out, so it does seem like > a reasonable feature to assume. Maybe we could have something like > asm-generic/no-io.h t

Re: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

2018-02-19 Thread Arnd Bergmann
On Tue, Feb 13, 2018 at 11:14 AM, Li Wei wrote: > add ufs node document for Hisilicon. > > Signed-off-by: Li Wei > --- > Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 37 > ++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/u

[4.4-stable 08/22] ncr5380: shut up gcc indentation warning

2018-02-20 Thread Arnd Bergmann
t;ncr5380: Use runtime register mapping"). We don't want the entire patch backported to stable kernels, but we can backport one hunk to get rid of the warning. Signed-off-by: Arnd Bergmann --- drivers/scsi/g_NCR5380.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/

[PATCH] scsi: lpfc: use memcpy_toio instead of writeq

2018-02-23 Thread Arnd Bergmann
to get a write-combining mapping on all architectures that support this? Fixes: 1351e69fc6db ("scsi: lpfc: Add push-to-adapter support to sli4") Signed-off-by: Arnd Bergmann --- drivers/scsi/lpfc/lpfc_sli.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/dri

Re: [PATCH] scsi: lpfc: use memcpy_toio instead of writeq

2018-02-23 Thread Arnd Bergmann
On Fri, Feb 23, 2018 at 5:41 PM, David Laight wrote: > From: Arnd Bergmann >> Sent: 23 February 2018 15:37 >> >> 32-bit architectures generally cannot use writeq(), so we now get a build >> failure for the lpfc driver: >> >> drivers/scsi/lpfc/lpfc_sli.c: In

Re: [PATCH] scsi: lpfc: use memcpy_toio instead of writeq

2018-02-23 Thread Arnd Bergmann
On Fri, Feb 23, 2018 at 4:36 PM, Arnd Bergmann wrote: > @@ -138,12 +137,10 @@ lpfc_sli4_wq_put(struct lpfc_queue *q, union lpfc_wqe > *wqe) > if (q->phba->sli3_options & LPFC_SLI4_PHWQ_ENABLED) > bf_set(wqe_wqid, &wqe->

Re: [PATCH] lpfc: correct writeq failures on 32-bit architectures

2018-02-26 Thread Arnd Bergmann
On Sat, Feb 24, 2018 at 11:30 PM, James Smart wrote: > writeq() is not present on all 32-bit architectures. > > When 32-bit, use writel() > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_sli.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git

Re: [PATCH] scsi: lpfc: use memcpy_toio instead of writeq

2018-02-26 Thread Arnd Bergmann
On Sun, Feb 25, 2018 at 11:02 AM, Johannes Thumshirn wrote: > Arnd Bergmann writes: >> 32-bit architectures generally cannot use writeq(), so we now get a build >> failure for the lpfc driver: >> >> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_sli4_wq_put'

[PATCH] scsi: qedi: fix build regression

2018-02-26 Thread Arnd Bergmann
nst struct qedi_debugfs_ops qedi_debugfs_ops[]; ^~~~ This removes the useless #ifdef around the declarations in qedi_dbg.h to make it always build. Fixes: 779936faf4f1 ("scsi: qedi: fix building with LTO") Signed-off-by: Arnd Bergmann --

Re: [PATCH] lpfc: correct writeq failures on 32-bit architectures

2018-02-26 Thread Arnd Bergmann
On Mon, Feb 26, 2018 at 6:01 PM, James Smart wrote: > > > On 2/26/2018 12:36 AM, Arnd Bergmann wrote: >> >> Unfortunately, this is still broken on all big-endian architectures. You >> could >> use __raw_writeq() here to fix it, or change the if() clause

Re: [PATCH] lpfc: correct writeq failures on 32-bit architectures

2018-02-27 Thread Arnd Bergmann
On Mon, Feb 26, 2018 at 10:41 PM, James Smart wrote: > On 2/26/2018 12:04 PM, Arnd Bergmann wrote: >> >> For the endianess, the key to understanding this is that readl/writel and >> readq/writeq follow the convention of accessing data as little-endian >> because

Re: [PATCH] lpfc: correct writeq failures on 32-bit architectures

2018-02-27 Thread Arnd Bergmann
On Tue, Feb 27, 2018 at 7:05 PM, James Smart wrote: > On 2/27/2018 12:58 AM, Arnd Bergmann wrote: > > So you point out a very real concern, as in most cases the source buffer is > a bytestream and the desire is to send the bytestream in the same byte order > as in memory. It

Re: [PATCH] lpfc: correct writeq failures on 32-bit architectures

2018-02-27 Thread Arnd Bergmann
On Tue, Feb 27, 2018 at 9:24 PM, James Smart wrote: > On 2/27/2018 12:15 PM, Arnd Bergmann wrote: >> >> Could you add an #ifdef and comment around the 'if (q->dpp_enable ...)' >> block then to make sure that if anybody tries to make it work on other >> arch

[PATCH] scsi: mpt3sas: clarify mmio pointer types

2018-03-01 Thread Arnd Bergmann
: Introduce Base function for cloning.") Signed-off-by: Arnd Bergmann --- drivers/scsi/mpt3sas/mpt3sas_base.c | 42 - drivers/scsi/mpt3sas/mpt3sas_base.h | 2 +- 2 files changed, 24 insertions(+), 20 deletions(-) diff --git a/drivers/scsi/mpt3sas/

Re: [PATCH v2] lpfc: use __raw_writeX on DPP copies

2018-03-05 Thread Arnd Bergmann
mpilation on some 32-bit systems as writeq() is not supported > on all architectures. Additionally, it was pointed out that as writeX() > does byteswapping if necessary for pci vs the cpu endianness, the code > was broken on BE PPC. > > After discussions with Arnd Bergmann, we&#

Re: 答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

2018-03-26 Thread Arnd Bergmann
tter left documented in your own binding. I've added a "jedec,ufshci-3.0" compatible string, which appears to be the latest version of the ufshci itself, and I've documented four clocks that are already used by the qualcomm variant of the platform device. Please have a look at th

Re: 答复: 答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

2018-03-26 Thread Arnd Bergmann
On Mon, Mar 26, 2018 at 12:26 PM, liwei (CM) wrote: > 发件人: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] 代表 Arnd Bergmann > > 主题: Re: 答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs > > On Fri, Mar 23, 2018 at 3:22 AM, liwei (CM) wrote: > >&g

Re: 答复: 答复: 答复: [PATCH v8 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

2018-03-28 Thread Arnd Bergmann
On Tue, Mar 27, 2018 at 8:15 AM, liwei (CM) wrote: > Hi, Arnd > > At present our ufs module mainly has four clocks from the outside: > hclk_ufs: main clock of ufs controller ,freq is 207.5MHz > cfg_phy_clk: configuration clock of MPHY, freq is 51.875MHz > ref_phy_clk: reference clock of MPHY

[PATCH v3 00/26] compat_ioctl: cleanups

2019-04-16 Thread Arnd Bergmann
aintainers. I hope you can still take these for the coming merge window, unless new problems come up. Arnd Arnd Bergmann (26): compat_ioctl: pppoe: fix PPPOEIOCSFWD handling compat_ioctl: move simple ppp command handling into driver compat_ioctl: avoid unused function warning fo

[PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-16 Thread Arnd Bergmann
e not interpreted as integer values. Acked-by: Jason Gunthorpe Acked-by: Daniel Vetter Acked-by: Mauro Carvalho Chehab Acked-by: Greg Kroah-Hartman Acked-by: David Sterba Acked-by: Darren Hart (VMware) Acked-by: Jonathan Cameron Acked-by: Bjorn Andersson Signed-off-by: Arnd Bergmann --- dr

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Arnd Bergmann
On Thu, Apr 25, 2019 at 5:22 PM Mauro Carvalho Chehab wrote: > Em Tue, 16 Apr 2019 22:25:33 +0200 Arnd Bergmann escreveu: > > If I understand your patch description well, using compat_ptr_ioctl > only works if the driver is not for s390, right? No, the purpose of compat_ptr_ioctl(

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Arnd Bergmann
On Thu, Apr 25, 2019 at 5:35 PM Al Viro wrote: > > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > If I understand your patch description well, using compat_ptr_ioctl > > only works if the driver is not for s390, right? > > No; s390 is where "oh, just set ->compat_ioct

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-26 Thread Arnd Bergmann
On Thu, Apr 25, 2019 at 11:25 PM Johannes Berg wrote: > On Thu, 2019-04-25 at 17:55 +0200, Arnd Bergmann wrote: > > On Thu, Apr 25, 2019 at 5:35 PM Al Viro wrote: > > > > > > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > >

[PATCH v5 00/18] compat_ioctl.c removal, part 2/3

2019-08-14 Thread Arnd Bergmann
ppp_generic Arnd Bergmann (16): xfs: compat_ioctl: use compat_ptr() xfs: compat_ioctl: add missing conversions gfs2: add compat_ioctl support fs: compat_ioctl: move FITRIM emulation into file systems watchdog: cpwd: use generic compat_ptr_ioctl compat_ioctl: move WDIOC handling into wdt

[PATCH v3 10/26] compat_ioctl: use correct compat_ptr() translation in drivers

2019-04-16 Thread Arnd Bergmann
thing, but using the new compat_ptr_ioctl() helper makes it more correct in theory, and simplifies the code. Acked-by: Greg Kroah-Hartman Acked-by: Andrew Donnellan Acked-by: Felipe Balbi Signed-off-by: Arnd Bergmann --- drivers/misc/cxl/flash.c| 8 +--- drivers/misc/g

[PATCH v3 13/26] compat_ioctl: move tape handling into drivers

2019-04-16 Thread Arnd Bergmann
that is now in a new linux/mtio.h header that wraps the existing uapi/linux/mtio.h header and provides an abstraction to let drivers handle both cases easily. Signed-off-by: Arnd Bergmann --- drivers/ide/ide-tape.c| 31 drivers/s390/char/tape_char.c | 41

Re: next build: 113 warnings 0 failures (next/next-20170605)

2017-06-06 Thread Arnd Bergmann
On Mon, Jun 5, 2017 at 11:02 AM, Olof's autobuilder wrote: > Here are the build results from automated periodic testing. > > The tree being built was next, found at: > > http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git (master > branch) > > Topmost commit: > > f0090bf Add linux-nex

Re: [PATCH 0/2] esas2r: Replace semaphores with mutexes

2017-06-08 Thread Arnd Bergmann
maphore with mutex > scsi: esas2r: Replace semaphore fs_api_semaphore with mutex Both conversions looks good. I think the interruption is not handled correctly here, but your patch doesn't change that. Reviewed-by: Arnd Bergmann

[PATCH] scsi: qla2xxx: fix printk format string warning on 32-bit

2017-06-09 Thread Arnd Bergmann
format string is %zx. Fixes: 0f110b54d157 ("scsi: qla2xxx: Retain loop test for fwdump length exceeding buffer length") Signed-off-by: Arnd Bergmann --- drivers/scsi/qla2xxx/qla_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init

<    1   2   3   4   5   >