Re: [PATCH v4 02/22] sg: remove typedefs, type+formatting cleanup

2019-08-29 Thread Johannes Thumshirn
Highly appreciated, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nürnberg Germany (HRB 247165, AG München) Key fi

Re: [PATCH v4 07/22] sg: move header to uapi section

2019-08-29 Thread kbuild test robot
/Douglas-Gilbert/sg-add-v4-interface/20190829-123646 config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-11) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by

[bug report] scsi: lpfc: Adding ability to reset chip via pci bus reset

2019-08-29 Thread Dan Carpenter
Hello James Smart, The patch 5021267af132: "scsi: lpfc: Adding ability to reset chip via pci bus reset" from Dec 13, 2018, leads to the following static checker warning: drivers/scsi/lpfc/lpfc_attr.c:1322 lpfc_reset_pci_bus() warn: passing bogus address: '&(phba->pcidev)->dev' val

Re: [PATCH v4 07/22] sg: move header to uapi section

2019-08-29 Thread Douglas Gilbert
uglas-Gilbert/sg-add-v4-interface/20190829-123646 config: x86_64-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.4.0-11) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbu

[RFC,v2] scsi: scan: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT

2019-08-29 Thread Andrey Melnikov
Hello. This patch break exposing individual RAID disks from adaptec raid controller. I need access to this disc's for S.M.A.R.T monitoring. Please find other way to workaround bugs in IBM/2145 controller.

[RFC PATCH 0/4] iscsi: chap: introduce support for SHA1 and SHA3-256

2019-08-29 Thread Maurizio Lombardi
iSCSI with the Challenge-Handshake Authentication Protocol is not FIPS compliant. This is due to the fact that CHAP currently uses MD5 as the only supported digest algorithm and MD5 is not allowed by FIPS. When FIPS mode is enabled on the target server, the CHAP authentication won't work because

[PATCH 1/4] target-iscsi: CHAP: add support to SHA1 and SHA3-256 hash functions

2019-08-29 Thread Maurizio Lombardi
This patches modifies the chap_server_compute_hash() function to make it agnostic to the choice of hash algorithm that is used. It also adds support to two new hash algorithms: SHA1 and SHA3-256 Signed-off-by: Maurizio Lombardi --- drivers/target/iscsi/iscsi_target_auth.c | 135 +

[PATCH 2/4] target-iscsi: remove unneeded function

2019-08-29 Thread Maurizio Lombardi
The digest type validy is already checked by chap_server_open(), therefore we can remove the chap_got_response() function. Signed-off-by: Maurizio Lombardi --- drivers/target/iscsi/iscsi_target_auth.c | 26 +--- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/dr

[PATCH 3/4] target-iscsi: tie the challenge length to the hash digest size

2019-08-29 Thread Maurizio Lombardi
Signed-off-by: Maurizio Lombardi --- drivers/target/iscsi/iscsi_target_auth.c | 37 +--- drivers/target/iscsi/iscsi_target_auth.h | 4 +-- 2 files changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_auth.c b/drivers/target/iscsi/iscsi_t

[PATCH 4/4] target-iscsi: rename some variables to avoid confusion.

2019-08-29 Thread Maurizio Lombardi
This patch renames some variables in chap_server_compute_hash() to make it harder to confuse the initiator's challenge with the target's challenge when the mutual chap authentication is used. Signed-off-by: Maurizio Lombardi --- drivers/target/iscsi/iscsi_target_auth.c | 40 -

Re: [PATCH v3] scsi: ufs: fix broken hba->outstanding_tasks

2019-08-29 Thread Martin K. Petersen
Stanley, > Currently bits in hba->outstanding_tasks are cleared only after their > corresponding task management commands are successfully done by > __ufshcd_issue_tm_cmd(). Applied to 5.4/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: Fix a recently introduced kernel warning

2019-08-29 Thread Martin K. Petersen
Bart, > According to the firmware documentation a status type 0 IOCB can be > followed by one or more status continuation type 0 IOCBs. Hence do not > complain if the completion function is not called from inside the > status type 0 IOCB handler. Applied to 5.4/scsi-queue, thanks! -- Martin K

Re: [PATCH v3 0/1] aacraid: Host adapter Adaptec 6405 constantly resets under high io load

2019-08-29 Thread Martin K. Petersen
> Problem description: > > A node with Adaptec 6405 controller, latest BIOS V5.3-0[19204] A lot > of disks attached to the controller. Simple test: running mkfs.ext4 > on many disks on the same controller in parallel (mkfs is not > important here, any serious io load trigger

Re: [PATCH] mpt3sas: Add sysfs parameter to set sdev qd to host can_queue

2019-08-29 Thread Martin K. Petersen
Sreekanth, > This patch provides the module parameter and sysfs interface named > 'enable_sdev_max_qd' to switch between the driver provided > (optimal)queue depth and controller queue depth (can_queue). Applied to 5.4/scsi-queue. Thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: hisi_sas: remove set but not used variable 'irq_value'

2019-08-29 Thread Martin K. Petersen
zhengbin, > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c: In function cq_interrupt_v1_hw: > drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:1542:6: warning: variable irq_value > set but not used [-Wunused-but-set-variable] Applied to 5.4/scsi-queue, thanks.

Re: [PATCH v2] scsi: ufs: remove set but not used variable 'val'

2019-08-29 Thread Martin K. Petersen
zhengbin, > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/ufs/ufs-qcom.c: In function ufs_qcom_pwr_change_notify: > drivers/scsi/ufs/ufs-qcom.c:808:6: warning: variable val set but not used > [-Wunused-but-set-variable] Applied to 5.4/scsi-queue, thanks. -- Martin K. Peters

Re: [PATCH] lpfc: Resolve checker warning for lpfc_new_io_buf()

2019-08-29 Thread Martin K. Petersen
James, > The patch d79c9e9d4b3d: "scsi: lpfc: Support dynamic unbounded SGL > lists on G7 hardware." from Aug 14, 2019, leads to the following > static checker warning: > >drivers/scsi/lpfc/lpfc_init.c:4107 lpfc_new_io_buf() > error: not allocating enough data 784 vs 768 Applied to 5.4/sc

Re: [PATCH] lpfc: Remove bg debugfs buffers

2019-08-29 Thread Martin K. Petersen
James, > Capturing and downloading dif command data and dif data was done a > dozen years ago and no longer being used. Also creates a potential > security hole. > > Remove the debugfs buffer for dif debugging. Applied to 5.4/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Enginee

Re: [PATCH] lpfc: Raise config max for lpfc_fcp_mq_threshold variable

2019-08-29 Thread Martin K. Petersen
James, > Raise the config max for lpfc_fcp_mq_threshold variable to 256. Not a big fan of these magic values. Applied to 5.3/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] lpfc: fix 12.4.0.0 GPF at boot

2019-08-29 Thread Martin K. Petersen
James, > The 12.4.0.0 patch that merged WQ/CQ pairs into single per-cpu pair > contained a bug: a local variable was set to the queue pair by index. > This should have allowed the local variable to be natively used. > Instead, the code reused the index relative to the local variable, > obtaining

Re: [RFC] Re: broken userland ABI in configfs binary attributes

2019-08-29 Thread Al Viro
On Tue, Aug 27, 2019 at 06:27:35PM +0100, Al Viro wrote: > Most of them are actually pure bollocks - "it can never happen, but if it > does, > let's return -EWHATEVER to feel better". Some are crap like -EINTR, which is > also bollocks - for one thing, process might've been closing files precise

Re: [PATCH 00/11] smartpqi updates

2019-08-29 Thread Martin K. Petersen
Don, > These patches are based on Linus's tree Applied to 5.4/scsi-queue. In the future, please make your commit descriptions a bit more verbose. Doesn't matter for adding new PCI ids. But it would be nice with some additional background for the more intricate functional driver changes. Thanks

Re: [PATCH 00/14] qedf: Miscellaneous fixes.

2019-08-29 Thread Martin K. Petersen
Saurav, > This series have bug fixes and improve the log messages for better > debugging. > > Kindly apply this series to scsi-queue at your earliest convenience. Applied to 5.4/scsi-queue. I fixed a warning in patch #8. Please verify. Thanks! -- Martin K. Petersen Oracle Linux Engineeri

Re: [PATCH 0/3] scsi: bnx2fc: remove some set but not used variables

2019-08-29 Thread Martin K. Petersen
zhengbin, > zhengbin (3): > scsi: bnx2fc: remove set but not used variable 'fh' > scsi: bnx2fc: remove set but not used variables 'lport','host' > scsi: bnx2fc: remove set but not used variables > 'task','port','orig_task' Applied to 5.4/scsi-queue, thanks. -- Martin K. Petersen

Re: [PATCH] scsi: fnic: print port speed only at driver init or speed change

2019-08-29 Thread Martin K. Petersen
John, > Port speed printing was added by commit d948e6383ec3 ("scsi: fnic: > Add port speed stat to fnic debug stats"). As currently configured, > this will cause the port speed to be printed to syslog every > 2 seconds. To prevent log spamming, only print the vnic port speed > at driver initial

Re: [RFC] Re: broken userland ABI in configfs binary attributes

2019-08-29 Thread Al Viro
On Thu, Aug 29, 2019 at 11:22:58PM +0100, Al Viro wrote: > On Tue, Aug 27, 2019 at 06:27:35PM +0100, Al Viro wrote: > > > Most of them are actually pure bollocks - "it can never happen, but if it > > does, > > let's return -EWHATEVER to feel better". Some are crap like -EINTR, which > > is > >

Re: [RFC] Re: broken userland ABI in configfs binary attributes

2019-08-29 Thread Dave Chinner
On Thu, Aug 29, 2019 at 11:22:58PM +0100, Al Viro wrote: > On Tue, Aug 27, 2019 at 06:27:35PM +0100, Al Viro wrote: > > > Most of them are actually pure bollocks - "it can never happen, but if it > > does, > > let's return -EWHATEVER to feel better". Some are crap like -EINTR, which > > is > >

Re: [RFC] Re: broken userland ABI in configfs binary attributes

2019-08-29 Thread Al Viro
On Fri, Aug 30, 2019 at 02:10:42PM +1000, Dave Chinner wrote: > > reiserfs_file_release(): > > tries to return an error if it can't free preallocated blocks. > > > > xfs_release(): > > similar to the previous case. > > Not quite right. XFS only returns an error if there is data > writeba

Re: [PATCH 00/14] qedf: Miscellaneous fixes.

2019-08-29 Thread Saurav Kashyap
Hi Martin, On 30/08/19, 4:22 AM, "Martin K. Petersen" wrote: > >Saurav, > >> This series have bug fixes and improve the log messages for better >> debugging. >> >> Kindly apply this series to scsi-queue at your earliest convenience. > >Applied to 5.4/scsi-queue. I fixed a warning in patch #8. Pl