RE: [PATCH v2 0/3] scsi: ufs: fix broken hba->outstanding_tasks

2019-07-25 Thread Avri Altman
Stanly, > > Currently bits in hba->outstanding_tasks are cleared only after their > corresponding task management commands are successfully done by > __ufshcd_issue_tm_cmd(). > > If timeout happens in a task management command, its corresponding > bit in hba->outstanding_tasks will not be cleare

RE: [PATCH v2 0/3] scsi: ufs: fix broken hba->outstanding_tasks

2019-07-25 Thread Stanley Chu
Hi Avri, On Thu, 2019-07-25 at 07:54 +, Avri Altman wrote: > Stanly, > > > > > Currently bits in hba->outstanding_tasks are cleared only after their > > corresponding task management commands are successfully done by > > __ufshcd_issue_tm_cmd(). > > > > If timeout happens in a task manageme

SCSI batching since next-20190723 seems to fail multipath table creation?

2019-07-25 Thread Steffen Maier
Hi Paolo, Since next-20190723, multipath-tools cannot assemble (zfcp-attached) SCSI disks into pathgroups anymore. Looking at the SCSI devices managed by multipath-tools, some paths have "alua" for the dh_handler sysfs attribute, while other paths to the same volumes have an unexpected "deta

Re: SCSI batching since next-20190723 seems to fail multipath table creation?

2019-07-25 Thread Paolo Bonzini
On 25/07/19 19:02, Steffen Maier wrote: > > 9e5470fe2d61 ("scsi: virtio_scsi: implement request batching") > 8930a6c20791 ("scsi: core: add support for request batching") > > REBOOT into kernel with above commits reverted and now multipath > assembly works again: Can you try applying only this f

[PATCH v2] scsi: scsi_debugfs: Use for_each_set_bit to simplify code

2019-07-25 Thread Andy Shevchenko
We can use for_each_set_bit() to slightly simplify the code. Signed-off-by: Andy Shevchenko --- - fix title by adding "fs" (Doug) drivers/scsi/scsi_debugfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/scsi_debugfs.c b/drivers/scsi/scsi_debugfs.c index c

[PATCH v2] scsi: mpt3sas: clean up a couple sizeof() uses

2019-07-25 Thread Dan Carpenter
There is a copy and paste bug here. It uses EVENT_TRIGGERS size instead of SCSI_TRIGGERS size but fortunately both size are 84 bytes so it doesn't affect runtime. These days the prefered style is to just say sizeof(object) instead of sizeof(type) so I have updated the function to the latest style