Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

2019-07-02 Thread Andrea Vai
Hi, I have a problem writing data to a USB pendrive, and it seems kernel-related. With the help of Greg an Alan (thanks) and some bisect, I found out the offending commit being commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6 Author: Jens Axboe Date: Thu Nov 1 16:36:27 2018 -0600 scsi: ki

[PATCH] scsi: use scmd_printk() to print which command timed out

2019-07-02 Thread Maurizio Lombardi
With a possibly faulty disk the following messages may appear in the logs: kernel: sd 0:0:9:0: timing out command, waited 180s kernel: sd 0:0:9:0: timing out command, waited 20s kernel: sd 0:0:9:0: timing out command, waited 20s kernel: sd 0:0:9:0: timing out command, waited 60s kernel: sd 0:0:9:0

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

2019-07-02 Thread Johannes Thumshirn
On Tue, Jul 02, 2019 at 12:46:45PM +0200, Andrea Vai wrote: > Hi, > I have a problem writing data to a USB pendrive, and it seems > kernel-related. With the help of Greg an Alan (thanks) and some > bisect, I found out the offending commit being > > commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

2019-07-02 Thread Ming Lei
On Tue, Jul 02, 2019 at 12:46:45PM +0200, Andrea Vai wrote: > Hi, > I have a problem writing data to a USB pendrive, and it seems > kernel-related. With the help of Greg an Alan (thanks) and some > bisect, I found out the offending commit being > > commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

Re: [PATCH] scsi: target/iblock: Fix overrun in WRITE SAME emulation

2019-07-02 Thread Bart Van Assche
On 7/1/19 10:12 AM, Roman Bolshakov wrote: WRITE SAME corrupts data on the block device behind iblock if the command is emulated. The emulation code issues (M - 1) * N times more bios than requested, where M is the number of 512 blocks per real block size and N is the NUMBER OF LOGICAL BLOCKS spe

[RESEND PATCH] scsi: target/iblock: Fix overrun in WRITE SAME emulation

2019-07-02 Thread Roman Bolshakov
WRITE SAME corrupts data on the block device behind iblock if the command is emulated. The emulation code issues (M - 1) * N times more bios than requested, where M is the number of 512 blocks per real block size and N is the NUMBER OF LOGICAL BLOCKS specified in WRITE SAME command. So, for a devic

[PATCH 0/3] zfcp: fixes for the zFCP device driver

2019-07-02 Thread Benjamin Block
Hello James and Martin, here are some fixes for the zFCP device driver. I am rather certain this won't fit into this rc-cycle anymore.. I just found these last week and with internal reviews and tests I was regrettably not able to post these any sooner. So please consider them for the next cycle.

Re: [PATCH V3 2/9] blk-zoned: update blkdev_nr_zones() with helper

2019-07-02 Thread Minwoo Im
On 19-07-02 10:42:28, Chaitanya Kulkarni wrote: > This patch updates the blkdev_nr_zones() with newly introduced helper > function to read the nr_sects from block device's hd_parts with the > help if part_nr_sects_read(). It looks good to me. Reviewed-by: Minwoo Im

[PATCH 1/3] zfcp: fix request object use-after-free in send path causing seqno errors

2019-07-02 Thread Benjamin Block
With a recent change to our send path for FSF commands we introduced a possible use-after-free of request-objects, that might further lead to zfcp crafting bad requests, which the FCP channel correctly complains about with an error (FSF_PROT_SEQ_NUMB_ERROR). This error is then handled by an adapter

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

2019-07-02 Thread Andrea Vai
On 02/07/19 20:01:13, Ming Lei wrote: > On Tue, Jul 02, 2019 at 12:46:45PM +0200, Andrea Vai wrote: > > Hi, > > I have a problem writing data to a USB pendrive, and it seems > > kernel-related. With the help of Greg an Alan (thanks) and some > > bisect, I found out the offending commit being > >

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

2019-07-02 Thread Andrea Vai
On 02/07/19 13:51:17, Johannes Thumshirn wrote: > On Tue, Jul 02, 2019 at 12:46:45PM +0200, Andrea Vai wrote: > > Hi, > > I have a problem writing data to a USB pendrive, and it seems > > kernel-related. With the help of Greg an Alan (thanks) and some > > bisect, I found out the offending commit

[PATCH 2/3] zfcp: fix request object use-after-free in send path causing wrong traces

2019-07-02 Thread Benjamin Block
When tracing instances where we open and close WKA ports, we also pass the request-ID of the respective FSF command. But after successfully sending the FSF command we must not use the request-object anymore, as this might result in an use-after-free (see "zfcp: fix request object use-after-free in

[Bug 197877] arcmsr fails to initialize Areca ARC-1110/ARC-1120 on some systems

2019-07-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=197877 k...@sognnes.no changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [RESEND PATCH] scsi: target/iblock: Fix overrun in WRITE SAME emulation

2019-07-02 Thread Martin K. Petersen
Roman, > WRITE SAME corrupts data on the block device behind iblock if the > command is emulated. The emulation code issues (M - 1) * N times more > bios than requested, where M is the number of 512 blocks per real > block size and N is the NUMBER OF LOGICAL BLOCKS specified in WRITE > SAME comm

[PATCH 3/3] zfcp: fix GCC compiler warning emitted with -Wmaybe-uninitialized

2019-07-02 Thread Benjamin Block
GCC v9 emits this warning: CC drivers/s390/scsi/zfcp_erp.o drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_action_enqueue': drivers/s390/scsi/zfcp_erp.c:217:26: warning: 'erp_action' may be used uninitialized in this function [-Wmaybe-uninitialized] 217 | struct zfcp_

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

2019-07-02 Thread Ming Lei
On Wed, Jul 03, 2019 at 12:39:31AM +0200, Andrea Vai wrote: > On 02/07/19 20:01:13, Ming Lei wrote: > > On Tue, Jul 02, 2019 at 12:46:45PM +0200, Andrea Vai wrote: > > > Hi, > > > I have a problem writing data to a USB pendrive, and it seems > > > kernel-related. With the help of Greg an Alan (th

Re: [RESEND PATCH] scsi: target/iblock: Fix overrun in WRITE SAME emulation

2019-07-02 Thread Michael Christie
On 07/03/2019 04:16 AM, Roman Bolshakov wrote: > WRITE SAME corrupts data on the block device behind iblock if the > command is emulated. The emulation code issues (M - 1) * N times more > bios than requested, where M is the number of 512 blocks per real block > size and N is the NUMBER OF LOGICAL

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

2019-07-02 Thread Andrea Vai
On 03/07/19 10:01:23, Ming Lei wrote: > On Wed, Jul 03, 2019 at 12:39:31AM +0200, Andrea Vai wrote: > > On 02/07/19 20:01:13, Ming Lei wrote: > > > On Tue, Jul 02, 2019 at 12:46:45PM +0200, Andrea Vai wrote: > > > > Hi, > > > > I have a problem writing data to a USB pendrive, and it seems > > > >

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

2019-07-02 Thread Ming Lei
On Wed, Jul 03, 2019 at 07:11:17AM +0200, Andrea Vai wrote: > On 03/07/19 10:01:23, Ming Lei wrote: > > On Wed, Jul 03, 2019 at 12:39:31AM +0200, Andrea Vai wrote: > > > On 02/07/19 20:01:13, Ming Lei wrote: > > > > On Tue, Jul 02, 2019 at 12:46:45PM +0200, Andrea Vai wrote: > > > > > Hi, > > > > >