Re: [PATCH v2 2/2] sd: Inline sd_probe_part2()

2019-05-01 Thread Hannes Reinecke
On 4/30/19 11:39 PM, Bart Van Assche wrote: Make sd_probe() easier to read by inlining sd_probe_part2(). This patch does not change any functionality. Cc: Lee Duncan Cc: Hannes Reinecke Cc: Luis Chamberlain Cc: Johannes Thumshirn Cc: Christoph Hellwig Cc: Pavel Machek Signed-off-by: Bart V

Re: [PATCH v2 1/2] sd: Rely on the driver core for asynchronous probing

2019-05-01 Thread Hannes Reinecke
On 4/30/19 11:39 PM, Bart Van Assche wrote: As explained during the 2018 LSF/MM session about increasing SCSI disk probing concurrency, the problems with the current probing approach are as follows: - The driver core is unaware of asynchronous SCSI LUN probing. wait_for_device_probe() waits f

Re: [scsi:misc 301/301] drivers/scsi/fdomain.c:442:12: sparse: sparse: context imbalance in 'fdomain_host_reset' - wrong count at exit

2019-05-01 Thread Johannes Thumshirn
On Tue, Apr 30, 2019 at 04:02:15PM +0800, kbuild test robot wrote: [...] > >> drivers/scsi/fdomain.c:442:12: sparse: sparse: context imbalance in > >> 'fdomain_host_reset' - wrong count at exit > > vim +/fdomain_host_reset +442 drivers/scsi/fdomain.c > > 92408047 Ondrej Zary 2019-04-29 441 >

[PATCH 1/4] lpfc: resolve lockdep warnings

2019-05-01 Thread James Smart
There were a number of erroneous comments and incorret older lockdep checks that were causing a number of warnings. Resolve the following: Inconsistent lock state warnings in lpfc_nvme_info_show(). Fixed comments and code on sequences where ring lock is now held instead of hbalock. Fixed comment

[PATCH 0/4] lpfc updated for 12.2.0.2

2019-05-01 Thread James Smart
Update lpfc to revision 12.2.0.2 A quick patch set that resolves lockdep checking issues and addresses a couple of bugs found when inspecting the paths for the lockdeps. The patches were cut against Martin's 5.2/scsi-queue tree James Smart (4): lpfc: resolve lockdep warnings lpfc: correct r

[PATCH 4/4] lpfc: Update lpfc version to 12.2.0.2

2019-05-01 Thread James Smart
Due to the couple of bug fixes, update lpfc version to 12.2.0.2 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h ind

[PATCH 3/4] lpfc: add check for loss of ndlp when sending RRQ

2019-05-01 Thread James Smart
There was a missing qualification of a valid ndlp structure when calling to send an RRQ for an abort. Add the check. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc

[PATCH 2/4] lpfc: correct rcu unlock issue in lpfc_nvme_info_show

2019-05-01 Thread James Smart
Many of the exit cases were not releasing the rcu read lock. Corrected the exit paths. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/lpf

[PATCH net-next 03/10] qed: Change hwfn used for sb initialization

2019-05-01 Thread Michal Kalderon
When initializing status blocks use the affined hwfn instead of the leading one for RDMA / Storage Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon --- drivers/infiniband/hw/qedr/main.c| 3 +- drivers/net/ethernet/qlogic/qed/qed_main.c | 47

[PATCH net-next 01/10] qed: Modify api for performing a dmae to another PF

2019-05-01 Thread Michal Kalderon
This patch modifies the dmae API to enable performing a dmae operation to another PF. This enables sharing between the llh entries between PFs and thus increasing the amount of filters per PF under certain configurations. The llh entries require using the dmae since the memory is widebus, which req

[PATCH net-next 07/10] qed*: Add iWARP 100g support

2019-05-01 Thread Michal Kalderon
Add iWARP engine affinity setting for supporting iWARP over 100g. iWARP cannot be distinguished by the LLH from L2, hence the engine division will affect L2 as well. For this reason we add a module parameter in qedr that enables the engine division. Signed-off-by: Ariel Elior Signed-off-by: Micha

[PATCH net-next 00/10] qed*: Improve performance on 100G link for offload protocols

2019-05-01 Thread Michal Kalderon
This patch series modifies the current implementation of PF selection. The refactoring of the llh code enables setting additional filters (mac / protocol) per PF, and improves performance for offload protocols (RoCE, iWARP, iSCSI, fcoe) on 100G link (was capped at 90G per single PF). Improved perf

[PATCH net-next 02/10] qed: Add llh ppfid interface and 100g support for offload protocols

2019-05-01 Thread Michal Kalderon
This patch refactors the current llh implementation. It exposes a hw resource called ppfid (port-pfid) and implements an API for configuring the resource. Default configuration which was used until now limited the number of filters per PF and did not support engine affinity per protocol. The new AP

[PATCH net-next 06/10] qed: Set the doorbell address correctly

2019-05-01 Thread Michal Kalderon
In 100g mode the doorbell bar is united for both engines. Set the correct offset in the hwfn so that the doorbell returned for RoCE is in the affined hwfn. Signed-off-by: Ariel Elior Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 29

[PATCH net-next 09/10] qedi: Use hwfns and affin_hwfn_idx to get MSI-X vector index

2019-05-01 Thread Michal Kalderon
From: Manish Rangankar MSI-X vector index is determined using qed device information and affinity to use. Signed-off-by: Manish Rangankar Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon --- drivers/scsi/qedi/qedi_main.c | 32 ++-- 1 file changed, 26 inse

[PATCH net-next 04/10] qed: Modify offload protocols to use the affined engine

2019-05-01 Thread Michal Kalderon
To enable 100g support for offload protocols each PF gets a dedicated engine to work on from the MFW. This patch modifies the code to use the affined hwfn instead of the leading one. The offload protocols require the ll2 to be opened on both engines, and not just the affined hwfn. Signed-off-by: A

[PATCH net-next 08/10] Revert "scsi: qedi: Allocate IRQs based on msix_cnt"

2019-05-01 Thread Michal Kalderon
From: Manish Rangankar Always request for number of irqs equals to number of queues. This reverts commit 1a291bce5eaf5374627d337157544aa6499ce34a. Signed-off-by: Manish Rangankar Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon --- drivers/scsi/qedi/qedi_main.c | 2 +- 1 file chan

[PATCH net-next 05/10] qedr: Change the MSI-X vectors selection to be based on affined engine

2019-05-01 Thread Michal Kalderon
Use the msix vectors of the affined hwfn and not the leading one. Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon --- drivers/infiniband/hw/qedr/main.c | 9 +++-- drivers/infiniband/hw/qedr/qedr.h | 2 ++ drivers/net/ethernet/qlogic/qed/qed_ll2.c | 4 ++-- 3 files

[PATCH net-next 10/10] qedf: Use hwfns and affin_hwfn_idx to get MSI-X vector index to use

2019-05-01 Thread Michal Kalderon
From: Chad Dupuis MSI-X vector index is determined using qed device information and affinity to use. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap Signed-off-by: Michal Kalderon --- drivers/scsi/qedf/qedf_main.c | 39 --- 1 file changed, 28 inse

Re: [PATCH net-next 07/10] qed*: Add iWARP 100g support

2019-05-01 Thread David Miller
From: Michal Kalderon Date: Wed, 1 May 2019 12:57:19 +0300 > diff --git a/drivers/infiniband/hw/qedr/main.c > b/drivers/infiniband/hw/qedr/main.c > index d93c8a893a89..8bc6775abb79 100644 > --- a/drivers/infiniband/hw/qedr/main.c > +++ b/drivers/infiniband/hw/qedr/main.c > @@ -52,6 +52,10 @@ MOD

Re: [PATCH net-next 07/10] qed*: Add iWARP 100g support

2019-05-01 Thread Leon Romanovsky
On Wed, May 01, 2019 at 08:35:22PM -0400, David Miller wrote: > From: Michal Kalderon > Date: Wed, 1 May 2019 12:57:19 +0300 > > > diff --git a/drivers/infiniband/hw/qedr/main.c > > b/drivers/infiniband/hw/qedr/main.c > > index d93c8a893a89..8bc6775abb79 100644 > > --- a/drivers/infiniband/hw/qed

RE: [PATCH] scsi: smartpqi: Reporting unhandled SCSI errors

2019-05-01 Thread Don.Brace
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Erwan Velu Sent: Wednesday, April 10, 2019 6:03 AM Cc: Erwan Velu ; Don Brace ; James E.J. Bottomley ; Martin K. Petersen ; open list:MICROSEMI SMART ARRAY SMARTPQI DRIVER (s

[PATCH 01/24] scsi: add SPDX tags to scsi midlayer files missing licensing information

2019-05-01 Thread Christoph Hellwig
Add the default kernel GPLv2 annotation to SCSI midlayer files missing any licensing information. Signed-off-by: Christoph Hellwig --- drivers/scsi/hosts.c| 1 + drivers/scsi/scsi.c | 1 + drivers/scsi/scsi_debugfs.h | 1 + drivers/scsi/scsi_error.c | 1 + drivers/scsi/scsi_ioc

[PATCH 11/24] libfc: remove duplicate GPL boilerplate text

2019-05-01 Thread Christoph Hellwig
The libfc uapi headers already have proper SPDX tags, remove the duplicate boilerplate text. Signed-off-by: Christoph Hellwig --- include/uapi/scsi/fc/fc_els.h | 13 - include/uapi/scsi/fc/fc_fs.h | 13 - include/uapi/scsi/fc/fc_gs.h | 13 - include/uapi/scs

[PATCH 07/24] scsi_transport_iscsi: switch to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_iscsi.c | 15 +-- include/scsi/scsi_transport_iscsi.h | 15 +-- 2 files changed, 2 insertions(+), 28 deletions(-) diff --git a/drivers/scsi/s

[PATCH 20/24] ses: switch to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/ses.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c index 0fc39224ce1e..8afea5a1d3f0 100644 --- a/

[PATCH 22/24] sr: add a SPDX tag to sr.c

2019-05-01 Thread Christoph Hellwig
sr.c is the only sr file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Christoph Hellwig --- drivers/scsi/sr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c index 039c27c2d7b3..701d1e68d86e 100644 --- a/

[PATCH 21/24] sg: switch to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/sg.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index d3f15319b9b3..bcdc28e5ede7 100644 --- a/drivers/scsi/sg.c

[PATCH 23/24] st: add a SPDX tag to st.c

2019-05-01 Thread Christoph Hellwig
st.c is the only st file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Christoph Hellwig --- drivers/scsi/st.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index 19c022e66d63..b814906af0a3 100644 --- a/

[PATCH 24/24] osst: add a SPDX tag to osst.c

2019-05-01 Thread Christoph Hellwig
osst.c is the only osst file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Chriosstoph Hellwig --- drivers/scsi/osst.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c index be3c73ebbfde..fe4f0e7d6359 1

[PATCH 17/24] libsas: switch remaining files to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/libsas/sas_discover.c | 18 +- drivers/scsi/libsas/sas_event.c | 18 +- drivers/scsi/libsas/sas_expander.c | 16 +--- drivers/scsi/l

[PATCH 19/24] sd: switch remaining files to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/sd_dif.c | 16 +--- drivers/scsi/sd_zbc.c | 16 +--- 2 files changed, 2 insertions(+), 30 deletions(-) diff --git a/drivers/scsi/sd_dif.c b/drivers/scsi/sd_d

[PATCH 14/24] libiscsi: switch to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/libiscsi.c | 15 +-- drivers/scsi/libiscsi_tcp.c | 13 + include/scsi/iscsi_if.h | 13 + include/scsi/iscsi_proto.h| 13 +--

[PATCH 16/24] libsas: switch sas_ata.[ch] to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/libsas/sas_ata.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index 1ecca71df8b

[PATCH 18/24] sd: add a SPDX tag to sd.c

2019-05-01 Thread Christoph Hellwig
sd.c is the only sd file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Christoph Hellwig --- drivers/scsi/sd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 2b2bc4b49d78..4852c2223359 100644 --- a/

[PATCH 12/24] libfc: switch to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/libfc/fc_disc.c | 14 +- drivers/scsi/libfc/fc_elsct.c | 14 +- drivers/scsi/libfc/fc_exch.c | 14 +- drivers/scsi/libfc/fc_fcp.c | 14 +--

[PATCH 13/24] libfcoe: switch to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/fcoe/fcoe.c | 14 +- drivers/scsi/fcoe/fcoe.h | 14 +- drivers/scsi/fcoe/fcoe_ctlr.c | 14 +- drivers/scsi/fcoe/fcoe_sysf

[PATCH 15/24] libsas: add a SPDX tag to sas_task.c

2019-05-01 Thread Christoph Hellwig
sas_task.c is the only libsas file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Christoph Hellwig --- drivers/scsi/libsas/sas_task.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libsas/sas_task.c b/drivers/scsi

[PATCH 09/24] scsi_transport_spi: switch to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_spi.c | 15 +-- include/scsi/scsi_transport_spi.h | 15 +-- 2 files changed, 2 insertions(+), 28 deletions(-) diff --git a/drivers/scsi/scsi_

[PATCH 08/24] scsi_transport_sas: switch to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2 SPDX tag instead of a free form blurb. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_sas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c index 60f1a81d2034..fbfe01b06

[PATCH 03/24] scsi_netlink: remove duplicate GPL boilerplate text

2019-05-01 Thread Christoph Hellwig
The SCSI netlink uapi header already has a proper SPDX tag, remove the duplicate boilerplate text. Signed-off-by: Christoph Hellwig --- include/uapi/scsi/scsi_netlink.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/include/uapi/scsi/scsi_netlink.h b/include/uapi/scsi/scsi_n

[PATCH 04/24] scsi_transport.h: switch to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- include/scsi/scsi_transport.h | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/include/scsi/scsi_transport.h b/include/scsi/scsi_transport.h index a3dcb1bfb362

[PATCH 02/24] scsi: switch the remaining scsi midlayer files to use SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_logging.c | 3 +-- drivers/scsi/scsi_sysctl.c | 2 +- drivers/scsi/scsi_trace.c | 14 +- 3 files changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/scs

[PATCH 06/24] scsi_transport_fc: switch to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_fc.c | 18 +- include/scsi/scsi_transport_fc.h | 18 +- 2 files changed, 2 insertions(+), 34 deletions(-) diff --git a/drivers/scsi/s

[PATCH 05/24] scsi_transport_fc: remove duplicate GPL boilerplate text

2019-05-01 Thread Christoph Hellwig
The FC transport class uapi headers already have proper SPDX tags, remove the duplicate boilerplate text. Signed-off-by: Christoph Hellwig --- include/uapi/scsi/scsi_bsg_fc.h | 15 --- include/uapi/scsi/scsi_netlink_fc.h | 15 --- 2 files changed, 30 deletions(-) dif

[PATCH 10/24] scsi_transport_srp: switch to SPDX tags

2019-05-01 Thread Christoph Hellwig
Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_srp.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/scsi/scsi_transport_srp.c b/drivers/scsi/scsi_transport_srp.c inde

switch core SCSI code to SPDX tags

2019-05-01 Thread Christoph Hellwig
Hi all, this series switches all SCSI midlayer, upper driver, transport class and library files to have proper SPDX tags instead of no licensing information or copy and pasted boilerplate code.

[PATCH] scsi: ses: Fix out-of-bounds memory access in ses_enclosure_data_process()

2019-05-01 Thread Waiman Long
KASAN has found a slab-out-of-bounds error in ses_enclosure_data_process(). [ 27.298092] BUG: KASAN: slab-out-of-bounds in ses_enclosure_data_process+0x919/0xe80 [ses] [ 27.306407] Read of size 1 at addr 8807c99048b1 by task systemd-udevd/1563 [ 27.315173] CPU: 18 PID: 1563 Comm: syste

[PATCH 3/3] ibmvscsi: fix tripping of blk_mq_run_hw_queue WARN_ON

2019-05-01 Thread Tyrel Datwyler
From: Tyrel Datwyler After a successful SRP login response we call scsi_unblock_requests() to kick any pending IO's. The callback to process this SRP response happens in a tasklet and therefore is in softirq context. The result of such is that when blk-mq is enabled it is no longer safe to call s

[PATCH 1/3] ibmvscsi: Wire up host_reset() in the drivers scsi_host_template

2019-05-01 Thread Tyrel Datwyler
From: Tyrel Datwyler Wire up the host_reset function in our driver_template to allow a user requested adpater reset via the host_reset sysfs attribute. Example: echo "adapter" > /sys/class/scsi_host/host0/host_reset Signed-off-by: Tyrel Datwyler --- drivers/scsi/ibmvscsi/ibmvscsi.c | 13

[PATCH 2/3] ibmvscsi: redo driver work thread to use enum action states

2019-05-01 Thread Tyrel Datwyler
From: Tyrel Datwyler The current implemenation relies on two flags in the drivers private host structure to signal the need for a host reset or to reenable the CRQ after a LPAR migration. This patch does away with those flags and introduces a single action flag and defined enums for the supported

Re: [PATCH 02/24] scsi: switch the remaining scsi midlayer files to use SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:13 PM, Christoph Hellwig wrote: Use the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_logging.c | 3 +-- drivers/scsi/scsi_sysctl.c | 2 +- drivers/scsi/scsi_trace.c | 14 +- 3 files changed, 3 insert

Re: [PATCH 01/24] scsi: add SPDX tags to scsi midlayer files missing licensing information

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:13 PM, Christoph Hellwig wrote: Add the default kernel GPLv2 annotation to SCSI midlayer files missing any licensing information. Signed-off-by: Christoph Hellwig --- drivers/scsi/hosts.c| 1 + drivers/scsi/scsi.c | 1 + drivers/scsi/scsi_debugfs.h | 1 + driver

Re: [PATCH 03/24] scsi_netlink: remove duplicate GPL boilerplate text

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:13 PM, Christoph Hellwig wrote: The SCSI netlink uapi header already has a proper SPDX tag, remove the duplicate boilerplate text. Signed-off-by: Christoph Hellwig --- include/uapi/scsi/scsi_netlink.h | 15 --- 1 file changed, 15 deletions(-) Reviewed-by: Hannes Rei

Re: [PATCH 05/24] scsi_transport_fc: remove duplicate GPL boilerplate text

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:13 PM, Christoph Hellwig wrote: The FC transport class uapi headers already have proper SPDX tags, remove the duplicate boilerplate text. Signed-off-by: Christoph Hellwig --- include/uapi/scsi/scsi_bsg_fc.h | 15 --- include/uapi/scsi/scsi_netlink_fc.h | 15 --

Re: [PATCH 04/24] scsi_transport.h: switch to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:13 PM, Christoph Hellwig wrote: Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- include/scsi/scsi_transport.h | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hann

Re: [PATCH 06/24] scsi_transport_fc: switch to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:13 PM, Christoph Hellwig wrote: Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_fc.c | 18 +- include/scsi/scsi_transport_fc.h | 18 +- 2 files changed, 2 insertions

Re: [PATCH 07/24] scsi_transport_iscsi: switch to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_iscsi.c | 15 +-- include/scsi/scsi_transport_iscsi.h | 15 +-- 2 files changed, 2 insertions

Re: [PATCH 08/24] scsi_transport_sas: switch to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2 SPDX tag instead of a free form blurb. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_sas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Rei

Re: [PATCH 09/24] scsi_transport_spi: switch to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_spi.c | 15 +-- include/scsi/scsi_transport_spi.h | 15 +-- 2 files changed, 2 insertions(+),

Re: [PATCH 10/24] scsi_transport_srp: switch to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_srp.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) Reviewed-by: Hannes Reinecke Cheers,

Re: [PATCH 11/24] libfc: remove duplicate GPL boilerplate text

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: The libfc uapi headers already have proper SPDX tags, remove the duplicate boilerplate text. Signed-off-by: Christoph Hellwig --- include/uapi/scsi/fc/fc_els.h | 13 - include/uapi/scsi/fc/fc_fs.h | 13 - include/uapi/scsi

Re: [PATCH 13/24] libfcoe: switch to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/fcoe/fcoe.c | 14 +- drivers/scsi/fcoe/fcoe.h | 14 +- drivers/scsi/fcoe/fcoe_ctlr.c

Re: [PATCH 12/24] libfc: switch to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/libfc/fc_disc.c | 14 +- drivers/scsi/libfc/fc_elsct.c | 14 +- drivers/scsi/libfc/fc_exch.c | 14 +

Re: [PATCH 14/24] libiscsi: switch to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/libiscsi.c | 15 +-- drivers/scsi/libiscsi_tcp.c | 13 + include/scsi/iscsi_if.h | 13 +---

Re: [PATCH 17/24] libsas: switch remaining files to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/libsas/sas_discover.c | 18 +- drivers/scsi/libsas/sas_event.c | 18 +- drivers/scsi/libsas/sas_

Re: [PATCH 16/24] libsas: switch sas_ata.[ch] to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/libsas/sas_ata.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/scsi/libsas/sas_ata.c b

Re: [PATCH 15/24] libsas: add a SPDX tag to sas_task.c

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: sas_task.c is the only libsas file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Christoph Hellwig --- drivers/scsi/libsas/sas_task.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 18/24] sd: add a SPDX tag to sd.c

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: sd.c is the only sd file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Christoph Hellwig --- drivers/scsi/sd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.

Re: [PATCH 19/24] sd: switch remaining files to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/sd_dif.c | 16 +--- drivers/scsi/sd_zbc.c | 16 +--- 2 files changed, 2 insertions(+), 30 deletions(-) Revi

Re: [PATCH 21/24] sg: switch to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/sg.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index d3f15319b9

Re: [PATCH 20/24] ses: switch to SPDX tags

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2 SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/ses.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.

Re: [PATCH 22/24] sr: add a SPDX tag to sr.c

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: sr.c is the only sr file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Christoph Hellwig --- drivers/scsi/sr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.

Re: [PATCH 23/24] st: add a SPDX tag to st.c

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: st.c is the only st file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Christoph Hellwig --- drivers/scsi/st.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/st.c b/drivers/scsi/st.

Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

2019-05-01 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: osst.c is the only osst file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Chriosstoph Hellwig --- drivers/scsi/osst.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/osst.c b/driver