WTS : Macbook Pro

2019-04-08 Thread Toner
Hello , We have the following Grade A Macbook Pro and Panasonic Toughbook with US keyboards looks like new . Grade A cf-c2ccezxcm - Panasonic Toughbook CF-C2 Convertible Laptop Panasonic Toughbook CF-C2 Convertible Laptop Intel Core i5-4300U 1.90GHz CPU 8GB RAM 128GB HDD Win 8.1 Pro QTY 150

Re: [EXT] [PATCH 02/11] qla2xxx: Change a stack variable into a static const variable

2019-04-08 Thread Himanshu Madhani
Hi Bart, On 4/4/19, 12:45 PM, "Bart Van Assche" wrote: External Email -- Make qla2x00_get_host_fabric_name() slightly faster by changing a stack array into a static array. Declare that array const now tha

Re: [PATCH 04/11] qla2xxx: Use ARRAY_SIZE() in the definition of QLA_LAST_SPEED

2019-04-08 Thread Himanshu Madhani
On 4/4/19, 12:45 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Bart Van Assche" wrote: Make the code easier to read by avoiding to use a hard-coded constant. This patch does not change any functionality. Cc: Himanshu Madhani Cc: Giridhar Malavali Signed-off-by

Re: [EXT] [PATCH 03/11] qla2xxx: Remove a comment that refers to the SCSI host lock

2019-04-08 Thread Himanshu Madhani
On 4/4/19, 12:45 PM, "Bart Van Assche" wrote: External Email -- Since qla2xxx_queuecommand() no longer takes the SCSI host lock, remove a comment that refers to the host lock. Cc: Himanshu Madhani

Re: [EXT] [PATCH 05/11] qla2xxx: Declare local symbols static

2019-04-08 Thread Himanshu Madhani
On 4/4/19, 12:45 PM, "Bart Van Assche" wrote: External Email -- This patch avoids that sparse complains that a declaration is missing. Cc: Himanshu Madhani Cc: Giridhar Malavali Signed-off-b

Re: [EXT] [PATCH 06/11] qla2xxx: Reduce the number of forward declarations

2019-04-08 Thread Himanshu Madhani
On 4/4/19, 12:45 PM, "Bart Van Assche" wrote: External Email -- Move the SCSI host template definition after the definition of the functions that it references. Remove the forward declarations that bec

Re: [EXT] [PATCH 07/11] qla2xxx: Make qla2x00_process_response_queue() easier to read

2019-04-08 Thread Himanshu Madhani
On 4/4/19, 12:45 PM, "Bart Van Assche" wrote: External Email -- Make qla2x00_process_response_queue() easier to read by splitting this function. This patch does not change any functionality. Cc: H

Re: [EXT] [PATCH 11/11] tcm_qla2xxx: Minimize #include directives

2019-04-08 Thread Himanshu Madhani
On 4/4/19, 12:45 PM, "Bart Van Assche" wrote: External Email -- Only include those header files that are needed by the code in this source file. Cc: Himanshu Madhani Cc: Giridhar Malavali

[Bug 107371] I/O error when accessing disk in standby

2019-04-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=107371 --- Comment #1 from flyse...@gmx.de --- still present in 4.19.29 -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH 1/4] scsi fc: add FPIN ELS definition

2019-04-08 Thread Ewan D. Milne
On Fri, 2019-04-05 at 16:04 -0700, James Smart wrote: > T11 has introduced a new Fabric Notifications mechanism whereby the > fabric can notify a port of events occurring in the fabric. > The notifications are given by the FPIN ELS. > > Add the FPIN ELS definitions to the kernel. > > Signed-off-b

Re: [PATCH 0/4] scsi fc FPIN event support

2019-04-08 Thread Ewan D. Milne
On Fri, 2019-04-05 at 16:04 -0700, James Smart wrote: > The FC standard has defined a new Fabric Performance Impact > Notification (FPIN) ELS that can be sent from the fabric to an > endpoint to communicate fabric integrity information. The FPIN > may communicate congestion detection, link integrit

Re: [PATCH 2/4] scsi_transport_fc: refactor event posting routines

2019-04-08 Thread Ewan D. Milne
On Fri, 2019-04-05 at 16:04 -0700, James Smart wrote: > There are two routines generating transport events that do the > same thing with only a couple of values set differently. > > Refactor so there's a single routine doing the netlink > operations to send the event. All the differences are passe

Re: [PATCH 3/4] scsi_transport_fc: Add FPIN fc event codes

2019-04-08 Thread Ewan D. Milne
On Fri, 2019-04-05 at 16:04 -0700, James Smart wrote: > Add a new event type - an FPIN event. > > Add a new routine, fc_host_fpin_rcv(), that lldd's call when > an FPIN is received. The routine processes the fpin payload. > For now, the routine only logs an FPIN event. > > Signed-off-by: Muneendr

Re: [PATCH 4/4] lpfc: add support for posting FC events on FPIN reception

2019-04-08 Thread Ewan D. Milne
On Fri, 2019-04-05 at 16:04 -0700, James Smart wrote: > This patch adds support to recognize FPIN ELS's that are received. > When one is received, the fc transport will be called to handle the > the FPIN. > > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_els.c | 8 > drivers

[Bug 107371] I/O error when accessing disk in standby

2019-04-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=107371 j...@jki.io changed: What|Removed |Added CC||j...@jki.io --- Comment #2 from j...@jki.io

Re: [PATCH] lpfc: Fix a recently introduced compiler warning

2019-04-08 Thread Martin K. Petersen
Bart, > This patch avoids that the following compiler warning is reported with > CONFIG_NVME_FC=n: Applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/4] scsi fc FPIN event support

2019-04-08 Thread Martin K. Petersen
James, > The FC standard has defined a new Fabric Performance Impact > Notification (FPIN) ELS that can be sent from the fabric to an > endpoint to communicate fabric integrity information. The FPIN > may communicate congestion detection, link integrity issues, or > other similar conditions. Ap

Re: [PATCH 00/11] qla2xxx patches for kernel v5.2

2019-04-08 Thread Martin K. Petersen
Bart, > This is a series with mostly source code cleanup patches for the > qla2xxx driver. Please consider this patch series for kernel v5.2. Applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: csiostor: fix missing data copy in csio_scsi_err_handler()

2019-04-08 Thread Martin K. Petersen
Varun, > If scsi cmd sglist is not suitable for DDP then csiostor driver uses > preallocated buffers for DDP, because of this data copy is required > from DDP buffer to scsi cmd sglist before calling ->scsi_done(). Applied to 5.1/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Eng

[PATCH][next] scsi: qla2xxx: fix spelling mistake "alredy" -> "already"

2019-04-08 Thread Colin King
From: Colin Ian King There is a spelling mistake in a ql_log message. Fix it. Signed-off-by: Colin Ian King --- drivers/scsi/qla2xxx/qla_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 1ca63e80a7

Re: [PATCH V4 3/7] blk-mq: quiesce queue before updating nr_hw_queues

2019-04-08 Thread Ming Lei
On Mon, Apr 8, 2019 at 11:17 AM jianchao.wang wrote: > > Hi Ming > > Why not add percpu_ref_tryget/put pair into run queue and requeue work, > or before queue the work ? If following this direction, most of block layer API might need the pair. Also Jens has complained in another thread, the pair

Re: [RFC PATCH 1/1] scsi: sd: associate sd_probe_domain with scsi_disk

2019-04-08 Thread Jin Cai
Hi, Bart It seems that the commit 21e6ba3 in branch 5.2/scsi-queue has addressed the deadlock issue we encountered. We will backport that patch to our kernel version and verify it with our test cases. Thanks Best regards On Sun, Apr 7, 2019 at 12:00 PM Bart Van Assche wrote: >

Re: [PATCH 0/2] Limit number of hw queues by nr_cpu_ids for virtio-blk and virtio-scsi

2019-04-08 Thread Dongli Zhang
ping? Thank you very much! Dongli Zhang On 03/27/2019 06:36 PM, Dongli Zhang wrote: > When tag_set->nr_maps is 1, the block layer limits the number of hw queues > by nr_cpu_ids. No matter how many hw queues are use by > virtio-blk/virtio-scsi, as they both have (tag_set->nr_maps == 1), they > ca

Re: [PATCH][next] scsi: qla2xxx: fix spelling mistake "alredy" -> "already"

2019-04-08 Thread Himanshu Madhani
Hi Colin, On 4/8/19, 1:20 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Colin King" wrote: From: Colin Ian King There is a spelling mistake in a ql_log message. Fix it. Signed-off-by: Colin Ian King --- drivers/scsi/qla2xxx/qla_nvme.c | 2 +- 1 file ch

[RFC PATCH 3/2] fdomain: Use SCSI host private data instead of global variables

2019-04-08 Thread Ondrej Zary
Move global variables into SCSI host private data in order to support multiple cards. Signed-off-by: Ondrej Zary --- drivers/scsi/fdomain.c | 593 + 1 file changed, 307 insertions(+), 286 deletions(-) diff --git a/drivers/scsi/fdomain.c b/drivers/

Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

2019-04-08 Thread Gustavo A. R. Silva
Hi all, Friendly ping: Who can take this? Thanks On 3/7/19 3:49 PM, Finn Thain wrote: > Adjust comments accordingly. > > Cc: Gustavo A. R. Silva > Cc: Michael Schmitz > Signed-off-by: Finn Thain > --- > drivers/scsi/NCR5380.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

2019-04-08 Thread Finn Thain
On Mon, 8 Apr 2019, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: > > Who can take this? > > Thanks > It has been queued up by Martin and James on git.kernel.org. Apparently it is to be pushed in the v5.2 merge window. --

RE: [PATCH] usb: uas: fix usb subsystem hang after power off hub port

2019-04-08 Thread Kento.A.Kobayashi
Hi, >So it looks as though the SCSI subsystem doesn't like to have a reset handler >call scsi_remove_host. Commands dispatched by the removal routines are forced >to wait for the reset recovery to finish, which won't happen until those >commands have been completed. You mean reset handeler sh

RE: [PATCH] usb: uas: fix usb subsystem hang after power off hub port

2019-04-08 Thread Alan Stern
On Tue, 9 Apr 2019 kento.a.kobaya...@sony.com wrote: > Hi, > > >So it looks as though the SCSI subsystem doesn't like to have a reset > >handler call scsi_remove_host. Commands dispatched by the removal routines > >are forced to wait for the reset recovery to finish, which won't happen > >unt

Re: [PATCH] scsi: mvumi: fix warning Using plain integer as NULL pointer

2019-04-08 Thread Martin K. Petersen
Hi Hariprasad, > Changed "0 to NULL" to avoid below sparse warnings > > drivers/scsi/mvumi.c:755:58: warning: Using plain integer as NULL > pointer > drivers/scsi/mvumi.c:1797:48: warning: Using plain integer as NULL > pointer > drivers/scsi/mvumi.c:2142:50: warning: Using plain integer as NULL

Re: [RFC PATCH 1/2] fdomain: Resurrect fdomain and fdomain_cs drivers

2019-04-08 Thread Martin K. Petersen
Hi Ondrej, > This reverts commit e184f2bf4d9f1a3c612a8c1d67e73e9cf8ab5ab9. > It does not compile but following patches will fix that. I don't have any particular objections to reviving this driver if people are actually using it. However, breaking bisection is going to be a problem. So you'll h

Re: [PATCH][next] scsi: qla2xxx: fix spelling mistake "alredy" -> "already"

2019-04-08 Thread Martin K. Petersen
Colin, > There is a spelling mistake in a ql_log message. Fix it. Applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] usb: uas: fix usb subsystem hang after power off hub port

2019-04-08 Thread Martin K. Petersen
Alan, > So it looks as though the SCSI subsystem doesn't like to have a reset > handler call scsi_remove_host. Are you talking about a PCI device removal handler or a SCSI error handler? > Commands dispatched by the removal routines are forced to wait for the > reset recovery to finish, which