Re: [PATCH] scsi: fix ata_port_wait_eh() hung caused by missing to wake up eh thread

2019-03-30 Thread zhengbin (A)
ping On 2019/3/26 21:29, zhengbin (A) wrote: > On 2019/3/25 19:55, zhengbin (A) wrote: >> On 2019/3/25 18:02, Pavel Tikhomirov wrote: >>> Likely we should do the same for host_eh_scheduled++ as we do for >>> host_failed++ in scsi_eh_inc_host_failed. Just put it in call_rcu. These >>> way rcu_rea

[PATCH] scsi: ufs: remove unnecessary pointer judgement

2019-03-30 Thread Zeng Guangyue
The pointer value is initialized as &hba->vreg_info, and it's never changed. It's not necessary to check the pointer is null or not. Signed-off-by: Zeng Guangyue --- drivers/scsi/ufs/ufshcd.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.

RE: [PATCH] scsi: ufs: remove unnecessary pointer judgement

2019-03-30 Thread Winkler, Tomas
> > The pointer value is initialized as &hba->vreg_info, and it's never changed. > It's > not necessary to check the pointer is null or not. > > Signed-off-by: Zeng Guangyue Looks like you are correct. Ack. Thanks Tomas > --- > drivers/scsi/ufs/ufshcd.c | 11 +-- > 1 file changed,