Re: [PATCH v4 00/14] qla2xxx: Add support for ISP28XX (Gen7) adapter

2019-03-19 Thread Martin K. Petersen
Himanshu, > This patch series adds support for our next generation ISP28XX (Gen7) > adapter. Some of the patches mixed fixing sparse warnings with functional changes. I would have like those to be separate commits. In the future, please make one logical change per patch. Applied to 5.2/scsi-qu

Re: [PATCH 00/30] lpfc updates for 12.2.0.1

2019-03-19 Thread Martin K. Petersen
James, > Update lpfc to revision 12.2.0.1 Applied this series to 5.2/scsi-queue. Please verify that I resolved the conflicts in lpfc: Correct localport timeout duration error correctly. Your commit clashed with Ewan's recent change to place completion on the stack. -- Martin K. Pet

Re: [PATCH] scsi: reshuffle no_scsi2_lun_in_cdb for better alignment

2019-03-19 Thread Martin K. Petersen
Christoph, >> no_scsi2_lun_in_cdb declares a new bitfield, but we should >> rather move it to the existing bitfield for better alignment. > > Independent of if this helps the alignment keeping the various bit field > flags together seems like a good idea: Applied to 5.2/scsi-queue, thanks! --

Re: [PATCH] scsi: remove the scsi_ioctl_reset export

2019-03-19 Thread Martin K. Petersen
Christoph, > This function is only used inside the SCSI midlayer. Applied to 5.2/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] Remove OSD include files

2019-03-19 Thread Martin K. Petersen
Bart, > All code from which the OSD include files were included has been > removed. Hence also remove the include files themselves. See also > commit 19fcae3d4f2d ("scsi: remove the SCSI OSD library"). Hand-applied to 5.2/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] Also call destroy_rcu_head() for passthrough requests

2019-03-19 Thread Martin K. Petersen
Bart, > cmd->rcu is initialized by scsi_initialize_rq(). For passthrough > requests, blk_get_request() calls scsi_initialize_rq(). For filesystem > requests, scsi_init_command() calls scsi_initialize_rq(). Make sure > that destroy_rcu_head() is called for passthrough requests. Applied to 5.1/sc

Re: [PATCH] Avoid that a kernel warning appears during system resume

2019-03-19 Thread Martin K. Petersen
Bart, > Since scsi_device_quiesce() skips SCSI devices that have another state > than RUNNING, OFFLINE or TRANSPORT_OFFLINE, scsi_device_resume() > should not complain about SCSI devices that have been skipped. Hence > this patch. This patch avoids that the following warning appears > during re

Re: [PATCH 0/2] qla2xxx: fixes for qla2xxx

2019-03-19 Thread Martin K. Petersen
Himanshu, > These are couple bug fixes for system crash and Target discovery > failure for qla2xxx driver. Applied to 5.1/scsi-fixes, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi_debug: fix write_same with virtual_gb problem

2019-03-19 Thread Bart Van Assche
On Tue, 2019-01-29 at 01:26 -0500, Martin K. Petersen wrote: > Doug, > > > The WRITE SAME(10) and (16) implementations didn't take account of the > > buffer wrap required when the virtual_gb parameter is greater than 0. > > > > Fix that and rename the fake_store() function to lba2fake_store() to

Re: [PATCH] scsi_debug: fix write_same with virtual_gb problem

2019-03-19 Thread Bart Van Assche
On Tue, 2019-03-19 at 12:24 -0700, Bart Van Assche wrote: > On Tue, 2019-01-29 at 01:26 -0500, Martin K. Petersen wrote: > > Doug, > > > > > The WRITE SAME(10) and (16) implementations didn't take account of the > > > buffer wrap required when the virtual_gb parameter is greater than 0. > > > > >

Re: [PATCH] scsi_debug: fix write_same with virtual_gb problem

2019-03-19 Thread Martin K. Petersen
Hi Bart, > Has this patch already been sent to Linus? I see it in your > 5.0/scsi-fixes branch but I can't find it in Linus' current master > branch. commit 40d07b523cf434f252b134c86b1f8f2d907ffb0b Author: Douglas Gilbert Date: Fri Jan 25 12:46:09 2019 -0500 scsi: scsi_debug: fix write_

Re: [PATCH] scsi_debug: fix write_same with virtual_gb problem

2019-03-19 Thread Martin K. Petersen
Bart, > Sorry, I was looking at the wrong branch. The patch is in Linus' > master but it seems like that patch is not yet in your 5.1/scsi-queue > branch? It wouldn't be as 5.1/scsi-queue is based on 5.0-rc1 and the fix went into 5.0-rc5. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi_debug: fix write_same with virtual_gb problem

2019-03-19 Thread James Bottomley
On Tue, 2019-03-19 at 15:37 -0400, Martin K. Petersen wrote: > Bart, > > > Sorry, I was looking at the wrong branch. The patch is in Linus' > > master but it seems like that patch is not yet in your 5.1/scsi- > > queue branch? > > It wouldn't be as 5.1/scsi-queue is based on 5.0-rc1 and the fix w

Re: [PATCH v6 0/7] scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips

2019-03-19 Thread Martin K. Petersen
Stanley, > This patch series adds UFS M-PHY and UFS host driver support in > MediaTek chipsets. > > In the meantime, re-factors ufshcd_get_pwr_dev_param in vendors' > drivers. This function is for vendors to decide finally agreed > attributes for power mode change if vendors define their host >

Re: [PATCH -next] mptfusion: remove set but not used variable 'req_idx, frameOffset'

2019-03-19 Thread Martin K. Petersen
YueHaibing, > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/message/fusion/mptspi.c: In function 'mptspi_writeIOCPage4': > drivers/message/fusion/mptspi.c:262:9: warning: > variable 'frameOffset' set but not used [-Wunused-but-set-variable] > > drivers/message/fusion/mptspi.c:261:9

Re: [PATCH 04/12] scsi: fix typo

2019-03-19 Thread Martin K. Petersen
Matteo, > Ping, can someone review and merge it? Applied to 5.2/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH -next] scsi: qedi: Remove set but not used variable 'cls_sess'

2019-03-19 Thread Martin K. Petersen
YueHaibing, > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/qedi/qedi_fw.c: In function 'qedi_tmf_resp_work': > drivers/scsi/qedi/qedi_fw.c:158:28: warning: > variable 'cls_sess' set but not used [-Wunused-but-set-variable] > > drivers/scsi/qedi/qedi_fw.c: In function 'qedi_tm

Re: [PATCH 25/30] lpfc: Reduce memory footprint for lpfc_queue

2019-03-19 Thread James Bottomley
On Tue, 2019-03-12 at 16:30 -0700, James Smart wrote: > Currently the driver maintains a sideband structure which has a > pointer for each queue element. However, at 8bytes a pointer, and up > to 4k elements per queue, and 100's of queues, this can take up a lot > of memory. > > Convert the driver

Re: [PATCH 25/30] lpfc: Reduce memory footprint for lpfc_queue

2019-03-19 Thread James Smart
> On Mar 19, 2019, at 6:02 PM, James Bottomley > wrote: > > On Tue, 2019-03-12 at 16:30 -0700, James Smart wrote: >> Currently the driver maintains a sideband structure which has a >> pointer for each queue element. However, at 8bytes a pointer, and up >> to 4k elements per queue, and 100's o

Re: [PATCH v4 09/14] qla2xxx: Update flash read/write routine

2019-03-19 Thread Nathan Chancellor
On Tue, Mar 12, 2019 at 11:08:18AM -0700, Himanshu Madhani wrote: > From: Joe Carnuccio > > This patch made following changes to flash access routines > - updated return type for read_optrom > - use void instead of uint32_t * for buffer parameter in read > and write optrom routines > - Fix flas