RE: [EXT] [PATCH v6 1/7] scsi: ufs: Introduce ufshcd_get_pwr_dev_param

2019-03-18 Thread Bean Huo (beanhuo)
This patch absolutely needed. >Subject: [EXT] [PATCH v6 1/7] scsi: ufs: Introduce ufshcd_get_pwr_dev_param > >ufshcd_get_pwr_dev_param is for vendors to decide finally agreed attributes >for power mode change if vendors define their host capability in struct >ufs_dev_params. > >This api is using b

RE: [EXT] [PATCH v6 2/7] scsi: ufs-qcom: Re-factor ufshcd_get_pwr_dev_param

2019-03-18 Thread Bean Huo (beanhuo)
> >Signed-off-by: Stanley Chu >Reviewed-by: Avri Altman Acked-by: Bean Huo

RE: [EXT] [PATCH v6 3/7] scsi: ufs-hisi: Re-factor ufshcd_get_pwr_dev_param

2019-03-18 Thread Bean Huo (beanhuo)
>Signed-off-by: Stanley Chu >Reviewed-by: Avri Altman Acked-by: Bean Huo

Re: [PATCH 2/2] qla2xxx: Fix NULL pointer crash due to stale CPUID

2019-03-18 Thread Ewan D. Milne
On Fri, 2019-03-15 at 15:04 -0700, Himanshu Madhani wrote: > This patch fixes crash due to NULL pointer derefrence because > CPU pointer is not set and used by driver. Instead, driver is > passes CPU as tag via ha->isp_ops->{lun_reset|target_reset} > ... > > Fixes: 9cf2bab630765 ("block: kill re

Re: [PATCH 1/2] qla2xxx: Fix FC-AL connection target discovery

2019-03-18 Thread Ewan D. Milne
On Fri, 2019-03-15 at 15:04 -0700, Himanshu Madhani wrote: > From: Quinn Tran > > Commit 7f147f9bfd44 fixed N2N target discovery for local loop. > However, same code is used for FC-AL discovery as well. Added check > to make sure we are bypassing area and domain check only in N2N > topology for t

[PATCH] Also call destroy_rcu_head() for passthrough requests

2019-03-18 Thread Bart Van Assche
cmd->rcu is initialized by scsi_initialize_rq(). For passthrough requests, blk_get_request() calls scsi_initialize_rq(). For filesystem requests, scsi_init_command() calls scsi_initialize_rq(). Make sure that destroy_rcu_head() is called for passthrough requests. Cc: Christoph Hellwig Cc: Hannes

Re: [PATCH 2/2] qla2xxx: Fix NULL pointer crash due to stale CPUID

2019-03-18 Thread Himanshu Madhani
Hi Ewan, On 3/18/19, 6:36 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Ewan D. Milne" wrote: On Fri, 2019-03-15 at 15:04 -0700, Himanshu Madhani wrote: > This patch fixes crash due to NULL pointer derefrence because > CPU pointer is not set and used by driver. Instead, dri

Re: [PATCH 0/5] smartpqi updates

2019-03-18 Thread Martin K. Petersen
Don, > - smartpqi-increase-LUN-reset-timeout > . resets can take longer than 30 seconds. > - smartpqi-add-H3C-controller-IDs > . add support for H3C controllers > - smartpqi-update-copyright > . add in Microchip, update Microsemi > - smartpqi-add-spdx > . add in spdx > - smartpqi-bump-dr

Re: [PATCH 0/4] hpsa updates

2019-03-18 Thread Martin K. Petersen
Don, > hpsa-check-for-lv-removal > - Detect LUN failures faster by checking command status >in complete_scsi_command. > - closes up a rare issue in multipath fail-overs > hpsa-correct-device-id-issues > - Close up a rare race condition where a volume list is >obtained from the control

Re: [PATCH] scsi: iscsi: flush running unbind operations when removing a session

2019-03-18 Thread Martin K. Petersen
Maurizio, > In some cases, the iscsi_remove_session() function is called while an > unbind_work operation is still running. This may cause a situation > where sysfs objects are removed in an incorrect order, triggering a > kernel warning. Applied to 5.1/scsi-fixes, thanks! -- Martin K. Peter

Re: [PATCH] scsi: target: add device product id and revision configfs attributes

2019-03-18 Thread Martin K. Petersen
Alan, > The product_id and revision attributes will allow for the modification > of the T10 Model and Revision strings returned in inquiry responses. > Its value can be viewed and modified via the ConfigFS path at: Applied to 5.2/scsi-queue. Thank you. -- Martin K. Petersen Oracle Linux

Re: [v1 0/7] Irq poll to address cpu lockup.

2019-03-18 Thread Martin K. Petersen
Suganath, > We have seen cpu lock up issue from fields if system has greater (more > than 96) logical cpu count. SAS3.0 controller (Invader series) > supports at max 96 msix vector and SAS3.5 product (Ventura) supports > at max 128 msix vectors. Applied to 5.2/scsi-queue. Thanks! -- Martin K

Re: [PATCH v6 0/7] scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips

2019-03-18 Thread Stanley Chu
Hi Martin, Would you have any further comments? Could be this series merged to scsi tree? On Sat, 2019-03-16 at 13:04 +0800, Stanley Chu wrote: > Hello, > > This patch series adds UFS M-PHY and UFS host driver support in MediaTek > chipsets. > > In the meantime, re-factors ufshcd_get_pwr_dev_

Re: [PATCH v6 0/7] scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips

2019-03-18 Thread Martin K. Petersen
Stanley, > Would you have any further comments? > > Could be this series merged to scsi tree? I just started merging things for 5.2 and I'm planning on taking a look at the latest iteration of your series. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 04/26] qedf: Simplify s/g list mapping.

2019-03-18 Thread Martin K. Petersen
Saurav/Chad: Please look into this. Thanks! > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on mkp-scsi/for-next] > [also build test WARNING on v5.0 next-20190306] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve th

Re: [PATCH v3 1/5] scsi: ufs: Remove unused min_uA field in struct ufs_vreg

2019-03-18 Thread Alim Akhtar
Hi Stanley On Mon, Mar 18, 2019 at 7:46 AM Stanley Chu wrote: > > There are two fields related to regulator current limit in struct > ufs_vreg: "min_uA" and "max_uA". > > "max_uA" is probed by "-max-microamp" property from device > tree and used for > > - regulator_set_load operations, and > - ic

[PATCH] Remove OSD include files

2019-03-18 Thread Bart Van Assche
All code from which the OSD include files were included has been removed. Hence also remove the include files themselves. See also commit 19fcae3d4f2d ("scsi: remove the SCSI OSD library"). Cc: Christoph Hellwig Cc: Jens Axboe Signed-off-by: Bart Van Assche --- include/scsi/osd_attributes.h |

Re: [v1 0/7] Irq poll to address cpu lockup.

2019-03-18 Thread Suganath Prabu Subramani
Thanks Martin. -Suganath On Tue, Mar 19, 2019 at 2:47 AM Martin K. Petersen wrote: > > > Suganath, > > > We have seen cpu lock up issue from fields if system has greater (more > > than 96) logical cpu count. SAS3.0 controller (Invader series) > > supports at max 96 msix vector and SAS3.5 produc

Re: [PATCH] Also call destroy_rcu_head() for passthrough requests

2019-03-18 Thread Hannes Reinecke
On 3/18/19 5:29 PM, Bart Van Assche wrote: cmd->rcu is initialized by scsi_initialize_rq(). For passthrough requests, blk_get_request() calls scsi_initialize_rq(). For filesystem requests, scsi_init_command() calls scsi_initialize_rq(). Make sure that destroy_rcu_head() is called for passthrough