Re: [PATCH v5 6/7] phy: mediatek: Add UFS M-PHY driver

2019-03-14 Thread Kishon Vijay Abraham I
Hi, On 14/03/19 9:38 AM, Stanley Chu wrote: > Add UFS M-PHY driver on MediaTek chipsets. > > Signed-off-by: Stanley Chu > Reviewed-by: Chunfeng Yun > --- > drivers/phy/mediatek/Kconfig | 11 ++ > drivers/phy/mediatek/Makefile | 1 + > drivers/phy/mediatek/phy-mtk-ufs.c | 239

RE: [PATCH v5 0/7] scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips

2019-03-14 Thread Avri Altman
> > Hello, > > This patch series adds UFS M-PHY and UFS host driver support in MediaTek > chipsets. > > In the meantime, re-factors ufshcd_get_pwr_dev_param in vendors' drivers. > This function is for vendors to decide finally agreed attributes for power > mode > change if vendors define > thei

Re: [PATCH v5 6/7] phy: mediatek: Add UFS M-PHY driver

2019-03-14 Thread Stanley Chu
Hi Kishon, On Thu, 2019-03-14 at 16:06 +0800, Kishon Vijay Abraham I wrote: > Hi, > > On 14/03/19 9:38 AM, Stanley Chu wrote: > > Add UFS M-PHY driver on MediaTek chipsets. > > > > Signed-off-by: Stanley Chu > > Reviewed-by: Chunfeng Yun > > --- > > drivers/phy/mediatek/Kconfig | 11 ++

RE: [PATCH v5 0/7] scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips

2019-03-14 Thread Stanley Chu
Hi Avri, On Thu, 2019-03-14 at 16:28 +0800, Avri Altman wrote: > > > > Hello, > > > > This patch series adds UFS M-PHY and UFS host driver support in MediaTek > > chipsets. > > > > In the meantime, re-factors ufshcd_get_pwr_dev_param in vendors' drivers. > > This function is for vendors to deci

Re: [PATCH v3 5/7] dt-bindings: scsi: ufs: Add document for ufs-mediatek

2019-03-14 Thread Marc Gonzalez
On 13/03/2019 20:48, Rob Herring wrote: Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt mentions: - -fixed-regulator : boolean property specifying that -supply is a fixed regulator. > There are no users of that property in tree and doesn't look like > adding it was ever reviewed. We have

Re: [PATCH v3 5/7] dt-bindings: scsi: ufs: Add document for ufs-mediatek

2019-03-14 Thread Marc Gonzalez
On 13/03/2019 20:48, Rob Herring wrote: Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt mentions: - -fixed-regulator : boolean property specifying that -supply is a fixed regulator. > There are no users of that property in tree and doesn't look like > adding it was ever reviewed. We have

scsi: ufs: fix up regulator operations

2019-03-14 Thread Stanley Chu
Hi, This patch series tries to clean-up and fix-up regulator operations in ufs driver. [PATCH 1/2] scsi: ufs: cleanup unused min_uA in struct ufs_vreg - min_uA in strcut ufs_vreg is not used by any ufs drivers thus remove it. [PATCH 2/2] scsi: ufs: fix regulator set load and icc-level r

[PATCH v1 0/2] scsi: ufs: fix up regulator operations

2019-03-14 Thread Stanley Chu
Hi, This patch series tries to clean-up and fix-up regulator operations in ufs driver. [PATCH 1/2] scsi: ufs: cleanup unused min_uA in struct ufs_vreg - min_uA in strcut ufs_vreg is not used by any ufs drivers thus remove it. [PATCH 2/2] scsi: ufs: fix regulator set load and icc-level r

[PATCH v1 1/2] scsi: ufs: cleanup unused min_uA in struct ufs_vreg

2019-03-14 Thread Stanley Chu
min_uA in strcut ufs_vreg is not used by any ufs drivers thus remove it. Signed-off-by: Stanley Chu --- drivers/scsi/ufs/ufs.h | 1 - drivers/scsi/ufs/ufshcd-pltfrm.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 7da7318eb6a6

[PATCH v1 2/2] scsi: ufs: fix regulator set load and icc-level configuration

2019-03-14 Thread Stanley Chu
Currently if a regulator has "-fixed-regulator" property in device tree, it will skip "max_uA" configuration. However, "regulator_set_load" operation shall be required on those regulators which specifically configured current limitation, i.e., "max_uA". Otherwise zero max_uA value may cause unexpe

Re: [PATCH] scsi: lpfc: Fix error codes in lpfc_sli4_pci_mem_setup()

2019-03-14 Thread Martin K. Petersen
Dan, > It used to be that "error" was set to -ENODEV at the start of the > function but we shifted some code around an now "error" is set to zero > for most error paths. There is a mix of direct returns and "goto out" > but I changed everything to direct returns for consistency. Applied to 5.1

Re: [PATCH] scsi: aacraid: Fix performance issue(QD) on logical drives

2019-03-14 Thread Martin K. Petersen
Hi Sagar, > From: Sagar Biradar > > To: Martin K. Petersen > To: James Bottomley > cc: linux-scsi > cc: aacr...@microsemi.com > cc: Dave Carroll > cc: Scott Benesh > cc: sta...@vger.kernel.org > > Fix performance issue where the queue depth for SmartIOC logical > volumes is set to 1, and a

Re: [PATCH] simscsi: use request tag instead of serial_number

2019-03-14 Thread Martin K. Petersen
Hannes, > Use the request tag for logging instead of the scsi command serial > number. Applied to 5.1/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v1 1/2] scsi: ufs: cleanup unused min_uA in struct ufs_vreg

2019-03-14 Thread Marc Gonzalez
On 14/03/2019 11:40, Stanley Chu wrote: > scsi: ufs: cleanup unused min_uA in struct ufs_vreg cleanup => drop/remove/delete > min_uA in strcut ufs_vreg is not used by any ufs > drivers thus remove it. Nits: min_uA => min_uA field (?) strcut => struct not used by any ufs drivers => not used any

Re: [PATCH v1 1/2] scsi: ufs: cleanup unused min_uA in struct ufs_vreg

2019-03-14 Thread Stanley Chu
Hi Marc, On Thu, 2019-03-14 at 19:57 +0800, Marc Gonzalez wrote: > On 14/03/2019 11:40, Stanley Chu wrote: > > > scsi: ufs: cleanup unused min_uA in struct ufs_vreg > > cleanup => drop/remove/delete > > > min_uA in strcut ufs_vreg is not used by any ufs > > drivers thus remove it. > > Nits: >

Re: ideas for fix to scsi_ioctl_reset

2019-03-14 Thread Bart Van Assche
On Wed, 2019-03-13 at 23:52 -0400, Douglas Gilbert wrote: > On 2019-03-13 10:39 p.m., Bart Van Assche wrote: > > On 3/13/19 6:32 PM, Douglas Gilbert wrote: > > > I agree that scsi_ioctl_reset() should be taught how to produce a request > > > that doesn't blow up intermediate code expecting all requ

Re: ideas for fix to scsi_ioctl_reset

2019-03-14 Thread Douglas Gilbert
On 2019-03-14 11:19 a.m., Bart Van Assche wrote: On Wed, 2019-03-13 at 23:52 -0400, Douglas Gilbert wrote: On 2019-03-13 10:39 p.m., Bart Van Assche wrote: On 3/13/19 6:32 PM, Douglas Gilbert wrote: I agree that scsi_ioctl_reset() should be taught how to produce a request that doesn't blow up

Re: [PATCH v5 4/7] dt-bindings: phy: Add document for phy-mtk-ufs

2019-03-14 Thread Rob Herring
On Wed, Mar 13, 2019 at 11:09 PM Stanley Chu wrote: > > Add UFS M-PHY node document for MediaTek SoC chips. > > Signed-off-by: Stanley Chu > --- > .../devicetree/bindings/phy/phy-mtk-ufs.txt | 38 +++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/device

Re: [PATCH v3 5/7] dt-bindings: scsi: ufs: Add document for ufs-mediatek

2019-03-14 Thread Rob Herring
On Thu, Mar 14, 2019 at 3:46 AM Marc Gonzalez wrote: > > On 13/03/2019 20:48, Rob Herring wrote: > > Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt mentions: > - -fixed-regulator : boolean property specifying that -supply is > a fixed regulator. > > > There are no users of that property

[PATCH 0/5] smartpqi updates

2019-03-14 Thread Don Brace
These patches are based on Linus's tree The changes are: - smartpqi-increase-LUN-reset-timeout . resets can take longer than 30 seconds. - smartpqi-add-H3C-controller-IDs . add support for H3C controllers - smartpqi-update-copyright . add in Microchip, update Microsemi - smartpqi-add-spdx

[PATCH 1/5] smartpqi: increase LUN reset timeout

2019-03-14 Thread Don Brace
From: Kevin Barnett Reviewed-by: Scott Benesh Reviewed-by: David Carroll Reviewed-by: Kevin Barnett Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/scsi

[PATCH 4/5] smartpqi: add spdx

2019-03-14 Thread Don Brace
Reviewed-by: David Carroll Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/Makefile |1 + drivers/scsi/smartpqi/smartpqi.h | 10 +- drivers/scsi/smartpqi/smartpqi_init.c

[PATCH 2/5] smartpqi: add H3C controller IDs

2019-03-14 Thread Don Brace
From: Ajish Koshy Reviewed-by: Scott Teel Reviewed-by: Scott Benesh Reviewed-by: David Carroll Reviewed-by: Kevin Barnett Signed-off-by: Ajish Koshy Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 16 1 file changed, 16 insertions(+) diff --git a/dr

[PATCH 5/5] smartpqi: bump driver version

2019-03-14 Thread Don Brace
Reviewed-by: Gerry Morong Reviewed-by: David Carroll Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/smart

[PATCH 3/5] smartpqi: update copyright

2019-03-14 Thread Don Brace
Reviewed-by: Gerry Morong Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: David Carroll Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h |5 +++-- drivers/scsi/smartpqi/smartpqi_init.c |5 +++-- drivers/scs

Re: [PATCH v3 5/7] dt-bindings: scsi: ufs: Add document for ufs-mediatek

2019-03-14 Thread Stanley Chu
Hi Rob and all, On Fri, 2019-03-15 at 00:44 +0800, Rob Herring wrote: > On Thu, Mar 14, 2019 at 3:46 AM Marc Gonzalez wrote: > > > > On 13/03/2019 20:48, Rob Herring wrote: > > > > Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt mentions: > > - -fixed-regulator : boolean property specifyi

Re: [PATCH 00/26] qedf: Misc fixes for the driver.

2019-03-14 Thread Saurav Kashyap
Hi Martin, Kindly share the latest update on this. Thanks, ~Saurav -Original Message- From: Saurav Kashyap Date: Tuesday, 5 March 2019 at 4:29 PM To: "martin.peter...@oracle.com" Cc: "qlogic-storage-upstr...@cavium.com" , "linux-scsi@vger.kernel.org" Subject: [PATCH 00/26] qedf: Misc