RE: [PATCH v1 2/2] scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips

2019-02-22 Thread Avri Altman
Hi, > + > +struct ufs_mtk_dev_params { > + u32 pwm_rx_gear;/* pwm rx gear to work in */ > + u32 pwm_tx_gear;/* pwm tx gear to work in */ > + u32 hs_rx_gear; /* hs rx gear to work in */ > + u32 hs_tx_gear; /* hs tx gear to work in */ > + u32 rx_la

Re: [PATCH -next] scsi: megaraid_sas: Remove a bunch of set but not used variables

2019-02-22 Thread Sumit Saxena
On Fri, Feb 22, 2019 at 7:30 AM Yue Haibing wrote: > > From: YueHaibing > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/megaraid/megaraid_sas_fusion.c: In function 'wait_and_poll': > drivers/scsi/megaraid/megaraid_sas_fusion.c:936:25: warning: > variable 'fusion' set but not

RE: [PATCH v1 2/2] scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips

2019-02-22 Thread Stanley Chu
Hi Avri, On Fri, 2019-02-22 at 10:29 +, Avri Altman wrote: > Hi, > > > + > > +struct ufs_mtk_dev_params { > > + u32 pwm_rx_gear;/* pwm rx gear to work in */ > > + u32 pwm_tx_gear;/* pwm tx gear to work in */ > > + u32 hs_rx_gear; /* hs rx gear to work in */ > > +

Re: [PATCH v2] scsi: sd: Optimal I/O size should be a multiple of physical block size

2019-02-22 Thread Christoph Hellwig
On Tue, Feb 12, 2019 at 04:21:05PM -0500, Martin K. Petersen wrote: > It was reported that some devices report an OPTIMAL TRANSFER LENGTH of > 0x blocks. That looks bogus, especially for a device with a > 4096-byte physical block size. > > Ignore OPTIMAL TRANSFER LENGTH if it is not a multiple

Re: [PATCH v2] scsi: sd: block: Fix regressions in read-only block device handling

2019-02-22 Thread Christoph Hellwig
On Tue, Feb 12, 2019 at 09:57:17PM -0500, Martin K. Petersen wrote: > Some devices come online in write protected state and switch to > read-write once they are ready to process I/O requests. These devices > broke with commit 20bd1d026aac ("scsi: sd: Keep disk read-only when > re-reading partition"

Re: [PATCH] scsi: Remove negative constant left-shifts

2019-02-22 Thread Lee Duncan
On 2/21/19 4:20 PM, Iustin Pop wrote: > Negative constant left-shift is undefined behaviour in the C standard, > and as such newer versions of clang (at least) warn against it. GCC > supports it for a long time, but it would be better to remove it and > rely on defined behaviour. > > My understand

[RESEND] [PATCH] Hold back_lock when calling iscsi_complete_task

2019-02-22 Thread Lee Duncan
From: Lee Duncan If there is an error queueing an iscsi command in iscsi_queuecommand(), for example if the transport fails to take the command in sessuin->tt->xmit_task(), then the error path can call iscsi_complete_task() without first aquiring the back_lock as required. This can lead to things

Re: WARNING: CPU: 2 PID: 11303 at drivers/scsi/scsi_lib.c:2600 scsi_device_resume+0x4f/0x58

2019-02-22 Thread Przemek Socha
Dnia piÄ…tek, 22 lutego 2019 04:55:20 CET piszesz: > On 2/20/19 1:17 PM, Przemek Socha wrote: > > Greetings, > > > > recently, after resume from hibernation I'm getting a strange warning in > > my > > dmesg output. > > > > The whole process (hibernate/resume) triggers WARN_ON_ONCE at line 2600 in

Re: [PATCH v4 7/8] phy: qcom: Utilize UFS reset controller

2019-02-22 Thread Stephen Boyd
Quoting Evan Green (2019-02-13 15:25:25) > Move the PHY reset from ufs-qcom into the respective PHYs. This will > allow us to merge the two phases of UFS PHY initialization. > > Signed-off-by: Evan Green > > --- Reviewed-by: Stephen Boyd

Re: [PATCH v4 8/8] phy: ufs-qcom: Refactor all init steps into phy_poweron

2019-02-22 Thread Stephen Boyd
Quoting Evan Green (2019-02-13 15:25:26) > The phy code was using implicit sequencing between the PHY driver > and the UFS driver to implement certain hardware requirements. > Specifically, the PHY reset register in the UFS controller needs > to be deasserted before serdes start occurs in the PHY.

[GIT PULL] SCSI fixes for 5.0-rc7

2019-02-22 Thread James Bottomley
Four small fixes: three in drivers and one in the core. The core fix is also minor in scope since the bug it fixes is only known to affect systems using SCSI reservations. Of the driver bugs, the libsas one is the most major because it can lead to multiple disks on the same expander not being ex