Re: [PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support

2019-02-20 Thread Thierry Reding
On Sat, Jan 05, 2019 at 12:58:58PM +0530, Manivannan Sadhasivam wrote: > Add UFS controller support for HiSilicon HI3670 SoC. > > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 18 ++ > 1 file changed, 18 insertions(+) Hi Martin, it loo

[PATCH -next] mptfusion: remove set but not used variable 'req_idx, frameOffset'

2019-02-20 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/message/fusion/mptspi.c: In function 'mptspi_writeIOCPage4': drivers/message/fusion/mptspi.c:262:9: warning: variable 'frameOffset' set but not used [-Wunused-but-set-variable] drivers/message/fusion/mptspi.c:261:9: warning: variable 'req_i

Re: [PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support

2019-02-20 Thread Martin K. Petersen
Hi Thierry, > it looks like you picked this up into the SCSI tree (perhaps > inadvertently). It's been causing linux-next to fail to build since > Monday (next-20190218) because it references a phandle (&crg_rst) > that's not available. I dropped the offending patch from the SCSI tree yesterday

Re: [RFC PATCH] scsi: fix oops in scsi_uninit_cmd()

2019-02-20 Thread Christoph Hellwig
[fullquote removed, please follow proper mail etiquette] On Tue, Feb 19, 2019 at 08:56:28AM -0800, Bart Van Assche wrote: > regression in the SCSI sd driver due to the switch from the legacy block > layer to scsi-mq. The above patch introduces two atomic operations in the > hot path and hence woul

Re: [RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it

2019-02-20 Thread Christoph Hellwig
On Tue, Feb 19, 2019 at 09:30:33PM -0800, ira.we...@intel.com wrote: > From: Ira Weiny > > Resending these as I had only 1 minor comment which I believe we have covered > in this series. I was anticipating these going through the mm tree as they > depend on a cleanup patch there and the IB chang

[PATCH] scsi: csiostor: fix incorrect if condition for setting dma mask

2019-02-20 Thread Varun Prakash
Use && instead of || in if condition as dma_set_mask_and_coherent() returns 0 on success. Fixes: c22b332d811b ("scsi: csiostor: switch to generic DMA API") Cc: sta...@vger.kernel.org Cc: Christoph Hellwig Signed-off-by: Varun Prakash --- drivers/scsi/csiostor/csio_init.c | 2 +- 1 file changed,

Re: [PATCH] scsi: csiostor: fix incorrect if condition for setting dma mask

2019-02-20 Thread John Garry
On 20/02/2019 15:35, Varun Prakash wrote: Use && instead of || in if condition as dma_set_mask_and_coherent() returns 0 on success. Fixes: c22b332d811b ("scsi: csiostor: switch to generic DMA API") Cc: sta...@vger.kernel.org Cc: Christoph Hellwig Signed-off-by: Varun Prakash --- drivers/scsi/

Re: [RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it

2019-02-20 Thread Ira Weiny
On Wed, Feb 20, 2019 at 07:19:30AM -0800, Christoph Hellwig wrote: > On Tue, Feb 19, 2019 at 09:30:33PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Resending these as I had only 1 minor comment which I believe we have > > covered > > in this series. I was anticipating these go

[PATCH] scsi: replace GFP_ATOMIC with GFP_KERNEL for sdev allocation

2019-02-20 Thread Benjamin Block
We had a test-report where, under memory pressure, adding LUNs to the systems would fail (the tests add LUNs strictly in sequence): [ 5525.853432] scsi 0:0:1:1088045124: Direct-Access IBM 2107900 .148 PQ: 0 ANSI: 5 [ 5525.853826] scsi 0:0:1:1088045124: alua: supports implicit TP

Re: [PATCH] scsi: replace GFP_ATOMIC with GFP_KERNEL for sdev allocation

2019-02-20 Thread Bart Van Assche
On Wed, 2019-02-20 at 19:48 +0100, Benjamin Block wrote: > We had a test-report where, under memory pressure, adding LUNs to the > systems would fail (the tests add LUNs strictly in sequence): Hi Benjamin, There are two more instances of GFP_ATOMIC in scsi_scan.c. Have you verified whether or not

Re: [RESEND PATCH 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-20 Thread Mike Marshall
Hi Ira Martin and I looked at your patch and agree that it doesn't change functionality for Orangefs. Reviewed-by: Mike Marshall On Wed, Feb 20, 2019 at 12:32 AM wrote: > > From: Ira Weiny > > To facilitate additional options to get_user_pages_fast() change the > singular write parameter to

Re: [PATCH] scsi: replace GFP_ATOMIC with GFP_KERNEL for sdev allocation

2019-02-20 Thread Benjamin Block
On Wed, Feb 20, 2019 at 11:11:31AM -0800, Bart Van Assche wrote: > On Wed, 2019-02-20 at 19:48 +0100, Benjamin Block wrote: > > We had a test-report where, under memory pressure, adding LUNs to the > > systems would fail (the tests add LUNs strictly in sequence): > > Hi Benjamin, > > There are tw

WARNING: CPU: 2 PID: 11303 at drivers/scsi/scsi_lib.c:2600 scsi_device_resume+0x4f/0x58

2019-02-20 Thread Przemek Socha
Greetings, recently, after resume from hibernation I'm getting a strange warning in my dmesg output. The whole process (hibernate/resume) triggers WARN_ON_ONCE at line 2600 in scsi_lib.c file. It is a Lenovo g50-45 netbook with sata ssd (micron 1100) and amd fch ahci piix4 (1022:7801) sata co

Re: [RESEND PATCH 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-20 Thread Souptick Joarder
Hi Ira, On Wed, Feb 20, 2019 at 11:01 AM wrote: > > From: Ira Weiny > > To facilitate additional options to get_user_pages_fast() change the > singular write parameter to be gup_flags. > > This patch does not change any functionality. New functionality will > follow in subsequent patches. > > S

Re: [PATCH] mpt3sas: Use driver scsi lookup to track outstanding IOs

2019-02-20 Thread Sasha Levin
On Tue, Feb 19, 2019 at 07:14:17PM +0530, Sreekanth Reddy wrote: Greg, This patch will fix the issue discussed in below email thread, https://patchwork.kernel.org/patch/10734933/ Yesterday same issue is been reported by Michal Soltys in below thread, https://marc.info/?l=linux-scsi&m=1550578308