On Fri, Feb 15, 2019 at 08:43:55AM +0100, Christoph Hellwig wrote:
> On Fri, Feb 15, 2019 at 07:55:39AM +0100, Hannes Reinecke wrote:
> >> Yeah, there is a few more. And the sad part is as of a few kernel
> >> release ago we shouldn't even need the fallback 32-bit dma mask
> >> anymore - we've cle
From: Sedat Dilek
commit 1917d42d14b7 ("fcoe: use enum for fip_mode") introduces a separate
enum for the fip_mode that shall be used during initialisation handling
until it is passed to fcoe_ctrl_link_up to set the initial fip_state.
That change was incomplete and gcc quietly converted in various
On 15/02/2019 08:08, Christoph Hellwig wrote:
On Fri, Feb 15, 2019 at 08:43:55AM +0100, Christoph Hellwig wrote:
On Fri, Feb 15, 2019 at 07:55:39AM +0100, Hannes Reinecke wrote:
Yeah, there is a few more. And the sad part is as of a few kernel
release ago we shouldn't even need the fallback 32
From: Colin Ian King
The null check on pointer sess and the subsequent call is redundant
as sess is null on all the the paths that lead to the out_term2 label.
Hence the null check and the call can be removed. Also remove the
redundant setting of sess to NULL as this is not required now.
Detect
Hi Sedat,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on scsi/for-next]
[also build test ERROR on v5.0-rc4 next-20190215]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
when create DMA pool for cmd frames failed, we should return -ENOMEM,
instead of 0.
In some case in:
megasas_init_adapter_fusion()
-->megasas_alloc_cmds()
-->megasas_create_frame_pool
create DMA pool failed,
--> megasas_free_cmds() [1]
-->megasas_alloc_cmds_f
From: Sedat Dilek
commit 1917d42d14b7 ("fcoe: use enum for fip_mode") introduces a separate
enum for the fip_mode that shall be used during initialisation handling
until it is passed to fcoe_ctrl_link_up to set the initial fip_state.
That change was incomplete and gcc quietly converted in various
On Thu, 2019-02-14 at 22:15 +0100, Jean Delvare wrote:
> From: Hannes Reinecke
>
> When evaluating the 'block limits' VPD page we need to check if
> the 'lbpme' (logical block provisioning management enable) bit
> is set in the READ CAPACITY (16) output.
> If it isn't we can safely assume that we
Hi,
This basically happens on most shutdowns (and one of the ways to
ensure it happens always is to for example change i/o schedulers
after the boot via simple udev rules).
Normally (on successful shutdown), the very last things displayed right after
sync messages are "sending message unit reset
On Fri, Feb 15, 2019 at 4:19 AM Hannes Reinecke wrote:
>
> From: Sedat Dilek
>
> commit 1917d42d14b7 ("fcoe: use enum for fip_mode") introduces a separate
> enum for the fip_mode that shall be used during initialisation handling
> until it is passed to fcoe_ctrl_link_up to set the initial fip_sta
On Fri, Feb 15, 2019 at 01:19:20PM +0100, Hannes Reinecke wrote:
> From: Sedat Dilek
>
> commit 1917d42d14b7 ("fcoe: use enum for fip_mode") introduces a separate
> enum for the fip_mode that shall be used during initialisation handling
> until it is passed to fcoe_ctrl_link_up to set the initial
> NOTE: This series depends on my clean up patch to remove the write parameter
> from gup_fast_permitted()[1]
>
> HFI1, qib, and mthca, use get_user_pages_fast() due to it performance
> advantages. These pages can be held for a significant time. But
> get_user_pages_fast() does not protect again
Two fairly small fixes: the qla one is a panic inducing use after free
and the entropy fix may seem minor but it has had huge userspace impact
thanks to an unrelated change in openssl that causes sshd to refuse
logins until it has enough entropy for the session keys, which causes
tens of minutes de
On Fri, Feb 15, 2019 at 12:37:57AM +0800, John Garry wrote:
> The sysfs phy_identifier attribute for a sas_end_device comes
> from the rphy phy_identifier value.
>
> Currently this is not being set for rphys with an end device attached,
> so we see incorrect symlinks from systemd disk/by-path:
>
The pull request you sent on Fri, 15 Feb 2019 11:17:11 -0800:
> git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/5ded5871030eb75017639148da0a58931dfbfc25
Thank you!
--
Deet-doot-dot, I am a bot.
ht
Add missing break statement and fix identation issue.
This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.
Fixes: 9cb62fa24e0d ("aacraid: Log firmware AIF messages")
Cc: sta...@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/aacraid/commsup.c |
On 2/12/19 9:21 PM, Bob Liu wrote:
> From: Anoob Soman
>
> When a target sends Check Condition, whilst initiator is busy xmiting
> re-queued data, could lead to race between iscsi_complete_task() and
> iscsi_xmit_task() and eventually crashing with the following kernel
> backtrace.
>
> [3326150.
On 2/8/19 1:24 PM, Bart Van Assche wrote:
> This patch does not change any functionality.
>
> Cc: Lee Duncan
> Cc: Chris Leech
> Signed-off-by: Bart Van Assche
> ---
> drivers/scsi/libiscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/libiscsi.c b/dr
On 2/6/19 2:32 AM, Johannes Thumshirn wrote:
> On 06/02/2019 06:21, Chaitanya Kulkarni wrote:
>> Hi,
>>
>> Since discussion of the storage stack and device driver at the LSFMM 2017
>> (https://lwn.net/Articles/717699/), Omar Sandoval introduced a new framework
>> "blktests" dedicated for Linux Ker
Hi Colin,
On 2/15/19, 1:52 AM, "Colin King" wrote:
External Email
From: Colin Ian King
The null check on pointer sess and the subsequent call is redundant
as sess is null on all the the paths that lead to the out_term2 label.
Hence the null check and the call can
This patch fixes following checkpatch ERROR
ERROR: space prohibited before that ',' (ctx:WxW)
No change is functionality due to this patch.
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_tmpl.c | 46 -
1 file changed, 23 insertions(+), 23
From: Joe Carnuccio
This patch adds new firmware dump template entries for
ISP27XX firmware dump.
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_tmpl.c | 191 +---
drivers/scsi/qla2xxx/qla_tmpl.h | 26 +-
2 fi
From: Quinn Tran
Prevent user from sending commands through SysFS while
FW is not running or reset is in progress.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/qla2xxx/qla_attr
From: Anil Gurumurthy
This patch adds SysFS node
1. There is a new sysfs node port_speed
2. The possible values are 2(Auto neg), 8, 16, 32
3. A value outside of the above defaults to Auto neg
4. Any update to the setting causes a link toggle
5. This feature is currently only for ISP27xx
Signed-
Hi Martin,
This series has misc bug fixes which includes cleanup for FC-NVMe code and
added first burst support for FC-NVMe devices. Other patches included in the
series adds new SysFS hook for setting port speed and patch to prevent access
to SysFS hook whle chip is down.
Please apply this ser
This patch fixes LUN discovery when loop ID is not yet assigned
by the firmware during driver load/sg_reset operations. Driver will
now search for new loop id before retrying login.
Fixes: 48acad099074 ("scsi: qla2xxx: Fix N2N link re-connect")
Cc: sta...@vger.kernel.org #4.19
Signed-off-by: Himan
From: Darren Trapp
Add Support for First Burst for FC-NVMe protocol. This
feature requires First Burst support in the firmware.
Signed-off-by: Darren Trapp
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 4
drivers/scsi/qla2xxx/qla_init.c | 6 ++
drivers/scsi/
From: Quinn Tran
add check to allow 1 discovery command per session to be sent.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scs
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 537098e8f1c1..0690dac24081 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
+++
From: Quinn Tran
current code hard code marker request to use request
and response queue 0. This patch make use of the
qpair as the path to access the request/response queues.
It allows marker to be place on any hardware queues.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
dr
For FC-NVMe, if the fw_started flag is not set or
fcport is deleted, then do not send Abort command
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_nvme.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
in
This patch fixes driver unload issue when FC-NVMe devices are
configured.
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_nvme.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nv
Fix the following warnings by adding the proper missing breaks:
drivers/scsi/mpt3sas/mpt3sas_base.c: In function ‘_base_display_OEMs_branding’:
drivers/scsi/mpt3sas/mpt3sas_base.c:3548:4: warning: this statement may fall
through [-Wimplicit-fallthrough=]
switch (ioc->pdev->subsystem_device) {
From: Giridhar Malavali
This patch fixes warning seen when BLK-MQ is enabled and hardware
does not support MQ. This will result into driver requesting MSIx
vectors which are equal or less than pre_desc via PCI IRQ Affinity
infrastructure.
[ 19.746300] qla2xxx [:00:00.0]-0005: : QLogic
Hi Meelis,
On 2/12/19, 6:37 PM, "Ming Lei" wrote:
External Email
On Wed, Feb 13, 2019 at 5:36 AM Meelis Roos wrote:
>
> > I tested todays 5.0.0-rc5-00358-gdf3865f on my sparcs and a couple
of servers that have qla2xxx
> > FC adapter gave me this warning:
Christoph?
> It was reported that some devices report an OPTIMAL TRANSFER LENGTH of
> 0x blocks. That looks bogus, especially for a device with a
> 4096-byte physical block size.
>
> Ignore OPTIMAL TRANSFER LENGTH if it is not a multiple of the device's
> reported physical block size.
>
> To
Manivannan,
> Ping on this patch!
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Christoph? Jens?
> Some devices come online in write protected state and switch to
> read-write once they are ready to process I/O requests. These devices
> broke with commit 20bd1d026aac ("scsi: sd: Keep disk read-only when
> re-reading partition") because we had no way to distinguish between a
Bob,
> When a target sends Check Condition, whilst initiator is busy xmiting
> re-queued data, could lead to race between iscsi_complete_task() and
> iscsi_xmit_task() and eventually crashing with the following kernel
> backtrace.
Applied to 5.0/scsi-fixes, thanks!
--
Martin K. Petersen
Damien,
> The function sd_zbc_do_report_zones() issues a REPORT ZONES command
> with a buffer size calculated based on the number of zones requested
> by the caller. This value should however not exceed the capabilities
> of the hardware maximum command size, that is, should not exceed the
> max
Bill,
> When sending an srb with qla2x00_start_sp, the sp can complete and be
> freed by the time we log the debug message saying we sent it. This can
> cause a panic if sp gets reused quickly or when running a kernel that
> poisons freed memory.
Applied to 5.1/scsi-queue, thanks!
--
Martin
John,
> The sysfs phy_identifier attribute for a sas_end_device comes
> from the rphy phy_identifier value.
Applied to 5.0/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Martin,
> Up to 4.12, __scsi_error_from_host_byte() would reset the host
> byte to DID_OK for various cases including DID_NEXUS_FAILURE.
> Commit 2a842acab109 ("block: introduce new block status code type")
> replaced this function with scsi_result_to_blk_status() and removed
> the host-byte res
Jean,
> When evaluating the 'block limits' VPD page we need to check if the
> 'lbpme' (logical block provisioning management enable) bit is set in
> the READ CAPACITY (16) output. If it isn't we can safely assume that
> we cannot use DISCARD on this device.
That's not entirely correct. We stil
Colin,
> The null check on pointer sess and the subsequent call is redundant as
> sess is null on all the the paths that lead to the out_term2 label.
> Hence the null check and the call can be removed. Also remove the
> redundant setting of sess to NULL as this is not required now.
Applied to
Himanshu,
> This series has misc bug fixes which includes cleanup for FC-NVMe code
> and added first burst support for FC-NVMe devices. Other patches
> included in the series adds new SysFS hook for setting port speed and
> patch to prevent access to SysFS hook whle chip is down.
Applied to 5.1
Himanshu,
> This patch fixes warning seen when BLK-MQ is enabled and hardware does
> not support MQ. This will result into driver requesting MSIx vectors
> which are equal or less than pre_desc via PCI IRQ Affinity
> infrastructure.
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen
On Fri, Jan 11, 2019 at 03:35:02PM -0600, Rob Herring wrote:
> On Sat, 5 Jan 2019 12:58:57 +0530, Manivannan Sadhasivam wrote:
> > Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very
> > similar to HI3660 SoC with almost same IPs. Only major difference in terms
> > of UFS is the P
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/qedi/qedi_fw.c: In function 'qedi_tmf_resp_work':
drivers/scsi/qedi/qedi_fw.c:158:28: warning:
variable 'cls_sess' set but not used [-Wunused-but-set-variable]
drivers/scsi/qedi/qedi_fw.c: In function 'qedi_tmf_work':
drivers/scsi/qedi/
49 matches
Mail list logo
