Re: [PATCH v2 7/7] scsi: libsas: fix issue of swapping two sas disks

2019-02-01 Thread John Garry
On 01/02/2019 02:04, Jason Yan wrote: On 2019/2/1 0:34, John Garry wrote: On 31/01/2019 02:55, Jason Yan wrote: On 2019/1/31 1:53, John Garry wrote: On 30/01/2019 08:24, Jason Yan wrote: The work flow of revalidation now is scanning expander phy by the sequence of the phy and check if the

Re: [PATCH v2 4/7] scsi: libsas: split the replacement of sas disks in two steps

2019-02-01 Thread John Garry
On 01/02/2019 01:58, Jason Yan wrote: On 2019/2/1 0:38, John Garry wrote: On 31/01/2019 10:29, John Garry wrote: On 31/01/2019 02:04, Jason Yan wrote: On 2019/1/31 1:22, John Garry wrote: On 30/01/2019 08:24, Jason Yan wrote: Now if a new device replaced a old device, the sas address wil

Re: [PATCH] qla2xxx: Add new FC-NVMe enable BIT to enable FC-NVMe feature

2019-02-01 Thread Ewan D. Milne
On Wed, 2019-01-30 at 09:50 -0800, Himanshu Madhani wrote: > From: Giridhar Malavali > > This patch adds new BIT detection to enable FC-NVMe feature in > the driver. > > Signed-off-by: Giridhar Malavali > Signed-off-by: Himanshu Madhani > --- > Hi Martin, > > This patch adds additional bit to

[PATCH] Revert "scsi: libfc: Add WARN_ON() when deleting rports"

2019-02-01 Thread Ross Lagerwall
This reverts commit bbc0f8bd88abefb0f27998f40a073634a3a2db89. It added a warning whose intent was to check whether the rport was still linked into the peer list. It doesn't work as intended and gives false positive warnings for two reasons: 1) If the rport is never linked into the peer list it wi

Re: remove exofs, the T10 OSD code and block/scsi bidi support V4

2019-02-01 Thread Jens Axboe
On 2/1/19 12:55 AM, Christoph Hellwig wrote: > The only real user of the T10 OSD protocol, the pNFS object layout > driver never went to the point of having shipping products, and we > removed it 1.5 years ago. Exofs is just a simple example without > real life users. > > The code has been mostly

Re: [PATCH 1/4] block: disk_events: introduce event flags

2019-02-01 Thread Martin Wilck
Hannes, all, On Mon, 2019-01-28 at 14:54 +0100, Martin Wilck wrote: > On Sat, 2019-01-26 at 11:09 +0100, Hannes Reinecke wrote: > > On 1/18/19 10:32 PM, Martin Wilck wrote: > > > Currently, an empty disk->events field tells the block layer not > > > to > > > forward > > > media change events to us

Re: Question on handling managed IRQs when hotplugging CPUs

2019-02-01 Thread Hannes Reinecke
On 1/31/19 6:48 PM, John Garry wrote: On 30/01/2019 12:43, Thomas Gleixner wrote: On Wed, 30 Jan 2019, John Garry wrote: On 29/01/2019 17:20, Keith Busch wrote: On Tue, Jan 29, 2019 at 05:12:40PM +, John Garry wrote: On 29/01/2019 15:44, Keith Busch wrote: Hm, we used to freeze the queu

Stall with RAID10 + XFS + mpt3sas

2019-02-01 Thread Sebastian Andrzej Siewior
Hi, I have a LSI SAS3008 [0] attached to a few disks. I've setup a md raid10 on on them and created XFS file system on it. While the raid was still rebuilding I rsynced approx 2TiB of data. This went smooth. The raid was still rebuilding and I started doing some I/O and after approximately 5 minut

mpt3sas and T10DIF

2019-02-01 Thread Sebastian Andrzej Siewior
Hi, I tried to use T10DIF on a SAS disk(s) behind a LSI SAS3008 controller. So I enabled type 1 via sg_format --format --fmtpinfo=2 /dev/sdX on each disk, waited a few hours. After the operation completed the disks reported that T10DIF is enabled. I was able to read/write from/to the disk

Re: mpt3sas and T10DIF

2019-02-01 Thread John Garry
On 01/02/2019 16:20, Sebastian Andrzej Siewior wrote: Hi, I tried to use T10DIF on a SAS disk(s) behind a LSI SAS3008 controller. So I enabled type 1 via sg_format --format --fmtpinfo=2 /dev/sdX on each disk, waited a few hours. After the operation completed the disks reported that T10D

Re: mpt3sas and T10DIF

2019-02-01 Thread Douglas Miller
I saw "ref tag" errors on NVMe devices, starting with 4.18 kernels. The fix was: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus&id=7809167da5c86fd6bf309b33dee7a797e263342f On 02/01/2019 10:20 AM, Sebastian Andrzej Siewior wrote: Hi, I tried to use

Re: Recent removal of bsg read/write support

2019-02-01 Thread Douglas Gilbert
Updated reply, see below. On 2018-09-03 4:34 a.m., Dror Levin wrote: On Sun, Sep 2, 2018 at 8:55 PM Linus Torvalds wrote: On Sun, Sep 2, 2018 at 4:44 AM Richard Weinberger wrote: CC'ing relevant people. Otherwise your mail might get lost. Indeed. Sorry for that. On Sun, Sep 2, 2018 a

Re: [PATCH v2 6/9] scsi: ufs: qcom: Expose the reset controller for PHY

2019-02-01 Thread Stephen Boyd
Quoting Evan Green (2019-01-23 14:11:34) > Expose a reset controller that the phy can use to perform its > initialization in a single callback. > > Also, change the use of the phy functions from ufs-qcom such that > phy_poweron actually fires up the phy, and phy_poweroff actually > powers it down.

Re: [PATCH] scsi: aic94xx: fix module loading

2019-02-01 Thread James Bottomley
On Wed, 2019-01-30 at 16:42 -0800, James Bottomley wrote: > The aic94xx driver is currently failing to load with errors like > > sysfs: cannot create duplicate filename > '/devices/pci:00/:00:03.0/:02:00.3/:07:02.0/revision' > > Because the PCI code had recently added a file name

Re: mpt3sas and T10DIF

2019-02-01 Thread Sebastian Andrzej Siewior
On 2019-02-01 16:35:32 [+], John Garry wrote: > Possibly missing this (not sure which 4.19 you mean): awesome. Thanks to both of you. That means that I could try it out again in the near future. Sebastian

[Bug 202425] 3w-9xxx: 3ware 9650SE-2LP RAID controller not working on AMD Ryzen system

2019-02-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202425 Bjorn Helgaas (bhelg...@google.com) changed: What|Removed |Added CC||bhelg...@google.com

Re: Question on handling managed IRQs when hotplugging CPUs

2019-02-01 Thread Thomas Gleixner
On Fri, 1 Feb 2019, Hannes Reinecke wrote: > Thing is, if we have _managed_ CPU hotplug (ie if the hardware provides some > means of quiescing the CPU before hotplug) then the whole thing is trivial; > disable SQ and wait for all outstanding commands to complete. > Then trivially all requests are c

Re: [PATCH] qla2xxx: Add new FC-NVMe enable BIT to enable FC-NVMe feature

2019-02-01 Thread Martin K. Petersen
Himanshu, > This patch adds new BIT detection to enable FC-NVMe feature in > the driver. > > Signed-off-by: Giridhar Malavali ^ Fixed Giridhar's address and applied to 5.1/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH -next] scsi: csiostor: Remove set but not used variable 'pln'

2019-02-01 Thread Martin K. Petersen
YueHaibing, > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/csiostor/csio_attr.c: In function 'csio_fcoe_free_vnp': > drivers/scsi/csiostor/csio_attr.c:500:21: warning: > variable 'pln' set but not used [-Wunused-but-set-variable] Applied to 5.1/scsi-queue. Thanks! -- Marti

[GIT PULL] SCSI fixes for 5.0-rc4

2019-02-01 Thread James Bottomley
Five minor bug fixes. The libfc one is a tiny memory leak, the zfcp one is an incorrect user visible parameter and the rest are on error legs or obscure features. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Dan Car

Re: [PATCH] scsi: aic94xx: fix module loading

2019-02-01 Thread Martin K. Petersen
James, > The aic94xx driver is currently failing to load with errors like > > sysfs: cannot create duplicate filename > '/devices/pci:00/:00:03.0/:02:00.3/:07:02.0/revision' > > Because the PCI code had recently added a file named 'revision' to > every PCI device. Fix this by r

[PATCH] tcmu: wait for nl reply only if there are listeners

2019-02-01 Thread Mike Christie
genlmsg_multicast_allns used to return -ESRCH even if the message was successfully sent to a listener. With commit: commit cb9f7a9a5c96a773bbc9c70660dc600cfff82f82 Author: Nicolas Dichtel Date: Tue Feb 6 14:48:32 2018 +0100 netlink: ensure to loop over all netns in genlmsg_multicast_allns(