RE: [EXT] [PATCH] scsi: bnx2i: fix indentation issue, remove a tab

2019-01-07 Thread Manish Rangankar
> -Original Message- > From: Colin King > Sent: Friday, January 4, 2019 10:32 PM > To: qlogic-storage-upstr...@qlogic.com; James E . J . Bottomley > ; Martin K . Petersen ; > linux-scsi@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [EXT] [PA

Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent

2019-01-07 Thread John Garry
On 04/01/2019 19:49, Souptick Joarder wrote: On Fri, Jan 4, 2019 at 9:34 PM John Garry wrote: On 04/01/2019 15:11, Sabyasachi Gupta wrote: On Fri, Jan 4, 2019 at 6:43 PM John Garry wrote: On 04/01/2019 12:48, Sabyasachi Gupta wrote: On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta wrote:

[PATCH v1 1/1] scsi: ufs: Fix system suspend status

2019-01-07 Thread stanley.chu
From: Stanley Chu hba->is_sys_suspended is set after successful system suspend but not clear after successful system resume. According to current behavior, hba->is_sys_suspended will not be set if host is runtime-suspended but not system-suspended. Thus we shall aligh the same policy: clear this

[PATCH v1 0/1] scsi: ufs: Fix system suspend status

2019-01-07 Thread stanley.chu
From: Stanley Chu Stanley Chu (1): scsi: ufs: Fix system suspend status drivers/scsi/ufs/ufshcd.c | 2 ++ 1 file changed, 2 insertions(+) -- 1.9.1

[PATCH v1] scsi: ufs: Fix system suspend status

2019-01-07 Thread stanley.chu
hba->is_sys_suspended is set after successful system suspend but not clear after successful system resume. Simply fix this flag to correct host status logs.

[PATCH] scsi: sd: Make protection lookup tables static

2019-01-07 Thread John Garry
Currently the protection lookup tables in sd_prot_flag_mask() and sd_prot_op() are declared non-static. As such, they will be rebuilt for each respective function call. Optimise by making them static. This saves ~100B object code for sd.c: Before: textdata bss dec hex filename

Re: [PATCH v4] scsi: add debugfs directories

2019-01-07 Thread John Garry
On 05/01/2019 01:52, Douglas Gilbert wrote: Add a top level "scsi" directory in debugfs (usually at /sys/kernel/debugfs/scsi) with two subdirectories: "uld" and "lld". The idea is to place mid-level related 'knobs' in the "scsi" directory, and for the ULDs to make subsirectories like "scsi/uld/sd

Re: [PATCH] scsi: sd: Make protection lookup tables static

2019-01-07 Thread Bart Van Assche
On Mon, 2019-01-07 at 22:41 +0800, John Garry wrote: > Currently the protection lookup tables in sd_prot_flag_mask() and > sd_prot_op() are declared non-static. As such, they will be rebuilt for > each respective function call. > > Optimise by making them static. > > This saves ~100B object code

Re: [PATCH] scsi: sd: Make protection lookup tables static

2019-01-07 Thread John Garry
On 07/01/2019 16:57, Bart Van Assche wrote: On Mon, 2019-01-07 at 22:41 +0800, John Garry wrote: Currently the protection lookup tables in sd_prot_flag_mask() and sd_prot_op() are declared non-static. As such, they will be rebuilt for each respective function call. Optimise by making them stati

Re: [PATCH] scsi: sd: Make protection lookup tables static

2019-01-07 Thread Bart Van Assche
On Mon, 2019-01-07 at 17:27 +, John Garry wrote: > On 07/01/2019 16:57, Bart Van Assche wrote: > > On Mon, 2019-01-07 at 22:41 +0800, John Garry wrote: > > > Currently the protection lookup tables in sd_prot_flag_mask() and > > > sd_prot_op() are declared non-static. As such, they will be rebui

Re: [PATCH v4] scsi: add debugfs directories

2019-01-07 Thread Douglas Gilbert
John, See response below. On 2019-01-07 10:38 a.m., John Garry wrote: On 05/01/2019 01:52, Douglas Gilbert wrote: Add a top level "scsi" directory in debugfs (usually at /sys/kernel/debugfs/scsi) with two subdirectories: "uld" and "lld". The idea is to place mid-level related 'knobs' in the "sc

[PATCH v5] scsi: add debugfs directories

2019-01-07 Thread Douglas Gilbert
Add a top level "scsi" directory in debugfs (usually at /sys/kernel/debug/scsi) with two subdirectories: "uld" and "lld". The idea is to place mid-level related 'knobs' in the "scsi" directory, and for the ULDs to make subdirectories like "scsi/uld/sd" and "scsi/uld/st" as required. LLDs could fol