Re: [PATCH v2] scsi: add debugfs directories

2019-01-04 Thread John Garry
On 01/01/2019 17:43, Douglas Gilbert wrote: Add a top level "scsi" directory in debugfs (usually at /sys/kernel/debugfs/scsi) with two subdirectories: "uld" and "lld". The idea is to place mid-level related 'knobs' in the "scsi" directory, and for the ULDs to make subsirectories like "scsi/uld/sd

Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent

2019-01-04 Thread Sabyasachi Gupta
On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta wrote: > > On Sat, Dec 1, 2018 at 6:40 PM Sabyasachi Gupta > wrote: > > > > On Wed, Nov 21, 2018 at 7:18 PM Sabyasachi Gupta > > wrote: > > > > > > Replace dma_alloc_coherent + memset with dma_zalloc_coherent > > > > > > Signed-off-by: Sabyasachi

Re: [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent

2019-01-04 Thread Sabyasachi Gupta
On Wed, Dec 19, 2018 at 6:41 PM Sabyasachi Gupta wrote: > > On Sat, Dec 1, 2018 at 6:45 PM Sabyasachi Gupta > wrote: > > > > On Sat, Nov 17, 2018 at 6:17 PM Sabyasachi Gupta > > wrote: > > > > > > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent > > > > > > Signed-off-by: Sabyasachi

Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent

2019-01-04 Thread John Garry
On 04/01/2019 12:48, Sabyasachi Gupta wrote: On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta wrote: On Sat, Dec 1, 2018 at 6:40 PM Sabyasachi Gupta wrote: On Wed, Nov 21, 2018 at 7:18 PM Sabyasachi Gupta wrote: Replace dma_alloc_coherent + memset with dma_zalloc_coherent If you're go

Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent

2019-01-04 Thread Sabyasachi Gupta
On Fri, Jan 4, 2019 at 6:43 PM John Garry wrote: > > On 04/01/2019 12:48, Sabyasachi Gupta wrote: > > On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta > > wrote: > >> > >> On Sat, Dec 1, 2018 at 6:40 PM Sabyasachi Gupta > >> wrote: > >>> > >>> On Wed, Nov 21, 2018 at 7:18 PM Sabyasachi Gupta > >

[PATCH 1/3] scsi: libsas: Fix some indentation in libsas.h

2019-01-04 Thread John Garry
Currently much indentation in this file is done with whitespaces instead of tabs, which can make reading difficult, so fix this up. Some other little minor tidy-up is done, but this file still has many other checkpatch warnings (generally linelength > 80 or function arguments have no identifier na

[PATCH 3/3] scsi: libsas: Support SATA PHY connection rate unmatch fixing during discovery

2019-01-04 Thread John Garry
+--+ +--+ | | | | | |--- 3.0 G ---| |--- 6.0 G --- SAS disk | | | | | |--- 3.0 G ---| |--- 6.0 G --- SAS disk |initiator | | | | de

[PATCH 2/3] scsi: libsas: Check SMP PHY control function result

2019-01-04 Thread John Garry
Currently the SMP PHY control execution result is checked, however the function result for the command is not. As such, we may be missing all potential errors, like SMP FUNCTION FAILED, INVALID REQUEST FRAME LENGTH, etc., meaning the PHY control request has failed. In some scenarios we need to en

[PATCH 0/3] libsas: SATA PHY connection rate matching during disovery

2019-01-04 Thread John Garry
This patchset looks to resolve an issue we see whereby a SATA end device negotiated linkrate may exceed the min linkrate to the initiator, and not be able to establish a connection. According to the SAS spec, we should lower the SATA PHY linkrate when this condition occurs. It appears that some S

Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent

2019-01-04 Thread John Garry
On 04/01/2019 15:11, Sabyasachi Gupta wrote: On Fri, Jan 4, 2019 at 6:43 PM John Garry wrote: On 04/01/2019 12:48, Sabyasachi Gupta wrote: On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta wrote: On Sat, Dec 1, 2018 at 6:40 PM Sabyasachi Gupta wrote: On Wed, Nov 21, 2018 at 7:18 PM Sabya

[PATCH v3] scsi: add debugfs directories

2019-01-04 Thread Douglas Gilbert
Add a top level "scsi" directory in debugfs (usually at /sys/kernel/debugfs/scsi) with two subdirectories: "uld" and "lld". The idea is to place mid-level related 'knobs' in the "scsi" directory, and for the ULDs to make subsirectories like "scsi/uld/sd" and "scsi/uld/st" as required. LLDs could f

Re: [PATCH v3] scsi: add debugfs directories

2019-01-04 Thread Bart Van Assche
On Fri, 2019-01-04 at 11:18 -0500, Douglas Gilbert wrote: > Add a top level "scsi" directory in debugfs (usually at > /sys/kernel/debugfs/scsi) with two subdirectories: "uld" and "lld". > The idea is to place mid-level related 'knobs' in the "scsi" > directory, and for the ULDs to make subsirector

Re: [PATCH v3] scsi: add debugfs directories

2019-01-04 Thread James Bottomley
On Fri, 2019-01-04 at 11:18 -0500, Douglas Gilbert wrote: > Add a top level "scsi" directory in debugfs (usually at > /sys/kernel/debugfs/scsi) with two subdirectories: "uld" and "lld". > The idea is to place mid-level related 'knobs' in the "scsi" > directory, and for the ULDs to make subsirector

Re: [PATCH v3] scsi: add debugfs directories

2019-01-04 Thread John Garry
On 04/01/2019 16:45, Bart Van Assche wrote: On Fri, 2019-01-04 at 11:18 -0500, Douglas Gilbert wrote: Add a top level "scsi" directory in debugfs (usually at /sys/kernel/debugfs/scsi) with two subdirectories: "uld" and "lld". The idea is to place mid-level related 'knobs' in the "scsi" directory

[PATCH] scsi: bnx2i: fix indentation issue, remove a tab

2019-01-04 Thread Colin King
From: Colin Ian King The return statement is indented incorrectly, fix this by removing a single tab. Signed-off-by: Colin Ian King --- drivers/scsi/bnx2i/bnx2i_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx

[PATCH] scsi: csiostor: fix two minor indentation issues

2019-01-04 Thread Colin King
From: Colin Ian King Two statements are indented incorrectly, fix these by removing a tab and a space. Signed-off-by: Colin Ian King --- drivers/scsi/csiostor/csio_mb.c | 2 +- drivers/scsi/csiostor/csio_scsi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/sc

[PATCH] scsi: gdth: fix indentation issue, remove a tab

2019-01-04 Thread Colin King
From: Colin Ian King A goto statement is indented incorrectly, fix this by removing a tab. Signed-off-by: Colin Ian King --- drivers/scsi/gdth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index 194c294f9b6c..159a4e301c4d 100644

Re: [PATCH v3] scsi: add debugfs directories

2019-01-04 Thread Douglas Gilbert
On 2019-01-04 11:52 a.m., James Bottomley wrote: On Fri, 2019-01-04 at 11:18 -0500, Douglas Gilbert wrote: Add a top level "scsi" directory in debugfs (usually at /sys/kernel/debugfs/scsi) with two subdirectories: "uld" and "lld". The idea is to place mid-level related 'knobs' in the "scsi" dire

Re: [PATCH v3] scsi: add debugfs directories

2019-01-04 Thread James Bottomley
On Fri, 2019-01-04 at 13:34 -0500, Douglas Gilbert wrote: > On 2019-01-04 11:52 a.m., James Bottomley wrote: > > On Fri, 2019-01-04 at 11:18 -0500, Douglas Gilbert wrote: > > > Add a top level "scsi" directory in debugfs (usually at > > > /sys/kernel/debugfs/scsi) with two subdirectories: "uld" and

Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent

2019-01-04 Thread Souptick Joarder
On Fri, Jan 4, 2019 at 9:34 PM John Garry wrote: > > On 04/01/2019 15:11, Sabyasachi Gupta wrote: > > On Fri, Jan 4, 2019 at 6:43 PM John Garry wrote: > >> > >> On 04/01/2019 12:48, Sabyasachi Gupta wrote: > >>> On Wed, Dec 19, 2018 at 6:49 PM Sabyasachi Gupta > >>> wrote: > > On Sat,

[PATCH] scsi: advansys: use struct_size() in kzalloc()

2019-01-04 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = kzalloc(sizeof(struct foo

[PATCH 04/12] scsi: fix typo

2019-01-04 Thread Matteo Croce
Fix spelling mistake: "lenght" -> "length" Signed-off-by: Matteo Croce --- drivers/scsi/be2iscsi/be_cmds.c | 2 +- drivers/scsi/lpfc/lpfc_debugfs.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c index 0a

[PATCH] scsi: mvsas: use struct_size() in kzalloc()

2019-01-04 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = kzalloc(sizeof(struct foo

Re: [PATCH 04/12] scsi: fix typo

2019-01-04 Thread Matteo Croce
On Fri, Jan 4, 2019 at 10:38 PM Matteo Croce wrote: > > Fix spelling mistake: "lenght" -> "length" > > Signed-off-by: Matteo Croce > --- > drivers/scsi/be2iscsi/be_cmds.c | 2 +- > drivers/scsi/lpfc/lpfc_debugfs.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > Hi, this patch w

[PATCH v4] scsi: add debugfs directories

2019-01-04 Thread Douglas Gilbert
Add a top level "scsi" directory in debugfs (usually at /sys/kernel/debugfs/scsi) with two subdirectories: "uld" and "lld". The idea is to place mid-level related 'knobs' in the "scsi" directory, and for the ULDs to make subsirectories like "scsi/uld/sd" and "scsi/uld/st" as required. LLDs could f

[PATCH v2 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding

2019-01-04 Thread Manivannan Sadhasivam
Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very similar to HI3660 SoC with almost same IPs. Only major difference in terms of UFS is the PHY. HI3670 has 10nm PHY. But since the original driver (HI3660 UFS) cannot make HI3670 UFS functional, a separate compatible is added for HI

[PATCH v2 3/3] scsi: ufs: Add HI3670 SoC UFS driver support

2019-01-04 Thread Manivannan Sadhasivam
Add HI3670 SoC UFS driver support by extending the common ufs-hisi driver. One major difference between HI3660 ad HI3670 SoCs interms of UFS is the PHY. HI3670 has a 10nm variant PHY and hence this parameter is used to distinguish the configuration. Signed-off-by: Manivannan Sadhasivam --- drive

[PATCH v2 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support

2019-01-04 Thread Manivannan Sadhasivam
Add UFS controller support for HiSilicon HI3670 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi i

[PATCH v2 0/3] Add UFS controller support for HI3670 SoC

2019-01-04 Thread Manivannan Sadhasivam
Hello, This patchset adds UFS controller support for HiSilicon HI3670 SoC. HI3760 SoC is very similar to HI3660 SoC with almost same IPs, hence the same driver is extended to provide UFS support. Only major difference is the PHY. HI3670 has 10nm PHY, hence that parameter is used to distinguish the