On 11/28/18 5:29 AM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 703127 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva
Acked-by: Artur Paszkiewicz
On 11/28/18 5:30 AM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that, in this particular case, a dash is added as a token in
> order to separate the "Fall through" annotation from the rest o
On 11/28/18 5:30 AM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that, in this particular case, a dash is added as a token in
> order to separate the "Fall through" annotations from the rest
We must free all irqs during shutdown, else kexec's 2nd kernel would hang
in pqi_wait_for_completion_io() as below:
Call trace:
pqi_wait_for_completion_io
pqi_submit_raid_request_synchronous.constprop.78+0x23c/0x310 [smartpqi]
pqi_configure_events+0xec/0x1f8 [smartpqi]
pqi_ctrl_init+0x814/0xc
On 11/28/18 5:30 AM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that, in this particular case, a dash is added as a token in
> order to separate the "fall through" annotations from the rest
This happens only in the following combinations:
1. smartpqi is built as module, not built-in;
2. We have a disk connected to smartpqi card;
3. Both kexec's 1st and 2nd kernels use this disk as Rootfs' mount point.
This issue can be found on my ARM64 board: QDF2400:
kexec -l /boot/vmlinuz-4.20.0
I somehow have a deja vu feeling I have already acked it, but anyways:
Acked-by: Johannes Thumshirn
Hello James,
> I noticed this version does only build here on kernel 4.18. I pushed the
> required changes for kernel 4.19 to my repository [1].
this patch [1] is required on 32 bit to fix
WARNING: "__udivdi3" [efct.ko] undefined!
It seems v2 contains some regressions:
My simple setup triggere
On 19/12/2018 18:27, Marc Gonzalez wrote:
> On 18/12/2018 17:54, Marc Gonzalez wrote:
>
>> Now the fun begins, to find the tiny difference that makes/breaks everything
>> :-)
> I thought I had found the problem:
> "clk_set_rate: ufs_unipro_core_clk_src" was not occurring.
> But, in fact, I think
On 20/12/2018 13:38, Marc Gonzalez wrote:
> Found something fishy... [ufs_phy_aux_clk rate returned 0]
Even with that "fixed" [or rather hacked around, since the syntax of
drivers/clk/qcom/gcc-msm8998.c remains nebulous, even after staring
at it, literally, for hours] the UFSHC refuses to functio
Hi Suganath,
On 12/19/18 10:19 PM, Suganath Prabu Subramani wrote:
Hi Gustavo,
This patch may not apply smoothly over 4.21/scsi-queue.
Our previous patch for Aero had some changes in this switch case.
Can you resend this patch with latest code base ?
Okay. I'll send a separate patch.
Thanks
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 1475400 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/
https://bugzilla.kernel.org/show_bug.cgi?id=201935
--- Comment #4 from Todd Aiken (tai...@mvtech.ca) ---
Just installed 4.19.11, and the fix works. Many thanks to everyone who helped
squash this bug. :-)
--
You are receiving this mail because:
You are the assignee for the bug.
From: Colin Ian King
Using snprintf without a format specifier is potentially risky if the
string phba->ModelDesc contains format specifiers. Replace this with
the safer and more efficient strscpy.
Cleans up clang warning:
drivers/scsi/lpfc/lpfc_scsi.c:4543:31: warning: format string is not a
st
On 12/20/18 12:12 AM, Christoph Hellwig wrote:
> On Wed, Dec 19, 2018 at 04:23:14PM -0700, Jens Axboe wrote:
>> On 12/19/18 7:39 AM, Christoph Hellwig wrote:
>>> Besides the OSD command set that never got traction, the only SCSI
>>> command using bidirectional buffers is XDWRITEREAD in the 10 and 3
On Fri, Dec 07, 2018 at 11:21:49PM +0530, Manivannan Sadhasivam wrote:
> Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very
> similar to HI3660 SoC with almost same IPs. Only major difference interms
s/interms/in terms/
> of UFS is the PHY. HI3670 has 10nm PHY.
>
> Signed-off-b
Besides the OSD command set that never got traction, the only SCSI
command using bidirectional buffers is XDWRITEREAD in the 10 and 32 byte
variants, which is extremely esoteric and has been removed from the spec
again as of SBC4r15. It probably doesn't make sense to keep the support
code around j
On 12/20/18 10:36 AM, Christoph Hellwig wrote:
> Besides the OSD command set that never got traction, the only SCSI
> command using bidirectional buffers is XDWRITEREAD in the 10 and 32 byte
> variants, which is extremely esoteric and has been removed from the spec
> again as of SBC4r15. It probab
On 2018-12-20 12:09 p.m., Jens Axboe wrote:
On 12/20/18 12:12 AM, Christoph Hellwig wrote:
On Wed, Dec 19, 2018 at 04:23:14PM -0700, Jens Axboe wrote:
On 12/19/18 7:39 AM, Christoph Hellwig wrote:
Besides the OSD command set that never got traction, the only SCSI
command using bidirectional bu
From: Mahesh Rajashekhara
Problem:
- during the driver initialization, driver will poll fw
for KERNEL_UP in a 30 seconds timeout.
- if the firmware is not ready after 30 seconds,
driver will not be loaded.
Fix:
- change timeout from 30 seconds to 3 minutes.
Reported-by: Feng Li
Review
From: Mahesh Rajashekhara
- when OFA event occurs, driver will stop traffic to
RAID/HBA path. Driver waits for all the outstanding
requests to complete.
- Driver sends OFA event acknowledgment to firmware.
- Driver will wait until the new firmware is up and running.
- Driver will free up the
These patches are based on Linus's tree
There are two more patches that need to be added
that were not fully tested until now.
The changes are:
- smartpqi-increase-fw-status-register-read-timeout
. wait longer for fw to fully initialize
- smartpqi-add-ofa-support
. allow on-line firmware upd
- need to bump up the driver version because
of the OFA patch and the fw status register
read timeout patch.
Reviewed-by: Gerry Morong
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/s
-Original Message-
From: Yanjiang Jin [mailto:yanjiang@hxt-semitech.com]
Sent: Thursday, December 20, 2018 2:33 AM
To: don.br...@microsemi.com; j...@linux.vnet.ibm.com;
martin.peter...@oracle.com; yanjiang@hxt-semitech.com
Cc: yu.zh...@hxt-semitech.com; jinyanji...@gmail.com;
esc
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Douglas Gilbert
> Sent: Wednesday, December 19, 2018 9:02 PM
> Subject: Re: remove exofs, the T10 OSD code and block/scsi bidi support V3
>
...
> While on the subject of bidi, the order
ping(Doug);
Thanks,
Fred
On 12/9/2018 5:01 PM, Fred Herard wrote:
> Gentle reminder...
>
> Reviewed-by: Rajan Shanmugavelu
> Reviewed-by: Lee Duncan
>
> Thanks,
> Fred
>
> On 12/2/2018 1:47 AM, Fred Herard wrote:
>> Hi Doug,
>>
>> Here's an updated patch with removal of the misplaced semicol
On 2018-12-20 4:45 p.m., Fred Herard wrote:
ping(Doug);
Thanks,
Fred
On 12/9/2018 5:01 PM, Fred Herard wrote:
Gentle reminder...
Reviewed-by: Rajan Shanmugavelu
Reviewed-by: Lee Duncan
Reviewed-by: Douglas Gilbert
Thanks.
Doug Gilbert
On 12/2/2018 1:47 AM, Fred Herard wrote:
Hi Dou
On 12/19/2018 10:04 AM, Sebastian Herbszt wrote:
Hello James,
I'd like to announce the availability of the Broadcom (Emulex) FC target
driver - efct.
This is the 2nd round of announcement. In the first round, after
discussion with community members, it was decided that the driver would
consi
On 12/20/2018 5:38 AM, Marc Gonzalez wrote:
On 19/12/2018 18:27, Marc Gonzalez wrote:
On 18/12/2018 17:54, Marc Gonzalez wrote:
Now the fun begins, to find the tiny difference that makes/breaks everything :-)
I thought I had found the problem:
"clk_set_rate: ufs_unipro_core_clk_src" was not
Yanjiang,
> We must free all irqs during shutdown, else kexec's 2nd kernel would
> hang in pqi_wait_for_completion_io() as below:
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Don,
> Changes since V1:
> . fix kbuild test robot and compile warnings (MIPS)
> . patch smartpqi-add-ofa-support
> . replace do_div MACRO with straight division
Since I had already pushed the series, this had to be an incremental
patch.
I did it by hand and also addressed the fall t
Stephan,
> Thanks. Is there any way to get that backported to older kernels?
> Without that little patch, HBAs relying on the mpt3sas are quite
> useless on the affected powerpc64 systems.
Once the commit hits Linus' tree you can send an inclusion request to
linux-stable.
--
Martin K. Peterse
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/fcoe/fcoe.c: In function 'fcoe_recv_frame':
> drivers/scsi/fcoe/fcoe.c:1672:20: warning:
> variable 'port' set but not used [-Wunused-but-set-variable]
>
> drivers/scsi/fcoe/fcoe.c: In function 'fcoe_device_notificati
Gustavo A.,
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
Applied to 4.21/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Qian,
> UBSAN reported those with MegaRAID SAS-3 3108,
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Gustavo A.,
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
Applied to 4.21/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
Artur,
> On 11/28/18 5:29 AM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Addresses-Coverity-ID: 703127 ("Missing break in switch")
>> Signed-off-by: Gustavo A. R. Silva
>
> Acked-by: Artur
Fred,
> This commit enhances iscsi initiator modules to capture iscsi debug
> messages using linux kernel tracepoint facility:
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Hi Rob,
On Thu, Dec 20, 2018 at 11:12:44AM -0600, Rob Herring wrote:
> On Fri, Dec 07, 2018 at 11:21:49PM +0530, Manivannan Sadhasivam wrote:
> > Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very
> > similar to HI3660 SoC with almost same IPs. Only major difference interms
>
>
Hi all,
After commit 4fd22c13ad44 ("scsi: smartpqi: add ofa support"), an arm
allyesconfig build with Clang fails with the following warning/error:
drivers/scsi/smartpqi/smartpqi_init.c:7473:2: warning: comparison of distinct
pointer types ('typeof ((sg_count)) *' (aka 'unsigned int *') and 'uin
On Fri, Dec 21, 2018 at 12:11:00AM -0700, Nathan Chancellor wrote:
> Hi all,
>
> After commit 4fd22c13ad44 ("scsi: smartpqi: add ofa support"), an arm
> allyesconfig build with Clang fails with the following warning/error:
>
> drivers/scsi/smartpqi/smartpqi_init.c:7473:2: warning: comparison of d
41 matches
Mail list logo
