[PATCH 0/12] scsi: arcmsr: update for ccb structure address can above 4GB

2018-12-19 Thread Ching Huang
>From Ching Huang This patch series are against to mkp's 4.21/scsi-queue. 1. Rename acb structure member roundup_ccbsize to ioqueue_size 2. Rename arcmsr_free_mu to arcmsr_free_io_queue 3. Merge arcmsr_alloc_io_queue to arcmsr_alloc_ccb_pool 4. Update arcmsr_alloc_ccb_pool for ccb buffer address

[PATCH 1/12] scsi: arcmsr: Rename acb structure member roundup_ccbsize to ioqueue_size

2018-12-19 Thread Ching Huang
>From Ching Huang Rename acb structure member roundup_ccbsize to ioqueue_size Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index 9c397a2..256fe9a 100755 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -739,7 +7

[PATCH 2/12] scsi: arcmsr: Rename arcmsr_free_mu to arcmsr_free_io_queue

2018-12-19 Thread Ching Huang
>From Ching Huang Rename arcmsr_free_mu to arcmsr_free_io_queue Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index f3a7855..f831c13 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -223,7

[PATCH V2] scsi: lpfc: Switch memcpy_fromio() to __read32_copy()

2018-12-19 Thread Huacai Chen
In commit bc73905abf770192 ("[SCSI] lpfc 8.3.16: SLI Additions, updates, and code cleanup"), lpfc_memcpy_to_slim() have switched memcpy_toio() to __write32_copy() in order to prevent unaligned 64 bit copy. Recently, we found that lpfc_memcpy_from_slim() have similar issues, so let it switch memcpy_

[PATCH 3/12] scsi: arcmsr: Merge arcmsr_alloc_io_queue to arcmsr_alloc_ccb_pool

2018-12-19 Thread Ching Huang
>From Ching Huang Merge arcmsr_alloc_io_queue to arcmsr_alloc_ccb_pool Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index f831c13..e1c75ca 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@

[PATCH 4/12] scsi: arcmsr: Update arcmsr_alloc_ccb_pool for ccb buffer address can above 4GB

2018-12-19 Thread Ching Huang
>From Ching Huang Update arcmsr_alloc_ccb_pool for ccb buffer address can above 4GB Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index 256fe9a..9041edc 100755 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -74

[PATCH 5/12] scsi: arcmsr: Update for ACB_ADAPTER_TYPE_A that ccb address can above 4GB

2018-12-19 Thread Ching Huang
>From Ching Huang Update for ACB_ADAPTER_TYPE_A that ccb address can above 4GB Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 5353dbb..2ff1c9a 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_h

[PATCH 6/12] scsi: arcmsr: Update for ACB_ADAPTER_TYPE_B that ccb address can above 4GB

2018-12-19 Thread Ching Huang
>From Ching Huang Update for ACB_ADAPTER_TYPE_B that ccb address can above 4GB Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 2ff1c9a..3d2727c 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_h

[PATCH 7/12] scsi: arcmsr: Update for ACB_ADAPTER_TYPE_C that ccb address can above 4GB

2018-12-19 Thread Ching Huang
>From Ching Huang Update for ACB_ADAPTER_TYPE_C that ccb address can above 4GB Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 3d2727c..39f3cd0 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_h

[PATCH 8/12] scsi: arcmsr: Update for ACB_ADAPTER_TYPE_D that ccb address can above 4GB

2018-12-19 Thread Ching Huang
>From Ching Huang Update for ACB_ADAPTER_TYPE_D that ccb address can above 4GB Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 39f3cd0..8cc2134 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_h

[PATCH 9/12] scsi: arcmsr: Add an option of set dma_mask_64 for ACB_ADAPTER_TYPE_A

2018-12-19 Thread Ching Huang
>From Ching Huang Add an option of set dma_mask_64 for ACB_ADAPTER_TYPE_A Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 8cc2134..45f1374 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c

[PATCH 10/12] scsi: arcmsr: Separate 'set dma mask' as a function

2018-12-19 Thread Ching Huang
>From Ching Huang Separate 'set dma mask' as a function Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 45f1374..30dff6c 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -927,6 +927,31

[PATCH 11/12] scsi: arcmsr: Fix suspend/resume of ACB_ADAPTER_TYPE_B

2018-12-19 Thread Ching Huang
>From Ching Huang Fix suspend/resume of ACB_ADAPTER_TYPE_B Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 30dff6c..9f85d5a 100755 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -1110,12 +11

[PATCH 12/12] scsi: arcmsr: Update driver version to v1.40.00.10-20181217

2018-12-19 Thread Ching Huang
>From Ching Huang Update driver version to v1.40.00.10-20181217 Signed-off-by: Ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h index 9041edc..a94c513 100755 --- a/drivers/scsi/arcmsr/arcmsr.h +++ b/drivers/scsi/arcmsr/arcmsr.h @@ -49,7 +49,7 @@ struct d

[PATCH 0/2] scsi: ufs: support new temperature atrib(UFSv3.0)

2018-12-19 Thread Uri
From: Uri Yanai Two patches adding support for new UFSv3.0 temperature attributes. * scsi: ufs: temperature notification: adds new attributes, macro definitions, ufs_features member to ufs_dev_desc and sysfs entries. * scsi: ufs: add registration to thermal zone: registers to thermal_zone interf

[PATCH 2/2] scsi: ufs: add registration to thermal zone

2018-12-19 Thread Uri
From: Uri Yanai Register to thermal_zone interface and implement the thermal ops. The thermal sets the temperature thresholds the Thermal Manager would be notified on crossing thresholds. The thermal interface adds a new thermal zone device sensor under /sys/class/thermal/ folder. Signed-off-by:

[PATCH 1/2] scsi: ufs: temperature notification

2018-12-19 Thread Uri
From: Uri Yanai Support the new temperature notification attributes introduced in UFSv3.0 Added new query requests, exception event mask, and ufs features attributes. Signed-off-by: Uri Yanai --- drivers/scsi/ufs/ufs-sysfs.c | 3 +++ drivers/scsi/ufs/ufs.h | 8 drivers/scsi/ufs/

[PATCH] scsi: csiostor: fix incorrect dma device in case of vport

2018-12-19 Thread Varun Prakash
In case of ->vport_create() call scsi_add_host_with_dma() instead of scsi_add_host() to pass correct dma device. Signed-off-by: Varun Prakash --- drivers/scsi/csiostor/csio_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/csiostor/csio_init.c b/drivers/scs

Re: [PATCH] scsi/dpt_i2o.c: Use dma_zalloc_coherent

2018-12-19 Thread Sabyasachi Gupta
On Sat, Dec 1, 2018 at 6:45 PM Sabyasachi Gupta wrote: > > On Sat, Nov 17, 2018 at 6:17 PM Sabyasachi Gupta > wrote: > > > > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent > > > > Signed-off-by: Sabyasachi Gupta > > Any comment on this patch? Any comment on this patch? > > > ---

Re: [PATCH] scsi/mvsas/mv_init.c: Use dma_zalloc_coherent

2018-12-19 Thread Sabyasachi Gupta
On Sat, Dec 1, 2018 at 6:40 PM Sabyasachi Gupta wrote: > > On Wed, Nov 21, 2018 at 7:18 PM Sabyasachi Gupta > wrote: > > > > Replace dma_alloc_coherent + memset with dma_zalloc_coherent > > > > Signed-off-by: Sabyasachi Gupta > > Any comment on this patch? Any comment on this patch? > > > ---

[PATCH] bsg: deprecate BIDI support in bsg

2018-12-19 Thread Christoph Hellwig
Besides the OSD command set that never got traction, the only SCSI command using bidirectional buffers is XDWRITEREAD in the 10 and 32 byte variants, which is extremely esoteric. It probably doesn't make sense to keep the support code around just for that, so start deprecating the support. Signed

Re: remove exofs, the T10 OSD code and block/scsi bidi support V3

2018-12-19 Thread Christoph Hellwig
On Mon, Nov 26, 2018 at 07:11:10PM +0200, Boaz Harrosh wrote: > On 11/11/18 15:32, Christoph Hellwig wrote: > > The only real user of the T10 OSD protocol, the pNFS object layout > > driver never went to the point of having shipping products, and we > > removed it 1.5 years ago. Exofs is just a si

Re: [PATCH 1/3] bsg: Make job reply size different than SCSI_SENSE_BUFFERSIZE

2018-12-19 Thread Christoph Hellwig
On Mon, Nov 26, 2018 at 11:02:42AM +0200, Avri Altman wrote: > The size of the bsg job reply was set to SCSI_SENSE_BUFFERSIZE back then > while it was part of the bsg_command. However, for the scsi transport > that uses it, it does not carry the scsi sense information. > > Rename it to clarify thi

Re: [PATCH v5 1/2] scsi: hisi_sas: Add support for DIF feature for v2 hw

2018-12-19 Thread John Garry
On 19/12/2018 04:35, Martin K. Petersen wrote: John, From: Xiang Chen For v3 hw, we support DIF operation for SAS, but not SATA. In addition, DIF CRC16 is supported. This patchset adds the SW support for the described features. The main components are as follows: - Get protection mask from

Re: [PATCH 05/41] scsi: aic7xxx: aic79xx: mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:26 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in some cases, I replaced "FALLTHROUGH" wi

Re: [PATCH 06/41] scsi: aic7xxx: mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:26 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in some cases, I replaced "FALLTHROUGH" wi

Re: [PATCH 07/41] scsi: be2iscsi: be_iscsi: Mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:26 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/

Re: [PATCH 08/41] scsi: be2iscsi: be_main: Mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1357387 ("Missing break in switc

Re: [PATCH 09/41] scsi: bfa: bfa_fcpim: Mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that I replaced "Fall through !!!" with a "fall

Re: [PATCH 10/41] scsi: bfa: bfa_fcs_lport: Mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I replaced "!!! f

Re: [PATCH 11/41] scsi: bfa: bfa_fcs_rport: Mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that I replaced "!! fall through !!" and "!!! fa

Re: [PATCH 12/41] scsi: bfa: bfa_ioc: Mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:27 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I replaced "!!! f

Re: [PATCH 13/41] scsi: csiostor: csio_wr: mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:28 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1056538 ("Missing break in switc

Re: [PATCH 14/41] scsi: esas2r: esas2r_init: mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:28 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/

[PATCH 6/8] scsi: hisi_sas: Add debugfs CQ file and add file operations

2018-12-19 Thread John Garry
From: Luo Jiaxing This patch create debugfs file for CQ and add file operations. Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 70 +++ 1 file changed, 70 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_s

[PATCH 7/8] scsi: hisi_sas: Add debugfs DQ file and add file operations

2018-12-19 Thread John Garry
From: Luo Jiaxing This patch create debugfs file for DQ and add file operations Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 52 +++ 1 file changed, 52 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sa

[PATCH 1/8] scsi: hisi_sas: Create root and device debugfs directories

2018-12-19 Thread John Garry
From: Luo Jiaxing This patch creates root directory at hisi_sas_init() and generate device directory when we probe device driver. And we remove the root directory at hisi_sas_exit(), but recursively delete device directory when we remove device driver. Signed-off-by: Luo Jiaxing Signed-off-by:

[PATCH 2/8] scsi: hisi_sas: Alloc debugfs snapshot buffer memory for all registers

2018-12-19 Thread John Garry
From: Luo Jiaxing This patch allocates snapshot memory for global reg, port regs, CQ, DQ, IOST, ITCT. When we fail to allocate memory for some registers, we free the memory and set hisi_sas_debugfs_enable as 0 to stop loading debugfs from running. Signed-off-by: Luo Jiaxing Signed-off-by: John

[PATCH 8/8] scsi: hisi_sas: Add debugfs IOST file and add file operations

2018-12-19 Thread John Garry
From: Luo Jiaxing This patch create debugfs file for IOST and add file operations. Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi

[PATCH 4/8] scsi: hisi_sas: Debugfs global register create file and add file operations

2018-12-19 Thread John Garry
From: Luo Jiaxing This patch create debugfs file for global register and add file operations. Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 8 drivers/scsi/hisi_sas/hisi_sas_main.c | 64 +++ drivers/scsi/hi

[PATCH 3/8] scsi: hisi_sas: Take debugfs snapshot for all regs

2018-12-19 Thread John Garry
From: Luo Jiaxing This patch take snapshot for global regs, port regs, CQ, DQ, IOST, ITCT. Then, Add code for snapshot trig and generate dump directory. Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 15 +++- drivers/scsi/hisi_sas/hisi_sas_

[PATCH 0/8] hisi_sas: debugfs support

2018-12-19 Thread John Garry
This patchset adds debugfs support for capturing driver state for particular times when the HW has malfunctioned (and we must reset the HW). Every controller HW version has had bugs. These bugs have been very painful to debug. One useful tool to debug these is being able to capture and export HW r

[PATCH 5/8] scsi: hisi_sas: Add debugfs for port registers

2018-12-19 Thread John Garry
From: Luo Jiaxing This patch create debugfs file for port register and add file operations. Signed-off-by: Luo Jiaxing Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 43 ++ drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 55

Re: scsi: ufs: Problem at init on msm8998

2018-12-19 Thread Marc Gonzalez
On 18/12/2018 17:54, Marc Gonzalez wrote: > Now the fun begins, to find the tiny difference that makes/breaks everything > :-) I thought I had found the problem: "clk_set_rate: ufs_unipro_core_clk_src" was not occurring. But, in fact, I think the bootloader already set the proper rate. I'll hav

Aw: [ANNOUNCE v2]: Broadcom (Emulex) FC Target driver - efct

2018-12-19 Thread Sebastian Herbszt
Hello James, > I'd like to announce the availability of the Broadcom (Emulex) FC target > driver - efct. > > This is the 2nd round of announcement.   In the first round, after > discussion with community members, it was decided that the driver would > consist of the following: >   - A SLI4-librar

[PATCH 1/1] scsi: storvsc: Always use blk-mq

2018-12-19 Thread Michael Kelley
With high IOPS storage being increasingly prevalent for guests on Hyper-V and in Azure, make blk-mq the default so that the full performance of the storage can be realized without having to tweak other configuration settings. Signed-off-by: Michael Kelley --- drivers/scsi/storvsc_drv.c | 1 + 1

Re: [PATCH 17/41] scsi: isci: phy: Mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:29 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 703127 ("Missing break in switch

Re: [PATCH 19/41] scsi: isci: remote_node_context: mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:30 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, a dash is added a

Re: [PATCH 20/41] scsi: isci: request: mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:30 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, a dash is added a

Re: [PATCH 26/41] scsi: lpfc: lpfc_nvme: Mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/

Re: [PATCH 25/41] scsi: lpfc: lpfc_nportdisc: Mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/

Re: [PATCH 23/41] scsi: lpfc: lpfc_els: Mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114978 ("Missing break in switch

Re: [PATCH 24/41] scsi: lpfc: lpfc_hbadisc: Mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I replaced "Drop

Re: [PATCH 27/41] scsi: lpfc: lpfc_scsi: Mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I replaced "Drop

Re: [PATCH 28/41] scsi: lpfc: lpfc_sli: Mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I replaced "Drop

Re: [PATCH 22/41] scsi: lpfc: lpfc_ct: Mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/

Re: [PATCH 18/41] scsi: isci: remote_device: Mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:30 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, a dash is added a

Re: [PATCH 16/41] scsi: imm: mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:29 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I placed all the

Re: [PATCH] bsg: deprecate BIDI support in bsg

2018-12-19 Thread Bart Van Assche
On Wed, 2018-12-19 at 15:39 +0100, Christoph Hellwig wrote: > Besides the OSD command set that never got traction, the only SCSI > command using bidirectional buffers is XDWRITEREAD in the 10 and 32 > byte variants, which is extremely esoteric. It probably doesn't make > sense to keep the support

Re: [PATCH] bsg: deprecate BIDI support in bsg

2018-12-19 Thread Jens Axboe
On 12/19/18 7:39 AM, Christoph Hellwig wrote: > Besides the OSD command set that never got traction, the only SCSI > command using bidirectional buffers is XDWRITEREAD in the 10 and 32 > byte variants, which is extremely esoteric. It probably doesn't make > sense to keep the support code around ju

Re: [PATCH 31/41] scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1475400 ("Missing break in switc

Re: [PATCH 32/41] scsi: myrb: Mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1465234 ("Missing break in switc

Re: [PATCH 34/41] scsi: osst: mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:33 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114983 ("Missing break in switch

Re: [PATCH 36/41] scsi: qla4xxx: ql4_os: mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:33 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that, in this particular case, I replaced "allow

Re: [PATCH 35/41] scsi: ppa: mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:33 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114988 ("Missing break in switch

Re: [PATCH 39/41] scsi: sym53c8xx_2: sym_nvram: Mark expected switch fall-through

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:34 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/

Re: [PATCH 37/41] scsi: st: mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:33 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114994 ("Missing break in switch

Re: [PATCH 38/41] scsi: sym53c8xx_2: sym_hipd: mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:34 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114996 ("Missing break in switch

Re: [PATCH 33/41] scsi: osd: osd_initiator: mark expected switch fall-throughs

2018-12-19 Thread Gustavo A. R. Silva
Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/

Re: remove exofs, the T10 OSD code and block/scsi bidi support V3

2018-12-19 Thread Douglas Gilbert
On 2018-12-19 9:43 a.m., Christoph Hellwig wrote: On Mon, Nov 26, 2018 at 07:11:10PM +0200, Boaz Harrosh wrote: On 11/11/18 15:32, Christoph Hellwig wrote: The only real user of the T10 OSD protocol, the pNFS object layout driver never went to the point of having shipping products, and we remov

[PATCH -next] scsi: qedi: Remove set but not used variables 'cdev, udev'

2018-12-19 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/qedi/qedi_iscsi.c: In function 'qedi_ep_connect': drivers/scsi/qedi/qedi_iscsi.c:813:23: warning: variable 'udev' set but not used [-Wunused-but-set-variable] drivers/scsi/qedi/qedi_iscsi.c:812:18: warning: variable 'cdev' set but not

Re: [PATCH] scsi: qla2xxx: deadlock by configfs_depend_item

2018-12-19 Thread Martin K. Petersen
Anatoliy, > The intent of invoking configfs_depend_item in commit 7474f52a82d51 > ("tcm_qla2xxx: Perform configfs depend/undepend for base_tpg") was to > prevent a physical Fibre Channel port removal when virtual (NPIV) > ports announced through that physical port are active. The change > does

Re: [PATCH] scsi: mpt3sas: fix memory ordering on 64bit writes

2018-12-19 Thread Martin K. Petersen
Stephan, > With revision 09c2f95ad404, 64bit writes in _base_writeq() were rewritten > to use __raw_writeq() instad of writeq(). > > This introduced a bug apparent on powerpc64 systems such as the Raptor > Talos II that causes the HBA to drop from the PCIe bus under heavy load and > being reinit

[PATCH -next] scsi: fcoe: remove set but not used variable 'port'

2018-12-19 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/fcoe/fcoe.c: In function 'fcoe_recv_frame': drivers/scsi/fcoe/fcoe.c:1672:20: warning: variable 'port' set but not used [-Wunused-but-set-variable] drivers/scsi/fcoe/fcoe.c: In function 'fcoe_device_notification': drivers/scsi/fcoe/fcoe

Re: [PATCH 0/4] megaraid_sas: Fix HW errata in Aero controllers

2018-12-19 Thread Martin K. Petersen
Shivasharan, > Below patch series adds workaround for Aero controllers due to a HW > errata that returns zero intermittently for read operations. > > Shivasharan S (4): > megaraid_sas: Fix Ventura series based checks > megaraid_sas: Introduce new Aero adapter type > megaraid_sas: change fu

Re: [PATCH 0/2] megaraid_sas: Fix 64-bit DMA addressing

2018-12-19 Thread Martin K. Petersen
Shivasharan, > This patchset fixes an issue with enabling 64-bit DMA for megaraid > controllers. The second patch updates the driver version for > tracking. Applied to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: remove dma_boundary limits for ex-DAC960 drivers

2018-12-19 Thread Martin K. Petersen
Christoph, > These drivers didn't bother to enable clustering, which allows merges > across pages. But the original block driver had not such limitation, > so there should be no need to set these limits either. Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engin

Re: [PATCH] scsi: csiostor: fix incorrect dma device in case of vport

2018-12-19 Thread Martin K. Petersen
Varun, > In case of ->vport_create() call scsi_add_host_with_dma() instead of > scsi_add_host() to pass correct dma device. Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] scsi: storvsc: Always use blk-mq

2018-12-19 Thread Martin K. Petersen
Michael, > With high IOPS storage being increasingly prevalent for guests > on Hyper-V and in Azure, make blk-mq the default so that the > full performance of the storage can be realized without having > to tweak other configuration settings. The legacy I/O path will be gone in 4.21 so this pat

Re: [PATCH] scsi: 3w-xxx: fix indentation issue, add missing tab

2018-12-19 Thread Martin K. Petersen
Colin, > There is a tab missing on a return statement, add the missing tab. Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: bfa: clean up a couple of indentation issues

2018-12-19 Thread Martin K. Petersen
Colin, > There is a break statement with an extra space that needs removed and > a call to bfa_trc that is indented one level too much. Fix these. Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 0/7] lpfc updates for 12.0.0.10

2018-12-19 Thread Martin K. Petersen
James, > Update lpfc to revision 12.0.0.10 > > This patch contains lpfc bug fixes, one debug addition, and one > feature addition. Applied to 4.21/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

[PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param

2018-12-19 Thread YueHaibing
The return code should be check while qla4xxx_copy_from_fwddb_param fails. Signed-off-by: YueHaibing --- drivers/scsi/qla4xxx/ql4_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 949e186..1bc4db6 100644 --- a/drivers/s

Re: [PATCH] scsi: mpt3sas: fix memory ordering on 64bit writes

2018-12-19 Thread Stephan Günther
On 2018/December/19 09:33, Martin K. Petersen wrote: > > Stephan, > > > With revision 09c2f95ad404, 64bit writes in _base_writeq() were rewritten > > to use __raw_writeq() instad of writeq(). > > > > This introduced a bug apparent on powerpc64 systems such as the Raptor > > Talos II that causes t

Re: [PATCH 31/41] scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-through

2018-12-19 Thread Suganath Prabu Subramani
Hi Gustavo, This patch may not apply smoothly over 4.21/scsi-queue. Our previous patch for Aero had some changes in this switch case. Can you resend this patch with latest code base ? Thanks, Suganath prabu On Thu, Dec 20, 2018 at 5:37 AM Gustavo A. R. Silva wrote: > > Hi, > > Friendly ping: >

Re: [PATCH 32/41] scsi: myrb: Mark expected switch fall-throughs

2018-12-19 Thread Hannes Reinecke
On 12/20/18 1:07 AM, Gustavo A. R. Silva wrote: Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addres

Re: [PATCH] bsg: deprecate BIDI support in bsg

2018-12-19 Thread Christoph Hellwig
On Wed, Dec 19, 2018 at 03:07:11PM -0800, Bart Van Assche wrote: > On Wed, 2018-12-19 at 15:39 +0100, Christoph Hellwig wrote: > > Besides the OSD command set that never got traction, the only SCSI > > command using bidirectional buffers is XDWRITEREAD in the 10 and 32 > > byte variants, which is e

Re: [PATCH] bsg: deprecate BIDI support in bsg

2018-12-19 Thread Christoph Hellwig
On Wed, Dec 19, 2018 at 04:23:14PM -0700, Jens Axboe wrote: > On 12/19/18 7:39 AM, Christoph Hellwig wrote: > > Besides the OSD command set that never got traction, the only SCSI > > command using bidirectional buffers is XDWRITEREAD in the 10 and 32 > > byte variants, which is extremely esoteric.

RE: [PATCH 1/3] bsg: Make job reply size different than SCSI_SENSE_BUFFERSIZE

2018-12-19 Thread Avri Altman
Hi, > > On Mon, Nov 26, 2018 at 11:02:42AM +0200, Avri Altman wrote: > > The size of the bsg job reply was set to SCSI_SENSE_BUFFERSIZE back then > > while it was part of the bsg_command. However, for the scsi transport > > that uses it, it does not carry the scsi sense information. > > > > Rename

Re: remove exofs, the T10 OSD code and block/scsi bidi support V3

2018-12-19 Thread Christoph Hellwig
On Wed, Dec 19, 2018 at 09:01:53PM -0500, Douglas Gilbert wrote: >> 1) reduce the size of every kernel with block layer support, and >> even more for every kernel with scsi support > > By proposing the removal of bidi support from the block layer, it isn't > just the SCSI subsystem that will

Re: [RESEND PATCH v2] megaraid: fix out-of-bound array accesses

2018-12-19 Thread Sumit Saxena
On Thu, Dec 13, 2018 at 6:57 PM Qian Cai wrote: > > UBSAN reported those with MegaRAID SAS-3 3108, > > [ 77.467308] UBSAN: Undefined behaviour in > drivers/scsi/megaraid/megaraid_sas_fp.c:117:32 > [ 77.475402] index 255 is out of range for type 'MR_LD_SPAN_MAP [1]' > [ 77.481677] CPU: 16 PI